[Phpmyadmin-devel] Dynamically increasing Create table dialog's size

Marc Delisle marc at infomarc.info
Tue Oct 11 11:59:38 CEST 2011


Le 2011-10-11 05:40, Piotr Przybylski a écrit :
> 2011/10/11 Rouslan Placella <rouslan at placella.com>:
>> On Tue, 2011-10-11 at 01:57 +0200, Piotr Przybylski wrote:
>>> 2011/10/11 Rouslan Placella <rouslan at placella.com>:
>>>> On Mon, 2011-10-10 at 22:42 +0200, Piotr Przybylski wrote:
>>>>> It still caused scrollbars to appear, so I tried to change Marc's
>>>>> approach - now window's scrollbars should be inactive, only dialog's
>>>>> content should have them [1]. While at it, I also upgraded jQuery UI
>>>>> to the newest stable version [2].
>>>>
>>>> I'm not convinced that this is better. Try the following scenario:
>>>> * Open a somewhat small browser window.
>>>> * Click Create table.
>>>> * Maximise the browser window.
>>>> The dialog remains the same size, is padded with a lot of white space
>>>> and there is no way to resize it, so the user has to close and reopen
>>>> it. Same goes for making the browser window smaller after opening the
>>>> dialog: you can't resize it, so you end up with two sets of scrollbars
>>>> anyway.
>>>
>>> What browser are you using? There is a callback that should be
>>> reacting to window's resize.
>>
>> So far I tried (under linux): Firefox 7, Opera 11 and Chromium 12. The
>> issue is present in all of them. I also tried IE8, where it doesn't seem
>> to work at all. Clicking the create table icon opens an unusable dialog.
>> See attached screenshot.
> 
> ... fail on my side, resize handler was broken. Fixed in master, I
> will take a look at IE when I get home.

Piotr,
with IE 9 (Vista) I get a tiny create table window.

-- 
Marc Delisle
http://infomarc.info




More information about the Developers mailing list