[Phpmyadmin-devel] Variable width for HTML table in Create table dialog

[Marc Delisle]

Piotr Przybylski a écrit :
> 2011/10/13 Marc Delisle <marc at infomarc.info>:
>> Piotr Przybylski a écrit :
>>> 2011/10/12 Marc Delisle <marc at infomarc.info>:
>>>> Piotr Przybylski a écrit :
>>>>> 2011/10/12 Marc Delisle <marc at infomarc.info>:
>>>>>> Hi,
>>>>>> To save horizontal space, I propose this change (also for original
>>>>>> theme), removing the "width: 14em":
>>>>>>
>>>>>> diff --git a/themes/pmahomme/css/theme_right.css.php
>>>>>> b/themes/pmahomme/css/theme_right.css.php
>>>>>> index 358b71b..9aa6d38 100644
>>>>>> --- a/themes/pmahomme/css/theme_right.css.php
>>>>>> +++ b/themes/pmahomme/css/theme_right.css.php
>>>>>> @@ -2414,7 +2414,6 @@ fieldset .disabled-field td {
>>>>>>  }
>>>>>>
>>>>>>  #table_columns input, #table_columns select {
>>>>>> -    width:              14em;
>>>>>>      box-sizing:         border-box;
>>>>>>      -ms-box-sizing:     border-box;
>>>>> Then <select>s will grow wider. How about changing it to 10em?
>>>> I'll try it.
>>>>
>>>>> And we should certainly remove this rule for checkboxes, it makes Null
>>>>> and A_I is much too wide.
>>>>>
>>>> My goal was precisely to narrow the checkboxes column.
>>>>
>>> We can target inputs with input[type=text], input[type=password] etc.
>>> It won't work only in IE6.
>>>
>> Look at my latest commit; I put everything at 10em as you suggested,
>> then targeted input[type="checkbox"] to narrow to 2em.
>>
> 
> I think we should target text inputs specifically, and don't touch
> checkboxes at all, just to be safe in case of future style changes.
> For instance, Opera can completely change checkbox rendering even with
> simple CSS rules that in theory don't collide with standard control
> drawing.
> 

Done, thanks.

-- 
Marc Delisle
http://infomarc.info