From marc at infomarc.info Sun Apr 1 14:11:58 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 01 Apr 2012 08:11:58 -0400 Subject: [Phpmyadmin-devel] guidelines for avoiding security pitfalls In-Reply-To: References: <20120328105335.0c4cba53@rincewind.suse.cz> <4F730622.6040109@infomarc.info> Message-ID: <4F78460E.7070805@infomarc.info> Le 2012-03-31 11:02, Dieter Adriaenssens a écrit : > Op 28 maart 2012 14:37 heeft Marc Delisle het > volgende geschreven: >> Le 2012-03-28 04:53, Michal Čihař a écrit : >>> Hi >>> >>> Dne Tue, 27 Mar 2012 22:01:05 +0200 >>> Dieter Adriaenssens napsal(a): >>> >>>> As discussed on the team meeting in February, I started creating a >>>> wiki page with some guidelines for avoiding security bugs [0]. >>>> The page is not finished yet, I just set out some ideas, that I will >>>> work out in the next few days. Feel free to comment, improve or add >>>> guidelines as you see fit. >>>> >>>> [0] http://wiki.phpmyadmin.net/pma/Security_pitfalls >>> >>> Thanks, looks great so far! >> >> Yes, thanks. I'm wondering, are there places where we really use >> htmlentities() for protection? > > htmlentities() is not much used (see lower), shall we replace them all > by htmlspecialchars and drop the htmlentities() from the guidelines? It would be more prudent to have a look at them, one by one, and see their exact purpose. Anyway, some of them are under libraries/tcpdf and some under /test. In the PHP Architect guide to PHP security by one of the PHP core developers, I checked the chapter about XSS. I could not find a suggestion to use htmlentities(); however, htmlspecialchars() does not find all XSS, so they suggest using preg_replace() with some clever patterns. > > Using htmlspecialchars() is sufficient to protect against XSS (and > possibly messing up of the html structure), > htmlentities() just converts more characters into their HTML character > entity equivalents (for example ü will become ü) > > Current occurences of escaping/sanitizing functions in PMA codebase: > > htmlentities() : 51 > htmlspecialchars() : 1041 > PMA_sanitize() : 40 > PMA_sanitize_file() : 3 > >> Also I think we should talk about PMA_sanitize(). > > Yes, but it should not be used in all cases? > Maybe, but it would be slower than just plain htmlspecialchars(). Also, with the default parameters of PMA_sanitize(), it just replaces "<" and ">" and takes care of our special formatting codes. -- Marc Delisle http://infomarc.info From marc at infomarc.info Sun Apr 1 14:41:32 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 01 Apr 2012 08:41:32 -0400 Subject: [Phpmyadmin-devel] GSOC 2012- Refactoring In-Reply-To: References: Message-ID: <4F784CFC.8090507@infomarc.info> Le 2012-03-31 14:03, Thilina Buddika Abeyrathna a écrit : > Hi, > When we are going to refactor the huge php file which contains mix of html > tags and php code like server_privileges.php script. And html tags are > printed by php in this script, what is the best way to refactor. I somewhat > confused about that. Is it good to separate html and php tags and implement > several functions? I like to see the suggestions. In the roadmap for version 4.0 [0], we indicate this: "The current and mix will be cleaned up in the process. The output will be moved to lib/include files which can be called by either the index page or by the specific files (which can still be referenced seperately)." The exact method to achieve this separation has not been chosen, but indeed, refactoring usually produces code having more, smaller functions. Look at this example: [1]. [0] http://wiki.phpmyadmin.net/pma/FOSDEM_2012_Meeting [1] https://github.com/phpmyadmin/phpmyadmin/commit/1394cc65e8bb3b5218ffb83dd3cb8490498bfe80 -- Marc Delisle http://infomarc.info From marc at infomarc.info Sun Apr 1 14:58:12 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 01 Apr 2012 08:58:12 -0400 Subject: [Phpmyadmin-devel] Plug-able authentication for phpMyAdimin In-Reply-To: <1333222122.16527.YahooMailNeo@web113403.mail.gq1.yahoo.com> References: <1333222122.16527.YahooMailNeo@web113403.mail.gq1.yahoo.com> Message-ID: <4F7850E4.6020704@infomarc.info> Le 2012-03-31 15:28, Darshana Gunawardana a écrit : > Hi Marc, > > I worked on implementing plug-able authentication and for simulation > purpose, a new tab was added to main tab pane and file importer was > used to import the plugin. Currently I have added another input to > specify the plugin name since the plugin name can defer from the file > name and it is required to install the plugin. Is there any other way > to find the plugin name other than this way? Darshana, I'm not sure I follow. Are you talking about the "INSTALL PLUGIN" statement? -- Marc Delisle http://infomarc.info From darshanasbg at yahoo.com Sun Apr 1 16:12:34 2012 From: darshanasbg at yahoo.com (Darshana Gunawardana) Date: Sun, 1 Apr 2012 07:12:34 -0700 (PDT) Subject: [Phpmyadmin-devel] Plug-able authentication for phpMyAdimin In-Reply-To: <4F7850E4.6020704@infomarc.info> References: <1333222122.16527.YahooMailNeo@web113403.mail.gq1.yahoo.com> <4F7850E4.6020704@infomarc.info> Message-ID: <1333289554.42566.YahooMailNeo@web113420.mail.gq1.yahoo.com> > Le 2012-03-31 15:28, Darshana Gunawardana a écrit : >> Hi Marc, >> >> I worked on implementing plug-able authentication and for simulation >> purpose, a new tab was added to main tab pane and file importer was >> used to import the plugin. Currently I have added another input to >> specify the plugin name since the plugin name can defer from the file >> name and it is required to install the plugin. Is there any other way >> to find the plugin name other than this way? >  > Darshana, > I'm not sure I follow. Are you talking about the "INSTALL PLUGIN" statement? > Marc Delisle Hi Marc, Yes, I am talking about the 'INSTALL PLUGIN' statement and according to the documentation[0] the plugin name is specified in 'st_mysql_plugin' structure[1]. So is there any way to get the plugin name? [0] http://dev.mysql.com/doc/refman/5.1/en/install-plugin.html [1] http://dev.mysql.com/doc/refman/5.1/en/plugin-data-structures.html -------------- next part -------------- An HTML attachment was scrubbed... URL: From rouslan at placella.com Sun Apr 1 19:49:44 2012 From: rouslan at placella.com (Rouslan Placella) Date: Sun, 01 Apr 2012 18:49:44 +0100 Subject: [Phpmyadmin-devel] guidelines for avoiding security pitfalls In-Reply-To: <4F78460E.7070805@infomarc.info> References: <20120328105335.0c4cba53@rincewind.suse.cz> <4F730622.6040109@infomarc.info> <4F78460E.7070805@infomarc.info> Message-ID: <4F789538.7030406@placella.com> On 01/04/12 13:11, Marc Delisle wrote: > Le 2012-03-31 11:02, Dieter Adriaenssens a écrit : >> Op 28 maart 2012 14:37 heeft Marc Delisle het >> volgende geschreven: >>> Le 2012-03-28 04:53, Michal Čihař a écrit : >>>> Hi >>>> >>>> Dne Tue, 27 Mar 2012 22:01:05 +0200 >>>> Dieter Adriaenssens napsal(a): >>>> >>>>> As discussed on the team meeting in February, I started creating a >>>>> wiki page with some guidelines for avoiding security bugs [0]. >>>>> The page is not finished yet, I just set out some ideas, that I will >>>>> work out in the next few days. Feel free to comment, improve or add >>>>> guidelines as you see fit. >>>>> >>>>> [0] http://wiki.phpmyadmin.net/pma/Security_pitfalls >>>> >>>> Thanks, looks great so far! >>> >>> Yes, thanks. I'm wondering, are there places where we really use >>> htmlentities() for protection? >> >> htmlentities() is not much used (see lower), shall we replace them all >> by htmlspecialchars and drop the htmlentities() from the guidelines? > > It would be more prudent to have a look at them, one by one, and see > their exact purpose. You'd use htmlentities() when you need to escape single quotes, htmlspecialchars() doesn't do that. E.g.: $name = htmlentities("foo's bar", ENT_QUOTES); echo ""; > Anyway, some of them are under libraries/tcpdf and some under /test. > > In the PHP Architect guide to PHP security by one of the PHP core > developers, I checked the chapter about XSS. I could not find a > suggestion to use htmlentities(); however, htmlspecialchars() does not > find all XSS, so they suggest using preg_replace() with some clever > patterns. > >> >> Using htmlspecialchars() is sufficient to protect against XSS (and >> possibly messing up of the html structure), >> htmlentities() just converts more characters into their HTML character >> entity equivalents (for example ü will become ü) >> >> Current occurences of escaping/sanitizing functions in PMA codebase: >> >> htmlentities() : 51 >> htmlspecialchars() : 1041 >> PMA_sanitize() : 40 >> PMA_sanitize_file() : 3 >> >>> Also I think we should talk about PMA_sanitize(). >> >> Yes, but it should not be used in all cases? >> > > Maybe, but it would be slower than just plain htmlspecialchars(). Also, > with the default parameters of PMA_sanitize(), it just replaces "<" and > ">" and takes care of our special formatting codes. > From selvam1991 at gmail.com Sun Apr 1 23:34:01 2012 From: selvam1991 at gmail.com (SELVAM P) Date: Mon, 2 Apr 2012 03:04:01 +0530 Subject: [Phpmyadmin-devel] GSoC 2012 - Plugins and OOP for import/export/transformations/authentication Message-ID: Hi Marc, Michal , I have been working on the proposal for more than a week now. And I strongly feel that we also need to add implement an application specific API for the phpmyadmin. Basic functionality should be available in the form of functions for the developers to built upon.Given the time constraint in GSoC I feel that we should built the base framework for the API. Also as the existing functionality like import/export will be converted to object-oriented. So common functionality can be added to the API side by side. The API will attract more developers to create plugins to extend phpmyadmin which is one of the major objectives of the project. Please leave your comments and suggestions. I have created my first draft proposal. How would you like me to share it? Is it ok if I mail it personally or use google docs? Eagerly awaiting your reply. -- Selvam Palanimalai Website || LinkedIN Department of EEE | Department of Biology, Birla Institute of Technology and Sciences -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Sun Apr 1 23:39:29 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 01 Apr 2012 17:39:29 -0400 Subject: [Phpmyadmin-devel] guidelines for avoiding security pitfalls In-Reply-To: <4F789538.7030406@placella.com> References: <20120328105335.0c4cba53@rincewind.suse.cz> <4F730622.6040109@infomarc.info> <4F78460E.7070805@infomarc.info> <4F789538.7030406@placella.com> Message-ID: <4F78CB11.3000505@infomarc.info> Le 2012-04-01 13:49, Rouslan Placella a écrit : > On 01/04/12 13:11, Marc Delisle wrote: >> Le 2012-03-31 11:02, Dieter Adriaenssens a écrit : >>> Op 28 maart 2012 14:37 heeft Marc Delisle het >>> volgende geschreven: >>>> Le 2012-03-28 04:53, Michal Čihař a écrit : >>>>> Hi >>>>> >>>>> Dne Tue, 27 Mar 2012 22:01:05 +0200 >>>>> Dieter Adriaenssens napsal(a): >>>>> >>>>>> As discussed on the team meeting in February, I started creating a >>>>>> wiki page with some guidelines for avoiding security bugs [0]. >>>>>> The page is not finished yet, I just set out some ideas, that I will >>>>>> work out in the next few days. Feel free to comment, improve or add >>>>>> guidelines as you see fit. >>>>>> >>>>>> [0] http://wiki.phpmyadmin.net/pma/Security_pitfalls >>>>> >>>>> Thanks, looks great so far! >>>> >>>> Yes, thanks. I'm wondering, are there places where we really use >>>> htmlentities() for protection? >>> >>> htmlentities() is not much used (see lower), shall we replace them all >>> by htmlspecialchars and drop the htmlentities() from the guidelines? >> >> It would be more prudent to have a look at them, one by one, and see >> their exact purpose. > > You'd use htmlentities() when you need to escape single quotes, > htmlspecialchars() doesn't do that. >From the PHP manual for htmlspecialchars(), we can use the ENT_QUOTES flag which does this: "'" (single quote) becomes ''' only when ENT_QUOTES is set. > > E.g.: > $name = htmlentities("foo's bar", ENT_QUOTES); > echo ""; > >> Anyway, some of them are under libraries/tcpdf and some under /test. >> >> In the PHP Architect guide to PHP security by one of the PHP core >> developers, I checked the chapter about XSS. I could not find a >> suggestion to use htmlentities(); however, htmlspecialchars() does not >> find all XSS, so they suggest using preg_replace() with some clever >> patterns. >> >>> >>> Using htmlspecialchars() is sufficient to protect against XSS (and >>> possibly messing up of the html structure), >>> htmlentities() just converts more characters into their HTML character >>> entity equivalents (for example ü will become ü) >>> >>> Current occurences of escaping/sanitizing functions in PMA codebase: >>> >>> htmlentities() : 51 >>> htmlspecialchars() : 1041 >>> PMA_sanitize() : 40 >>> PMA_sanitize_file() : 3 >>> >>>> Also I think we should talk about PMA_sanitize(). >>> >>> Yes, but it should not be used in all cases? >>> >> >> Maybe, but it would be slower than just plain htmlspecialchars(). Also, >> with the default parameters of PMA_sanitize(), it just replaces "<" and >> ">" and takes care of our special formatting codes. >> -- Marc Delisle http://infomarc.info From marc at infomarc.info Mon Apr 2 00:00:10 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 01 Apr 2012 18:00:10 -0400 Subject: [Phpmyadmin-devel] Plug-able authentication for phpMyAdimin In-Reply-To: <1333289554.42566.YahooMailNeo@web113420.mail.gq1.yahoo.com> References: <1333222122.16527.YahooMailNeo@web113403.mail.gq1.yahoo.com> <4F7850E4.6020704@infomarc.info> <1333289554.42566.YahooMailNeo@web113420.mail.gq1.yahoo.com> Message-ID: <4F78CFEA.804@infomarc.info> Le 2012-04-01 10:12, Darshana Gunawardana a écrit : >> Le 2012-03-31 15:28, Darshana Gunawardana a écrit : > >>> Hi Marc, >>> >>> I worked on implementing plug-able authentication and for simulation >>> purpose, a new tab was added to main tab pane and file importer was >>> used to import the plugin. Currently I have added another input to >>> specify the plugin name since the plugin name can defer from the file >>> name and it is required to install the plugin. Is there any other way >>> to find the plugin name other than this way? >> >> Darshana, >> I'm not sure I follow. Are you talking about the "INSTALL PLUGIN" statement? >> Marc Delisle > > > Hi Marc, > > Yes, I am talking about the 'INSTALL PLUGIN' statement and according to the documentation[0] the plugin name is specified in 'st_mysql_plugin' structure[1]. So is there any way to get the plugin name? > > [0] http://dev.mysql.com/doc/refman/5.1/en/install-plugin.html > [1] http://dev.mysql.com/doc/refman/5.1/en/plugin-data-structures.html I'm not familiar with this, but I suggest contacting Sergei Golubchik, the creator of the MySQL plugins. See http://montyprogram.com/people/ and there is a "Contact us" link. -- Marc Delisle http://infomarc.info From marc at infomarc.info Mon Apr 2 00:05:46 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 01 Apr 2012 18:05:46 -0400 Subject: [Phpmyadmin-devel] GSoC 2012 - Plugins and OOP for import/export/transformations/authentication In-Reply-To: References: Message-ID: <4F78D13A.1080102@infomarc.info> Le 2012-04-01 17:34, SELVAM P a écrit : > Hi Marc, Michal , > > I have been working on the proposal for more than a week now. > And I strongly feel that we also need to add implement > an application specific API for the phpmyadmin. > Basic functionality should be available in the form of functions for the > developers to built upon.Given the time constraint in GSoC I feel that we > should built the base framework for the API. Also as the > existing functionality like import/export will be converted to > object-oriented. So common functionality can be added to the API side by > side. > The API will attract more developers to create plugins to extend phpmyadmin > which is one of the major objectives of the project. Please leave your > comments and suggestions. > > I have created my first draft proposal. How would you like me to share it? > Is it ok if I mail it personally or use google docs? Hi Selvam, please submit your proposal in its current state to the google-melange.com website, you'll get comments by our mentoring team and you can further refine the proposal. Details available at [0]. [0] http://wiki.phpmyadmin.net/pma/GSoC_2012_Applicant_Guide -- Marc Delisle http://infomarc.info From kilicoglutuncay at gmail.com Mon Apr 2 17:33:24 2012 From: kilicoglutuncay at gmail.com (tuncay kilicoglu) Date: Mon, 2 Apr 2012 18:33:24 +0300 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query Message-ID: Hi, I am Tuncay Kılıçoğlu. I study Computer Engineering at Çanakkale 18 Mart University, Turkey. Open source is very popular at our university (4 of my classmates were at GSoC last year :) ) , I have involved with some open source projects with Pardus ( A Turkish Linux distro that had been to GSoC 2 times before). I joined COMAK project which is a project about running Pardus tools with Gnome rather than KDE. I love Gnu/Linux. Besides that, I have worked at a few commercial companies for a year w,th PHP. I used to use Zend framework for a long time. I'm well adapted to PHP's niceties. I've used Mysql so far and PhpMyadmin is my favoriate database manager interface. I also liked software engineering lessons at school a lot and I use many refactoring techniques consistently. I need to take some advice before I start reading source code. What kind of refactoring styles are we talking about? What are Table search, db search and multitable query are related to? What's bad with current code? Do we also need to modularize scripts into seperate for better abstraction? or It's about refactoring inner details of functions? or is it about objectifying the code? Please give me a quick brief about project because I couldn't find any on mailing list. (You may give the link for the thread, too) Thanks in advance, Best, -- Tuncay KILIÇOĞLU -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Mon Apr 2 17:44:55 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 02 Apr 2012 11:44:55 -0400 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: References: Message-ID: <4F79C977.2090601@infomarc.info> Le 2012-04-02 11:33, tuncay kilicoglu a écrit : > > I need to take some advice before I start reading source code. What kind of > refactoring styles are we talking about? What are Table search, db search > and multitable query are related to? What's bad with current code? Do we > also need to modularize scripts into seperate for better abstraction? or > It's about refactoring inner details of functions? or is it about > objectifying the code? Here is what needs improvement in the current code: - large chunks of procedural code without functions - reference to global variables - HTML and PHP mixed together (but we are not implementing a templating solution) Going to OOP is not necessary in the project but would be welcome. > > Please give me a quick brief about project because I couldn't find any on > mailing list. (You may give the link for the thread, too) -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From nandu130 at gmail.com Mon Apr 2 19:18:55 2012 From: nandu130 at gmail.com (nandu) Date: Mon, 2 Apr 2012 22:48:55 +0530 Subject: [Phpmyadmin-devel] proposals: Refactoring: Insert/edit, Privileges, Operations, Structure In-Reply-To: References: <4F75D26C.6060002@gmail.com> <4F76F0E1.9080704@infomarc.info> Message-ID: hello Reagarding the submitting of patch I have a doubt since the ios device alphabets to be lowecased, should I just submit a text file with the following code?? $(function () { $('input:text').prop({ autocapitalize: 'off', autocorrect: 'off' }); }); I never submitted a patch before. thanks.. Mar 31, 2012 at 10:36 PM, J.M. wrote: > Am 31. März 2012 18:51 schrieb nandu : > > Marc, > > > > Thanks for considering, you asked me to submit patch, well for that i > need > > some time till then I found another thing > > that is when we log into phpMyadmin from an iOS device is difficult > because > > the device uppercases the first letter automatically. This can be > disabled > > by adding two attributes in the input tag and setting them both to off. > > it can be patched through > > autocapitalize="off" autocorrect="off" attributes in input. > > jQuery('input[type=text]').attr('autocapitalize','off'); > > > > Also i need some guidelines from you with my proposal > > thanks > > > > > > > > > > > > On Sat, Mar 31, 2012 at 5:26 PM, Marc Delisle > wrote: > >> > >> Le 2012-03-31 06:19, nandu a écrit : > >> > PHP code mixed with HTML tags will basically cause crash, "strip_tags" > >> > to > >> > strip every html and php tags > >> > in $var, every characters after "<" is removed. > >> > i think strip_tags() is mixed up. > >> > > >> > we often get error:tbl_replace.php: Missing parameter when adding i.e. > >> > entries into mysql from within > >> > phpmyadmin chences of having issue with cookies on the system, i.e.if > >> > disabled cookies in the browser > >> > this can be changed. > >> > Instead of using the elseif statements code can be reduced with > >> > > >> > >> Nandu, > >> please submit some patches, it will be easier to see what you mean. > >> > >> > > >> > wecan either use the static method in the code in order to improve the > >> > efficiency. > >> > another point I would like to ask what if we use the complete pathname > >> > with > >> > require and include, it will be much faster. > >> > >> Seems like a good idea. I took this example in the PHP manual's > comments: > >> > >> // this can be inside libraries/common.inc.php > >> define('__ROOT__', dirname(dirname(__FILE__))); > >> // then other scripts use this > >> require_once(__ROOT__.'/foo.php); > >> > >> So we could define __ROOT__ once and use it afterwards. One thing I'm > >> not sure about: we prefixed with './' to help in open_basedir case, so > >> we would have to test this case. > >> > >> -- > >> Marc Delisle > >> http://infomarc.info > >> > >> > >> > ------------------------------------------------------------------------------ > >> This SF email is sponsosred by: > >> Try Windows Azure free for 90 days Click Here > >> http://p.sf.net/sfu/sfd2d-msazure > >> _______________________________________________ > >> Phpmyadmin-devel mailing list > >> Phpmyadmin-devel at lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > > > > > > > > > -- > > Nandlal Ahirwar > > MCA, II yr > > Maulana Azad National Institute of Technology, Bhopal > > India > > > > > > > ------------------------------------------------------------------------------ > > This SF email is sponsosred by: > > Try Windows Azure free for 90 days Click Here > > http://p.sf.net/sfu/sfd2d-msazure > > _______________________________________________ > > Phpmyadmin-devel mailing list > > Phpmyadmin-devel at lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > > > Adding autocapitalize and/or autocorrect attributes to tags is > not valid HTML5, though, which is what we'd like to achieve (refer to > http://www.w3schools.com/html5/tag_input.asp for all input tag > attributes allowed in HTML5). > > I suggest setting these attributes using jQuery in a document-ready > event handler if the user agent matches iOS or Android. Like this: > > $(function () { > $('input:text').prop({ > autocapitalize: 'off', > autocorrect: 'off' > }); > }); > > What do you think? > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Mon Apr 2 20:16:32 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 02 Apr 2012 14:16:32 -0400 Subject: [Phpmyadmin-devel] proposals: Refactoring: Insert/edit, Privileges, Operations, Structure In-Reply-To: References: <4F75D26C.6060002@gmail.com> <4F76F0E1.9080704@infomarc.info> Message-ID: <4F79ED00.2060105@infomarc.info> Le 2012-04-02 13:18, nandu a écrit : > hello > Reagarding the submitting of patch I have a doubt since the ios device > alphabets to be lowecased, should I just submit a text file with the > following code?? > > $(function () { > $('input:text').prop({ > autocapitalize: 'off', > autocorrect: 'off' > }); > }); > > I never submitted a patch before. Hi, to see what a patch looks like, please visit [0], click on one of the artifact, then download a file which is attached to the artifact. [0] https://sourceforge.net/tracker/?group_id=23067&atid=377410 > thanks.. > Mar 31, 2012 at 10:36 PM, J.M. wrote: > >> Am 31. März 2012 18:51 schrieb nandu : >>> Marc, >>> >>> Thanks for considering, you asked me to submit patch, well for that i >> need >>> some time till then I found another thing >>> that is when we log into phpMyadmin from an iOS device is difficult >> because >>> the device uppercases the first letter automatically. This can be >> disabled >>> by adding two attributes in the input tag and setting them both to off. >>> it can be patched through >>> autocapitalize="off" autocorrect="off" attributes in input. >>> jQuery('input[type=text]').attr('autocapitalize','off'); >>> >>> Also i need some guidelines from you with my proposal >>> thanks >>> >>> >>> >>> >>> >>> On Sat, Mar 31, 2012 at 5:26 PM, Marc Delisle >> wrote: >>>> >>>> Le 2012-03-31 06:19, nandu a écrit : >>>>> PHP code mixed with HTML tags will basically cause crash, "strip_tags" >>>>> to >>>>> strip every html and php tags >>>>> in $var, every characters after "<" is removed. >>>>> i think strip_tags() is mixed up. >>>>> >>>>> we often get error:tbl_replace.php: Missing parameter when adding i.e. >>>>> entries into mysql from within >>>>> phpmyadmin chences of having issue with cookies on the system, i.e.if >>>>> disabled cookies in the browser >>>>> this can be changed. >>>>> Instead of using the elseif statements code can be reduced with >>>>> >>>> >>>> Nandu, >>>> please submit some patches, it will be easier to see what you mean. >>>> >>>>> >>>>> wecan either use the static method in the code in order to improve the >>>>> efficiency. >>>>> another point I would like to ask what if we use the complete pathname >>>>> with >>>>> require and include, it will be much faster. >>>> >>>> Seems like a good idea. I took this example in the PHP manual's >> comments: >>>> >>>> // this can be inside libraries/common.inc.php >>>> define('__ROOT__', dirname(dirname(__FILE__))); >>>> // then other scripts use this >>>> require_once(__ROOT__.'/foo.php); >>>> >>>> So we could define __ROOT__ once and use it afterwards. One thing I'm >>>> not sure about: we prefixed with './' to help in open_basedir case, so >>>> we would have to test this case. >>>> >>>> -- >>>> Marc Delisle >>>> http://infomarc.info >>>> >>>> >>>> >> ------------------------------------------------------------------------------ >>>> This SF email is sponsosred by: >>>> Try Windows Azure free for 90 days Click Here >>>> http://p.sf.net/sfu/sfd2d-msazure >>>> _______________________________________________ >>>> Phpmyadmin-devel mailing list >>>> Phpmyadmin-devel at lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >>> >>> >>> >>> >>> -- >>> Nandlal Ahirwar >>> MCA, II yr >>> Maulana Azad National Institute of Technology, Bhopal >>> India >>> >>> >>> >> ------------------------------------------------------------------------------ >>> This SF email is sponsosred by: >>> Try Windows Azure free for 90 days Click Here >>> http://p.sf.net/sfu/sfd2d-msazure >>> _______________________________________________ >>> Phpmyadmin-devel mailing list >>> Phpmyadmin-devel at lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >>> >> >> Adding autocapitalize and/or autocorrect attributes to tags is >> not valid HTML5, though, which is what we'd like to achieve (refer to >> http://www.w3schools.com/html5/tag_input.asp for all input tag >> attributes allowed in HTML5). >> >> I suggest setting these attributes using jQuery in a document-ready >> event handler if the user agent matches iOS or Android. Like this: >> >> $(function () { >> $('input:text').prop({ >> autocapitalize: 'off', >> autocorrect: 'off' >> }); >> }); >> >> What do you think? >> >> >> ------------------------------------------------------------------------------ >> This SF email is sponsosred by: >> Try Windows Azure free for 90 days Click Here >> http://p.sf.net/sfu/sfd2d-msazure >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> > > > > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > > > > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From thilinaabeyrathna at gmail.com Mon Apr 2 20:39:05 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Tue, 3 Apr 2012 00:09:05 +0530 Subject: [Phpmyadmin-devel] GSOC 2012 - Proposal - Refactoring: Insert/edit, Privileges, Operations, Structure Message-ID: Hi Marc, I have submitted my project proposal for "Refactoring : Insert/edit, Privileges, Operations, Structure" project idea. I'll very thankful you if you can review it and give me some feed back for further improvements of proposal. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From hiddenpearls at gmail.com Mon Apr 2 20:43:16 2012 From: hiddenpearls at gmail.com (Adnan) Date: Mon, 2 Apr 2012 23:43:16 +0500 Subject: [Phpmyadmin-devel] GSoC 2012: Refactoring Designer/schema integration In-Reply-To: References: <20120312202430.6a5d6f73@nutt.cihar.com> <4F71D117.1070602@infomarc.info> <4F72D230.2050905@gmail.com> Message-ID: On Sat, Mar 31, 2012 at 1:07 PM, Adnan wrote: > > > On Wed, Mar 28, 2012 at 1:56 PM, Dieter Adriaenssens < > dieter.adriaenssens at gmail.com> wrote: > >> On 27/03/2012 22:13, Adnan wrote: >> > >> > >> > On Tue, Mar 27, 2012 at 7:39 PM, Marc Delisle > > > wrote: >> > >> > Le 2012-03-26 06:10, Adnan a écrit : >> > > 2012/3/25 Adnan > > > >> > > >> > >> >> > >> >> > >> 2012/3/13 Adnan > > > >> > >> >> > >>> >> > >>> >> > >>> 2012/3/13 Michal Čihař > michal at cihar.com>> >> > >>> >> > >>>> Hi >> > >>>> >> > >>>> Dne Mon, 5 Mar 2012 10:54:03 +0500 >> > >>>> Adnan > >> > napsal(a): >> > >>>> >> > >>>>> Refactoring phpMyAdmin codebase is important at this stage. I >> > had an >> > >>>> idea >> > >>>>> to make mobile version of phpMyAdmin for iPhone/Android using >> > phoneGap >> > >>>>> but Michal >> > >>>>> Čihař said we will refactoring PMA this year GSoC. So, >> > Refactoring >> > >>>>> Designer/schema integration would be best for me because I >> > have work on >> > >>>>> Schema integration in GSoC 2010. >> > >>>>> >> > >>>>> schema export is already in OOP btw but Designer not yet. will >> > start >> > >>>>> looking into codecase and ask questions. >> > >>>> >> > >>>> Please note that schema is OOP, but does not really use OOP >> > practices >> > >>>> much - there is quite a lot of duplicate code, which should be >> > rather >> > >>>> inherited from parent classes and shared. >> > >>>> >> > >>>> Yeah, I'm recalling my code done in GSoC 2010 ;) >> > >>> >> > >> I didn't understand what PMA Designer feature does ? I played >> > with its >> > >> options/menu but these are simple operations. >> > >> >> > > I can see the foreign key relations now in Designer. >> > > >> > >> what is the main function of PMA Designer ? >> > >> >> > >> plus I think we may use jQueryUI Draggable API's for this. >> > >> > Indeed, a more standard API would be welcome. >> > >> > Yes, I found this JS Library http://raphaeljs.com/ This lib will make >> > Deigner/Schema feature more robust if it works. I will try by making a >> demo >> > What about its License ? Can we use this lib ? >> >> The MIT license [0] allows us to use it and include it in phpMyAdmin as >> long as we don't remove the copyright clause from the lib file. >> >> [0] http://raphaeljs.com/license.html >> >> Alright. > I think we should name Designer/Schema Feature to something else more > logical. Because both these features will be merged in one. So, we should > have more logical name. > my suggestion is "Relational Schema" > I have submitted my Proposal. Please have a look and let me know feedback. Thanks > -- >> Kind regards, >> >> Dieter Adriaenssens >> >> >> >> ------------------------------------------------------------------------------ >> This SF email is sponsosred by: >> Try Windows Azure free for 90 days Click Here >> http://p.sf.net/sfu/sfd2d-msazure >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> >> > > > -- > Muhammad Adnan > Twitter: @hiddenpearls > I blog too do u know ? http:// www.imblog.info > Failure takes you higher than success ..! > you sell code, I sell my brain. > > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From pe.chanaka.ck at gmail.com Mon Apr 2 21:37:26 2012 From: pe.chanaka.ck at gmail.com (Chanaka Dharmarathna) Date: Tue, 3 Apr 2012 01:07:26 +0530 Subject: [Phpmyadmin-devel] GSoC 2012 Project Proposal for "Refactoring: Display query results" idea Message-ID: Hi Michal, I have submitted my project proposal on project idea "Refactoring: Display query results" [0] under GSoC 2012. I would be very thankful if you can review it and give me your suggestions to do the necessary improvements on it. [0]: https://wiki.phpmyadmin.net/pma/GSoC_2012_Ideas_List#Refactoring:_Displaying_query_results Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya ____________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From ayax88 at gmail.com Tue Apr 3 00:33:22 2012 From: ayax88 at gmail.com (Ammar Yasir) Date: Tue, 3 Apr 2012 04:03:22 +0530 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query Message-ID: Hi, The noticed that the table search scripts(tbl_select.php, tbl_zoom_select.php) and multi-table query(db_qbe.php) basically display a 'Query-by-Example' form. I think we can design a qbeForm class through which we can customize a QBE form for each of the three scripts. The basic elements of a QBE form are columns and details about each column. Considering column as an entity, we can assign HTML content of each column element like datatype, collation, operator, sort, criteria as the attributes of 'column' entity. To be more specific, a 'column' entity would contain, S.No. | Attribute | HTML | Script 1 | Data-type | text | tbl_select.php, tbl_zoom_select.php 2 | Collation | text | tbl_select.php, tbl_zoom_select.php 3 | Sort | HTML Select | db_qbe.php 4 | Ins/Del | HTML input | db_qbe.php 5 | Modify | output of S.No 4 | db_qbe.php 6 | Show | HTML checkbox | db_qbe.php 7 | Criteria | (a) HTML input | db_qbe.php | (b) HTML Select | tbl_select.php, tbl_zoom_select.php 8 | Value | (a) HTML input | tbl_select.php, tbl_zoom_select.php | (b) multiselect | tbl_select.php, tbl_zoom_select.php | Foreign Values | tbl_select.php, tbl_zoom_select.php, browse_foreigners.php We can decide on what HTML we want to display for each 'column' entity(depending on the script in consideration) and customize our QBE form. One thing to note is that, from 'column' entity we will generate an empty HTML skeleton (say column block). The values of HTML select and others(for example operators) will be updated using AJAX calls. I guess that could also be included as a procedure in the QBE class (or column class). A QBE form can consist of various column blocks ( tbl_zoom_select.php has 2, db_qbe.php initially has 3 and tbl_select.php has count($fields) ). For, db_qbe.php 'column' blocks can be added dynamically just by creating an instance of 'column' entity. One issue could be that in tbl_zoom_select.php and db_qbe.php we need to select columns, i.e, columns are displayed in a select box, while in tbl_select.php all the columns are listed. But I guess, it can be worked out in time. Regards, Ammar Yasir -------------- next part -------------- An HTML attachment was scrubbed... URL: From ayax88 at gmail.com Tue Apr 3 00:39:09 2012 From: ayax88 at gmail.com (Ammar Yasir) Date: Tue, 3 Apr 2012 04:09:09 +0530 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: <4F79C977.2090601@infomarc.info> References: <4F79C977.2090601@infomarc.info> Message-ID: On Mon, Apr 2, 2012 at 9:14 PM, Marc Delisle wrote: > Le 2012-04-02 11:33, tuncay kilicoglu a écrit : > > > > I need to take some advice before I start reading source code. What kind > of > > refactoring styles are we talking about? What are Table search, db search > > and multitable query are related to? What's bad with current code? Do we > > also need to modularize scripts into seperate for better abstraction? or > > It's about refactoring inner details of functions? or is it about > > objectifying the code? > > Here is what needs improvement in the current code: > > - large chunks of procedural code without functions > - reference to global variables > Hi, Can we have more clarity on improving reference to global variables. Is the following snippet an example of the same where? (From tbl_select.php, $_POST parameters are referenced through $GLOBALS) $post_params = array( 'ajax_request', 'collations', 'db', 'distinct', 'fields', 'func', 'max_number_of_fields', 'names', 'order', 'orderField', 'param', 'session_max_rows', 'table', 'types', 'where', ); foreach ($post_params as $one_post_param) { if (isset($_POST[$one_post_param])) { $GLOBALS[$one_post_param] = $_POST[$one_post_param]; } } > - HTML and PHP mixed together (but we are not implementing a templating > solution) > > Going to OOP is not necessary in the project but would be welcome. > > > > > Please give me a quick brief about project because I couldn't find any on > > mailing list. (You may give the link for the thread, too) > > > > -- > Marc Delisle > http://infomarc.info > > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu130 at gmail.com Tue Apr 3 07:43:08 2012 From: nandu130 at gmail.com (nandu) Date: Tue, 3 Apr 2012 11:13:08 +0530 Subject: [Phpmyadmin-devel] proposals: Refactoring: Insert/edit, Privileges, Operations, Structure In-Reply-To: <4F79ED00.2060105@infomarc.info> References: <4F75D26C.6060002@gmail.com> <4F76F0E1.9080704@infomarc.info> <4F79ED00.2060105@infomarc.info> Message-ID: Marc I tried my hands on git and was able to push my changes in phpmyadmin repository, please let me know if any further changes required. Thanks On Mon, Apr 2, 2012 at 11:46 PM, Marc Delisle wrote: > Le 2012-04-02 13:18, nandu a écrit : > > hello > > Reagarding the submitting of patch I have a doubt since the ios device > > alphabets to be lowecased, should I just submit a text file with the > > following code?? > > > > $(function () { > > $('input:text').prop({ > > autocapitalize: 'off', > > autocorrect: 'off' > > }); > > }); > > > > I never submitted a patch before. > > Hi, > to see what a patch looks like, please visit [0], click on one of the > artifact, then download a file which is attached to the artifact. > > [0] https://sourceforge.net/tracker/?group_id=23067&atid=377410 > > > thanks.. > > Mar 31, 2012 at 10:36 PM, J.M. wrote: > > > >> Am 31. März 2012 18:51 schrieb nandu : > >>> Marc, > >>> > >>> Thanks for considering, you asked me to submit patch, well for that i > >> need > >>> some time till then I found another thing > >>> that is when we log into phpMyadmin from an iOS device is difficult > >> because > >>> the device uppercases the first letter automatically. This can be > >> disabled > >>> by adding two attributes in the input tag and setting them both to off. > >>> it can be patched through > >>> autocapitalize="off" autocorrect="off" attributes in input. > >>> jQuery('input[type=text]').attr('autocapitalize','off'); > >>> > >>> Also i need some guidelines from you with my proposal > >>> thanks > >>> > >>> > >>> > >>> > >>> > >>> On Sat, Mar 31, 2012 at 5:26 PM, Marc Delisle > >> wrote: > >>>> > >>>> Le 2012-03-31 06:19, nandu a écrit : > >>>>> PHP code mixed with HTML tags will basically cause crash, > "strip_tags" > >>>>> to > >>>>> strip every html and php tags > >>>>> in $var, every characters after "<" is removed. > >>>>> i think strip_tags() is mixed up. > >>>>> > >>>>> we often get error:tbl_replace.php: Missing parameter when adding > i.e. > >>>>> entries into mysql from within > >>>>> phpmyadmin chences of having issue with cookies on the system, i.e.if > >>>>> disabled cookies in the browser > >>>>> this can be changed. > >>>>> Instead of using the elseif statements code can be reduced with > >>>>> > >>>> > >>>> Nandu, > >>>> please submit some patches, it will be easier to see what you mean. > >>>> > >>>>> > >>>>> wecan either use the static method in the code in order to improve > the > >>>>> efficiency. > >>>>> another point I would like to ask what if we use the complete > pathname > >>>>> with > >>>>> require and include, it will be much faster. > >>>> > >>>> Seems like a good idea. I took this example in the PHP manual's > >> comments: > >>>> > >>>> // this can be inside libraries/common.inc.php > >>>> define('__ROOT__', dirname(dirname(__FILE__))); > >>>> // then other scripts use this > >>>> require_once(__ROOT__.'/foo.php); > >>>> > >>>> So we could define __ROOT__ once and use it afterwards. One thing I'm > >>>> not sure about: we prefixed with './' to help in open_basedir case, so > >>>> we would have to test this case. > >>>> > >>>> -- > >>>> Marc Delisle > >>>> http://infomarc.info > >>>> > >>>> > >>>> > >> > ------------------------------------------------------------------------------ > >>>> This SF email is sponsosred by: > >>>> Try Windows Azure free for 90 days Click Here > >>>> http://p.sf.net/sfu/sfd2d-msazure > >>>> _______________________________________________ > >>>> Phpmyadmin-devel mailing list > >>>> Phpmyadmin-devel at lists.sourceforge.net > >>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > >>> > >>> > >>> > >>> > >>> -- > >>> Nandlal Ahirwar > >>> MCA, II yr > >>> Maulana Azad National Institute of Technology, Bhopal > >>> India > >>> > >>> > >>> > >> > ------------------------------------------------------------------------------ > >>> This SF email is sponsosred by: > >>> Try Windows Azure free for 90 days Click Here > >>> http://p.sf.net/sfu/sfd2d-msazure > >>> _______________________________________________ > >>> Phpmyadmin-devel mailing list > >>> Phpmyadmin-devel at lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > >>> > >> > >> Adding autocapitalize and/or autocorrect attributes to tags is > >> not valid HTML5, though, which is what we'd like to achieve (refer to > >> http://www.w3schools.com/html5/tag_input.asp for all input tag > >> attributes allowed in HTML5). > >> > >> I suggest setting these attributes using jQuery in a document-ready > >> event handler if the user agent matches iOS or Android. Like this: > >> > >> $(function () { > >> $('input:text').prop({ > >> autocapitalize: 'off', > >> autocorrect: 'off' > >> }); > >> }); > >> > >> What do you think? > >> > >> > >> > ------------------------------------------------------------------------------ > >> This SF email is sponsosred by: > >> Try Windows Azure free for 90 days Click Here > >> http://p.sf.net/sfu/sfd2d-msazure > >> _______________________________________________ > >> Phpmyadmin-devel mailing list > >> Phpmyadmin-devel at lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > >> > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > This SF email is sponsosred by: > > Try Windows Azure free for 90 days Click Here > > http://p.sf.net/sfu/sfd2d-msazure > > > > > > > > _______________________________________________ > > Phpmyadmin-devel mailing list > > Phpmyadmin-devel at lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > > -- > Marc Delisle > http://infomarc.info > > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Tue Apr 3 16:53:14 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 03 Apr 2012 10:53:14 -0400 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: References: <4F79C977.2090601@infomarc.info> Message-ID: <4F7B0EDA.3020103@infomarc.info> Le 2012-04-02 18:39, Ammar Yasir a écrit : > Hi, > Can we have more clarity on improving reference to global variables. Is the > following snippet an example of the same where? > (From tbl_select.php, $_POST parameters are referenced through $GLOBALS) > $post_params = array( > 'ajax_request', > 'collations', > 'db', > 'distinct', > 'fields', > 'func', > 'max_number_of_fields', > 'names', > 'order', > 'orderField', > 'param', > 'session_max_rows', > 'table', > 'types', > 'where', > ); > foreach ($post_params as $one_post_param) { > if (isset($_POST[$one_post_param])) { > $GLOBALS[$one_post_param] = $_POST[$one_post_param]; > } > } Ammar, this snippet is code added recently, to be able to remove the grab_globals.lib.php library. tbl_select.php uses globals instead of directly referencing $_POST['foo'] so this snippet was a way to keep the script working until better refactoring. However, many scripts are using other global variables as a way to communicate between them or between functions, and we should try to minimize this behavior. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From hiddenpearls at gmail.com Tue Apr 3 18:15:04 2012 From: hiddenpearls at gmail.com (Adnan) Date: Tue, 3 Apr 2012 21:15:04 +0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration Message-ID: hello Michal, I have submitted my proposal, please have a look at it. Give your important input So I could edit my proposal then. Thanks -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Tue Apr 3 18:46:49 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 03 Apr 2012 12:46:49 -0400 Subject: [Phpmyadmin-devel] proposals: Refactoring: Insert/edit, Privileges, Operations, Structure In-Reply-To: References: <4F75D26C.6060002@gmail.com> <4F76F0E1.9080704@infomarc.info> <4F79ED00.2060105@infomarc.info> Message-ID: <4F7B2979.7060205@infomarc.info> Le 2012-04-03 01:43, nandu a écrit : > Marc > I tried my hands on git and was able to push my changes in phpmyadmin > repository, please let me know > if any further changes required. > > Thanks > > Nandu, please give the reference to your repository. Also, please use bottom-posting on this list. > > > > On Mon, Apr 2, 2012 at 11:46 PM, Marc Delisle wrote: > >> Le 2012-04-02 13:18, nandu a écrit : >>> hello >>> Reagarding the submitting of patch I have a doubt since the ios device >>> alphabets to be lowecased, should I just submit a text file with the >>> following code?? >>> >>> $(function () { >>> $('input:text').prop({ >>> autocapitalize: 'off', >>> autocorrect: 'off' >>> }); >>> }); >>> >>> I never submitted a patch before. >> >> Hi, >> to see what a patch looks like, please visit [0], click on one of the >> artifact, then download a file which is attached to the artifact. >> >> [0] https://sourceforge.net/tracker/?group_id=23067&atid=377410 >> >>> thanks.. >>> Mar 31, 2012 at 10:36 PM, J.M. wrote: >>> >>>> Am 31. März 2012 18:51 schrieb nandu : >>>>> Marc, >>>>> >>>>> Thanks for considering, you asked me to submit patch, well for that i >>>> need >>>>> some time till then I found another thing >>>>> that is when we log into phpMyadmin from an iOS device is difficult >>>> because >>>>> the device uppercases the first letter automatically. This can be >>>> disabled >>>>> by adding two attributes in the input tag and setting them both to off. >>>>> it can be patched through >>>>> autocapitalize="off" autocorrect="off" attributes in input. >>>>> jQuery('input[type=text]').attr('autocapitalize','off'); >>>>> >>>>> Also i need some guidelines from you with my proposal >>>>> thanks >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> On Sat, Mar 31, 2012 at 5:26 PM, Marc Delisle >>>> wrote: >>>>>> >>>>>> Le 2012-03-31 06:19, nandu a écrit : >>>>>>> PHP code mixed with HTML tags will basically cause crash, >> "strip_tags" >>>>>>> to >>>>>>> strip every html and php tags >>>>>>> in $var, every characters after "<" is removed. >>>>>>> i think strip_tags() is mixed up. >>>>>>> >>>>>>> we often get error:tbl_replace.php: Missing parameter when adding >> i.e. >>>>>>> entries into mysql from within >>>>>>> phpmyadmin chences of having issue with cookies on the system, i.e.if >>>>>>> disabled cookies in the browser >>>>>>> this can be changed. >>>>>>> Instead of using the elseif statements code can be reduced with >>>>>>> >>>>>> >>>>>> Nandu, >>>>>> please submit some patches, it will be easier to see what you mean. >>>>>> >>>>>>> >>>>>>> wecan either use the static method in the code in order to improve >> the >>>>>>> efficiency. >>>>>>> another point I would like to ask what if we use the complete >> pathname >>>>>>> with >>>>>>> require and include, it will be much faster. >>>>>> >>>>>> Seems like a good idea. I took this example in the PHP manual's >>>> comments: >>>>>> >>>>>> // this can be inside libraries/common.inc.php >>>>>> define('__ROOT__', dirname(dirname(__FILE__))); >>>>>> // then other scripts use this >>>>>> require_once(__ROOT__.'/foo.php); >>>>>> >>>>>> So we could define __ROOT__ once and use it afterwards. One thing I'm >>>>>> not sure about: we prefixed with './' to help in open_basedir case, so >>>>>> we would have to test this case. >>>>>> >>>>>> -- >>>>>> Marc Delisle >>>>>> http://infomarc.info >>>>>> >>>>>> >>>>>> >>>> >> ------------------------------------------------------------------------------ >>>>>> This SF email is sponsosred by: >>>>>> Try Windows Azure free for 90 days Click Here >>>>>> http://p.sf.net/sfu/sfd2d-msazure >>>>>> _______________________________________________ >>>>>> Phpmyadmin-devel mailing list >>>>>> Phpmyadmin-devel at lists.sourceforge.net >>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Nandlal Ahirwar >>>>> MCA, II yr >>>>> Maulana Azad National Institute of Technology, Bhopal >>>>> India >>>>> >>>>> >>>>> >>>> >> ------------------------------------------------------------------------------ >>>>> This SF email is sponsosred by: >>>>> Try Windows Azure free for 90 days Click Here >>>>> http://p.sf.net/sfu/sfd2d-msazure >>>>> _______________________________________________ >>>>> Phpmyadmin-devel mailing list >>>>> Phpmyadmin-devel at lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >>>>> >>>> >>>> Adding autocapitalize and/or autocorrect attributes to tags is >>>> not valid HTML5, though, which is what we'd like to achieve (refer to >>>> http://www.w3schools.com/html5/tag_input.asp for all input tag >>>> attributes allowed in HTML5). >>>> >>>> I suggest setting these attributes using jQuery in a document-ready >>>> event handler if the user agent matches iOS or Android. Like this: >>>> >>>> $(function () { >>>> $('input:text').prop({ >>>> autocapitalize: 'off', >>>> autocorrect: 'off' >>>> }); >>>> }); >>>> >>>> What do you think? -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From nandu130 at gmail.com Tue Apr 3 19:45:15 2012 From: nandu130 at gmail.com (nandu) Date: Tue, 3 Apr 2012 23:15:15 +0530 Subject: [Phpmyadmin-devel] Refactoring: Insert/edit, Privileges, Operations, Structure Message-ID: Marc Please visit https://sourceforge.net/tracker/?func=detail&aid=3514666&group_id=23067&atid=377410 -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From thilinaabeyrathna at gmail.com Tue Apr 3 20:02:46 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Tue, 3 Apr 2012 23:32:46 +0530 Subject: [Phpmyadmin-devel] GSOC- Refactoring Message-ID: Hi Marc, I'm looking to refactor some small piece of code in phpmyadmin. Then I can more familiar with code base. So if you have suggestion please let me know. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ayax88 at gmail.com Tue Apr 3 22:28:43 2012 From: ayax88 at gmail.com (Ammar Yasir) Date: Wed, 4 Apr 2012 01:58:43 +0530 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: References: Message-ID: On Tue, Apr 3, 2012 at 4:03 AM, Ammar Yasir wrote: > Hi, > > The noticed that the table search scripts(tbl_select.php, > tbl_zoom_select.php) and multi-table query(db_qbe.php) basically display a > 'Query-by-Example' form. I think we can design a qbeForm class through > which we can customize a QBE form for each of the three scripts. > > The basic elements of a QBE form are columns and details about each > column. Considering column as an entity, we can assign HTML content of each > column element like datatype, collation, operator, sort, criteria as the > attributes of 'column' entity. To be more specific, > a 'column' entity would contain, > S.No. | Attribute | HTML | Script > 1 | Data-type | text | tbl_select.php, > tbl_zoom_select.php > 2 | Collation | text | tbl_select.php, > tbl_zoom_select.php > 3 | Sort | HTML Select | db_qbe.php > 4 | Ins/Del | HTML input | db_qbe.php > 5 | Modify | output of S.No 4 | db_qbe.php > 6 | Show | HTML checkbox | db_qbe.php > 7 | Criteria | (a) HTML input | db_qbe.php > | (b) HTML Select | tbl_select.php, > tbl_zoom_select.php > 8 | Value | (a) HTML input | tbl_select.php, > tbl_zoom_select.php > | (b) multiselect | tbl_select.php, > tbl_zoom_select.php > | Foreign Values | tbl_select.php, > tbl_zoom_select.php, browse_foreigners.php > > We can decide on what HTML we want to display for each 'column' > entity(depending on the script in consideration) and customize our QBE form. > One thing to note is that, from 'column' entity we will generate an empty > HTML skeleton (say column block). The values of HTML select and others(for > example operators) will be updated using AJAX calls. I guess that could > also be included as a procedure in the QBE class (or column class). > A QBE form can consist of various column blocks ( tbl_zoom_select.php has > 2, db_qbe.php initially has 3 and tbl_select.php has count($fields) ). > For, db_qbe.php 'column' blocks can be added dynamically just by creating > an instance of 'column' entity. > One issue could be that in tbl_zoom_select.php and db_qbe.php we need to > select columns, i.e, columns are displayed in a select box, while in > tbl_select.php all the columns are listed. But I guess, it can be worked > out in time. > > Regards, > Ammar Yasir > > Would such OOP be feasible? -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Tue Apr 3 23:07:13 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 03 Apr 2012 17:07:13 -0400 Subject: [Phpmyadmin-devel] GSOC- Refactoring In-Reply-To: References: Message-ID: <4F7B6681.6050707@infomarc.info> Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit : > Hi Marc, > I'm looking to refactor some small piece of code in phpmyadmin. Then I can > more familiar with code base. So if you have suggestion please let me know. Thilina, in user_password.php there is a long "if" that starts with if (isset($_REQUEST['nopass'])) { can you improve some parts of it? -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From marc at infomarc.info Tue Apr 3 22:51:03 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 03 Apr 2012 16:51:03 -0400 Subject: [Phpmyadmin-devel] about jquery.event.drag Message-ID: <4F7B62B7.2090601@infomarc.info> Hi Madhura, Is there a specific reason why you committed a minified version of this library? See [0]. [0] http://threedubmedia.com/code/event/drag -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From atulpratapsingh05 at gmail.com Wed Apr 4 00:22:41 2012 From: atulpratapsingh05 at gmail.com (Atul Pratap Singh) Date: Wed, 4 Apr 2012 03:52:41 +0530 Subject: [Phpmyadmin-devel] GSoC proposal: Refactoring: Insert/edit, Privileges, Operations, Structure Message-ID: Hi all, I am Atul Pratap Singh, a student from Varanasi, India. I have submitted my proposal for Refactoring: Insert/edit, Privileges, Operations, Structure for GSoC. Please provide your valuable comments and suggestions. It would be great if someone could suggest me some refactoring work in any scripts to practice on. Regards -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India. -------------- next part -------------- An HTML attachment was scrubbed... URL: From rouslan at placella.com Wed Apr 4 01:58:44 2012 From: rouslan at placella.com (Rouslan Placella) Date: Wed, 04 Apr 2012 00:58:44 +0100 Subject: [Phpmyadmin-devel] Updated: GSoC proposal for "Removal of frames" Message-ID: <4F7B8EB4.1080603@placella.com> Hi all, I have just updated my proposal for the removal of frames from PMA. I've made all my points, but it still needs some work, so any feedback will be greatly appreciated :) Thanks. Bye, Rouslan From madhura.cj at gmail.com Wed Apr 4 05:50:55 2012 From: madhura.cj at gmail.com (Madhura Jayaratne) Date: Wed, 4 Apr 2012 09:20:55 +0530 Subject: [Phpmyadmin-devel] about jquery.event.drag In-Reply-To: <4F7B62B7.2090601@infomarc.info> References: <4F7B62B7.2090601@infomarc.info> Message-ID: On Wed, Apr 4, 2012 at 2:21 AM, Marc Delisle wrote: > Hi Madhura, > > Is there a specific reason why you committed a minified version of this > library? See [0]. > > [0] http://threedubmedia.com/code/event/drag > > Hi, No Marc, I think I didn't know by then that the JS libraries are minified when we do a release. I'll update QA_3_5 and master branches. -- Thanks and Regards, Madhura Jayaratne -------------- next part -------------- An HTML attachment was scrubbed... URL: From thilinaabeyrathna at gmail.com Wed Apr 4 06:01:55 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Wed, 4 Apr 2012 09:31:55 +0530 Subject: [Phpmyadmin-devel] GSOC- Refactoring In-Reply-To: <4F7B6681.6050707@infomarc.info> References: <4F7B6681.6050707@infomarc.info> Message-ID: On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle wrote: > Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit : > > Hi Marc, > > I'm looking to refactor some small piece of code in phpmyadmin. Then I > can > > more familiar with code base. So if you have suggestion please let me > know. > > > Thilina, > in user_password.php there is a long "if" that starts with > > if (isset($_REQUEST['nopass'])) { > > can you improve some parts of it? > > Hi Marc, Ok, I'll do. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu130 at gmail.com Wed Apr 4 08:59:49 2012 From: nandu130 at gmail.com (nandu) Date: Wed, 4 Apr 2012 12:29:49 +0530 Subject: [Phpmyadmin-devel] Refactoring: Insert/edit, Privileges, Operations, Structure In-Reply-To: References: Message-ID: Marc, I have posted the 2 patches at the following posts I am unable to change tat [unknown] to my username [nandu130], with reference to the commands git config --global user.name = " " git config --global user.email = " " github is too slow, again cloning and all\ please visit [0], [1] I have successfully posted the patches there. [0] http://sourceforge.net/tracker/?func=detail&aid=3514669&group_id=23067&atid=377410 [1] ] https://sourceforge.net/tracker/?func=detail&aid=3514666&group_id=23067&atid=377410 thanks I -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From hiddenpearls at gmail.com Wed Apr 4 11:07:56 2012 From: hiddenpearls at gmail.com (Adnan) Date: Wed, 4 Apr 2012 14:07:56 +0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: References: Message-ID: On Tue, Apr 3, 2012 at 9:15 PM, Adnan wrote: > hello Michal, > > I have submitted my proposal, please have a look at it. Give your > important input So I could edit my proposal then. > Thanks > Any input please ? > -- > Muhammad Adnan > Twitter: @hiddenpearls > I blog too do u know ? http:// www.imblog.info > Failure takes you higher than success ..! > you sell code, I sell my brain. > > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Wed Apr 4 18:27:52 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 04 Apr 2012 12:27:52 -0400 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: References: Message-ID: <4F7C7688.9070500@infomarc.info> Le 2012-04-03 16:28, Ammar Yasir a écrit : > On Tue, Apr 3, 2012 at 4:03 AM, Ammar Yasir wrote: > >> Hi, >> >> The noticed that the table search scripts(tbl_select.php, >> tbl_zoom_select.php) and multi-table query(db_qbe.php) basically display a >> 'Query-by-Example' form. I think we can design a qbeForm class through >> which we can customize a QBE form for each of the three scripts. >> >> The basic elements of a QBE form are columns and details about each >> column. Considering column as an entity, we can assign HTML content of each >> column element like datatype, collation, operator, sort, criteria as the >> attributes of 'column' entity. To be more specific, >> a 'column' entity would contain, >> S.No. | Attribute | HTML | Script >> 1 | Data-type | text | tbl_select.php, >> tbl_zoom_select.php >> 2 | Collation | text | tbl_select.php, >> tbl_zoom_select.php >> 3 | Sort | HTML Select | db_qbe.php >> 4 | Ins/Del | HTML input | db_qbe.php >> 5 | Modify | output of S.No 4 | db_qbe.php >> 6 | Show | HTML checkbox | db_qbe.php >> 7 | Criteria | (a) HTML input | db_qbe.php >> | (b) HTML Select | tbl_select.php, >> tbl_zoom_select.php >> 8 | Value | (a) HTML input | tbl_select.php, >> tbl_zoom_select.php >> | (b) multiselect | tbl_select.php, >> tbl_zoom_select.php >> | Foreign Values | tbl_select.php, >> tbl_zoom_select.php, browse_foreigners.php >> >> We can decide on what HTML we want to display for each 'column' >> entity(depending on the script in consideration) and customize our QBE form. >> One thing to note is that, from 'column' entity we will generate an empty >> HTML skeleton (say column block). The values of HTML select and others(for >> example operators) will be updated using AJAX calls. I guess that could >> also be included as a procedure in the QBE class (or column class). >> A QBE form can consist of various column blocks ( tbl_zoom_select.php has >> 2, db_qbe.php initially has 3 and tbl_select.php has count($fields) ). >> For, db_qbe.php 'column' blocks can be added dynamically just by creating >> an instance of 'column' entity. >> One issue could be that in tbl_zoom_select.php and db_qbe.php we need to >> select columns, i.e, columns are displayed in a select box, while in >> tbl_select.php all the columns are listed. But I guess, it can be worked >> out in time. >> >> Regards, >> Ammar Yasir >> >> Would such OOP be feasible? Ammar, maybe but db_qbe.php has a look very different from tbl_select.php. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From darshanasbg at yahoo.com Wed Apr 4 19:50:29 2012 From: darshanasbg at yahoo.com (Darshana Gunawardana) Date: Wed, 4 Apr 2012 10:50:29 -0700 (PDT) Subject: [Phpmyadmin-devel] [GSoC 2012] Removal of frames Message-ID: <1333561829.72463.YahooMailNeo@web113420.mail.gq1.yahoo.com> Hi Dieter, I would like to know more about the idea 'Removal of Frames'. I have gone through with the wiki page[0] yet i want to clarify the scope of this project. [0] https://wiki.phpmyadmin.net/pma/Remove_frames Thank you. Darshana -------------- next part -------------- An HTML attachment was scrubbed... URL: From pe.chanaka.ck at gmail.com Thu Apr 5 04:55:22 2012 From: pe.chanaka.ck at gmail.com (Chanaka Dharmarathna) Date: Thu, 5 Apr 2012 08:25:22 +0530 Subject: [Phpmyadmin-devel] Need some suggestions for a feature request In-Reply-To: References: <4F5E2AA0.1080009@infomarc.info> <4F5E5C49.80806@infomarc.info> Message-ID: On Fri, Mar 30, 2012 at 10:27 AM, Chanaka Dharmarathna < pe.chanaka.ck at gmail.com> wrote: > > > On Thu, Mar 22, 2012 at 1:25 AM, Chanaka Dharmarathna < > pe.chanaka.ck at gmail.com> wrote: > >> >> >> On Sat, Mar 17, 2012 at 11:06 PM, Chanaka Dharmarathna < >> pe.chanaka.ck at gmail.com> wrote: >> >>> >>> >>> On Tue, Mar 13, 2012 at 1:57 AM, Marc Delisle wrote: >>> >>>> Le 2012-03-12 13:53, Chanaka Dharmarathna a écrit : >>>> > On Mon, Mar 12, 2012 at 10:26 PM, Marc Delisle >>>> wrote: >>>> > >>>> >> Le 2012-03-12 05:55, Chanaka Dharmarathna a écrit : >>>> >>> Hi All, >>>> >>> >>>> >>> I'm interested on working the feature request [1]. As I >>>> understood, it >>>> >> is >>>> >>> requested to link each result, which shows after browsing (click >>>> brows) >>>> >> any >>>> >>> field in table structure, to relevant data row in that table. >>>> Please make >>>> >>> me correct if I'm wrong. >>>> >>> >>>> >>> But if the browsing row is already a link, due to that field has a >>>> >> relation >>>> >>> with another table field, what should be the behavior of this >>>> feature. My >>>> >>> suggestion is to without bothering the column already a link or >>>> not, add >>>> >> a >>>> >>> new link as 'show data row' after click on corresponding cells. If >>>> you >>>> >> have >>>> >>> any suggestions please inform me to make some improvements. As well >>>> it is >>>> >>> very helpful for me if you can suggest some source files related to >>>> these >>>> >>> feature. >>>> >>> >>>> >>> [1] >>>> >>> >>>> >> >>>> http://sourceforge.net/tracker/index.php?func=detail&aid=2998185&group_id=23067&atid=377411 >>>> >>> >>>> >>> Regards ! >>>> >> >>>> >> Hi, >>>> >> first, are you aware that this feature request refers to the "browse >>>> >> distinct value" action, not the browse action? >>>> >> >>>> >> Click on a table, then Structure, then under More, click Browse >>>> distinct >>>> >> values. >>>> >> >>>> >> In the results panel, I could not find a situation where there are >>>> links. >>>> >> >>>> >> >>>> >> -- >>>> >> Marc Delisle >>>> >> http://infomarc.info >>>> >> >>>> >> >>>> > Hi Marc, >>>> > >>>> > I mean the same thing which you have described. I'll describe >>>> you what >>>> > is the scenario I mentioned. >>>> > >>>> > * We have a Company which buys Car from several companies and sells to >>>> > customers. >>>> > * We have 5 tables in our database. company, car, customer, sales and >>>> > source_of_supply. >>>> > * Source of Supply table has n:m relationship (Company - Car) >>>> > * Sales table has n:m relationship (Customer - Car) >>>> > >>>> > While browsing distinct values of car_id or company_id in structure >>>> of the >>>> > source_of_supply table, each data appear as a link. If I click on it, >>>> a >>>> > drop down appear with the possible values in a pop up, and the link >>>> for >>>> > corresponding company or car can be appear in that pop up. Same thing >>>> for >>>> > the sales table. Hope you can understand the described scenario and >>>> hoping >>>> > any suggestions. >>>> > >>>> > Regards ! >>>> >>>> Hi Chanaka, >>>> Your suggestion makes sense but it will be easier to decide when seeing >>>> the implementation. >>>> >>>> -- >>>> Marc Delisle >>>> http://infomarc.info >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Try before you buy = See our experts in action! >>>> The most comprehensive online learning library for Microsoft developers >>>> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, >>>> Metro Style Apps, more. Free future releases when you subscribe now! >>>> http://p.sf.net/sfu/learndevnow-dev2 >>>> _______________________________________________ >>>> Phpmyadmin-devel mailing list >>>> Phpmyadmin-devel at lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >>>> >>>> >>> Hi Marc, >>> >>> I implemented the feature request *ID: 2998185* in sourceforge [1]. The >>> patch is attached for this implementation in tracker:patches [2]. Please >>> update me if there should be any improvements regarding to this. >>> >>> Regards ! >>> >>> [1] >>> https://sourceforge.net/tracker/index.php?func=detail&aid=2998185&group_id=23067&atid=377411 >>> [2] >>> https://sourceforge.net/tracker/?func=detail&aid=3507111&group_id=23067&atid=377410 >>> >>> -- >>> ____________________________________ >>> >>> Chanaka Indrajith >>> Bsc.Computer Engineering Undergraduate >>> Faculty of Engineering >>> University of Peradeniya >>> ____________________________________ >>> >>> >> Hi Marc, >> >> Sorry for little delay to respond. I got your suggestions to improve the >> patch [1] regarding the feature request [2]. >> I did those improvements and attached the modified patch and a sql file >> with some data on the same page [1]. >> Thanks for your valuable suggestions. >> >> >> [1] >> https://sourceforge.net/tracker/index.php?func=detail&aid=2998185&group_id=23067&atid=377411 >> [2] >> https://sourceforge.net/tracker/?func=detail&aid=3507111&group_id=23067&atid=377410 >> >> Regards ! >> >> -- >> ____________________________________ >> >> Chanaka Indrajith >> Bsc.Computer Engineering Undergraduate >> Faculty of Engineering >> University of Peradeniya >> ____________________________________ >> >> > Hi, > > Including the suggestions of Marc, I improved the patch for feature > request [0] , and attached at [1]. If anyone can review it, I can do the > needed modifications to that if needed. > > Regards ! > > [0]: > https://sourceforge.net/tracker/index.php?func=detail&aid=2998185&group_id=23067&atid=377411 > [1]: > https://sourceforge.net/tracker/?func=detail&aid=3507111&group_id=23067&atid=377410 > > -- > ____________________________________ > > Chanaka Indrajith > Bsc.Computer Engineering Undergraduate > Faculty of Engineering > University of Peradeniya > ____________________________________ > > Hi Marc, I update my patch [0] , to support latest code base. [0]: https://sourceforge.net/tracker/?func=detail&aid=3507111&group_id=23067&atid=377410 Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya ____________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From dieter.adriaenssens at gmail.com Thu Apr 5 11:52:42 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Thu, 5 Apr 2012 11:52:42 +0200 Subject: [Phpmyadmin-devel] [GSoC 2012] Removal of frames In-Reply-To: <1333561829.72463.YahooMailNeo@web113420.mail.gq1.yahoo.com> References: <1333561829.72463.YahooMailNeo@web113420.mail.gq1.yahoo.com> Message-ID: Hi, Op 4 april 2012 19:50 heeft Darshana Gunawardana het volgende geschreven: > Hi Dieter, > > I would like to know more about the idea 'Removal of Frames'. I have gone > through with the wiki page[0] yet i want to clarify the scope of this > project. I think that the idea is quite clear : the current html we are using now will be removed. The different pages (navigation and main) will be merged into one page and
will be used to get the same visual result. Because of the merging some functionality and scripts will have to be created to accommodate refreshing of data, when navigating. I hope this helps to get an idea. -- Kind regards, Dieter Adriaenssens From michal at cihar.com Thu Apr 5 15:30:48 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 5 Apr 2012 15:30:48 +0200 Subject: [Phpmyadmin-devel] PDF export - ID: 1376650 -- need help In-Reply-To: <4F721199.8000102@placella.com> References: <4F71CBD0.70602@infomarc.info> <4F72109C.7010002@placella.com> <4F721199.8000102@placella.com> Message-ID: <20120405153048.39f42279@rincewind.suse.cz> Hi Dne Tue, 27 Mar 2012 20:14:33 +0100 Rouslan Placella napsal(a): > Actually, nevermind, it only works as: > > grep -r pdf_structure_or_data * As you most likely doing this in Git checout, "git grep pdf_structure_or_data" might be even better choice. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Thu Apr 5 15:33:02 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 5 Apr 2012 15:33:02 +0200 Subject: [Phpmyadmin-devel] Improving Sync for Big Tables In-Reply-To: References: <4F6BC696.6020307@gmail.com> Message-ID: <20120405153302.07470968@rincewind.suse.cz> Hi Dne Mon, 26 Mar 2012 02:54:16 +0500 adeel khan napsal(a): > But as we can set the timeout value to a minimum execution time > programmatically we would always be assured that we would able to get that > time for a pass. This is already used in importing, see libraries/import.lib.php, especially PMA_checkTimeout, so it might be turned into more generic solution. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Thu Apr 5 15:38:16 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 5 Apr 2012 15:38:16 +0200 Subject: [Phpmyadmin-devel] Display multiple query results at once In-Reply-To: References: Message-ID: <20120405153816.77f4e7d7@rincewind.suse.cz> Hi Dne Wed, 28 Mar 2012 02:38:09 +0530 Chanaka Dharmarathna napsal(a): > I feel it's better to have some clarifications on above title under [1] in > GSoC idea list. This topic is mentioned about displaying multiple query > results at once in same page (Please make me correct if I'm wrong). The > results will be appear as set of tables in the same page. > > But, in order to get those multiple query results, from where I should > execute those two queries separately ? > > If it is SQL tab in pma, is it a task relating to above title that > improving SQL query window page to adding multiple query boxes ? or any > suggested way ? There is not need to add multiple query boxes as you can enter multiple queries in one (eg. SELECT 1; SELECT 2). Anyway this is mostly important for routines as described earlier by Rouslan. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Thu Apr 5 16:58:04 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 05 Apr 2012 10:58:04 -0400 Subject: [Phpmyadmin-devel] about the export_xml branch Message-ID: <4F7DB2FC.4080209@infomarc.info> Hi, is this branch still active and needed? -- Marc Delisle http://infomarc.info From michal at cihar.com Thu Apr 5 17:17:22 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 5 Apr 2012 17:17:22 +0200 Subject: [Phpmyadmin-devel] about the export_xml branch In-Reply-To: <4F7DB2FC.4080209@infomarc.info> References: <4F7DB2FC.4080209@infomarc.info> Message-ID: <20120405171722.16651ffe@rincewind.suse.cz> Hi Dne Thu, 05 Apr 2012 10:58:04 -0400 Marc Delisle napsal(a): > is this branch still active and needed? I've asked about this less than year ago ;-) http://thread.gmane.org/gmane.comp.php.phpmyadmin.devel/9743 -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Thu Apr 5 17:24:10 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 05 Apr 2012 11:24:10 -0400 Subject: [Phpmyadmin-devel] about the export_xml branch In-Reply-To: <20120405171722.16651ffe@rincewind.suse.cz> References: <4F7DB2FC.4080209@infomarc.info> <20120405171722.16651ffe@rincewind.suse.cz> Message-ID: <4F7DB91A.5080702@infomarc.info> Le 2012-04-05 11:17, Michal Čihař a écrit : > Hi > > Dne Thu, 05 Apr 2012 10:58:04 -0400 > Marc Delisle napsal(a): > >> is this branch still active and needed? > > I've asked about this less than year ago ;-) > > http://thread.gmane.org/gmane.comp.php.phpmyadmin.devel/9743 There was a commit on this branch on Feb 16, 2012. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From pe.chanaka.ck at gmail.com Thu Apr 5 19:26:47 2012 From: pe.chanaka.ck at gmail.com (Chanaka Dharmarathna) Date: Thu, 5 Apr 2012 22:56:47 +0530 Subject: [Phpmyadmin-devel] Display multiple query results at once In-Reply-To: <20120405153816.77f4e7d7@rincewind.suse.cz> References: <20120405153816.77f4e7d7@rincewind.suse.cz> Message-ID: On Thu, Apr 5, 2012 at 7:08 PM, Michal Čihař wrote: > Hi > > Dne Wed, 28 Mar 2012 02:38:09 +0530 > Chanaka Dharmarathna napsal(a): > > > I feel it's better to have some clarifications on above title under [1] > in > > GSoC idea list. This topic is mentioned about displaying multiple query > > results at once in same page (Please make me correct if I'm wrong). The > > results will be appear as set of tables in the same page. > > > > But, in order to get those multiple query results, from where I should > > execute those two queries separately ? > > > > If it is SQL tab in pma, is it a task relating to above title that > > improving SQL query window page to adding multiple query boxes ? or any > > suggested way ? > > There is not need to add multiple query boxes as you can enter multiple > queries in one (eg. SELECT 1; SELECT 2). Anyway this is mostly > important for routines as described earlier by Rouslan. > > -- > Michal Čihař | http://cihar.com | http://blog.cihar.com > > > ------------------------------------------------------------------------------ > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > Hi Michal, I got the idea you mentioned and already have started to fix the bug [0] using multiple queries in the same SQL query box. [0]: https://sourceforge.net/tracker/?func=detail&aid=3474853&group_id=23067&atid=377408 Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From dieter.adriaenssens at gmail.com Thu Apr 5 21:22:48 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Thu, 5 Apr 2012 21:22:48 +0200 Subject: [Phpmyadmin-devel] about the export_xml branch In-Reply-To: <4F7DB91A.5080702@infomarc.info> References: <4F7DB2FC.4080209@infomarc.info> <20120405171722.16651ffe@rincewind.suse.cz> <4F7DB91A.5080702@infomarc.info> Message-ID: Op 5 april 2012 17:24 heeft Marc Delisle het volgende geschreven: > Le 2012-04-05 11:17, Michal Čihař a écrit : >> Hi >> >> Dne Thu, 05 Apr 2012 10:58:04 -0400 >> Marc Delisle napsal(a): >> >>> is this branch still active and needed? >> >> I've asked about this less than year ago ;-) >> >> http://thread.gmane.org/gmane.comp.php.phpmyadmin.devel/9743 > > There was a commit on this branch on Feb 16, 2012. Madhura did something with that branch, but I don't kno what. I created it before previous GSoC, as far as I'm concerned it can be removed. -- Kind regards, Dieter Adriaenssens From dieter.adriaenssens at gmail.com Thu Apr 5 21:40:29 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Thu, 5 Apr 2012 21:40:29 +0200 Subject: [Phpmyadmin-devel] about the export_xml branch In-Reply-To: References: <4F7DB2FC.4080209@infomarc.info> <20120405171722.16651ffe@rincewind.suse.cz> <4F7DB91A.5080702@infomarc.info> Message-ID: Op 5 april 2012 21:22 heeft Dieter Adriaenssens het volgende geschreven: > Op 5 april 2012 17:24 heeft Marc Delisle het > volgende geschreven: >> Le 2012-04-05 11:17, Michal Čihař a écrit : >>> Hi >>> >>> Dne Thu, 05 Apr 2012 10:58:04 -0400 >>> Marc Delisle napsal(a): >>> >>>> is this branch still active and needed? >>> >>> I've asked about this less than year ago ;-) >>> >>> http://thread.gmane.org/gmane.comp.php.phpmyadmin.devel/9743 >> >> There was a commit on this branch on Feb 16, 2012. > > Madhura did something with that branch, but I don't kno what. > I created it before previous GSoC, as far as I'm concerned it can be removed. Wait, that branch contains some patches for exporting views in xml. But they would cause problems when import the xml again, AFAIR. I was going to fix this before merging it to master. If we get a GSoC project for the plugins idea, these changes might be void anyway. commits : bbdf4cf808e6 87575151eec d0caeef254b d03cf63a9fd -- Kind regards, Dieter Adriaenssens From alex.ukf at gmail.com Thu Apr 5 21:50:59 2012 From: alex.ukf at gmail.com (Alex Marin) Date: Thu, 5 Apr 2012 22:50:59 +0300 Subject: [Phpmyadmin-devel] Such a beautiful evening ... Message-ID: ... for reading GSoC applications before going to sleep, isn't it? So, with the start of the final countdown, I thought I'd add another proposal to your list. I realize that there is not much time left for feedback, but I hope you enjoy my ideas. All the best, Alex -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu130 at gmail.com Thu Apr 5 22:07:51 2012 From: nandu130 at gmail.com (nandu) Date: Fri, 6 Apr 2012 01:37:51 +0530 Subject: [Phpmyadmin-devel] draft proposal feedback Message-ID: Marc I drafted a proposal, please tell me whether any changes? http://www.4shared.com/office/Abflf2Jn/proposal_Refactoring.html thanks -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Thu Apr 5 22:16:03 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 05 Apr 2012 16:16:03 -0400 Subject: [Phpmyadmin-devel] draft proposal feedback In-Reply-To: References: Message-ID: <4F7DFD83.5050809@infomarc.info> Le 2012-04-05 16:07, nandu a écrit : > Marc > > I drafted a proposal, please tell me whether any changes? > > http://www.4shared.com/office/Abflf2Jn/proposal_Refactoring.html Sorry, as mentioned on our applicant guide, the mentors do not wish to help drafting proposals. Please submit your proposal via the google-melange.com site (before the deadline) and the mentors will comment it. Then you can refine it as needed. -- Marc Delisle http://infomarc.info From nandu130 at gmail.com Thu Apr 5 22:18:38 2012 From: nandu130 at gmail.com (nandu) Date: Fri, 6 Apr 2012 01:48:38 +0530 Subject: [Phpmyadmin-devel] draft proposal feedback In-Reply-To: <4F7DFD83.5050809@infomarc.info> References: <4F7DFD83.5050809@infomarc.info> Message-ID: ok, expecting some feedback atleast Sir. On Fri, Apr 6, 2012 at 1:46 AM, Marc Delisle wrote: > Le 2012-04-05 16:07, nandu a écrit : > > Marc > > > > I drafted a proposal, please tell me whether any changes? > > > > http://www.4shared.com/office/Abflf2Jn/proposal_Refactoring.html > > Sorry, as mentioned on our applicant guide, the mentors do not wish to > help drafting proposals. Please submit your proposal via the > google-melange.com site (before the deadline) and the mentors will > comment it. Then you can refine it as needed. > > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From madhura.cj at gmail.com Fri Apr 6 05:18:39 2012 From: madhura.cj at gmail.com (Madhura Jayaratne) Date: Fri, 6 Apr 2012 08:48:39 +0530 Subject: [Phpmyadmin-devel] about the export_xml branch In-Reply-To: References: <4F7DB2FC.4080209@infomarc.info> <20120405171722.16651ffe@rincewind.suse.cz> <4F7DB91A.5080702@infomarc.info> Message-ID: On Fri, Apr 6, 2012 at 12:52 AM, Dieter Adriaenssens < dieter.adriaenssens at gmail.com> wrote: > Op 5 april 2012 17:24 heeft Marc Delisle het > volgende geschreven: > > Le 2012-04-05 11:17, Michal Čihař a écrit : > >> Hi > >> > >> Dne Thu, 05 Apr 2012 10:58:04 -0400 > >> Marc Delisle napsal(a): > >> > >>> is this branch still active and needed? > >> > >> I've asked about this less than year ago ;-) > >> > >> http://thread.gmane.org/gmane.comp.php.phpmyadmin.devel/9743 > > > > There was a commit on this branch on Feb 16, 2012. > > Madhura did something with that branch, but I don't kno what. > I created it before previous GSoC, as far as I'm concerned it can be > removed. > > I fixed the bug #3076692 [1] with commits e659018eb1ee and 6108cd4d01be. And also did some code cleaning up. -- Thanks and Regards, Madhura Jayaratne [1] http://sourceforge.net/tracker/?func=detail&aid=3076692&group_id=23067&atid=377408 -------------- next part -------------- An HTML attachment was scrubbed... URL: From waheedmp3 at gmail.com Fri Apr 6 06:28:51 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Fri, 6 Apr 2012 06:28:51 +0200 Subject: [Phpmyadmin-devel] GSoC Patch submitting Message-ID: I read that GSoC applicants should submit patches until 10/4, which is after the SoC registration deadline, does that mean I'll be able to edit my proposal to add patches info. until that day? even after registration close? If no, then how will I include my patches' info. in my proposal later? Best Regards,, -------------- next part -------------- An HTML attachment was scrubbed... URL: From michal at cihar.com Fri Apr 6 08:34:10 2012 From: michal at cihar.com (Michal =?ISO-8859-2?B?yGloYfg=?=) Date: Fri, 6 Apr 2012 08:34:10 +0200 Subject: [Phpmyadmin-devel] GSoC Patch submitting In-Reply-To: References: Message-ID: <20120406083410.4350e73d@nutt.cihar.com> Hi Dne Fri, 6 Apr 2012 06:28:51 +0200 Ahmed Waheed napsal(a): > I read that GSoC applicants should submit patches until 10/4, which is > after the SoC registration deadline, > does that mean I'll be able to edit my proposal to add patches info. until > that day? even after registration close? > If no, then how will I include my patches' info. in my proposal later? I'm not 100% sure about editing proposal, but you will definitely be able to comment it. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From waheedmp3 at gmail.com Fri Apr 6 11:37:45 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Fri, 6 Apr 2012 11:37:45 +0200 Subject: [Phpmyadmin-devel] GSoC Patch submitting In-Reply-To: <20120406083410.4350e73d@nutt.cihar.com> References: <20120406083410.4350e73d@nutt.cihar.com> Message-ID: Hi Michal, But are you sure about the patch submitting deadline? and my proposal would be eligible at first, I want make sure that my proposal will not be neglected because it won't contain any patches at first, can anyone verify that? -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Fri Apr 6 12:53:30 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 06 Apr 2012 06:53:30 -0400 Subject: [Phpmyadmin-devel] GSoC Patch submitting In-Reply-To: References: <20120406083410.4350e73d@nutt.cihar.com> Message-ID: <4F7ECB2A.2090606@infomarc.info> Le 2012-04-06 05:37, Ahmed Waheed a écrit : > Hi Michal, > But are you sure about the patch submitting deadline? and my proposal > would be eligible at first, I want make sure that my proposal will not be > neglected because it won't contain any patches at first, can anyone verify > that? The phpMyAdmin mentoring team won't consider a proposal from someone who has not submitted a patch before April 10, 19:00 UTC. -- Marc Delisle http://infomarc.info From marc at infomarc.info Fri Apr 6 13:09:03 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 06 Apr 2012 07:09:03 -0400 Subject: [Phpmyadmin-devel] about the export_xml branch In-Reply-To: References: <4F7DB2FC.4080209@infomarc.info> <20120405171722.16651ffe@rincewind.suse.cz> <4F7DB91A.5080702@infomarc.info> Message-ID: <4F7ECECF.6090805@infomarc.info> Le 2012-04-05 23:18, Madhura Jayaratne a écrit : > On Fri, Apr 6, 2012 at 12:52 AM, Dieter Adriaenssens < > dieter.adriaenssens at gmail.com> wrote: > >> Op 5 april 2012 17:24 heeft Marc Delisle het >> volgende geschreven: >>> Le 2012-04-05 11:17, Michal Čihař a écrit : >>>> Hi >>>> >>>> Dne Thu, 05 Apr 2012 10:58:04 -0400 >>>> Marc Delisle napsal(a): >>>> >>>>> is this branch still active and needed? >>>> >>>> I've asked about this less than year ago ;-) >>>> >>>> http://thread.gmane.org/gmane.comp.php.phpmyadmin.devel/9743 >>> >>> There was a commit on this branch on Feb 16, 2012. >> >> Madhura did something with that branch, but I don't kno what. >> I created it before previous GSoC, as far as I'm concerned it can be >> removed. >> >> I fixed the bug #3076692 [1] with commits e659018eb1ee and 6108cd4d01be. > And also did some code cleaning up. Any plans to merge to master? -- Marc Delisle http://infomarc.info From ayax88 at gmail.com Fri Apr 6 13:38:51 2012 From: ayax88 at gmail.com (Ammar Yasir) Date: Fri, 6 Apr 2012 17:08:51 +0530 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: <4F7B0EDA.3020103@infomarc.info> References: <4F79C977.2090601@infomarc.info> <4F7B0EDA.3020103@infomarc.info> Message-ID: On Tue, Apr 3, 2012 at 8:23 PM, Marc Delisle wrote: > Le 2012-04-02 18:39, Ammar Yasir a écrit : > > Hi, > > Can we have more clarity on improving reference to global variables. Is > the > > following snippet an example of the same where? > > (From tbl_select.php, $_POST parameters are referenced through $GLOBALS) > > $post_params = array( > > 'ajax_request', > > 'collations', > > 'db', > > 'distinct', > > 'fields', > > 'func', > > 'max_number_of_fields', > > 'names', > > 'order', > > 'orderField', > > 'param', > > 'session_max_rows', > > 'table', > > 'types', > > 'where', > > ); > > foreach ($post_params as $one_post_param) { > > if (isset($_POST[$one_post_param])) { > > $GLOBALS[$one_post_param] = $_POST[$one_post_param]; > > } > > } > > Ammar, > this snippet is code added recently, to be able to remove the > grab_globals.lib.php library. > > tbl_select.php uses globals instead of directly referencing > $_POST['foo'] so this snippet was a way to keep the script working until > better refactoring. > > However, many scripts are using other global variables as a way to > communicate between them or between functions, and we should try to > minimize this behavior. > > Is the use of $sql_query variable as a GET variable for sql.php an example of the same? (communication between scripts) > -- > Marc Delisle > http://infomarc.info > > > > ------------------------------------------------------------------------------ > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Fri Apr 6 13:51:31 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 06 Apr 2012 07:51:31 -0400 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: References: <4F79C977.2090601@infomarc.info> <4F7B0EDA.3020103@infomarc.info> Message-ID: <4F7ED8C3.8080700@infomarc.info> Le 2012-04-06 07:38, Ammar Yasir a écrit : > On Tue, Apr 3, 2012 at 8:23 PM, Marc Delisle wrote: > >> Le 2012-04-02 18:39, Ammar Yasir a écrit : >>> Hi, >>> Can we have more clarity on improving reference to global variables. Is >> the >>> following snippet an example of the same where? >>> (From tbl_select.php, $_POST parameters are referenced through $GLOBALS) >>> $post_params = array( >>> 'ajax_request', >>> 'collations', >>> 'db', >>> 'distinct', >>> 'fields', >>> 'func', >>> 'max_number_of_fields', >>> 'names', >>> 'order', >>> 'orderField', >>> 'param', >>> 'session_max_rows', >>> 'table', >>> 'types', >>> 'where', >>> ); >>> foreach ($post_params as $one_post_param) { >>> if (isset($_POST[$one_post_param])) { >>> $GLOBALS[$one_post_param] = $_POST[$one_post_param]; >>> } >>> } >> >> Ammar, >> this snippet is code added recently, to be able to remove the >> grab_globals.lib.php library. >> >> tbl_select.php uses globals instead of directly referencing >> $_POST['foo'] so this snippet was a way to keep the script working until >> better refactoring. >> >> However, many scripts are using other global variables as a way to >> communicate between them or between functions, and we should try to >> minimize this behavior. >> >> Is the use of $sql_query variable as a GET variable for sql.php an > example of the same? > (communication between scripts) GET and POST variables are always about communication between scripts, right? I meant that some functions are either using the global keyword or $GLOBALS to reach some global variables. Also, procedural code in included files are using global variables. -- Marc Delisle http://infomarc.info From madhura.cj at gmail.com Fri Apr 6 14:24:12 2012 From: madhura.cj at gmail.com (Madhura Jayaratne) Date: Fri, 6 Apr 2012 17:54:12 +0530 Subject: [Phpmyadmin-devel] about the export_xml branch In-Reply-To: <4F7ECECF.6090805@infomarc.info> References: <4F7DB2FC.4080209@infomarc.info> <20120405171722.16651ffe@rincewind.suse.cz> <4F7DB91A.5080702@infomarc.info> <4F7ECECF.6090805@infomarc.info> Message-ID: On Fri, Apr 6, 2012 at 4:39 PM, Marc Delisle wrote: > Le 2012-04-05 23:18, Madhura Jayaratne a écrit : > > On Fri, Apr 6, 2012 at 12:52 AM, Dieter Adriaenssens < > > dieter.adriaenssens at gmail.com> wrote: > > > >> Op 5 april 2012 17:24 heeft Marc Delisle het > >> volgende geschreven: > >>> Le 2012-04-05 11:17, Michal Čihař a écrit : > >>>> Hi > >>>> > >>>> Dne Thu, 05 Apr 2012 10:58:04 -0400 > >>>> Marc Delisle napsal(a): > >>>> > >>>>> is this branch still active and needed? > >>>> > >>>> I've asked about this less than year ago ;-) > >>>> > >>>> http://thread.gmane.org/gmane.comp.php.phpmyadmin.devel/9743 > >>> > >>> There was a commit on this branch on Feb 16, 2012. > >> > >> Madhura did something with that branch, but I don't kno what. > >> I created it before previous GSoC, as far as I'm concerned it can be > >> removed. > >> > >> I fixed the bug #3076692 [1] with commits e659018eb1ee and 6108cd4d01be. > > And also did some code cleaning up. > > Any plans to merge to master? > > Well, as mentioned by Dieter, problems when importing back an xml export has to be resolved before merging the changes to master. The bug I fixed was one of them. Bug #3136655 [2] is another. ( This one seems to be fixed with the patches attached to #3135414 [3]. Need to verify though). If these are the only problems I think it's ok to merge the branch to master. -- Thanks and Regards, Madhura Jayaratne [2] http://sourceforge.net/tracker/?func=detail&aid=3136655&group_id=23067&atid=377408 [3] http://sourceforge.net/tracker/?func=detail&aid=3135414&group_id=23067&atid=377410 -------------- next part -------------- An HTML attachment was scrubbed... URL: From waheedmp3 at gmail.com Fri Apr 6 14:53:43 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Fri, 6 Apr 2012 14:53:43 +0200 Subject: [Phpmyadmin-devel] GSoC Patch submitting In-Reply-To: <4F7ECB2A.2090606@infomarc.info> References: <20120406083410.4350e73d@nutt.cihar.com> <4F7ECB2A.2090606@infomarc.info> Message-ID: Hi Marc, Well, today is the proposal deadline, how would I attach the patches I submit later before 10 April to my proposal? Best Regards,, -------------- next part -------------- An HTML attachment was scrubbed... URL: From darshanasbg at yahoo.com Fri Apr 6 15:09:57 2012 From: darshanasbg at yahoo.com (Darshana Gunawardana) Date: Fri, 6 Apr 2012 06:09:57 -0700 (PDT) Subject: [Phpmyadmin-devel] GSoC Patch submitting In-Reply-To: References: <20120406083410.4350e73d@nutt.cihar.com> <4F7ECB2A.2090606@infomarc.info> Message-ID: <1333717797.44625.YahooMailNeo@web113402.mail.gq1.yahoo.com> > Hi Marc, >    Well, today is the proposal deadline, how would I attach the patches I submit later before 10 April to my proposal? > Best Regards,, Hi Ahmed, As far as I know, even after the deadline applicant and the mentors of organization can comment about the proposal. So all you have to do is put a comment once you have done submitting a patch.  - Regards, Darshana -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Fri Apr 6 15:33:28 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 06 Apr 2012 09:33:28 -0400 Subject: [Phpmyadmin-devel] GSoC Patch submitting In-Reply-To: References: <20120406083410.4350e73d@nutt.cihar.com> <4F7ECB2A.2090606@infomarc.info> Message-ID: <4F7EF0A8.9020004@infomarc.info> Le 2012-04-06 08:53, Ahmed Waheed a écrit : > Hi Marc, > Well, today is the proposal deadline, how would I attach the patches I > submit later before 10 April to my proposal? > Best Regards,, Ahmed, you do not attach the patches to your proposal; you either modify your proposal or add a comment to it, referencing your patch(es). See [0] in the "Contributing codes" for two ways of submitting a patch. [0] http://www.phpmyadmin.net/home_page/devel.php -- Marc Delisle http://infomarc.info From waheedmp3 at gmail.com Fri Apr 6 15:44:40 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Fri, 6 Apr 2012 15:44:40 +0200 Subject: [Phpmyadmin-devel] GSoC Patch submitting In-Reply-To: <4F7EF0A8.9020004@infomarc.info> References: <20120406083410.4350e73d@nutt.cihar.com> <4F7ECB2A.2090606@infomarc.info> <4F7EF0A8.9020004@infomarc.info> Message-ID: Thanks Marc, and Darshana. Best Regards,, -------------- next part -------------- An HTML attachment was scrubbed... URL: From waheedmp3 at gmail.com Fri Apr 6 15:51:01 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Fri, 6 Apr 2012 15:51:01 +0200 Subject: [Phpmyadmin-devel] Design features Message-ID: Hi everybody,, I checked PMA well, and so the documentation for the design features and all I found is that it enables: -Exporting graphical schema for existing databases. -Creating, and editing relations between tables graphically. So I just want to make sure; is there any feature that enable designing new graphical models schema, or E-R diagrams? Best Regards,, Ahmed Waheed -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Fri Apr 6 16:18:08 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 06 Apr 2012 10:18:08 -0400 Subject: [Phpmyadmin-devel] Design features In-Reply-To: References: Message-ID: <4F7EFB20.6060903@infomarc.info> Le 2012-04-06 09:51, Ahmed Waheed a écrit : > Hi everybody,, > I checked PMA well, and so the documentation for the design features > and all I found is that it enables: > -Exporting graphical schema for existing databases. > -Creating, and editing relations between tables graphically. > So I just want to make sure; is there any feature that enable designing > new graphical models schema, or E-R diagrams? No. -- Marc Delisle http://infomarc.info From waheedmp3 at gmail.com Fri Apr 6 16:43:17 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Fri, 6 Apr 2012 16:43:17 +0200 Subject: [Phpmyadmin-devel] Project Component Message-ID: Hi everybody,, If my project Idea consists of many features, is it just to be rejected if some features are in another project? Would it be considered equivalent to other project that contain some of the same features? or can these features be reduced and customized by the mentors if another project with the same features is accepted? Best Regards,, -------------- next part -------------- An HTML attachment was scrubbed... URL: From ayax88 at gmail.com Fri Apr 6 16:53:25 2012 From: ayax88 at gmail.com (Ammar Yasir) Date: Fri, 6 Apr 2012 20:23:25 +0530 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: <4F7ED8C3.8080700@infomarc.info> References: <4F79C977.2090601@infomarc.info> <4F7B0EDA.3020103@infomarc.info> <4F7ED8C3.8080700@infomarc.info> Message-ID: On Fri, Apr 6, 2012 at 5:21 PM, Marc Delisle wrote: > Le 2012-04-06 07:38, Ammar Yasir a écrit : > > On Tue, Apr 3, 2012 at 8:23 PM, Marc Delisle wrote: > > > >> Le 2012-04-02 18:39, Ammar Yasir a écrit : > >>> Hi, > >>> Can we have more clarity on improving reference to global variables. Is > >> the > >>> following snippet an example of the same where? > >>> (From tbl_select.php, $_POST parameters are referenced through > $GLOBALS) > >>> $post_params = array( > >>> 'ajax_request', > >>> 'collations', > >>> 'db', > >>> 'distinct', > >>> 'fields', > >>> 'func', > >>> 'max_number_of_fields', > >>> 'names', > >>> 'order', > >>> 'orderField', > >>> 'param', > >>> 'session_max_rows', > >>> 'table', > >>> 'types', > >>> 'where', > >>> ); > >>> foreach ($post_params as $one_post_param) { > >>> if (isset($_POST[$one_post_param])) { > >>> $GLOBALS[$one_post_param] = $_POST[$one_post_param]; > >>> } > >>> } > >> > >> Ammar, > >> this snippet is code added recently, to be able to remove the > >> grab_globals.lib.php library. > >> > >> tbl_select.php uses globals instead of directly referencing > >> $_POST['foo'] so this snippet was a way to keep the script working until > >> better refactoring. > >> > >> However, many scripts are using other global variables as a way to > >> communicate between them or between functions, and we should try to > >> minimize this behavior. > >> > >> Is the use of $sql_query variable as a GET variable for sql.php an > > example of the same? > > (communication between scripts) > > GET and POST variables are always about communication between scripts, > right? > > I meant that some functions are either using the global keyword or > $GLOBALS to reach some global variables. Also, procedural code in > included files are using global variables. > > Okay, thanks for clarifying. I submitted my proposal for Refactoring: table search, db search and multi-table query. I know it's very late but any comments will be very helpful. > > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Fri Apr 6 17:49:48 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 06 Apr 2012 11:49:48 -0400 Subject: [Phpmyadmin-devel] Project Component In-Reply-To: References: Message-ID: <4F7F109C.5050001@infomarc.info> Le 2012-04-06 10:43, Ahmed Waheed a écrit : > Hi everybody,, > If my project Idea consists of many features, is it just to be rejected > if some features are in another project? > Would it be considered equivalent to other project that contain some of the > same features? > or can these features be reduced and customized by the mentors if another > project with the same features is accepted? > > Best Regards,, Hi, our list of ideas has been built to avoid duplication between them, so try to base your proposal on one of these ideas. However you can submit more than one proposal to phpMyAdmin. -- Marc Delisle http://infomarc.info From dieter.adriaenssens at gmail.com Fri Apr 6 18:35:16 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Fri, 6 Apr 2012 18:35:16 +0200 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: References: Message-ID: Op 4 april 2012 11:07 heeft Adnan het volgende geschreven: > > > On Tue, Apr 3, 2012 at 9:15 PM, Adnan wrote: >> >> hello Michal, >> >> I have submitted my proposal, please have a look at it. Give your >> important input So I could edit my proposal then. >> Thanks > > Any input please ? You proposal will be reviewed by the mentors in due time. Your proposal is not the only one to be reviewed, so please be patient. -- Kind regards, Dieter Adriaenssens From hiddenpearls at gmail.com Fri Apr 6 18:37:30 2012 From: hiddenpearls at gmail.com (Adnan) Date: Fri, 6 Apr 2012 21:37:30 +0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: References: Message-ID: On Fri, Apr 6, 2012 at 9:35 PM, Dieter Adriaenssens < dieter.adriaenssens at gmail.com> wrote: > Op 4 april 2012 11:07 heeft Adnan het > volgende geschreven: > > > > > > On Tue, Apr 3, 2012 at 9:15 PM, Adnan wrote: > >> > >> hello Michal, > >> > >> I have submitted my proposal, please have a look at it. Give your > >> important input So I could edit my proposal then. > >> Thanks > > > > Any input please ? > > You proposal will be reviewed by the mentors in due time. Your > proposal is not the only one to be reviewed, so please be patient. > > Thanks, I got it. > -- > Kind regards, > > Dieter Adriaenssens > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From phil.230 at gmail.com Fri Apr 6 18:41:31 2012 From: phil.230 at gmail.com (Philip Karailanidis) Date: Fri, 6 Apr 2012 19:41:31 +0300 Subject: [Phpmyadmin-devel] Feature ID: 3494139 Message-ID: Hello Everyone! I am new to the team! I joined because I want to make a proposal for GSoC so I'm getting to know phpMyAdmin. I am going to start working on a feature request http://sourceforge.net/tracker/?func=detail&aid=3494139&group_id=23067&atid=377411 and I was wondering if anyone else is already working on that. Thanks! (Sorry if this is the wrong place to post :) ) -------------- next part -------------- An HTML attachment was scrubbed... URL: From hiddenpearls at gmail.com Fri Apr 6 18:42:59 2012 From: hiddenpearls at gmail.com (Adnan) Date: Fri, 6 Apr 2012 21:42:59 +0500 Subject: [Phpmyadmin-devel] Feature ID: 3494139 In-Reply-To: References: Message-ID: On Fri, Apr 6, 2012 at 9:41 PM, Philip Karailanidis wrote: > Hello Everyone! > > I am new to the team! > You're welcome. > I joined because I want to make a proposal for GSoC so I'm getting to know > phpMyAdmin. > > I am going to start working on a feature request > > > http://sourceforge.net/tracker/?func=detail&aid=3494139&group_id=23067&atid=377411 > > and I was wondering if anyone else is already working on that. > > Thanks! > > (Sorry if this is the wrong place to post :) ) > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From waheedmp3 at gmail.com Fri Apr 6 18:55:18 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Fri, 6 Apr 2012 18:55:18 +0200 Subject: [Phpmyadmin-devel] Project Component In-Reply-To: <4F7F109C.5050001@infomarc.info> References: <4F7F109C.5050001@infomarc.info> Message-ID: I'm submitting an idea of my own, not one of the listed.. and I noticed that one of the features is proposed by someone else too, I thought to remove this feature from my proposal to avoid duplication, but the problem is that rest of my features depend on this feature which is not implemented yet..I can't remove it, and in the same time I'm afraid that to be considered a duplication..my proposal contains other features it is only one feature that is proposed by someone else. so what? -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu130 at gmail.com Fri Apr 6 19:16:08 2012 From: nandu130 at gmail.com (nandu) Date: Fri, 6 Apr 2012 22:46:08 +0530 Subject: [Phpmyadmin-devel] problem in submitting proposal Message-ID: sir, earlier at the start I was new to GSoC and registered as mentor, now when I want to submit the proposal how do I change it do I need to create new username for it? How can I submit my proposal?? -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From selvam1991 at gmail.com Fri Apr 6 19:55:59 2012 From: selvam1991 at gmail.com (SELVAM P) Date: Fri, 6 Apr 2012 23:25:59 +0530 Subject: [Phpmyadmin-devel] Proposal: Plugins and OOP for import/export/transformations/authentication Message-ID: Hi everyone, I have uploaded my proposal at google melange. Also at as a weblink. Please leave your valuable comments. Thanks! -- Selvam Palanimalai Website || LinkedIN Department of EEE | Department of Biology, Birla Institute of Technology and Sciences -------------- next part -------------- An HTML attachment was scrubbed... URL: From selvam1991 at gmail.com Fri Apr 6 20:03:07 2012 From: selvam1991 at gmail.com (SELVAM P) Date: Fri, 6 Apr 2012 23:33:07 +0530 Subject: [Phpmyadmin-devel] patch for bug ID: 3511588 Message-ID: Hi Michal, As per your comments, I have submitted a new patch for the bug *structure schema printed multiple times in Word export - ID: 3511588.* Please have a look. Thanks! -- Selvam Palanimalai Website || LinkedIN Department of EEE | Department of Biology, Birla Institute of Technology and Sciences -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: 0005-Export-in-word-format.patch Type: application/octet-stream Size: 1166 bytes Desc: not available URL: From nandu1304 at gmail.com Sat Apr 7 07:56:17 2012 From: nandu1304 at gmail.com (nandlal ahirwar) Date: Sat, 7 Apr 2012 11:26:17 +0530 Subject: [Phpmyadmin-devel] Regarding Change of Email Message-ID: Sir, I submitted my proposal with this email-id (nandu1304 at gmail.com), Earlier I was using (nandu130 at gmail.com), I was registered as a mentor at the starting, which I realized later at the time of submission of proposal. Kindly consider my proposal from this new email (nandu1304 at gmail.com) thank you -------------- next part -------------- An HTML attachment was scrubbed... URL: From hiddenpearls at gmail.com Sat Apr 7 11:02:22 2012 From: hiddenpearls at gmail.com (Adnan) Date: Sat, 7 Apr 2012 14:02:22 +0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: References: Message-ID: On Fri, Apr 6, 2012 at 9:37 PM, Adnan wrote: > > > On Fri, Apr 6, 2012 at 9:35 PM, Dieter Adriaenssens < > dieter.adriaenssens at gmail.com> wrote: > >> Op 4 april 2012 11:07 heeft Adnan het >> volgende geschreven: >> > >> > >> > On Tue, Apr 3, 2012 at 9:15 PM, Adnan wrote: >> >> >> >> hello Michal, >> >> >> >> I have submitted my proposal, please have a look at it. Give your >> >> important input So I could edit my proposal then. >> >> Thanks >> > >> > Any input please ? >> >> You proposal will be reviewed by the mentors in due time. Your >> proposal is not the only one to be reviewed, so please be patient. >> >> Thanks, I got it. > I wanted to discuss about the bad design patterns used in schema generation classes. According to my knowledge, 1. In Class PMA_Schema_PDF and other schema classes, properties are used with var which is deprecated from PHP 5.0 to 5.1.3 as declaring properties like var was standard in php4. So, in php5 standards are to use public,protected or private keywords. Though after 5.1.3 var is not deprecated and doesn't issue E_STRICT warning. so var used in current code is considered as public. Best pattren is to use protected keyword for properties in Schema classes. 2. Singleton/factory pattern is not used in schema classes. I guess, we should use it instead of instantiating objects on running scripts. > -- >> Kind regards, >> >> Dieter Adriaenssens >> >> >> ------------------------------------------------------------------------------ >> For Developers, A Lot Can Happen In A Second. >> Boundary is the first to Know...and Tell You. >> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! >> http://p.sf.net/sfu/Boundary-d2dvs2 >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> > > > > -- > Muhammad Adnan > Twitter: @hiddenpearls > I blog too do u know ? http:// www.imblog.info > Failure takes you higher than success ..! > you sell code, I sell my brain. > > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Sat Apr 7 13:32:45 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 07 Apr 2012 07:32:45 -0400 Subject: [Phpmyadmin-devel] phpMyAdmin 3.5.0 is released Message-ID: <4F8025DD.4070904@infomarc.info> Welcome to phpMyAdmin 3.5.0; here are the major new features: * browse-mode improvements ** grid editing ** remember recent tables ** remember last sort order by table ** flexible column width ** reorder columns ** more compact navigation bar * AJAXification of many operations * reorganised server status page, with server monitoring * improved support for stored routines, events and triggers * openGIS support * zoom-search in table search * Drizzle support * improved ENUM/SET editor Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team From marc at infomarc.info Sat Apr 7 13:52:47 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 07 Apr 2012 07:52:47 -0400 Subject: [Phpmyadmin-devel] Feature ID: 3494139 In-Reply-To: References: Message-ID: <4F802A8F.2080009@infomarc.info> Le 2012-04-06 12:41, Philip Karailanidis a écrit : > Hello Everyone! > > I am new to the team! > I joined because I want to make a proposal for GSoC so I'm getting to know > phpMyAdmin. > > I am going to start working on a feature request > > http://sourceforge.net/tracker/?func=detail&aid=3494139&group_id=23067&atid=377411 > > and I was wondering if anyone else is already working on that. > > Thanks! > > (Sorry if this is the wrong place to post :) ) Hello, welcome, this is the correct place to post. Please add a comment to the feature request artifact, mentioning that you are working on it. -- Marc Delisle http://infomarc.info From hiddenpearls at gmail.com Sat Apr 7 14:18:02 2012 From: hiddenpearls at gmail.com (Adnan) Date: Sat, 7 Apr 2012 17:18:02 +0500 Subject: [Phpmyadmin-devel] phpMyAdmin 3.5.0 is released In-Reply-To: <4F8025DD.4070904@infomarc.info> References: <4F8025DD.4070904@infomarc.info> Message-ID: On Sat, Apr 7, 2012 at 4:32 PM, Marc Delisle wrote: > Welcome to phpMyAdmin 3.5.0; here are the major new features: > > * browse-mode improvements > ** grid editing > ** remember recent tables > ** remember last sort order by table > ** flexible column width > ** reorder columns > ** more compact navigation bar > * AJAXification of many operations > * reorganised server status page, with server monitoring > * improved support for stored routines, events and triggers > * openGIS support > * zoom-search in table search > * Drizzle support > * improved ENUM/SET editor > > Details will appear on http://phpmyadmin.net. In a hurry? you can visit > http://sourceforge.net/projects/phpmyadmin to download. > > Marc Delisle, for the team > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > great!! -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu130 at gmail.com Sat Apr 7 15:36:56 2012 From: nandu130 at gmail.com (nandu) Date: Sat, 7 Apr 2012 19:06:56 +0530 Subject: [Phpmyadmin-devel] proposals: Refactoring: Insert/edit, Privileges, Operations, Structure In-Reply-To: References: <4F75D26C.6060002@gmail.com> <4F76F0E1.9080704@infomarc.info> Message-ID: On Sun, Apr 1, 2012 at 12:26 AM, Dieter Adriaenssens < dieter.adriaenssens at gmail.com> wrote: > Op 31 maart 2012 19:20 heeft nandu het volgende > geschreven: > > Thanks.. > > they are related javascript code embedded in (or referenced from) HTML5 > > documents can use the objects and methods provided by jQuery to perform > its > > tasks. yes you are correct that it cannot be used in html5, > > So can it be considered as 1 thing that i can include in my proposal, > though > > am intending to find others too??? > > Please use bottom posting on this mailing list. [0] > > Can you prepare a patch that implements this idea and post it to our > tracker [1] or create a fork of the phpmyadmin code on github and > issues a pull request, as explained on our website [3]. > hello, I have my semester exams going on currently so am not able to give the maximum time to this patch, I also regret that I dint followed the bottom level posting, and all the mess ups. In order to identify a device we can use if( navigator.userAgent.match(/Android/i) || navigator.userAgent.match(/webOS/i) || navigator.userAgent.match(/iPhone/i) || navigator.userAgent.match(/iPad/i) || navigator.userAgent.match(/iPod/i) || navigator.userAgent.match(/BlackBerry/i) ) { $(function () { $('input:text').prop({ autocapitalize: 'off', autocorrect: 'off' }); }); } I am confused regarding which file this code is to be updated in phpmyadmin?? I have to submit the patch before 10th.. please help > > [0] https://en.wikipedia.org/wiki/Posting_style#Bottom-posting > [1] http://sourceforge.net/tracker/?group_id=23067&atid=377410 > [2] http://www.phpmyadmin.net/home_page/devel.php > > Kind regards, > > Dieter > > > > On Sat, Mar 31, 2012 at 10:36 PM, J.M. wrote: > >> > >> Am 31. März 2012 18:51 schrieb nandu : > >> > Marc, > >> > > >> > Thanks for considering, you asked me to submit patch, well for that i > >> > need > >> > some time till then I found another thing > >> > that is when we log into phpMyadmin from an iOS device is difficult > >> > because > >> > the device uppercases the first letter automatically. This can be > >> > disabled > >> > by adding two attributes in the input tag and setting them both to > off. > >> > it can be patched through > >> > autocapitalize="off" autocorrect="off" attributes in input. > >> > jQuery('input[type=text]').attr('autocapitalize','off'); > >> > > >> > Also i need some guidelines from you with my proposal > >> > thanks > >> > > >> > > >> > > >> > > >> > > >> > On Sat, Mar 31, 2012 at 5:26 PM, Marc Delisle > >> > wrote: > >> >> > >> >> Le 2012-03-31 06:19, nandu a écrit : > >> >> > PHP code mixed with HTML tags will basically cause crash, > >> >> > "strip_tags" > >> >> > to > >> >> > strip every html and php tags > >> >> > in $var, every characters after "<" is removed. > >> >> > i think strip_tags() is mixed up. > >> >> > > >> >> > we often get error:tbl_replace.php: Missing parameter when adding > >> >> > i.e. > >> >> > entries into mysql from within > >> >> > phpmyadmin chences of having issue with cookies on the system, > i.e.if > >> >> > disabled cookies in the browser > >> >> > this can be changed. > >> >> > Instead of using the elseif statements code can be reduced with > >> >> > > >> >> > >> >> Nandu, > >> >> please submit some patches, it will be easier to see what you mean. > >> >> > >> >> > > >> >> > wecan either use the static method in the code in order to improve > >> >> > the > >> >> > efficiency. > >> >> > another point I would like to ask what if we use the complete > >> >> > pathname > >> >> > with > >> >> > require and include, it will be much faster. > >> >> > >> >> Seems like a good idea. I took this example in the PHP manual's > >> >> comments: > >> >> > >> >> // this can be inside libraries/common.inc.php > >> >> define('__ROOT__', dirname(dirname(__FILE__))); > >> >> // then other scripts use this > >> >> require_once(__ROOT__.'/foo.php); > >> >> > >> >> So we could define __ROOT__ once and use it afterwards. One thing I'm > >> >> not sure about: we prefixed with './' to help in open_basedir case, > so > >> >> we would have to test this case. > >> >> > >> >> -- > >> >> Marc Delisle > >> >> http://infomarc.info > >> >> > >> >> > >> >> > >> >> > ------------------------------------------------------------------------------ > >> >> This SF email is sponsosred by: > >> >> Try Windows Azure free for 90 days Click Here > >> >> http://p.sf.net/sfu/sfd2d-msazure > >> >> _______________________________________________ > >> >> Phpmyadmin-devel mailing list > >> >> Phpmyadmin-devel at lists.sourceforge.net > >> >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > >> > > >> > > >> > > >> > > >> > -- > >> > Nandlal Ahirwar > >> > MCA, II yr > >> > Maulana Azad National Institute of Technology, Bhopal > >> > India > >> > > >> > > >> > > >> > > ------------------------------------------------------------------------------ > >> > This SF email is sponsosred by: > >> > Try Windows Azure free for 90 days Click Here > >> > http://p.sf.net/sfu/sfd2d-msazure > >> > _______________________________________________ > >> > Phpmyadmin-devel mailing list > >> > Phpmyadmin-devel at lists.sourceforge.net > >> > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > >> > > >> > >> Adding autocapitalize and/or autocorrect attributes to tags is > >> not valid HTML5, though, which is what we'd like to achieve (refer to > >> http://www.w3schools.com/html5/tag_input.asp for all input tag > >> attributes allowed in HTML5). > >> > >> I suggest setting these attributes using jQuery in a document-ready > >> event handler if the user agent matches iOS or Android. Like this: > >> > >> $(function () { > >> $('input:text').prop({ > >> autocapitalize: 'off', > >> autocorrect: 'off' > >> }); > >> }); > >> > >> What do you think? > >> > >> > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu1304 at gmail.com Sat Apr 7 15:53:54 2012 From: nandu1304 at gmail.com (nandlal ahirwar) Date: Sat, 7 Apr 2012 19:23:54 +0530 Subject: [Phpmyadmin-devel] regarding patch Message-ID: On Sun, Apr 1, 2012 at 12:26 AM, Dieter Adriaenssens < dieter.adriaenssens at gmail.com> wrote: > Op 31 maart 2012 19:20 heeft nandu het volgende > geschreven: > > Thanks.. > > they are related javascript code embedded in (or referenced from) HTML5 > > documents can use the objects and methods provided by jQuery to perform > its > > tasks. yes you are correct that it cannot be used in html5, > > So can it be considered as 1 thing that i can include in my proposal, > though > > am intending to find others too??? > Please use bottom posting on this mailing list. [0] > > Can you prepare a patch that implements this idea and post it to our > tracker [1] or create a fork of the phpmyadmin code on github and > issues a pull request, as explained on our website [3]. > hello, I have my semester exams going on currently so am not able to give the maximum time to this patch, I also regret that I dint followed the bottom level posting, and all the mess ups. In order to identify a device we can use if( navigator.userAgent.match(/ Android/i) || navigator.userAgent.match(/webOS/i) || navigator.userAgent.match(/iPhone/i) || navigator.userAgent.match(/iPad/i) || navigator.userAgent.match(/iPod/i) || navigator.userAgent.match(/BlackBerry/i) ) { $(function () { $('input:text').prop({ autocapitalize: 'off', autocorrect: 'off' }); }); } I am confused regarding which file this code is to be updated in phpmyadmin?? I have to submit the patch before 10th.. please help -------------- next part -------------- An HTML attachment was scrubbed... URL: From ayax88 at gmail.com Sat Apr 7 16:01:17 2012 From: ayax88 at gmail.com (Ammar Yasir) Date: Sat, 7 Apr 2012 19:31:17 +0530 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: References: <4F79C977.2090601@infomarc.info> <4F7B0EDA.3020103@infomarc.info> <4F7ED8C3.8080700@infomarc.info> Message-ID: On Fri, Apr 6, 2012 at 8:23 PM, Ammar Yasir wrote: > > > On Fri, Apr 6, 2012 at 5:21 PM, Marc Delisle wrote: > >> Le 2012-04-06 07:38, Ammar Yasir a écrit : >> > On Tue, Apr 3, 2012 at 8:23 PM, Marc Delisle >> wrote: >> > >> >> Le 2012-04-02 18:39, Ammar Yasir a écrit : >> >>> Hi, >> >>> Can we have more clarity on improving reference to global variables. >> Is >> >> the >> >>> following snippet an example of the same where? >> >>> (From tbl_select.php, $_POST parameters are referenced through >> $GLOBALS) >> >>> $post_params = array( >> >>> 'ajax_request', >> >>> 'collations', >> >>> 'db', >> >>> 'distinct', >> >>> 'fields', >> >>> 'func', >> >>> 'max_number_of_fields', >> >>> 'names', >> >>> 'order', >> >>> 'orderField', >> >>> 'param', >> >>> 'session_max_rows', >> >>> 'table', >> >>> 'types', >> >>> 'where', >> >>> ); >> >>> foreach ($post_params as $one_post_param) { >> >>> if (isset($_POST[$one_post_param])) { >> >>> $GLOBALS[$one_post_param] = $_POST[$one_post_param]; >> >>> } >> >>> } >> >> >> >> Ammar, >> >> this snippet is code added recently, to be able to remove the >> >> grab_globals.lib.php library. >> >> >> >> tbl_select.php uses globals instead of directly referencing >> >> $_POST['foo'] so this snippet was a way to keep the script working >> until >> >> better refactoring. >> >> >> >> However, many scripts are using other global variables as a way to >> >> communicate between them or between functions, and we should try to >> >> minimize this behavior. >> >> >> >> Is the use of $sql_query variable as a GET variable for sql.php an >> > example of the same? >> > (communication between scripts) >> >> GET and POST variables are always about communication between scripts, >> right? >> >> I meant that some functions are either using the global keyword or >> $GLOBALS to reach some global variables. Also, procedural code in >> included files are using global variables. >> >> Okay, thanks for clarifying. I submitted my proposal for Refactoring: > table search, db search and multi-table query. I know it's very late but > any comments will be very helpful. > >> >> Hi, I submitted a patch back in February [0]. Will that be okay for considering my proposal, or do I need to submit some patch specific to refactoring? [0] https://sourceforge.net/tracker/index.php?func=detail&aid=3489549&group_id=23067&atid=377410 > -- >> Marc Delisle >> http://infomarc.info >> >> >> ------------------------------------------------------------------------------ >> For Developers, A Lot Can Happen In A Second. >> Boundary is the first to Know...and Tell You. >> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! >> http://p.sf.net/sfu/Boundary-d2dvs2 >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Sat Apr 7 16:19:52 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 07 Apr 2012 10:19:52 -0400 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: References: <4F79C977.2090601@infomarc.info> <4F7B0EDA.3020103@infomarc.info> <4F7ED8C3.8080700@infomarc.info> Message-ID: <4F804D08.6030809@infomarc.info> Le 2012-04-07 10:01, Ammar Yasir a écrit : > On Fri, Apr 6, 2012 at 8:23 PM, Ammar Yasir wrote: > > I submitted a patch back in February [0]. Will that be okay for considering > my proposal, or do I need to submit some patch specific to refactoring? > > [0] > https://sourceforge.net/tracker/index.php?func=detail&aid=3489549&group_id=23067&atid=377410 You have contributed to phpMyAdmin in the past, all these contributions count to evaluate your potential. If we need something more, we'll ask you via the google-melange comments. -- Marc Delisle http://infomarc.info From hiddenpearls at gmail.com Sat Apr 7 16:30:18 2012 From: hiddenpearls at gmail.com (Adnan) Date: Sat, 7 Apr 2012 19:30:18 +0500 Subject: [Phpmyadmin-devel] [GSoC2012] Refactoring: Table search, Db search, Multi-table query In-Reply-To: <4F804D08.6030809@infomarc.info> References: <4F79C977.2090601@infomarc.info> <4F7B0EDA.3020103@infomarc.info> <4F7ED8C3.8080700@infomarc.info> <4F804D08.6030809@infomarc.info> Message-ID: On Sat, Apr 7, 2012 at 7:19 PM, Marc Delisle wrote: > Le 2012-04-07 10:01, Ammar Yasir a écrit : > > On Fri, Apr 6, 2012 at 8:23 PM, Ammar Yasir wrote: > > > > > I submitted a patch back in February [0]. Will that be okay for > considering > > my proposal, or do I need to submit some patch specific to refactoring? > > > > [0] > > > https://sourceforge.net/tracker/index.php?func=detail&aid=3489549&group_id=23067&atid=377410 > > You have contributed to phpMyAdmin in the past, all these contributions > count to evaluate your potential. If we need something more, we'll ask > you via the google-melange comments. > Awesome!! :) > > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu1304 at gmail.com Sat Apr 7 17:12:16 2012 From: nandu1304 at gmail.com (nandlal ahirwar) Date: Sat, 7 Apr 2012 20:42:16 +0530 Subject: [Phpmyadmin-devel] for patch submission Message-ID: hello, I have my semester exams going on currently so am not able to give the maximum time to this patch, I also regret that I dint followed the bottom level posting, and all the mess ups. In order to identify a ios device we can use if( navigator.userAgent.match(/ Android/i) || navigator.userAgent.match(/ webOS/i) || navigator.userAgent.match(/iPhone/i) || navigator.userAgent.match(/iPad/i) || navigator.userAgent.match(/iPod/i) || navigator.userAgent.match(/BlackBerry/i) ) { $(function () { $('input:text').prop({ autocapitalize: 'off', autocorrect: 'off' }); }); } I am confused regarding which file this code is to be updated in phpmyadmin?? I have to submit the patch before 10th.. please help -------------- next part -------------- An HTML attachment was scrubbed... URL: From pe.chanaka.ck at gmail.com Sat Apr 7 20:06:04 2012 From: pe.chanaka.ck at gmail.com (Chanaka Dharmarathna) Date: Sat, 7 Apr 2012 23:36:04 +0530 Subject: [Phpmyadmin-devel] Submitted a patch for feature request ID: 3511561 Message-ID: Hi, I have implemented the feature request [0] and submitted the patch at [1]. If there is anything to improve in my patch, I'm looking for your valuable suggestions. [0]: https://sourceforge.net/tracker/?func=detail&aid=3511561&group_id=23067&atid=377411 [1]: https://sourceforge.net/tracker/index.php?func=detail&aid=3515738&group_id=23067&atid=377410 Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From thilinaabeyrathna at gmail.com Sat Apr 7 20:50:48 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Sun, 8 Apr 2012 00:20:48 +0530 Subject: [Phpmyadmin-devel] GSOC- Refactoring In-Reply-To: References: <4F7B6681.6050707@infomarc.info> Message-ID: On Wed, Apr 4, 2012 at 9:31 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna at gmail.com> wrote: > > > On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle wrote: > >> Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit : >> > Hi Marc, >> > I'm looking to refactor some small piece of code in phpmyadmin. Then I >> can >> > more familiar with code base. So if you have suggestion please let me >> know. >> >> >> Thilina, >> in user_password.php there is a long "if" that starts with >> >> if (isset($_REQUEST['nopass'])) { >> >> can you improve some parts of it? >> >> Hi Marc, > Ok, I'll do. > Hi Marc, I have tried to do some refactoring for user_password.php script which you mentioned earlier. please review that and give me some advice to improve my refactoring skill, because I'm new to code refactpring. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From thilinaabeyrathna at gmail.com Sat Apr 7 21:10:12 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Sun, 8 Apr 2012 00:40:12 +0530 Subject: [Phpmyadmin-devel] GSOC- Refactoring In-Reply-To: References: <4F7B6681.6050707@infomarc.info> Message-ID: On Sun, Apr 8, 2012 at 12:20 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna at gmail.com> wrote: > > > On Wed, Apr 4, 2012 at 9:31 AM, Thilina Buddika Abeyrathna < > thilinaabeyrathna at gmail.com> wrote: > >> >> >> On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle wrote: >> >>> Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit : >>> > Hi Marc, >>> > I'm looking to refactor some small piece of code in phpmyadmin. Then I >>> can >>> > more familiar with code base. So if you have suggestion please let me >>> know. >>> >>> >>> Thilina, >>> in user_password.php there is a long "if" that starts with >>> >>> if (isset($_REQUEST['nopass'])) { >>> >>> can you improve some parts of it? >>> >>> Hi Marc, >> Ok, I'll do. >> > > Hi Marc, > I have tried to do some refactoring for user_password.php script which you > mentioned earlier. please review that and give me some advice to improve my > refactoring skill [0], because I'm new to code refactoring. > > [0] - > https://sourceforge.net/tracker/?func=detail&aid=3515741&group_id=23067&atid=377410 > -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu1304 at gmail.com Sun Apr 8 18:10:10 2012 From: nandu1304 at gmail.com (nandlal ahirwar) Date: Sun, 8 Apr 2012 21:40:10 +0530 Subject: [Phpmyadmin-devel] for patch submission In-Reply-To: References: Message-ID: On Sat, Apr 7, 2012 at 8:42 PM, nandlal ahirwar wrote: > hello, > I have my semester exams going on currently so am not able to give > the maximum time > to this patch, I also regret that I dint followed the bottom level posting, > and all the mess ups. > In order to identify a ios device we can use > > if( navigator.userAgent.match(/ > Android/i) > || navigator.userAgent.match(/ > webOS/i) > || navigator.userAgent.match(/iPhone/i) > || navigator.userAgent.match(/iPad/i) > || navigator.userAgent.match(/iPod/i) > || navigator.userAgent.match(/BlackBerry/i) > ) > > > { > > $(function () { > $('input:text').prop({ > autocapitalize: 'off', > autocorrect: 'off' > }); > }); > > } > > I am confused regarding which file this code is to be updated in > phpmyadmin?? > I have to submit the patch before 10th.. please help > mentors!!...we need you, where are you guys am stucked with my refactoring, and please do commrnent on my above post..please -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Sun Apr 8 18:18:57 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 08 Apr 2012 12:18:57 -0400 Subject: [Phpmyadmin-devel] for patch submission In-Reply-To: References: Message-ID: <4F81BA71.2050305@infomarc.info> Le 2012-04-08 12:10, nandlal ahirwar a écrit : > On Sat, Apr 7, 2012 at 8:42 PM, nandlal ahirwar wrote: > >> hello, >> I have my semester exams going on currently so am not able to give >> the maximum time >> to this patch, I also regret that I dint followed the bottom level posting, >> and all the mess ups. >> In order to identify a ios device we can use >> >> if( navigator.userAgent.match(/ >> Android/i) >> || navigator.userAgent.match(/ >> webOS/i) >> || navigator.userAgent.match(/iPhone/i) >> || navigator.userAgent.match(/iPad/i) >> || navigator.userAgent.match(/iPod/i) >> || navigator.userAgent.match(/BlackBerry/i) >> ) >> >> >> { >> >> $(function () { >> $('input:text').prop({ >> autocapitalize: 'off', >> autocorrect: 'off' >> }); >> }); >> >> } >> >> I am confused regarding which file this code is to be updated in >> phpmyadmin?? >> I have to submit the patch before 10th.. please help >> > > > > mentors!!...we need you, where are you guys am stucked with my refactoring, > and please do > commrnent on my above post..please Mentors can comment a submitted patch, but do you really expect us to help you prepare a patch whose goal is to evaluate your potential? -- Marc Delisle http://infomarc.info From nandu130 at gmail.com Sun Apr 8 18:27:05 2012 From: nandu130 at gmail.com (nandu) Date: Sun, 8 Apr 2012 21:57:05 +0530 Subject: [Phpmyadmin-devel] for patch submission In-Reply-To: <4F81BA71.2050305@infomarc.info> References: <4F81BA71.2050305@infomarc.info> Message-ID: On Sun, Apr 8, 2012 at 9:48 PM, Marc Delisle wrote: > Le 2012-04-08 12:10, nandlal ahirwar a écrit : > > On Sat, Apr 7, 2012 at 8:42 PM, nandlal ahirwar > wrote: > > > >> hello, > >> I have my semester exams going on currently so am not able to > give > >> the maximum time > >> to this patch, I also regret that I dint followed the bottom level > posting, > >> and all the mess ups. > >> In order to identify a ios device we can use > >> > >> if( navigator.userAgent.match(/ > >> Android/i) > >> || navigator.userAgent.match(/ > >> webOS/i) > >> || navigator.userAgent.match(/iPhone/i) > >> || navigator.userAgent.match(/iPad/i) > >> || navigator.userAgent.match(/iPod/i) > >> || navigator.userAgent.match(/BlackBerry/i) > >> ) > >> > >> > >> { > >> > >> $(function () { > >> $('input:text').prop({ > >> autocapitalize: 'off', > >> autocorrect: 'off' > >> }); > >> }); > >> > >> } > >> > >> I am confused regarding which file this code is to be updated in > >> phpmyadmin?? > >> I have to submit the patch before 10th.. please help > >> > > > > > > > > mentors!!...we need you, where are you guys am stucked with my > refactoring, > > and please do > > commrnent on my above post..please > > Mentors can comment a submitted patch, but do you really expect us to > help you prepare a patch whose goal is to evaluate your potential? > agreed Sir, read lot of materials in mean time, and am on my way to complete it, knew a lot of stupidity i made up, and now correcting them, though am not abe to give my 100% because of my final semester exams which will end on 20th, but still working for my passion. > > > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Nandlal Ahirwar MCA, II yr Maulana Azad National Institute of Technology, Bhopal India -------------- next part -------------- An HTML attachment was scrubbed... URL: From nandu1304 at gmail.com Sun Apr 8 19:04:19 2012 From: nandu1304 at gmail.com (nandlal ahirwar) Date: Sun, 8 Apr 2012 22:34:19 +0530 Subject: [Phpmyadmin-devel] for patch submission In-Reply-To: References: Message-ID: Mentors can comment a submitted patch, but do you really expect us to help you prepare a patch whose goal is to evaluate your potential? agreed Sir, read lot of materials in mean time, and am on my way to complete it, knew a lot of stupidity i made up, and now correcting them, though am not abe to give my 100% because of my final semester exams which will end on 20th, but still working for my passion -- Marc Delisle http://infomarc.info ------------------------------ ------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel On Sun, Apr 8, 2012 at 9:40 PM, nandlal ahirwar wrote: > > > On Sat, Apr 7, 2012 at 8:42 PM, nandlal ahirwar wrote: > >> hello, >> I have my semester exams going on currently so am not able to give >> the maximum time >> to this patch, I also regret that I dint followed the bottom level >> posting, >> and all the mess ups. >> In order to identify a ios device we can use >> >> if( navigator.userAgent.match(/ >> Android/i) >> || navigator.userAgent.match(/ >> webOS/i) >> || navigator.userAgent.match(/iPhone/i) >> || navigator.userAgent.match(/iPad/i) >> || navigator.userAgent.match(/iPod/i) >> || navigator.userAgent.match(/BlackBerry/i) >> ) >> >> >> { >> >> $(function () { >> $('input:text').prop({ >> autocapitalize: 'off', >> autocorrect: 'off' >> }); >> }); >> >> } >> >> I am confused regarding which file this code is to be updated in >> phpmyadmin?? >> I have to submit the patch before 10th.. please help >> > > > > mentors!!...we need you, where are you guys am stucked with my > refactoring, and please do > commrnent on my above post..please > -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at mynetx.net Sun Apr 8 23:09:11 2012 From: me at mynetx.net (J.M.) Date: Sun, 8 Apr 2012 23:09:11 +0200 Subject: [Phpmyadmin-devel] Website render for 3.5.0 release Message-ID: When/How is phpmyadmin.net's render.py called the next time to reflect 3.5.0 release? -- J.M. Rütter, JubloWebSolutions DE: Postfach 2174, 56107 Lahnstein, DE UK: 68 Holmsley Lane, Woodlesford, Leeds LS26 8RY, UK www.mynetx.net | www.jublo.net From waheedmp3 at gmail.com Mon Apr 9 00:03:49 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Mon, 9 Apr 2012 00:03:49 +0200 Subject: [Phpmyadmin-devel] Submitting patches Message-ID: Hi, I'm sorry for being yet not submitted any patches, but I'm so busy having exams since the SoC registration opened. I'm checking bug tracker now to fix some bugs, but I need help on how to prepare the patch, and how to submit it, I couldn't find any post/submit tab on patch tracker, or any writing/coding rules on how to make a patch. On the developer wiki, it is said that some bugs are for juniors who don't have knowledge with the code base..then I need to read the code base anyway, right? Then, how and from where to start reading the code? Best Regards,, -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at mynetx.net Mon Apr 9 00:36:56 2012 From: me at mynetx.net (J.M.) Date: Mon, 9 Apr 2012 00:36:56 +0200 Subject: [Phpmyadmin-devel] Submitting patches In-Reply-To: References: Message-ID: > Hi, > > I'm sorry for being yet not submitted any patches, but I'm so busy having > exams since the SoC registration opened. > I'm checking bug tracker now to fix some bugs, but I need  help on how to > prepare the patch, and how to submit it, I couldn't find any post/submit tab > on patch tracker, or any writing/coding rules on how to make a patch. > On the developer wiki, it is said that some bugs are for juniors who don't > have knowledge with the code base..then I need to read the code base anyway, > right? > Then, how and from where to start reading the code? > > Best Regards,, > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > Hi Ahmed, Regarding how to submit patches 1. First of all, clone the phpMyAdmin Git repository (see [1]). 2. Make sure to set your Git username and email settings properly (see [2]). 3. Then, prepare your code changes as you normally would. 4. Next, commit the changes to go into your patch to your local repo clone. 5. Subsequently, tell git to create a patch for you (see [3]). 6. Last, send us your patch file (see [4]), or create a pull request at Github. About the "post/submit tab": There is a (very) small "Add new" link on top of the bug tracker. :) [1] http://git.io/pma [2] http://book.git-scm.com/2_setup_and_initialization.html [3] http://schacon.github.com/git/git-format-patch.html [4] https://sourceforge.net/tracker/?func=add&group_id=23067&atid=377410 About reading the code base, it’s best starting to scan through main.php (this is the 2-column file showing the language and theme switchers and the server versions you’re running) and the libraries folder—just to get a basic idea of how phpMyAdmin works internally. For fixing small bugs, it’s usually best to investigate the code in the files affected or loaded by the page that contains the error. -- mynetx (Jo Michael) From waheedmp3 at gmail.com Mon Apr 9 00:50:36 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Mon, 9 Apr 2012 00:50:36 +0200 Subject: [Phpmyadmin-devel] Submitting patches In-Reply-To: References: Message-ID: Thanks Jo, Another question: how to test my code locally to see if it works? I have phpMyAdmin installed, i the same time I'll work on the copy I pulled from GIT, then how would I try my fixes? would I try the copy of PMA from GIT after I edit the code? or can I merge that code to the PMA I already installed? Best Regards,, -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at mynetx.net Mon Apr 9 01:15:19 2012 From: me at mynetx.net (J.M.) Date: Mon, 9 Apr 2012 01:15:19 +0200 Subject: [Phpmyadmin-devel] Submitting patches In-Reply-To: References: Message-ID: >      Another question: how to test my code locally to see if it works? > I have phpMyAdmin installed, i the same time I'll work on the copy I pulled > from GIT, then how would I try my fixes? would I try the copy of PMA from > GIT after I edit the code? or can I merge that code to the PMA I already > installed? The easiest way to test your code is by cloning Github’s phpMyAdmin master branch. You should create your Git repository for phpMyAdmin inside the document root of your local webserver, so you can reach the cloned folder by accessing a subfolder of localhost in your browser. Then, do your code changes in the local copy, and test them in the browser. As soon as the bug that you’re working on is fixed, stage (add) the files in Git and commit them with a proper commit message. -- mynetx (Jo Michael) From waheedmp3 at gmail.com Mon Apr 9 01:20:20 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Mon, 9 Apr 2012 01:20:20 +0200 Subject: [Phpmyadmin-devel] Submitting patches In-Reply-To: References: Message-ID: well, and this cloned copy won't need any configuration(i.e: database or something) as when I install PMA for personal usage? -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at mynetx.net Mon Apr 9 01:26:19 2012 From: me at mynetx.net (J.M.) Date: Mon, 9 Apr 2012 01:26:19 +0200 Subject: [Phpmyadmin-devel] Submitting patches In-Reply-To: References: Message-ID: > well, and this cloned copy won't need any configuration(i.e: database or > something) as when I install PMA for personal usage? Each copy of phpMyAdmin that’s intended to be used, so the cloned one as well, needs a configuration file. However, throw a peek into the root folder .gitignore file. You will find that the custom config.inc.php that you need to create is ignored by Git and won’t get added to your commits. As for the database, if you want to test the local installation, a local mySQL server is best. Provided that your firewall allows outgoing access on port 3306, and that you have a remote mySQL server allowing access from your local phpMyAdmin server IP, you may specify any server you want to, in config.inc.php. It doesn’t necessarily have to be a localhosted mySQL server (which in turn speeds up any communication). -- mynetx (Jo Michael) From waheedmp3 at gmail.com Mon Apr 9 07:52:34 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Mon, 9 Apr 2012 07:52:34 +0200 Subject: [Phpmyadmin-devel] clone is so slow Message-ID: Hi, The process : git clone git at github.com:phpmyadmin/phpmyadmin.git is so slow, it takes a long time to complete, why? is there any way to speed it up? I tried it once, and I'm trying to clone again now to a different directory, can I just copy&paste the first copy to the new directory and work on it? -------------- next part -------------- An HTML attachment was scrubbed... URL: From yasitha4 at gmail.com Mon Apr 9 08:10:43 2012 From: yasitha4 at gmail.com (yasitha pandithawatta) Date: Mon, 9 Apr 2012 11:40:43 +0530 Subject: [Phpmyadmin-devel] clone is so slow In-Reply-To: References: Message-ID: Hi Ahmed , Yes it will take some time. After get it, keep a reference for the clone. You can update the reference and use copy of it for development. On Mon, Apr 9, 2012 at 11:22 AM, Ahmed Waheed wrote: > Hi, > The process : git clone git at github.com:phpmyadmin/phpmyadmin.git > is so slow, it takes a long time to complete, why? is there any way to > speed it up? > I tried it once, and I'm trying to clone again now to a different > directory, can I just copy&paste the first copy to the new directory and > work on it? > > > > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka -------------- next part -------------- An HTML attachment was scrubbed... URL: From waheedmp3 at gmail.com Mon Apr 9 08:15:55 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Mon, 9 Apr 2012 08:15:55 +0200 Subject: [Phpmyadmin-devel] clone is so slow In-Reply-To: References: Message-ID: hi yasitha, how to make a reference for the clone? I cloned it first someplace, now I want it to be in my webserver root so that I can test it, can I copy it to www/ and work on it and commit changes from www/ ? -------------- next part -------------- An HTML attachment was scrubbed... URL: From hiddenpearls at gmail.com Mon Apr 9 12:51:59 2012 From: hiddenpearls at gmail.com (Adnan) Date: Mon, 9 Apr 2012 15:51:59 +0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: References: Message-ID: On Sat, Apr 7, 2012 at 2:02 PM, Adnan wrote: > > > On Fri, Apr 6, 2012 at 9:37 PM, Adnan wrote: > >> >> >> On Fri, Apr 6, 2012 at 9:35 PM, Dieter Adriaenssens < >> dieter.adriaenssens at gmail.com> wrote: >> >>> Op 4 april 2012 11:07 heeft Adnan het >>> volgende geschreven: >>> > >>> > >>> > On Tue, Apr 3, 2012 at 9:15 PM, Adnan wrote: >>> >> >>> >> hello Michal, >>> >> >>> >> I have submitted my proposal, please have a look at it. Give your >>> >> important input So I could edit my proposal then. >>> >> Thanks >>> > >>> > Any input please ? >>> >>> You proposal will be reviewed by the mentors in due time. Your >>> proposal is not the only one to be reviewed, so please be patient. >>> >>> Thanks, I got it. >> > I wanted to discuss about the bad design patterns used in schema > generation classes. According to my knowledge, > > 1. In Class PMA_Schema_PDF and other schema classes, properties are used > with var which is deprecated from PHP 5.0 to 5.1.3 as declaring properties > like var was standard in php4. So, in php5 standards are to use > public,protected or private keywords. Though after 5.1.3 var is not > deprecated and doesn't issue E_STRICT warning. so var used in current code > is considered as public. Best pattren is to use protected keyword for > properties in Schema classes. > > 2. Singleton/factory pattern is not used in schema classes. I guess, we > should use it instead of instantiating objects on running scripts. > any input on this please ? > -- >>> Kind regards, >>> >>> Dieter Adriaenssens >>> >>> >>> ------------------------------------------------------------------------------ >>> For Developers, A Lot Can Happen In A Second. >>> Boundary is the first to Know...and Tell You. >>> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! >>> http://p.sf.net/sfu/Boundary-d2dvs2 >>> _______________________________________________ >>> Phpmyadmin-devel mailing list >>> Phpmyadmin-devel at lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >>> >> >> >> >> -- >> Muhammad Adnan >> Twitter: @hiddenpearls >> I blog too do u know ? http:// www.imblog.info >> Failure takes you higher than success ..! >> you sell code, I sell my brain. >> >> > > > -- > Muhammad Adnan > Twitter: @hiddenpearls > I blog too do u know ? http:// www.imblog.info > Failure takes you higher than success ..! > you sell code, I sell my brain. > > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Mon Apr 9 12:57:49 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 09 Apr 2012 06:57:49 -0400 Subject: [Phpmyadmin-devel] Website render for 3.5.0 release In-Reply-To: References: Message-ID: <4F82C0AD.7050305@infomarc.info> Le 2012-04-08 17:09, J.M. a écrit : > When/How is phpmyadmin.net's render.py called the next time to reflect > 3.5.0 release? The site was reflected a few hours after the release; just reload the page in your browser. -- Marc Delisle http://infomarc.info From ak1733 at gmail.com Mon Apr 9 13:15:36 2012 From: ak1733 at gmail.com (adeel khan) Date: Mon, 9 Apr 2012 16:15:36 +0500 Subject: [Phpmyadmin-devel] Improving Sync for Big Tables In-Reply-To: <20120405153302.07470968@rincewind.suse.cz> References: <4F6BC696.6020307@gmail.com> <20120405153302.07470968@rincewind.suse.cz> Message-ID: Hi, I didnt checked this mail. Sorry Michal i didnt applied to gsoc this time, because of some constraints. I hope any one else would improve the sync feature for big tables by going through the idea. I think its workable. As you have already mentioned that importing use this scheme for assuring script exec time because the same case applies to importing of data. You need some assurance that the script should run to a minimal time, and you can always tell user (which is not the case in import) that how much data is inserted or else. adeel On Thu, Apr 5, 2012 at 6:33 PM, Michal Čihař wrote: > Hi > > Dne Mon, 26 Mar 2012 02:54:16 +0500 > adeel khan napsal(a): > > > But as we can set the timeout value to a minimum execution time > > programmatically we would always be assured that we would able to get > that > > time for a pass. > > This is already used in importing, see libraries/import.lib.php, > especially PMA_checkTimeout, so it might be turned into more generic > solution. > > -- > Michal Čihař | http://cihar.com | http://blog.cihar.com > > > ------------------------------------------------------------------------------ > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From rouslan at placella.com Mon Apr 9 13:23:17 2012 From: rouslan at placella.com (Rouslan Placella) Date: Mon, 09 Apr 2012 12:23:17 +0100 Subject: [Phpmyadmin-devel] clone is so slow In-Reply-To: References: Message-ID: <4F82C6A5.8030901@placella.com> On 09/04/12 07:15, Ahmed Waheed wrote: > hi yasitha, > how to make a reference for the clone? > I cloned it first someplace, now I want it to be in my webserver root so > that I can test it You can always clone locally. Say, if you just finished cloning into ./pma, then you can make another clone like this: git clone ./pma /var/www/pma > can I copy it to www/ and work on it and commit changes > from www/ ? Yes, you can and you probably should, as it makes testing a hell of a lot faster. Bye, Rouslan From phil.230 at gmail.com Mon Apr 9 16:37:24 2012 From: phil.230 at gmail.com (Philip Karailanidis) Date: Mon, 9 Apr 2012 17:37:24 +0300 Subject: [Phpmyadmin-devel] Feature ID: 3494139 In-Reply-To: <4F802A8F.2080009@infomarc.info> References: <4F802A8F.2080009@infomarc.info> Message-ID: Thank you for the replies! Well, the feature is ready and all there's left is for me to submit the patch. I got to know github today (frankly more complicated than I thought) and I have cloned the phpmyadmin repo to my pc. Now, in order to submit the patch, should I make a new branch, where I can commit the changes and then make a pull request? I am a little bit confused by the whole thing... svn is much simpler! thanks again :) On Sat, Apr 7, 2012 at 2:52 PM, Marc Delisle wrote: > Le 2012-04-06 12:41, Philip Karailanidis a écrit : > > Hello Everyone! > > > > I am new to the team! > > I joined because I want to make a proposal for GSoC so I'm getting to > know > > phpMyAdmin. > > > > I am going to start working on a feature request > > > > > http://sourceforge.net/tracker/?func=detail&aid=3494139&group_id=23067&atid=377411 > > > > and I was wondering if anyone else is already working on that. > > > > Thanks! > > > > (Sorry if this is the wrong place to post :) ) > > Hello, > welcome, this is the correct place to post. Please add a comment to the > feature request artifact, mentioning that you are working on it. > > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at mynetx.net Mon Apr 9 16:41:13 2012 From: me at mynetx.net (J.M.) Date: Mon, 9 Apr 2012 16:41:13 +0200 Subject: [Phpmyadmin-devel] Feature ID: 3494139 In-Reply-To: References: <4F802A8F.2080009@infomarc.info> Message-ID: > Now, in order to submit the patch, should I make a new branch, where I can > commit the changes and then make a pull request? You may, but don't need to create a new branch. Making a pull request from your forked master branch is fine, too! -- mynetx (Jo Michael) From waheedmp3 at gmail.com Mon Apr 9 17:03:45 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Mon, 9 Apr 2012 17:03:45 +0200 Subject: [Phpmyadmin-devel] Deadline for patch submission Message-ID: Hi, How much hours remaining for GSoC applicant patch submission ? How match patch should I submit at least? -------------- next part -------------- An HTML attachment was scrubbed... URL: From phil.230 at gmail.com Mon Apr 9 17:15:14 2012 From: phil.230 at gmail.com (Philip Karailanidis) Date: Mon, 9 Apr 2012 18:15:14 +0300 Subject: [Phpmyadmin-devel] Feature ID: 3494139 In-Reply-To: References: <4F802A8F.2080009@infomarc.info> Message-ID: Thanks Michael! I have made the pull request :) As I specify, the patch is only a first approach, there is a lot of work to be done. I only did it so soon beacuse of the GSoC application, but I'm gonna work on it in the future anyways :D Oh, and git isn't so bad after all! On Mon, Apr 9, 2012 at 5:41 PM, J.M. wrote: > > Now, in order to submit the patch, should I make a new branch, where I > can > > commit the changes and then make a pull request? > > You may, but don't need to create a new branch. > Making a pull request from your forked master branch is fine, too! > > -- > mynetx (Jo Michael) > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From phil.230 at gmail.com Mon Apr 9 17:32:16 2012 From: phil.230 at gmail.com (Philip Karailanidis) Date: Mon, 9 Apr 2012 18:32:16 +0300 Subject: [Phpmyadmin-devel] Feature ID: 3494139 In-Reply-To: References: <4F802A8F.2080009@infomarc.info> Message-ID: I just realized deadline for aplications was until 6th of April -.- And I thought deadline for REGISTRATION was until then... Anyways, I guess better luck next year! :) It was nice though because it got me going! I'm definitely going to make that patch awesome! :D On Mon, Apr 9, 2012 at 6:15 PM, Philip Karailanidis wrote: > Thanks Michael! > > I have made the pull request :) > As I specify, the patch is only a first approach, there is a lot of work > to be done. > I only did it so soon beacuse of the GSoC application, but I'm gonna work > on it in the future anyways :D > > Oh, and git isn't so bad after all! > > > On Mon, Apr 9, 2012 at 5:41 PM, J.M. wrote: > >> > Now, in order to submit the patch, should I make a new branch, where I >> can >> > commit the changes and then make a pull request? >> >> You may, but don't need to create a new branch. >> Making a pull request from your forked master branch is fine, too! >> >> -- >> mynetx (Jo Michael) >> >> >> ------------------------------------------------------------------------------ >> For Developers, A Lot Can Happen In A Second. >> Boundary is the first to Know...and Tell You. >> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! >> http://p.sf.net/sfu/Boundary-d2dvs2 >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Mon Apr 9 19:46:47 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 09 Apr 2012 13:46:47 -0400 Subject: [Phpmyadmin-devel] Deadline for patch submission In-Reply-To: References: Message-ID: <4F832087.1060601@infomarc.info> Le 2012-04-09 11:03, Ahmed Waheed a écrit : > Hi, > How much hours remaining for GSoC applicant patch submission ? How match > patch should I submit at least? Hi, use [0] to know about the deadline and number of patches. Use [1] to know the current UTC time. [0] http://wiki.phpmyadmin.net/pma/GSoC_2012_Applicant_Guide#Be_familiar_with_the_GSoC_timeline [1] http://timeanddate.com/worldclock/ -- Marc Delisle http://infomarc.info From marc at infomarc.info Mon Apr 9 20:28:42 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 09 Apr 2012 14:28:42 -0400 Subject: [Phpmyadmin-devel] Feature ID: 3494139 In-Reply-To: References: <4F802A8F.2080009@infomarc.info> Message-ID: <4F832A5A.3090503@infomarc.info> Le 2012-04-09 11:32, Philip Karailanidis a écrit : > I just realized deadline for aplications was until 6th of April -.- > And I thought deadline for REGISTRATION was until then... > > Anyways, I guess better luck next year! :) > It was nice though because it got me going! > I'm definitely going to make that patch awesome! :D Philip, it happens that a student submits many patches and is even invited to be part of the team, before sending his application to GSoC. This is the best way to proceed, as participating in the open source movement should not be limited to a few weeks during GSoC. -- Marc Delisle http://infomarc.info From waheedmp3 at gmail.com Tue Apr 10 03:03:04 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Tue, 10 Apr 2012 03:03:04 +0200 Subject: [Phpmyadmin-devel] Bugs availability Message-ID: Hi, To know the bugs that are available for fixing, the resolution field is "none", right? for example: is that bug available for me to fix bug #*3501122?* -------------- next part -------------- An HTML attachment was scrubbed... URL: From waheedmp3 at gmail.com Tue Apr 10 03:14:50 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Tue, 10 Apr 2012 03:14:50 +0200 Subject: [Phpmyadmin-devel] Bugs availability In-Reply-To: References: Message-ID: sorry, I meant "status" should be "open", right? -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at mynetx.net Tue Apr 10 03:20:49 2012 From: me at mynetx.net (J.M.) Date: Tue, 10 Apr 2012 03:20:49 +0200 Subject: [Phpmyadmin-devel] Bugs availability In-Reply-To: References: Message-ID: > sorry, I meant "status" should be "open", right? Generally, yes. As for the bug [0] that you mentioned, the comments thread shows that somebody already submitted a patch for a duplicate bug. @Marc, what about that patch/duplicate? [0] https://sourceforge.net/tracker/index.php?func=detail&aid=3501122&group_id=23067&atid=377408 -- mynetx (Jo Michael) From waheedmp3 at gmail.com Tue Apr 10 03:36:03 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Tue, 10 Apr 2012 03:36:03 +0200 Subject: [Phpmyadmin-devel] Bugs availability In-Reply-To: References: Message-ID: @Jo then why both bugs still with status "open"? -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at mynetx.net Tue Apr 10 04:04:45 2012 From: me at mynetx.net (J.M.) Date: Tue, 10 Apr 2012 04:04:45 +0200 Subject: [Phpmyadmin-devel] Bugs availability In-Reply-To: References: Message-ID: > @Jo then why both bugs still with status "open"? We leave the status of bugs and feature requests "open" until a phpMyAdmin version has been released that contains their fixes. Items we already worked on are marked with a resolution != "None" and/or Priority = 1. They also have an updated subject line that starts like "(ok 4.0)" or "(ok 3.5.1)" etc. Marc or Michal can tell you why these bug fixes are not yet added to the code. -- mynetx (Jo Michael) From pe.chanaka.ck at gmail.com Tue Apr 10 06:08:37 2012 From: pe.chanaka.ck at gmail.com (Chanaka Dharmarathna) Date: Tue, 10 Apr 2012 09:38:37 +0530 Subject: [Phpmyadmin-devel] Submitted a patch for feature request ID: 3511561 In-Reply-To: References: Message-ID: On Sat, Apr 7, 2012 at 11:36 PM, Chanaka Dharmarathna < pe.chanaka.ck at gmail.com> wrote: > Hi, > > I have implemented the feature request [0] and submitted the patch at [1]. > If there is anything to improve in my patch, I'm looking for your valuable > suggestions. > > [0]: > https://sourceforge.net/tracker/?func=detail&aid=3511561&group_id=23067&atid=377411 > [1]: > https://sourceforge.net/tracker/index.php?func=detail&aid=3515738&group_id=23067&atid=377410 > > Regards ! > -- > ____________________________________ > > Chanaka Indrajith > Bsc.Computer Engineering Undergraduate > Faculty of Engineering > University of Peradeniya > Sri Lanka > ____________________________________ > > Hi, I did some modifications to my patch [0] regarding the feature request [1]. Your suggestions are well come if there should be any improvements. [0]: https://sourceforge.net/tracker/index.php?func=detail&aid=3515738&group_id=23067&atid=377410 [1]: https://sourceforge.net/tracker/?func=detail&aid=3511561&group_id=23067&atid=377411 Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From thilinaabeyrathna at gmail.com Tue Apr 10 08:31:10 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Tue, 10 Apr 2012 12:01:10 +0530 Subject: [Phpmyadmin-devel] GSOC- Refactoring In-Reply-To: References: <4F7B6681.6050707@infomarc.info> Message-ID: On Sun, Apr 8, 2012 at 12:40 AM, Thilina Buddika Abeyrathna < thilinaabeyrathna at gmail.com> wrote: > > > On Sun, Apr 8, 2012 at 12:20 AM, Thilina Buddika Abeyrathna < > thilinaabeyrathna at gmail.com> wrote: > >> >> >> On Wed, Apr 4, 2012 at 9:31 AM, Thilina Buddika Abeyrathna < >> thilinaabeyrathna at gmail.com> wrote: >> >>> >>> >>> On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle wrote: >>> >>>> Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit : >>>> > Hi Marc, >>>> > I'm looking to refactor some small piece of code in phpmyadmin. Then >>>> I can >>>> > more familiar with code base. So if you have suggestion please let me >>>> know. >>>> >>>> >>>> Thilina, >>>> in user_password.php there is a long "if" that starts with >>>> >>>> if (isset($_REQUEST['nopass'])) { >>>> >>>> can you improve some parts of it? >>>> >>>> Hi Marc, >>> Ok, I'll do. >>> >> >> Hi Marc, >> I have tried to do some refactoring for user_password.php script which >> you mentioned earlier. please review that and give me some advice to >> improve my refactoring skill [0], because I'm new to code refactoring. >> > > >> [0] - >> https://sourceforge.net/tracker/?func=detail&aid=3515741&group_id=23067&atid=377410 >> > Hi Marc, I have updated the patch [0]. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From phil.230 at gmail.com Tue Apr 10 11:10:01 2012 From: phil.230 at gmail.com (Filippos Karailanidis) Date: Tue, 10 Apr 2012 12:10:01 +0300 Subject: [Phpmyadmin-devel] Feature ID: 3494139 In-Reply-To: <4F832A5A.3090503@infomarc.info> References: <4F802A8F.2080009@infomarc.info> <4F832A5A.3090503@infomarc.info> Message-ID: Thank you for the advice, Marc. For now, I'm going to keep working on that patch. We'll see what will happen in the future... :) On Mon, Apr 9, 2012 at 9:28 PM, Marc Delisle wrote: > Le 2012-04-09 11:32, Philip Karailanidis a écrit : > > I just realized deadline for aplications was until 6th of April -.- > > And I thought deadline for REGISTRATION was until then... > > > > Anyways, I guess better luck next year! :) > > It was nice though because it got me going! > > I'm definitely going to make that patch awesome! :D > > Philip, > it happens that a student submits many patches and is even invited to be > part of the team, before sending his application to GSoC. > > This is the best way to proceed, as participating in the open source > movement should not be limited to a few weeks during GSoC. > > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Tue Apr 10 12:34:23 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 10 Apr 2012 06:34:23 -0400 Subject: [Phpmyadmin-devel] Bugs availability In-Reply-To: References: Message-ID: <4F840CAF.5050103@infomarc.info> Le 2012-04-09 21:20, J.M. a écrit : >> sorry, I meant "status" should be "open", right? > > Generally, yes. > As for the bug [0] that you mentioned, the comments thread shows that > somebody already submitted a patch for a duplicate bug. > > @Marc, what about that patch/duplicate? > > [0] https://sourceforge.net/tracker/index.php?func=detail&aid=3501122&group_id=23067&atid=377408 Jo, the patch needs a careful analysis. -- Marc Delisle http://infomarc.info From michal at cihar.com Tue Apr 10 13:56:34 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Tue, 10 Apr 2012 13:56:34 +0200 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: References: Message-ID: <20120410135634.31d7ff3c@rincewind.suse.cz> Hi Dne Mon, 9 Apr 2012 15:51:59 +0500 Adnan napsal(a): > On Sat, Apr 7, 2012 at 2:02 PM, Adnan wrote: > > I wanted to discuss about the bad design patterns used in schema > > generation classes. According to my knowledge, > > > > 1. In Class PMA_Schema_PDF and other schema classes, properties are used > > with var which is deprecated from PHP 5.0 to 5.1.3 as declaring properties > > like var was standard in php4. So, in php5 standards are to use > > public,protected or private keywords. Though after 5.1.3 var is not > > deprecated and doesn't issue E_STRICT warning. so var used in current code > > is considered as public. Best pattren is to use protected keyword for > > properties in Schema classes. > > > > 2. Singleton/factory pattern is not used in schema classes. I guess, we > > should use it instead of instantiating objects on running scripts. > > > any input on this please ? Yes, you have input at the proposal. Please try to avoid spreading same topic over several channels. Also do not expect everybody is online and has time 24/7 - people are away from computers sometimes. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From hiddenpearls at gmail.com Tue Apr 10 14:46:40 2012 From: hiddenpearls at gmail.com (Adnan) Date: Tue, 10 Apr 2012 17:46:40 +0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: <20120410135634.31d7ff3c@rincewind.suse.cz> References: <20120410135634.31d7ff3c@rincewind.suse.cz> Message-ID: On Tue, Apr 10, 2012 at 4:56 PM, Michal Čihař wrote: > Hi > > Dne Mon, 9 Apr 2012 15:51:59 +0500 > Adnan napsal(a): > > > On Sat, Apr 7, 2012 at 2:02 PM, Adnan wrote: > > > I wanted to discuss about the bad design patterns used in schema > > > generation classes. According to my knowledge, > > > > > > 1. In Class PMA_Schema_PDF and other schema classes, properties are > used > > > with var which is deprecated from PHP 5.0 to 5.1.3 as declaring > properties > > > like var was standard in php4. So, in php5 standards are to use > > > public,protected or private keywords. Though after 5.1.3 var is not > > > deprecated and doesn't issue E_STRICT warning. so var used in current > code > > > is considered as public. Best pattren is to use protected keyword for > > > properties in Schema classes. > > > > > > 2. Singleton/factory pattern is not used in schema classes. I guess, > we > > > should use it instead of instantiating objects on running scripts. > > > > > any input on this please ? > > Yes, you have input at the proposal. Please try to avoid spreading same > topic over several channels. Also do not expect everybody is online and > has time 24/7 - people are away from computers sometimes. > Thanks for input. Sorry, It will never happen again. > > -- > Michal Čihař | http://cihar.com | http://blog.cihar.com > > > ------------------------------------------------------------------------------ > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From waheedmp3 at gmail.com Tue Apr 10 15:17:25 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Tue, 10 Apr 2012 15:17:25 +0200 Subject: [Phpmyadmin-devel] Creating table Message-ID: I need an example on writing queries within PMA scripts using PMA_DBI, for example: creating a table. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Tue Apr 10 15:32:19 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 10 Apr 2012 09:32:19 -0400 Subject: [Phpmyadmin-devel] Creating table In-Reply-To: References: Message-ID: <4F843663.30608@infomarc.info> Le 2012-04-10 09:17, Ahmed Waheed a écrit : > I need an example on writing queries within PMA scripts using PMA_DBI, for > example: creating a table. Ahmed, I don't think it's too much to ask from a would-be GSoC participant to look a bit inside phpMyAdmin source code (or use a search technique like "git grep" that was suggested a few days ago) in order to find the answer. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From thilinaabeyrathna at gmail.com Tue Apr 10 15:45:29 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Tue, 10 Apr 2012 19:15:29 +0530 Subject: [Phpmyadmin-devel] GSOC- Refactoring In-Reply-To: References: <4F7B6681.6050707@infomarc.info> Message-ID: On Tue, Apr 10, 2012 at 12:01 PM, Thilina Buddika Abeyrathna < thilinaabeyrathna at gmail.com> wrote: > > > On Sun, Apr 8, 2012 at 12:40 AM, Thilina Buddika Abeyrathna < > thilinaabeyrathna at gmail.com> wrote: > >> >> >> On Sun, Apr 8, 2012 at 12:20 AM, Thilina Buddika Abeyrathna < >> thilinaabeyrathna at gmail.com> wrote: >> >>> >>> >>> On Wed, Apr 4, 2012 at 9:31 AM, Thilina Buddika Abeyrathna < >>> thilinaabeyrathna at gmail.com> wrote: >>> >>>> >>>> >>>> On Wed, Apr 4, 2012 at 2:37 AM, Marc Delisle wrote: >>>> >>>>> Le 2012-04-03 14:02, Thilina Buddika Abeyrathna a écrit : >>>>> > Hi Marc, >>>>> > I'm looking to refactor some small piece of code in phpmyadmin. Then >>>>> I can >>>>> > more familiar with code base. So if you have suggestion please let >>>>> me know. >>>>> >>>>> >>>>> Thilina, >>>>> in user_password.php there is a long "if" that starts with >>>>> >>>>> if (isset($_REQUEST['nopass'])) { >>>>> >>>>> can you improve some parts of it? >>>>> >>>>> Hi Marc, >>>> Ok, I'll do. >>>> >>> >>> Hi Marc, >>> I have tried to do some refactoring for user_password.php script which >>> you mentioned earlier. please review that and give me some advice to >>> improve my refactoring skill [0], because I'm new to code refactoring. >>> >> >> >>> [0] - >>> https://sourceforge.net/tracker/?func=detail&aid=3515741&group_id=23067&atid=377410 >>> >> > Hi Marc, > I have updated the patch [0]. > > Hi Marc, Can you review my second patch which is regarding to refactoring [1]. I have fixed previous bug. [1] - https://sourceforge.net/tracker/?func=detail&aid=3515741&group_id=23067&atid=377410 -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From waheedmp3 at gmail.com Tue Apr 10 15:50:46 2012 From: waheedmp3 at gmail.com (Ahmed Waheed) Date: Tue, 10 Apr 2012 15:50:46 +0200 Subject: [Phpmyadmin-devel] Creating table In-Reply-To: <4F843663.30608@infomarc.info> References: <4F843663.30608@infomarc.info> Message-ID: Hi Marc, Sorry for inconvenience, I'm just having exams current days and that leaves me no chance to work enough on both the proposal"previously" and now for the patches, I actually was about to leave the whole thing, but I'm trying as much as I can..I'm stuck at the gears of time. Best Regards,, -------------- next part -------------- An HTML attachment was scrubbed... URL: From rouslan at placella.com Tue Apr 10 23:44:56 2012 From: rouslan at placella.com (Rouslan Placella) Date: Tue, 10 Apr 2012 22:44:56 +0100 Subject: [Phpmyadmin-devel] jQuery update broke some charts Message-ID: <4F84A9D8.4060007@placella.com> Hi there, It looks like the "live traffic monitor" and the "monitor" from the status tab are broken in current master. The points are not being plotted at all on the charts. According to git-bisect this is the first bad commit: > commit 1fd405d20e2399e035478c414bbb4acb3ea2dd23 > Author: Marc Delisle > Date: Sat Apr 7 09:29:47 2012 -0400 > > Update to jQuery 1.7.2 Bye, Rouslan From marc at infomarc.info Wed Apr 11 00:11:38 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 10 Apr 2012 18:11:38 -0400 Subject: [Phpmyadmin-devel] jQuery update broke some charts In-Reply-To: <4F84A9D8.4060007@placella.com> References: <4F84A9D8.4060007@placella.com> Message-ID: <4F84B01A.2000005@infomarc.info> Le 2012-04-10 17:44, Rouslan Placella a écrit : > Hi there, > > It looks like the "live traffic monitor" and the "monitor" from the > status tab are broken in current master. The points are not being > plotted at all on the charts. According to git-bisect this is the first > bad commit: > >> commit 1fd405d20e2399e035478c414bbb4acb3ea2dd23 >> Author: Marc Delisle >> Date: Sat Apr 7 09:29:47 2012 -0400 >> >> Update to jQuery 1.7.2 > > Bye, > Rouslan Thanks Rouslan, I have put back jQuery 1.6.2 for now. I tried the newer Highcharts (2.2.1) but got other js errors so it needs more testing. -- Marc Delisle http://infomarc.info From michal at cihar.com Wed Apr 11 08:48:28 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 11 Apr 2012 08:48:28 +0200 Subject: [Phpmyadmin-devel] Any further release of 3.4 Message-ID: <20120411084828.6f08c863@rincewind.suse.cz> Hi all now when 3.5 is out, do we plan to do one more release of 3.4 series or not? The main reason for this question is whether bug fixes and translation updates should still be pushed to QA_3_4 or it can be safely ignored. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From tyronx at gmail.com Wed Apr 11 08:49:13 2012 From: tyronx at gmail.com (Tyron Madlener) Date: Wed, 11 Apr 2012 08:49:13 +0200 Subject: [Phpmyadmin-devel] jQuery update broke some charts In-Reply-To: <4F84B01A.2000005@infomarc.info> References: <4F84A9D8.4060007@placella.com> <4F84B01A.2000005@infomarc.info> Message-ID: I'll try to have a look at this today. On Wed, Apr 11, 2012 at 12:11 AM, Marc Delisle wrote: > Le 2012-04-10 17:44, Rouslan Placella a écrit : > > Hi there, > > > > It looks like the "live traffic monitor" and the "monitor" from the > > status tab are broken in current master. The points are not being > > plotted at all on the charts. According to git-bisect this is the first > > bad commit: > > > >> commit 1fd405d20e2399e035478c414bbb4acb3ea2dd23 > >> Author: Marc Delisle > >> Date: Sat Apr 7 09:29:47 2012 -0400 > >> > >> Update to jQuery 1.7.2 > > > > Bye, > > Rouslan > > Thanks Rouslan, I have put back jQuery 1.6.2 for now. I tried the newer > Highcharts (2.2.1) but got other js errors so it needs more testing. > > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dieter.adriaenssens at gmail.com Wed Apr 11 09:17:49 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Wed, 11 Apr 2012 09:17:49 +0200 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <20120411084828.6f08c863@rincewind.suse.cz> References: <20120411084828.6f08c863@rincewind.suse.cz> Message-ID: Op 11 april 2012 08:48 heeft Michal Čihař het volgende geschreven: > Hi all > > now when 3.5 is out, do we plan to do one more release of 3.4 series or > not? The main reason for this question is whether bug fixes and > translation updates should still be pushed to QA_3_4 or it can be > safely ignored. Hi, I think we can stop bugfix support for the 3.4 series, now that 3.5 is out. Same for translation updates. We could do one final bugfix release in 3.4 with the bugs that are solved in that branch at the moment, with a final update of the translations at the time of the release. >From then on we would only do security releases in the 3.4 branch. Kind regards, Dieter > -- >        Michal Čihař | http://cihar.com | http://blog.cihar.com > > ------------------------------------------------------------------------------ > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Kind regards, Dieter Adriaenssens From thijs at debian.org Wed Apr 11 10:17:50 2012 From: thijs at debian.org (Thijs Kinkhorst) Date: Wed, 11 Apr 2012 10:17:50 +0200 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <20120411084828.6f08c863@rincewind.suse.cz> References: <20120411084828.6f08c863@rincewind.suse.cz> Message-ID: <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> On Wed, April 11, 2012 08:48, Michal Cihar wrote: > now when 3.5 is out, do we plan to do one more release of 3.4 series or > not? The main reason for this question is whether bug fixes and > translation updates should still be pushed to QA_3_4 or it can be > safely ignored. We have a problem with getting 3.5 in Debian because 3.5 contains code that may only be used in non-commercial context, or otherwise a paid licence is needed (highcharts). That's obviously prohibitive for us. As long as that's not resolved we need to stick wih 3.4; so it really depends on what timeframe we're looking at there if we could make use of further 3.4 updates. Cheers, Thijs From michal at cihar.com Wed Apr 11 11:38:50 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 11 Apr 2012 11:38:50 +0200 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: References: <20120411084828.6f08c863@rincewind.suse.cz> Message-ID: <20120411113850.42aafd61@rincewind.suse.cz> Hi Dne Wed, 11 Apr 2012 09:17:49 +0200 Dieter Adriaenssens napsal(a): > I think we can stop bugfix support for the 3.4 series, now that 3.5 is > out. Same for translation updates. > We could do one final bugfix release in 3.4 with the bugs that are > solved in that branch at the moment, with a final update of the > translations at the time of the release. > From then on we would only do security releases in the 3.4 branch. I thought about this approach as well. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Wed Apr 11 13:17:07 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 11 Apr 2012 13:17:07 +0200 Subject: [Phpmyadmin-devel] clone is so slow In-Reply-To: References: Message-ID: <20120411131707.0c398e21@rincewind.suse.cz> Hi Dne Mon, 9 Apr 2012 07:52:34 +0200 Ahmed Waheed napsal(a): > The process : git clone git at github.com:phpmyadmin/phpmyadmin.git > is so slow, it takes a long time to complete, why? is there any way to > speed it up? > I tried it once, and I'm trying to clone again now to a different > directory, can I just copy&paste the first copy to the new directory and > work on it? Indeed it takes quite long, I've asked github support to compact the repository using git gc --aggressive, what would cut it's size by 100 MB. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Wed Apr 11 13:39:30 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 11 Apr 2012 13:39:30 +0200 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> References: <20120411084828.6f08c863@rincewind.suse.cz> <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> Message-ID: <20120411133930.5f467cf4@rincewind.suse.cz> Hi Dne Wed, 11 Apr 2012 10:17:50 +0200 "Thijs Kinkhorst" napsal(a): > On Wed, April 11, 2012 08:48, Michal Cihar wrote: > > now when 3.5 is out, do we plan to do one more release of 3.4 series or > > not? The main reason for this question is whether bug fixes and > > translation updates should still be pushed to QA_3_4 or it can be > > safely ignored. > > We have a problem with getting 3.5 in Debian because 3.5 contains code > that may only be used in non-commercial context, or otherwise a paid > licence is needed (highcharts). That's obviously prohibitive for us. Obviously we're not alone in this: https://github.com/Snorby/snorby/issues/70 https://github.com/auxesis/visage/issues/54 Especially second issue looks promising as there seems to be possibility to get Highcharts licensed under GPL. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Wed Apr 11 14:15:06 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 11 Apr 2012 08:15:06 -0400 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <20120411113850.42aafd61@rincewind.suse.cz> References: <20120411084828.6f08c863@rincewind.suse.cz> <20120411113850.42aafd61@rincewind.suse.cz> Message-ID: <4F8575CA.6060001@infomarc.info> Le 2012-04-11 05:38, Michal Čihař a écrit : > Hi > > Dne Wed, 11 Apr 2012 09:17:49 +0200 > Dieter Adriaenssens napsal(a): > >> I think we can stop bugfix support for the 3.4 series, now that 3.5 is >> out. Same for translation updates. >> We could do one final bugfix release in 3.4 with the bugs that are >> solved in that branch at the moment, with a final update of the >> translations at the time of the release. >> From then on we would only do security releases in the 3.4 branch. > > I thought about this approach as well. Agreed, I'll proceed today. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From marc at infomarc.info Wed Apr 11 14:22:21 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 11 Apr 2012 08:22:21 -0400 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <20120411133930.5f467cf4@rincewind.suse.cz> References: <20120411084828.6f08c863@rincewind.suse.cz> <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> <20120411133930.5f467cf4@rincewind.suse.cz> Message-ID: <4F85777D.6030403@infomarc.info> Le 2012-04-11 07:39, Michal Čihař a écrit : > Hi > > Dne Wed, 11 Apr 2012 10:17:50 +0200 > "Thijs Kinkhorst" napsal(a): > >> On Wed, April 11, 2012 08:48, Michal Cihar wrote: >>> now when 3.5 is out, do we plan to do one more release of 3.4 series or >>> not? The main reason for this question is whether bug fixes and >>> translation updates should still be pushed to QA_3_4 or it can be >>> safely ignored. >> >> We have a problem with getting 3.5 in Debian because 3.5 contains code >> that may only be used in non-commercial context, or otherwise a paid >> licence is needed (highcharts). That's obviously prohibitive for us. > > Obviously we're not alone in this: > > https://github.com/Snorby/snorby/issues/70 > https://github.com/auxesis/visage/issues/54 > > Especially second issue looks promising as there seems to be > possibility to get Highcharts licensed under GPL. Michal, who will contact Torstein Hønsi about this? -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From marc at infomarc.info Wed Apr 11 14:28:57 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 11 Apr 2012 08:28:57 -0400 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <4F85777D.6030403@infomarc.info> References: <20120411084828.6f08c863@rincewind.suse.cz> <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> <20120411133930.5f467cf4@rincewind.suse.cz> <4F85777D.6030403@infomarc.info> Message-ID: <4F857909.7040508@infomarc.info> Le 2012-04-11 08:22, Marc Delisle a écrit : > Le 2012-04-11 07:39, Michal Čihař a écrit : >> Hi >> >> Dne Wed, 11 Apr 2012 10:17:50 +0200 >> "Thijs Kinkhorst" napsal(a): >> >>> On Wed, April 11, 2012 08:48, Michal Cihar wrote: >>>> now when 3.5 is out, do we plan to do one more release of 3.4 series or >>>> not? The main reason for this question is whether bug fixes and >>>> translation updates should still be pushed to QA_3_4 or it can be >>>> safely ignored. >>> >>> We have a problem with getting 3.5 in Debian because 3.5 contains code >>> that may only be used in non-commercial context, or otherwise a paid >>> licence is needed (highcharts). That's obviously prohibitive for us. >> >> Obviously we're not alone in this: >> >> https://github.com/Snorby/snorby/issues/70 >> https://github.com/auxesis/visage/issues/54 >> >> Especially second issue looks promising as there seems to be >> possibility to get Highcharts licensed under GPL. > > Michal, > who will contact Torstein Hønsi about this? Also, from [0], "I have only been granted permission to distributed highcharts.js under the GPLv2, not highcharts.src.js." This means that we should not have renamed highcharts.src.js to highcharts.js because it can create some confusion. [0] https://github.com/auxesis/visage/commit/58fdbcc9d3b1ccbc8101a1e3fb8cf02303ca91ac -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From michal at cihar.com Wed Apr 11 14:46:18 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 11 Apr 2012 14:46:18 +0200 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <4F857909.7040508@infomarc.info> References: <20120411084828.6f08c863@rincewind.suse.cz> <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> <20120411133930.5f467cf4@rincewind.suse.cz> <4F85777D.6030403@infomarc.info> <4F857909.7040508@infomarc.info> Message-ID: <20120411144618.6e1da600@rincewind.suse.cz> Hi Dne Wed, 11 Apr 2012 08:28:57 -0400 Marc Delisle napsal(a): > Also, from [0], "I have only been granted permission to distributed > highcharts.js under the GPLv2, not highcharts.src.js." > > This means that we should not have renamed highcharts.src.js to > highcharts.js because it can create some confusion. Okay, in this case it probably won't really help as I doubt highcharts.js is preferred form of modification according to GPL... -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Wed Apr 11 14:26:16 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 11 Apr 2012 08:26:16 -0400 Subject: [Phpmyadmin-devel] 3.5.1-rc1 ? Message-ID: <4F857868.4090601@infomarc.info> Hi, I'll wait for the Highcharts licensing issue, but I think we could start MAINT_3_5_1, release 3.5.1-rc1 and switch QA_3_5 to 3.5.2-dev. Anything serious that should go into 3.5.1? -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From marc at infomarc.info Wed Apr 11 15:00:30 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 11 Apr 2012 09:00:30 -0400 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <20120411144618.6e1da600@rincewind.suse.cz> References: <20120411084828.6f08c863@rincewind.suse.cz> <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> <20120411133930.5f467cf4@rincewind.suse.cz> <4F85777D.6030403@infomarc.info> <4F857909.7040508@infomarc.info> <20120411144618.6e1da600@rincewind.suse.cz> Message-ID: <4F85806E.2020805@infomarc.info> Le 2012-04-11 08:46, Michal Čihař a écrit : > Hi > > Dne Wed, 11 Apr 2012 08:28:57 -0400 > Marc Delisle napsal(a): > >> Also, from [0], "I have only been granted permission to distributed >> highcharts.js under the GPLv2, not highcharts.src.js." >> >> This means that we should not have renamed highcharts.src.js to >> highcharts.js because it can create some confusion. > > Okay, in this case it probably won't really help as I doubt > highcharts.js is preferred form of modification according to GPL... But we could ask to relicense highcharts.src.js. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From michal at cihar.com Wed Apr 11 15:21:53 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 11 Apr 2012 15:21:53 +0200 Subject: [Phpmyadmin-devel] Dropping ErrorIconic/MainPageIconic Message-ID: <20120411152153.57bf539e@rincewind.suse.cz> Hi all are there any objections against dropping ErrorIconic/MainPageIconic configuration options? I think this is something what should be decided on theme level and it's fully up to theme to choose how to render things. Also when I tried to disable MainPageIconic, it leads currently to mixed results and does not fully disable icons. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Wed Apr 11 15:27:15 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 11 Apr 2012 09:27:15 -0400 Subject: [Phpmyadmin-devel] Dropping ErrorIconic/MainPageIconic In-Reply-To: <20120411152153.57bf539e@rincewind.suse.cz> References: <20120411152153.57bf539e@rincewind.suse.cz> Message-ID: <4F8586B3.7010508@infomarc.info> Le 2012-04-11 09:21, Michal Čihař a écrit : > Hi all > > are there any objections against dropping ErrorIconic/MainPageIconic > configuration options? I think this is something what should be decided > on theme level and it's fully up to theme to choose how to render > things. > > Also when I tried to disable MainPageIconic, it leads currently to > mixed results and does not fully disable icons. OK for me. I am building a list of options (either config or on-screen) for potential removing in 4.0, I'll send it for discussion in a few days. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From michal at cihar.com Wed Apr 11 15:41:34 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 11 Apr 2012 15:41:34 +0200 Subject: [Phpmyadmin-devel] Dropping ErrorIconic/MainPageIconic In-Reply-To: <4F8586B3.7010508@infomarc.info> References: <20120411152153.57bf539e@rincewind.suse.cz> <4F8586B3.7010508@infomarc.info> Message-ID: <20120411154134.65f887cf@rincewind.suse.cz> Hi Dne Wed, 11 Apr 2012 09:27:15 -0400 Marc Delisle napsal(a): > Le 2012-04-11 09:21, Michal Čihař a écrit : > > Hi all > > > > are there any objections against dropping ErrorIconic/MainPageIconic > > configuration options? I think this is something what should be decided > > on theme level and it's fully up to theme to choose how to render > > things. > > > > Also when I tried to disable MainPageIconic, it leads currently to > > mixed results and does not fully disable icons. > > OK for me. I've just made pull request for this, will merge it tomorrow unless somebody objects. > I am building a list of options (either config or on-screen) for > potential removing in 4.0, I'll send it for discussion in a few days. Well I was about to start this, but one by one slowly removing them ;-). -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Wed Apr 11 18:51:28 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 11 Apr 2012 12:51:28 -0400 Subject: [Phpmyadmin-devel] phpMyAdmin 3.4.11-rc1 is released Message-ID: <4F85B690.2090309@infomarc.info> Welcome to the first release candidate for phpMyAdmin 3.4.11, the last bugfix release in the 3.4 series. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From marc at infomarc.info Wed Apr 11 19:24:34 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 11 Apr 2012 13:24:34 -0400 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <4F85806E.2020805@infomarc.info> References: <20120411084828.6f08c863@rincewind.suse.cz> <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> <20120411133930.5f467cf4@rincewind.suse.cz> <4F85777D.6030403@infomarc.info> <4F857909.7040508@infomarc.info> <20120411144618.6e1da600@rincewind.suse.cz> <4F85806E.2020805@infomarc.info> Message-ID: <4F85BE52.2000603@infomarc.info> Le 2012-04-11 09:00, Marc Delisle a écrit : > Le 2012-04-11 08:46, Michal Čihař a écrit : >> Hi >> >> Dne Wed, 11 Apr 2012 08:28:57 -0400 >> Marc Delisle napsal(a): >> >>> Also, from [0], "I have only been granted permission to distributed >>> highcharts.js under the GPLv2, not highcharts.src.js." >>> >>> This means that we should not have renamed highcharts.src.js to >>> highcharts.js because it can create some confusion. >> >> Okay, in this case it probably won't really help as I doubt >> highcharts.js is preferred form of modification according to GPL... > > But we could ask to relicense highcharts.src.js. I am sending the permission request. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From michal at cihar.com Thu Apr 12 10:05:16 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 12 Apr 2012 10:05:16 +0200 Subject: [Phpmyadmin-devel] Any further release of 3.4 In-Reply-To: <4F85BE52.2000603@infomarc.info> References: <20120411084828.6f08c863@rincewind.suse.cz> <169566247de959221fb68fcfc71a1b25.squirrel@wm.kinkhorst.nl> <20120411133930.5f467cf4@rincewind.suse.cz> <4F85777D.6030403@infomarc.info> <4F857909.7040508@infomarc.info> <20120411144618.6e1da600@rincewind.suse.cz> <4F85806E.2020805@infomarc.info> <4F85BE52.2000603@infomarc.info> Message-ID: <20120412100516.7589faba@rincewind.suse.cz> Hi Dne Wed, 11 Apr 2012 13:24:34 -0400 Marc Delisle napsal(a): > Le 2012-04-11 09:00, Marc Delisle a écrit : > > But we could ask to relicense highcharts.src.js. > > I am sending the permission request. Thanks for doing that :-). -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Thu Apr 12 13:04:54 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 12 Apr 2012 07:04:54 -0400 Subject: [Phpmyadmin-devel] Configuration directives changes for 4.x Message-ID: <4F86B6D6.7080705@infomarc.info> Hi, The $cfg['VerboseMultiSubmit'] directive is set to true by default and I never felt the need to change it. I suggest to remove it. The purpose of $cfg['Servers'][$i]['verbose_check'] is to verify whether the user has a pre-version 2.5.0 column_info table; we can safely remove this verification. $cfg['SkipLockedTables'] could be removed and the corresponding behavior always executed. The $cfg['SuggestDBName'] directive is set to true by default and I never felt the need to change it. I suggest to remove it. The $cfg['LightTabs'] directive is set to false by default and I never felt the need to change it. I suggest to remove it. Comments? -- Marc Delisle http://infomarc.info From phil.230 at gmail.com Thu Apr 12 16:55:45 2012 From: phil.230 at gmail.com (Filippos Karailanidis) Date: Thu, 12 Apr 2012 17:55:45 +0300 Subject: [Phpmyadmin-devel] db Export: Bug or not? Message-ID: Hello everyone, I noticed something and I don't know whether it's a bug or not. When exporting a database, there's Quick and Custom. Try selecting Custom, a list of the tables in the database appears. If you change the tables selected, obviously only those selected are exported. BUT, if you deselect some tables and then click Quick again and export, AGAIN the ones selected will be the only ones exported. In my mind, when the user decides to click Quick again, he changed his mind and he wants the whole database exported. This doesn't happen though if he has selected specific tables when he was in Custom. Maybe it's just me, that's why I wanted to ask you guys first, before reporting this as a bug. I hope I was clear -- Filippos Karailanidis -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Thu Apr 12 17:06:24 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 12 Apr 2012 11:06:24 -0400 Subject: [Phpmyadmin-devel] db Export: Bug or not? In-Reply-To: References: Message-ID: <4F86EF70.7090408@infomarc.info> Le 2012-04-12 10:55, Filippos Karailanidis a écrit : > Hello everyone, > > I noticed something and I don't know whether it's a bug or not. > > > When exporting a database, there's Quick and Custom. > > Try selecting Custom, a list of the tables in the database appears. > If you change the tables selected, obviously only those selected are > exported. > > BUT, if you deselect some tables and then click Quick again and export, > AGAIN the ones selected will be the only ones exported. > > In my mind, when the user decides to click Quick again, he changed his mind > and he wants the whole database exported. > This doesn't happen though if he has selected specific tables when he was > in Custom. > > > Maybe it's just me, that's why I wanted to ask you guys first, before > reporting this as a bug. > I hope I was clear Filippos, I don't think we can assume that he wants the whole db exported, especially as his previous operation was to deselect/select some tables. Quick means "display only the minimal options", it does not mean to revert to the default options. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From phil.230 at gmail.com Thu Apr 12 17:53:39 2012 From: phil.230 at gmail.com (Filippos Karailanidis) Date: Thu, 12 Apr 2012 18:53:39 +0300 Subject: [Phpmyadmin-devel] db Export: Bug or not? In-Reply-To: <4F86EF70.7090408@infomarc.info> References: <4F86EF70.7090408@infomarc.info> Message-ID: I see. The way I was thinking about it, is like when you install an application. In the installation Wizard, you can choose Custom Installation, make changes, and the change your mind, go back and select Quick (Typical) Installation so that the defaults are applied. But I guess that's not the case here, it's just about display, not an absolute choice. Thanks Marc On Thu, Apr 12, 2012 at 6:06 PM, Marc Delisle wrote: > Le 2012-04-12 10:55, Filippos Karailanidis a écrit : > > Hello everyone, > > > > I noticed something and I don't know whether it's a bug or not. > > > > > > When exporting a database, there's Quick and Custom. > > > > Try selecting Custom, a list of the tables in the database appears. > > If you change the tables selected, obviously only those selected are > > exported. > > > > BUT, if you deselect some tables and then click Quick again and export, > > AGAIN the ones selected will be the only ones exported. > > > > In my mind, when the user decides to click Quick again, he changed his > mind > > and he wants the whole database exported. > > This doesn't happen though if he has selected specific tables when he was > > in Custom. > > > > > > Maybe it's just me, that's why I wanted to ask you guys first, before > > reporting this as a bug. > > I hope I was clear > > Filippos, > I don't think we can assume that he wants the whole db exported, > especially as his previous operation was to deselect/select some tables. > > Quick means "display only the minimal options", it does not mean to > revert to the default options. > > -- > Marc Delisle > http://infomarc.info > > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -- Filippos Karailanidis -------------- next part -------------- An HTML attachment was scrubbed... URL: From dieter.adriaenssens at gmail.com Fri Apr 13 09:44:18 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Fri, 13 Apr 2012 09:44:18 +0200 Subject: [Phpmyadmin-devel] Configuration directives changes for 4.x In-Reply-To: <4F86B6D6.7080705@infomarc.info> References: <4F86B6D6.7080705@infomarc.info> Message-ID: Op 12 april 2012 13:04 heeft Marc Delisle het volgende geschreven: > Hi, > The $cfg['VerboseMultiSubmit'] directive is set to true by default and I > never felt the need to change it. I suggest to remove it. > > The purpose of $cfg['Servers'][$i]['verbose_check'] is to verify whether > the user has a pre-version 2.5.0 column_info table; we can safely remove > this verification. > > $cfg['SkipLockedTables'] could be removed and the corresponding behavior > always executed. > > The $cfg['SuggestDBName'] directive is set to true by default and I > never felt the need to change it. I suggest to remove it. > > The $cfg['LightTabs'] directive is set to false by default and I never > felt the need to change it. I suggest to remove it. > > Comments? No comments. We could ask the same question on the users mailing list and see if there are some objections? Kind regards, Dieter From marc at infomarc.info Sat Apr 14 13:48:47 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 14 Apr 2012 07:48:47 -0400 Subject: [Phpmyadmin-devel] phpMyAdmin 3.4.11 is released Message-ID: <4F89641F.3080405@infomarc.info> Welcome to phpMyAdmin 3.4.11, the last bugfix release in the 3.4 series. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team From marc at infomarc.info Sat Apr 14 15:05:27 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 14 Apr 2012 09:05:27 -0400 Subject: [Phpmyadmin-devel] session-based upload progress Message-ID: <4F897617.5080309@infomarc.info> Hi, apart from Jo and me, who has tested this feature (under PHP 5.4)? When I try it, most of the times the counter does not reach 100% even if the file is no longer in the upload area. -- Marc Delisle http://infomarc.info From marc at infomarc.info Sat Apr 14 15:19:58 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 14 Apr 2012 09:19:58 -0400 Subject: [Phpmyadmin-devel] Moving "Browse distinct values" to the right Message-ID: <4F89797E.7060804@infomarc.info> Hi, according to the principle that most-used features should be listed first, I would like to make a change (for 4.x) on table Structure. "Browse distinct values" would move to the last position among the actions. -- Marc Delisle http://infomarc.info From marc at infomarc.info Sat Apr 14 15:27:18 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 14 Apr 2012 09:27:18 -0400 Subject: [Phpmyadmin-devel] "More" actions lost Message-ID: <4F897B36.5000505@infomarc.info> Hi, when shrinking the window, "Browse distinct values" and "Primary" are lost (then don't switch to the More dropdown). -- Marc Delisle http://infomarc.info From madhura.cj at gmail.com Sat Apr 14 15:39:14 2012 From: madhura.cj at gmail.com (Madhura Jayaratne) Date: Sat, 14 Apr 2012 19:09:14 +0530 Subject: [Phpmyadmin-devel] Moving "Browse distinct values" to the right In-Reply-To: <4F89797E.7060804@infomarc.info> References: <4F89797E.7060804@infomarc.info> Message-ID: On Sat, Apr 14, 2012 at 6:49 PM, Marc Delisle wrote: > Hi, > according to the principle that most-used features should be listed > first, I would like to make a change (for 4.x) on table Structure. > > "Browse distinct values" would move to the last position among the actions. > > -- > Marc Delisle > http://infomarc.info > > Fine by me. And currently its short title is also "Browse distinct values", due to which it takes a relatively large space when not hidden under "More". How about using something like "Distinct" as the short title for "Browse distinct values"? -- Thanks and Regards, Madhura Jayaratne -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Sat Apr 14 15:41:48 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 14 Apr 2012 09:41:48 -0400 Subject: [Phpmyadmin-devel] Moving "Browse distinct values" to the right In-Reply-To: References: <4F89797E.7060804@infomarc.info> Message-ID: <4F897E9C.9070005@infomarc.info> Le 2012-04-14 09:39, Madhura Jayaratne a écrit : > On Sat, Apr 14, 2012 at 6:49 PM, Marc Delisle wrote: > >> Hi, >> according to the principle that most-used features should be listed >> first, I would like to make a change (for 4.x) on table Structure. >> >> "Browse distinct values" would move to the last position among the actions. >> >> -- >> Marc Delisle >> http://infomarc.info >> >> > Fine by me. > And currently its short title is also "Browse distinct values", due to > which it takes a relatively large space when not hidden under "More". How > about using something like "Distinct" as the short title for "Browse > distinct values"? I think that "Browse" is important to keep. Would "Browse distinct" be better? -- Marc Delisle http://infomarc.info From dieter.adriaenssens at gmail.com Sat Apr 14 15:49:02 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Sat, 14 Apr 2012 15:49:02 +0200 Subject: [Phpmyadmin-devel] session-based upload progress In-Reply-To: <4F897617.5080309@infomarc.info> References: <4F897617.5080309@infomarc.info> Message-ID: Op 14 april 2012 15:05 heeft Marc Delisle het volgende geschreven: > Hi, > apart from Jo and me, who has tested this feature (under PHP 5.4)? I currently have no php 5.4 set up to test with. -- Kind regards, Dieter Adriaenssens From madhura.cj at gmail.com Sat Apr 14 16:28:08 2012 From: madhura.cj at gmail.com (Madhura Jayaratne) Date: Sat, 14 Apr 2012 19:58:08 +0530 Subject: [Phpmyadmin-devel] Moving "Browse distinct values" to the right In-Reply-To: <4F897E9C.9070005@infomarc.info> References: <4F89797E.7060804@infomarc.info> <4F897E9C.9070005@infomarc.info> Message-ID: On Apr 14, 2012 7:12 PM, "Marc Delisle" wrote: > > Le 2012-04-14 09:39, Madhura Jayaratne a écrit : > > On Sat, Apr 14, 2012 at 6:49 PM, Marc Delisle wrote: > > > >> Hi, > >> according to the principle that most-used features should be listed > >> first, I would like to make a change (for 4.x) on table Structure. > >> > >> "Browse distinct values" would move to the last position among the actions. > >> > >> -- > >> Marc Delisle > >> http://infomarc.info > >> > >> > > Fine by me. > > And currently its short title is also "Browse distinct values", due to > > which it takes a relatively large space when not hidden under "More". How > > about using something like "Distinct" as the short title for "Browse > > distinct values"? > > I think that "Browse" is important to keep. Would "Browse distinct" be > better? > I was looking for a single word to go with the others. But considering the clarity, I think what you suggested would be better. -------------- next part -------------- An HTML attachment was scrubbed... URL: From piotr.prz at gmail.com Sat Apr 14 18:23:35 2012 From: piotr.prz at gmail.com (Piotr Przybylski) Date: Sat, 14 Apr 2012 18:23:35 +0200 Subject: [Phpmyadmin-devel] Moving "Browse distinct values" to the right In-Reply-To: References: <4F89797E.7060804@infomarc.info> <4F897E9C.9070005@infomarc.info> Message-ID: 2012/4/14 Madhura Jayaratne : > > On Apr 14, 2012 7:12 PM, "Marc Delisle" wrote: >> >> Le 2012-04-14 09:39, Madhura Jayaratne a écrit : >> > On Sat, Apr 14, 2012 at 6:49 PM, Marc Delisle >> > wrote: >> > >> >> Hi, >> >> according to the principle that most-used features should be listed >> >> first, I would like to make a change (for 4.x) on table Structure. >> >> >> >> "Browse distinct values" would move to the last position among the >> >> actions. >> >> >> >> -- >> >> Marc Delisle >> >> http://infomarc.info >> >> >> >> >> > Fine by me. >> > And currently its short title is also "Browse distinct values", due to >> > which it takes a relatively large space when not hidden under "More". >> > How >> > about using something like "Distinct" as the short title for "Browse >> > distinct values"? >> >> I think that "Browse" is important to keep. Would "Browse distinct" be >> better? >> > I was looking for a single word to go with the others. But considering the > clarity, I think what you suggested would be better. > How about "Distinct values"? I think it sounds better than "Browse distinct" (distinct what?) -- Regards, Piotr Przybylski From me at mynetx.net Sat Apr 14 20:09:11 2012 From: me at mynetx.net (J.M.) Date: Sat, 14 Apr 2012 20:09:11 +0200 Subject: [Phpmyadmin-devel] "More" actions lost In-Reply-To: <4F897B36.5000505@infomarc.info> References: <4F897B36.5000505@infomarc.info> Message-ID: > when shrinking the window, "Browse distinct values" and "Primary" are > lost (then don't switch to the More dropdown). Fixed in 582ac4d. However, something is wrong when loading the page when the window is already small (so "More" shows) and then made wider only a bit (so "More" still shows). Test table is: -- -- Table structure for table `table1` -- CREATE TABLE IF NOT EXISTS `table1` ( `computer` int(2) NOT NULL AUTO_INCREMENT, `system` int(1) NOT NULL, UNIQUE KEY `test` (`computer`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=2 ; -- -- Dumping data for table `table1` -- INSERT INTO `table1` (`computer`, `system`) VALUES (1, 2); -- mynetx (Jo Michael) From marc at infomarc.info Sat Apr 14 22:37:59 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 14 Apr 2012 16:37:59 -0400 Subject: [Phpmyadmin-devel] Moving "Browse distinct values" to the right In-Reply-To: References: <4F89797E.7060804@infomarc.info> <4F897E9C.9070005@infomarc.info> Message-ID: <4F89E027.8040703@infomarc.info> Le 2012-04-14 12:23, Piotr Przybylski a écrit : > 2012/4/14 Madhura Jayaratne : >> >> On Apr 14, 2012 7:12 PM, "Marc Delisle" wrote: >>> >>> Le 2012-04-14 09:39, Madhura Jayaratne a écrit : >>>> On Sat, Apr 14, 2012 at 6:49 PM, Marc Delisle >>>> wrote: >>>> >>>>> Hi, >>>>> according to the principle that most-used features should be listed >>>>> first, I would like to make a change (for 4.x) on table Structure. >>>>> >>>>> "Browse distinct values" would move to the last position among the >>>>> actions. >>>>> >>>>> -- >>>>> Marc Delisle >>>>> http://infomarc.info >>>>> >>>>> >>>> Fine by me. >>>> And currently its short title is also "Browse distinct values", due to >>>> which it takes a relatively large space when not hidden under "More". >>>> How >>>> about using something like "Distinct" as the short title for "Browse >>>> distinct values"? >>> >>> I think that "Browse" is important to keep. Would "Browse distinct" be >>> better? >>> >> I was looking for a single word to go with the others. But considering the >> clarity, I think what you suggested would be better. >> > > How about "Distinct values"? I think it sounds better than "Browse > distinct" (distinct what?) > Yes, a good compromise. -- Marc Delisle http://infomarc.info From alex.ukf at gmail.com Sat Apr 14 23:08:26 2012 From: alex.ukf at gmail.com (Alex Marin) Date: Sun, 15 Apr 2012 00:08:26 +0300 Subject: [Phpmyadmin-devel] Memory vs Speed Message-ID: Hi, I've got an implementation question: Say we have a file with tables to be imported and we have two ways of doing so, each of them having different performance issues: 1. Keep an array with all the tables' contents and run PMA_buildSQL() after all of them have been read. 2. Once a full table has been read, insert it with PMA_buildSQL() in the database. Option 1. has the advantage of making only one call to the expensive PMA_buildSQL() function. But what happens if we have more than 1000 tables? The array containing all of them will grow pretty big. Option 2. uses far less memory in this case, but, on the other hand, it makes 1000 calls to the previous function. What would make a good argument in choosing one of those approaches? -- Alex From marc at infomarc.info Sat Apr 14 23:40:57 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 14 Apr 2012 17:40:57 -0400 Subject: [Phpmyadmin-devel] Memory vs Speed In-Reply-To: References: Message-ID: <4F89EEE9.4090605@infomarc.info> Le 2012-04-14 17:08, Alex Marin a écrit : > Hi, > > I've got an implementation question: > Say we have a file with tables to be imported and we have two ways > of doing so, each of them having different performance issues: > > 1. Keep an array with all the tables' contents and run PMA_buildSQL() > after all of them have been read. > 2. Once a full table has been read, insert it with PMA_buildSQL() > in the database. > > Option 1. has the advantage of making only one call to the expensive > PMA_buildSQL() function. But what happens if we have more than 1000 > tables? The array containing all of them will grow pretty big. > Option 2. uses far less memory in this case, but, on the other hand, > it makes 1000 calls to the previous function. > > What would make a good argument in choosing one of those approaches? Alex, if you _have_ to choose one of the approaches, you have to choose the one that works for a great number of tables (or one really big table), therefore #2. Otherwise, you should tell the limitations of the approach to the user. If you _don't have_ to choose (if coding both approaches is easy), you can code both and call the best one, depending on the number of tables. P.S. maybe PMA_buildSQL() itself needs improvement. -- Marc Delisle http://infomarc.info From rouslan at placella.com Tue Apr 17 00:21:43 2012 From: rouslan at placella.com (Rouslan Placella) Date: Mon, 16 Apr 2012 23:21:43 +0100 Subject: [Phpmyadmin-devel] Error when dropping user in current master Message-ID: <4F8C9B77.1040501@placella.com> Hi all, I've just noticed that there is a problem when dropping a user in current master. If you go to Users tab at the server level and check a box near a user and then click "Go" in the "Remove selected users" fieldset, the "Loading" message will appear, but nothing will happen (although the user will get removed). I think that this occurs because the reply from the server is plain HTML instead of JSON. Git-bisect said: 91e0d2f5842fc35d6d08577899157aea7ba84ce0 is the first bad commit commit 91e0d2f5842fc35d6d08577899157aea7ba84ce0 Author: Jo Michael Date: Fri Mar 16 16:49:01 2012 +0100 Added user export for checkbox-selected users Bye, Rouslan From yasitha4 at gmail.com Wed Apr 18 06:07:26 2012 From: yasitha4 at gmail.com (yasitha pandithawatta) Date: Wed, 18 Apr 2012 09:37:26 +0530 Subject: [Phpmyadmin-devel] Automated Testing - GSoC 2012 Message-ID: Hi, Is there any place to change Ajax mode through the system, or we have to change it in the code? Are we really using the non-Ajax mode? When writing the selenium testing this may cause a problem. Do we have to consider non-Ajax mode when writing the tests? Regards -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Wed Apr 18 12:14:01 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 18 Apr 2012 06:14:01 -0400 Subject: [Phpmyadmin-devel] Automated Testing - GSoC 2012 In-Reply-To: References: Message-ID: <4F8E93E9.7000400@infomarc.info> Le 2012-04-18 00:07, yasitha pandithawatta a écrit : > Hi, > > Is there any place to change Ajax mode through the system, or we have to > change it in the code? Are we really using the non-Ajax mode? When writing > the selenium testing this may cause a problem. Do we have to consider > non-Ajax mode when writing the tests? > > Regards Yasitha, forget the non-Ajax mode for the 4.0 version; see [0]. [0] http://wiki.phpmyadmin.net/pma/FOSDEM_2012_Meeting#Remove_frames -- Marc Delisle http://infomarc.info From rouslan at placella.com Wed Apr 18 20:35:12 2012 From: rouslan at placella.com (Rouslan Placella) Date: Wed, 18 Apr 2012 19:35:12 +0100 Subject: [Phpmyadmin-devel] Error on db privileges page in master Message-ID: <4F8F0960.6080906@placella.com> Hi all, I just noticed a strange behaviour when you click on the db privileges tab. You get the correct page, but the breadcrumbs, menubar and navigation think that you are at server level, rather than at db level. Git-bisect said: fa02a8669ddceeb77367a420a1a84dd303a2b297 is the first bad commit commit fa02a8669ddceeb77367a420a1a84dd303a2b297 Author: Marc Delisle Date: Sun Mar 4 07:31:37 2012 -0500 All cases of globalizing $_GET variables are hopefully covered by now Bye, Rouslan From hiddenpearls at gmail.com Thu Apr 19 09:23:12 2012 From: hiddenpearls at gmail.com (Adnan) Date: Thu, 19 Apr 2012 12:23:12 +0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: References: <20120410135634.31d7ff3c@rincewind.suse.cz> Message-ID: On Tue, Apr 10, 2012 at 5:46 PM, Adnan wrote: > > > On Tue, Apr 10, 2012 at 4:56 PM, Michal Čihař wrote: > >> Hi >> >> Dne Mon, 9 Apr 2012 15:51:59 +0500 >> Adnan napsal(a): >> >> > On Sat, Apr 7, 2012 at 2:02 PM, Adnan wrote: >> > > I wanted to discuss about the bad design patterns used in schema >> > > generation classes. According to my knowledge, >> > > >> > > 1. In Class PMA_Schema_PDF and other schema classes, properties are >> used >> > > with var which is deprecated from PHP 5.0 to 5.1.3 as declaring >> properties >> > > like var was standard in php4. So, in php5 standards are to use >> > > public,protected or private keywords. Though after 5.1.3 var is not >> > > deprecated and doesn't issue E_STRICT warning. so var used in current >> code >> > > is considered as public. Best pattren is to use protected keyword for >> > > properties in Schema classes. >> > > >> > > 2. Singleton/factory pattern is not used in schema classes. I guess, >> we >> > > should use it instead of instantiating objects on running scripts. >> > > >> > any input on this please ? >> >> Yes, you have input at the proposal. Please try to avoid spreading same >> topic over several channels. Also do not expect everybody is online and >> has time 24/7 - people are away from computers sometimes. >> > Thanks for input. Sorry, It will never happen again. > >> >> -- >> Michal Čihař | http://cihar.com | http://blog.cihar.com >> >> >> ------------------------------------------------------------------------------ >> Better than sec? Nothing is better than sec when it comes to >> monitoring Big Data applications. Try Boundary one-second >> resolution app monitoring today. Free. >> http://p.sf.net/sfu/Boundary-dev2dev >> >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> >> > > > -- > Muhammad Adnan > Twitter: @hiddenpearls > I blog too do u know ? http:// www.imblog.info > Failure takes you higher than success ..! > you sell code, I sell my brain. > > hi guys, here is a very initial demo of PMA-Designer using jQueryUI API's. Suggestions are always welcome. drag and drop the fields and experience it. http://jollyhits.com/pma/ -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Thu Apr 19 12:01:59 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 19 Apr 2012 06:01:59 -0400 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: References: <20120410135634.31d7ff3c@rincewind.suse.cz> Message-ID: <4F8FE297.2030004@infomarc.info> Le 2012-04-19 03:23, Adnan a écrit : > hi guys, > > here is a very initial demo of PMA-Designer using jQueryUI API's. > Suggestions are always welcome. > drag and drop the fields and experience it. > http://jollyhits.com/pma/ Hi, First, please use the correct terminology: tables and _columns_, not fields. Second, it's not intuitive that dragging a column to another table means to establish a relation between these tables. On the other hand, drawing a line between columns would be intuitive. -- Marc Delisle http://infomarc.info From marc at infomarc.info Thu Apr 19 12:22:31 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 19 Apr 2012 06:22:31 -0400 Subject: [Phpmyadmin-devel] Error on db privileges page in master In-Reply-To: <4F8F0960.6080906@placella.com> References: <4F8F0960.6080906@placella.com> Message-ID: <4F8FE767.5090309@infomarc.info> Le 2012-04-18 14:35, Rouslan Placella a écrit : > Hi all, > > I just noticed a strange behaviour when you click on the db privileges > tab. You get the correct page, but the breadcrumbs, menubar and > navigation think that you are at server level, rather than at db level. Should be fixed now, thanks for reporting. -- Marc Delisle http://infomarc.info From hiddenpearls at gmail.com Thu Apr 19 12:28:03 2012 From: hiddenpearls at gmail.com (Adnan) Date: Thu, 19 Apr 2012 15:28:03 +0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: <4F8FE297.2030004@infomarc.info> References: <20120410135634.31d7ff3c@rincewind.suse.cz> <4F8FE297.2030004@infomarc.info> Message-ID: On Thu, Apr 19, 2012 at 3:01 PM, Marc Delisle wrote: > Le 2012-04-19 03:23, Adnan a écrit : > > > hi guys, > > > > here is a very initial demo of PMA-Designer using jQueryUI API's. > > Suggestions are always welcome. > > drag and drop the fields and experience it. > > http://jollyhits.com/pma/ > > Hi, > > First, please use the correct terminology: tables and _columns_, not > fields. > > Ok > Second, it's not intuitive that dragging a column to another table means > to establish a relation between these tables. > On the other hand, drawing a line between columns would be intuitive. > > Of course, There would be a line showing relation between columns using Canvas tags like in current PMA-Designer. I was showing a very initial demo with dragging columns actually. > -- > Marc Delisle > http://infomarc.info > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain. -------------- next part -------------- An HTML attachment was scrubbed... URL: From rouslan at placella.com Thu Apr 19 12:43:22 2012 From: rouslan at placella.com (Rouslan Placella) Date: Thu, 19 Apr 2012 05:43:22 -0500 Subject: [Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration In-Reply-To: <4F8FE297.2030004@infomarc.info> References: <20120410135634.31d7ff3c@rincewind.suse.cz> <4F8FE297.2030004@infomarc.info> Message-ID: <20120419054322.gal1agl9kosk40kc@webmail.opentransfer.com> Quoting Marc Delisle : > Le 2012-04-19 03:23, Adnan a écrit : > >> hi guys, >> >> here is a very initial demo of PMA-Designer using jQueryUI API's. >> Suggestions are always welcome. >> drag and drop the fields and experience it. >> http://jollyhits.com/pma/ > > Hi, > > First, please use the correct terminology: tables and _columns_, not fields. > > Second, it's not intuitive that dragging a column to another table means > to establish a relation between these tables. > > On the other hand, drawing a line between columns would be intuitive. Also, positioning a table behind another table sometimes triggers the "Confirm relation" message. Bye, Rouslan From wiltave at gmail.com Thu Apr 19 17:46:36 2012 From: wiltave at gmail.com (Willian Gustavo Veiga) Date: Thu, 19 Apr 2012 12:46:36 -0300 Subject: [Phpmyadmin-devel] Bug #3441722 - Where should we store the description? Message-ID: <4F90335C.5010109@gmail.com> I've been trying to fix the bug #3441722 and I have few questions. I've stored descriptions in /libraries/data_mysql.inc.php: $cfg['ColumnTypesDescription'] = !empty($cfg['ColumnTypesDescription']) ? $cfg['ColumnTypesDescription'] : array( 'TINYINT' => 'A very small integer. The signed range is -128 to 127. The unsigned range is 0 to 255.', 'SMALLINT' => 'A small integer. The signed range is -32768 to 32767. The unsigned range is 0 to 65535.', 'MEDIUMINT' => 'A medium-sized integer. The signed range is -8388608 to 8388607. The unsigned range is 0 to 16777215.', 'INT' => 'A normal-size integer. The signed range is -2147483648 to 2147483647. The unsigned range is 0 to 4294967295.', 'BIGINT' => 'A large integer. The signed range is -9223372036854775808 to 9223372036854775807. The unsigned range is 0 to 18446744073709551615.', 'DECIMAL' => 'A packed "exact" fixed-point number. M is the total number of digits (the precision) and D is the number of digits after the decimal point (the scale). The decimal point and (for negative numbers) the "-" sign are not counted in M. If D is 0, values have no decimal point or fractional part. The maximum number of digits (M) for DECIMAL is 65. The maximum number of supported decimals (D) is 30. If D is omitted, the default is 0. If M is omitted, the default is 10.', 'FLOAT' => 'A small (single-precision) floating-point number. Permissible values are -3.402823466E+38 to -1.175494351E-38, 0, and 1.175494351E-38 to 3.402823466E+38. These are the theoretical limits, based on the IEEE standard. The actual range might be slightly smaller depending on your hardware or operating system.', // .... I don't think these description should be there, but I don't know the "right" place. Maybe we should create a database table or a file to store these information. I've implemented some code to fix this bug and it's working, maybe I should do a pull request. I am pretty new to PhpMyAdmin's codebase. Thank you very much and sorry about my english. -------------- next part -------------- An HTML attachment was scrubbed... URL: From rouslan at placella.com Thu Apr 19 18:21:27 2012 From: rouslan at placella.com (Rouslan Placella) Date: Thu, 19 Apr 2012 17:21:27 +0100 Subject: [Phpmyadmin-devel] Bug #3441722 - Where should we store the description? In-Reply-To: <4F90335C.5010109@gmail.com> References: <4F90335C.5010109@gmail.com> Message-ID: <4F903B87.8020205@placella.com> On 19/04/12 16:46, Willian Gustavo Veiga wrote: > I've been trying to fix the bug #3441722 > > and I have few questions. I've stored descriptions in > /libraries/data_mysql.inc.php: > > $cfg['ColumnTypesDescription'] = !empty($cfg['ColumnTypesDescription']) > ? $cfg['ColumnTypesDescription'] > : array( > 'TINYINT' => 'A very small integer. The signed range is -128 to > 127. The unsigned range is 0 to 255.', > 'SMALLINT' => 'A small integer. The signed range is -32768 to > 32767. The unsigned range is 0 to 65535.', > 'MEDIUMINT' => 'A medium-sized integer. The signed range is > -8388608 to 8388607. The unsigned range is 0 to 16777215.', > 'INT' => 'A normal-size integer. The signed range is -2147483648 > to 2147483647. The unsigned range is 0 to 4294967295.', > 'BIGINT' => 'A large integer. The signed range is > -9223372036854775808 to 9223372036854775807. The unsigned range is 0 to > 18446744073709551615.', > 'DECIMAL' => 'A packed "exact" fixed-point number. M is the > total number of digits (the precision) and D is the number of digits > after the decimal point (the scale). The decimal point and (for negative > numbers) the "-" sign are not counted in M. If D is 0, values have no > decimal point or fractional part. The maximum number of digits (M) for > DECIMAL is 65. The maximum number of supported decimals (D) is 30. If D > is omitted, the default is 0. If M is omitted, the default is 10.', > 'FLOAT' => 'A small (single-precision) floating-point number. > Permissible values are -3.402823466E+38 to -1.175494351E-38, 0, and > 1.175494351E-38 to 3.402823466E+38. These are the theoretical limits, > based on the IEEE standard. The actual range might be slightly smaller > depending on your hardware or operating system.', > // .... > > I don't think these description should be there, but I don't know the > "right" place. Maybe we should create a database table or a file to > store these information. I've implemented some code to fix this bug and > it's working, maybe I should do a pull request. > > I am pretty new to PhpMyAdmin's codebase. > > Thank you very much and sorry about my english. libraries/data_mysql.inc.php looks fine to me, although I'm not sure if the descriptions belong in the configuration array. Also, if you're preparing a pull request, you might want to add the type descriptions for Drizzle as well. Bye, Rouslan From marc at infomarc.info Thu Apr 19 23:27:17 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 19 Apr 2012 17:27:17 -0400 Subject: [Phpmyadmin-devel] wiki and configuration directives Message-ID: <4F908335.9070002@infomarc.info> Hi, I realize that we should have discussed this at the last team meeting but I just remembered this issue. I find it difficult and error-prone to document configuration directives at two places: Documentation.html and the wiki [0]. My suggestion is to remove it from the wiki. [0] http://wiki.phpmyadmin.net/pma/Config -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From rouslan at placella.com Thu Apr 19 23:33:13 2012 From: rouslan at placella.com (Rouslan Placella) Date: Thu, 19 Apr 2012 22:33:13 +0100 Subject: [Phpmyadmin-devel] wiki and configuration directives In-Reply-To: <4F908335.9070002@infomarc.info> References: <4F908335.9070002@infomarc.info> Message-ID: <4F908499.804@placella.com> On 19/04/12 22:27, Marc Delisle wrote: > Hi, > I realize that we should have discussed this at the last team meeting > but I just remembered this issue. > > I find it difficult and error-prone to document configuration directives > at two places: Documentation.html and the wiki [0]. > > My suggestion is to remove it from the wiki. > > [0] http://wiki.phpmyadmin.net/pma/Config I agree, but we need to merge the two first. The wiki, for example, seems to contain some information about in which version the value for a particular variable has changed. Bye, Rouslan From bennetch at gmail.com Fri Apr 20 00:13:17 2012 From: bennetch at gmail.com (Isaac Bennetch) Date: Thu, 19 Apr 2012 17:13:17 -0500 Subject: [Phpmyadmin-devel] wiki and configuration directives In-Reply-To: <4F908499.804@placella.com> References: <4F908335.9070002@infomarc.info> <4F908499.804@placella.com> Message-ID: <40A4BF73-FC80-4E8F-8238-F5EA7BB3668F@gmail.com> On Apr 19, 2012, at 4:33 PM, Rouslan Placella wrote: > On 19/04/12 22:27, Marc Delisle wrote: >> Hi, >> I realize that we should have discussed this at the last team meeting >> but I just remembered this issue. >> >> I find it difficult and error-prone to document configuration directives >> at two places: Documentation.html and the wiki [0]. >> >> My suggestion is to remove it from the wiki. >> >> [0] http://wiki.phpmyadmin.net/pma/Config > > I agree, but we need to merge the two first. The wiki, for example, > seems to contain some information about in which version the value for a > particular variable has changed. > > Bye, > Rouslan While there is some extra information in the wiki, I don't know that tracking when something changed needs to be maintained painstakingly in Documentation.html. As I recall, adding that to the wiki was a workaround to deal with the fact that Documentation.html is always targeted at a specific release version. The wiki had to deal gracefully with multiple, and sometimes conflicting, configuration values. I'm all for merging the two; I try to keep the wiki updated from time to time but obviously that falls apart when I'm too busy. I personally feel that documentation of configuration changes belongs in the release notes rather than Documentation.html, but I'm pretty sure whatever solution you all find will be great. Thanks From wiltave at gmail.com Fri Apr 20 02:21:32 2012 From: wiltave at gmail.com (Willian Gustavo Veiga) Date: Thu, 19 Apr 2012 21:21:32 -0300 Subject: [Phpmyadmin-devel] Bug #3441722 - Where should we store the description? Message-ID: <4F90AC0C.4060506@gmail.com> Rouslan, first of all thank you for your time. > although I'm not sure if the descriptions belong in the configuration array. So, what do you suggest? You're right Rouslan, it shouldn't be part of the configuration array. Maybe a function that returns these data ... > Also, if you're preparing a pull request, you might want to add the type descriptions for Drizzle as well. Great, i'll do the same for the Drizzle. Thank you very much. I really appreciate your help Rouslan. From michal at cihar.com Fri Apr 20 11:16:33 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Fri, 20 Apr 2012 11:16:33 +0200 Subject: [Phpmyadmin-devel] Bug #3441722 - Where should we store the description? In-Reply-To: <4F90AC0C.4060506@gmail.com> References: <4F90AC0C.4060506@gmail.com> Message-ID: <20120420111633.019f1d0d@rincewind.suse.cz> Hi Dne Thu, 19 Apr 2012 21:21:32 -0300 Willian Gustavo Veiga napsal(a): > Rouslan, first of all thank you for your time. > > > although I'm not sure if the descriptions belong in the configuration array. > > So, what do you suggest? You're right Rouslan, it shouldn't be part of > the configuration array. Maybe a function that returns these data ... Yes function for getting description for type in libraries/data_mysql.inc.php would be IMHO best. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From wiltave at gmail.com Fri Apr 20 18:44:51 2012 From: wiltave at gmail.com (Willian Gustavo Veiga) Date: Fri, 20 Apr 2012 13:44:51 -0300 Subject: [Phpmyadmin-devel] Bug #3441722 - Where should we store the description? Message-ID: <4F919283.5060607@gmail.com> Hi Michal Čihař, how are you doing? > Yes function for getting description for type in libraries/data_mysql.inc.php would be IMHO best. I've made it this way. Pull request done: https://github.com/phpmyadmin/phpmyadmin/pull/42 Drizzle needs better descriptions. Thank you for your time. From piotr.prz at gmail.com Fri Apr 20 19:13:33 2012 From: piotr.prz at gmail.com (Piotr Przybylski) Date: Fri, 20 Apr 2012 19:13:33 +0200 Subject: [Phpmyadmin-devel] Bug #3441722 - Where should we store the description? In-Reply-To: <4F919283.5060607@gmail.com> References: <4F919283.5060607@gmail.com> Message-ID: 2012/4/20 Willian Gustavo Veiga : > Hi Michal Čihař, how are you doing? > >>  Yes function for getting description for type in libraries/data_mysql.inc.php would be IMHO best. > > I've made it this way. Pull request done: > https://github.com/phpmyadmin/phpmyadmin/pull/42 > Drizzle needs better descriptions. > > Thank you for your time. > I think you should make descriptions shorter. Example for LONGTEXT, you have: "A TEXT column with a maximum length of 4,294,967,295 or 4GB (232 - 1) characters. The effective maximum length is less if the value contains multi-byte characters. The effective maximum length of LONGTEXT columns also depends on the configured maximum packet size in the client/server protocol and available memory. Each LONGTEXT value is stored using a four-byte length prefix that indicates the number of bytes in the value." I believe we should give only essential information: "A TEXT column with a maximum length of 4,294,967,295 or 4GB (232 - 1) bytes, uses 4-byte header to store length." If somebody want the full text he should go to the documentation. -- Regards, Piotr Przybylski From dieter.adriaenssens at gmail.com Sun Apr 22 15:23:09 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Sun, 22 Apr 2012 15:23:09 +0200 Subject: [Phpmyadmin-devel] wiki and configuration directives In-Reply-To: <40A4BF73-FC80-4E8F-8238-F5EA7BB3668F@gmail.com> References: <4F908335.9070002@infomarc.info> <4F908499.804@placella.com> <40A4BF73-FC80-4E8F-8238-F5EA7BB3668F@gmail.com> Message-ID: Kind regards, Dieter Adriaenssens. Op 20 apr. 2012 00:13 schreef "Isaac Bennetch" het volgende: > > On Apr 19, 2012, at 4:33 PM, Rouslan Placella wrote: > > > On 19/04/12 22:27, Marc Delisle wrote: > >> Hi, > >> I realize that we should have discussed this at the last team meeting > >> but I just remembered this issue. > >> > >> I find it difficult and error-prone to document configuration directives > >> at two places: Documentation.html and the wiki [0]. > >> > >> My suggestion is to remove it from the wiki. > >> > >> [0] http://wiki.phpmyadmin.net/pma/Config > > > > I agree, but we need to merge the two first. The wiki, for example, > > seems to contain some information about in which version the value for a > > particular variable has changed. > > > > Bye, > > Rouslan > > While there is some extra information in the wiki, I don't know that tracking when something changed needs to be maintained painstakingly in Documentation.html. As I recall, adding that to the wiki was a workaround to deal with the fact that Documentation.html is always targeted at a specific release version. The wiki had to deal gracefully with multiple, and sometimes conflicting, configuration values. I'm all for merging the two; I try to keep the wiki updated from time to time but obviously that falls apart when I'm too busy. > > I personally feel that documentation of configuration changes belongs in the release notes rather than Documentation.html, but I'm pretty sure whatever solution you all find will be great. FYI : there is a third place where information/documentation about the configuration options can be found, i.e. the libraries\config.Inc.php > Thanks > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel -------------- next part -------------- An HTML attachment was scrubbed... URL: From robbat2 at users.sourceforge.net Mon Apr 23 08:33:38 2012 From: robbat2 at users.sourceforge.net (Robin H. Johnson) Date: Mon, 23 Apr 2012 06:33:38 +0000 Subject: [Phpmyadmin-devel] Report from Percona Live MySQL 2012 & Thanks to Yosun Chang Message-ID: <20120423063338.GA25867@orbis-terrarum.net> Hi all, This is my report back from the Percona MySQL conference. This is my 5th year representing PMA at the MySQL conference: I've been there 2012, 2011, 2010, 2009, 2006 (Marc did it solo in 2007/2008 as I couldn't afford it or had conflicts). I realize that I've also been involved with phpMyAdmin for more than 11 years now. My first patch went in 2001/04/29 and I was on the mailing lists prior to the SourceForge move. I'd like to extend a special thank you to Yosun Chang. (BCC'd). She saw our booth last year: http://yfrog.com/h0avrihj Blogged about designer mode: http://yosun.me/2011/04/13/enabling-phpmyadmin-designer-mode-for-ajax-view-of-table-relations/ And then this year she came back and loaned us a monitor to help show off features, and lend a hand on the first night: https://twitter.com/#!/Yosun/status/189863107638726657/photo/1 She's also all-around awesome and has a little startup: http://www.kubikulo.com/ General: - The GIS functionality was a hit, along with the always popular DB designer and charts. - As per previous years, there are two types of people that came to the booth: - Those to give us kudos as they already use PMA - those that were lurking the conference, and often haven't used MySQL at all before, if they were even a tech type. Specific list of bugs & feature requests: - DB Designer and other tools that require the PMAdb to be created need to be easier to get going. Maybe include the ability to specify your MySQL root credentials and use them to create a database, import the schema, create the PMA user? - It needs to be possible to put PMAdb on a different server. For if you're connecting PMA to a readonly replication slave, and you cannot save your bookmarks or query history. - Charts functionality is popular, but painful to use sometimes: An example from the GIS sample data I was using: Creating a chart of the population of regions of Mexico: You have to create a view with name/population first, and chart that. It was simply not doable with the base table. - User auth is still a holdback. There is demand for a transformation function: auth(user, password[, server[, token]]) does validation, and on success, returns (mysqluser, mysqlpassword), which is used to connect to MySQL. The transformation function should have some common variants, but also be able to plug in something else custom (eg LDAP). - Some users complained that the versions of PMA deployed by cpanel and Rackspace are out-of-date and/or crippled. User management esp was noted as crippled. - Engine support: Tokutek asked about what was needed to get their engine listed in the create table dropdown. - Replication status: can we include the stats from the Maatkit/Percona Toolkit heartbeat app, and/or possible other tools? - The DB Designer had some feature requests too: - Some rough attempt at an initial layout solution - Auto-save layout changes - Create table opening in a new tab - PR material needed: We've got the artwork material we used for the banner in 2005, and the team shirts made at the same time, but not much other selection of open-format vector artwork for usage in conference programs and other promotional material. I've seen jpegs of newer logo materials, but very little by way of vector source artwork. Negatives: - Our banner, originally printed for the first ever team meeting back at LinuxTag 2005 in Karlsruhe, got lost at the end of this trip :-(. -- Robin Hugh Johnson Gentoo Linux: Developer, Trustee & Infrastructure Lead E-Mail : robbat2 at gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 From michal at cihar.com Mon Apr 23 12:30:19 2012 From: michal at cihar.com (Michal =?ISO-8859-2?B?yGloYfg=?=) Date: Mon, 23 Apr 2012 12:30:19 +0200 Subject: [Phpmyadmin-devel] Report from Percona Live MySQL 2012 & Thanks to Yosun Chang In-Reply-To: <20120423063338.GA25867@orbis-terrarum.net> References: <20120423063338.GA25867@orbis-terrarum.net> Message-ID: <20120423123019.3cf9eec7@nutt.cihar.com> Hi Robin Dne Mon, 23 Apr 2012 06:33:38 +0000 "Robin H. Johnson" napsal(a): > This is my report back from the Percona MySQL conference. Thanks for sharing these thoughts. > - It needs to be possible to put PMAdb on a different server. For if > you're connecting PMA to a readonly replication slave, and you cannot > save your bookmarks or query history. This is already present ($cfg['Servers'][$i]['controlhost']). -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Mon Apr 23 18:50:25 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 23 Apr 2012 12:50:25 -0400 Subject: [Phpmyadmin-devel] Report from Percona Live MySQL 2012 & Thanks to Yosun Chang In-Reply-To: <20120423063338.GA25867@orbis-terrarum.net> References: <20120423063338.GA25867@orbis-terrarum.net> Message-ID: <4F958851.6010003@infomarc.info> Le 2012-04-23 02:33, Robin H. Johnson a écrit : > Hi all, > > This is my report back from the Percona MySQL conference. Thanks for the report, Robin. > Specific list of bugs & feature requests: > - DB Designer and other tools that require the PMAdb to be created need > to be easier to get going. Maybe include the ability to specify your > MySQL root credentials and use them to create a database, import the > schema, create the PMA user? How would the credentials of the control user be stored permanently in config.inc.php? See https://sourceforge.net/tracker/?func=detail&aid=2163957&group_id=23067&atid=377411 > - It needs to be possible to put PMAdb on a different server. For if > you're connecting PMA to a readonly replication slave, and you cannot > save your bookmarks or query history. > - Charts functionality is popular, but painful to use sometimes: > An example from the GIS sample data I was using: > Creating a chart of the population of regions of Mexico: > You have to create a view with name/population first, and chart that. > It was simply not doable with the base table. > - User auth is still a holdback. There is demand for a transformation > function: > auth(user, password[, server[, token]]) does validation, and on success, > returns (mysqluser, mysqlpassword), which is used to connect to MySQL. > The transformation function should have some common variants, but also > be able to plug in something else custom (eg LDAP). How about our "signon" auth feature? > - Some users complained that the versions of PMA deployed by cpanel and > Rackspace are out-of-date and/or crippled. User management esp was > noted as crippled. We have no control over this, have we? > - Engine support: Tokutek asked about what was needed to get their > engine listed in the create table dropdown. I don't remember reading any feature request about this. > - Replication status: can we include the stats from the Maatkit/Percona > Toolkit heartbeat app, and/or possible other tools? These are command-line tools so investigation has to be done about interfacing them. > - The DB Designer had some feature requests too: > - Some rough attempt at an initial layout solution > - Auto-save layout changes > - Create table opening in a new tab > - PR material needed: We've got the artwork material we used for the > banner in 2005, and the team shirts made at the same time, but not > much other selection of open-format vector artwork for usage in > conference programs and other promotional material. I've seen jpegs of > newer logo materials, but very little by way of vector source artwork. > > Negatives: > - Our banner, originally printed for the first ever team meeting back at > LinuxTag 2005 in Karlsruhe, got lost at the end of this trip :-(. > This vinyl banner was printed a few years after the first team meeting, for one of my trips to the MySQL Users conference in Santa Clara. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From marc at infomarc.info Mon Apr 23 18:52:49 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 23 Apr 2012 12:52:49 -0400 Subject: [Phpmyadmin-devel] wiki and configuration directives In-Reply-To: References: <4F908335.9070002@infomarc.info> <4F908499.804@placella.com> <40A4BF73-FC80-4E8F-8238-F5EA7BB3668F@gmail.com> Message-ID: <4F9588E1.5010603@infomarc.info> Le 2012-04-22 09:23, Dieter Adriaenssens a écrit : > Kind regards, > Dieter Adriaenssens. > Op 20 apr. 2012 00:13 schreef "Isaac Bennetch" het > volgende: >> >> On Apr 19, 2012, at 4:33 PM, Rouslan Placella > wrote: >> >>> On 19/04/12 22:27, Marc Delisle wrote: >>>> Hi, >>>> I realize that we should have discussed this at the last team meeting >>>> but I just remembered this issue. >>>> >>>> I find it difficult and error-prone to document configuration > directives >>>> at two places: Documentation.html and the wiki [0]. >>>> >>>> My suggestion is to remove it from the wiki. >>>> >>>> [0] http://wiki.phpmyadmin.net/pma/Config >>> >>> I agree, but we need to merge the two first. The wiki, for example, >>> seems to contain some information about in which version the value for a >>> particular variable has changed. >>> >>> Bye, >>> Rouslan >> >> While there is some extra information in the wiki, I don't know that > tracking when something changed needs to be maintained painstakingly in > Documentation.html. As I recall, adding that to the wiki was a workaround > to deal with the fact that Documentation.html is always targeted at a > specific release version. The wiki had to deal gracefully with multiple, > and sometimes conflicting, configuration values. I'm all for merging the > two; I try to keep the wiki updated from time to time but obviously that > falls apart when I'm too busy. >> >> I personally feel that documentation of configuration changes belongs in > the release notes rather than Documentation.html, but I'm pretty sure > whatever solution you all find will be great. > > FYI : there is a third place where information/documentation about the > configuration options can be found, i.e. the libraries\config.Inc.php Dieter, you probably mean libraries/config.default.php. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From dieter.adriaenssens at gmail.com Mon Apr 23 23:03:55 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Mon, 23 Apr 2012 23:03:55 +0200 Subject: [Phpmyadmin-devel] wiki and configuration directives In-Reply-To: <4F9588E1.5010603@infomarc.info> References: <4F908335.9070002@infomarc.info> <4F908499.804@placella.com> <40A4BF73-FC80-4E8F-8238-F5EA7BB3668F@gmail.com> <4F9588E1.5010603@infomarc.info> Message-ID: Op 23 april 2012 18:52 heeft Marc Delisle het volgende geschreven: > Le 2012-04-22 09:23, Dieter Adriaenssens a écrit : >> Kind regards, >> Dieter Adriaenssens. >> Op 20 apr. 2012 00:13 schreef "Isaac Bennetch" het >> volgende: >>> >>> On Apr 19, 2012, at 4:33 PM, Rouslan Placella >> wrote: >>> >>>> On 19/04/12 22:27, Marc Delisle wrote: >>>>> Hi, >>>>> I realize that we should have discussed this at the last team meeting >>>>> but I just remembered this issue. >>>>> >>>>> I find it difficult and error-prone to document configuration >> directives >>>>> at two places: Documentation.html and the wiki [0]. >>>>> >>>>> My suggestion is to remove it from the wiki. >>>>> >>>>> [0] http://wiki.phpmyadmin.net/pma/Config >>>> >>>> I agree, but we need to merge the two first. The wiki, for example, >>>> seems to contain some information about in which version the value for a >>>> particular variable has changed. >>>> >>>> Bye, >>>> Rouslan >>> >>> While there is some extra information in the wiki, I don't know that >> tracking when something changed needs to be maintained painstakingly in >> Documentation.html. As I recall, adding that to the wiki was a workaround >> to deal with the fact that Documentation.html is always targeted at a >> specific release version. The wiki had to deal gracefully with multiple, >> and sometimes conflicting, configuration values. I'm all for merging the >> two; I try to keep the wiki updated from time to time but obviously that >> falls apart when I'm too busy. >>> >>> I personally feel that documentation of configuration changes  belongs in >> the release notes rather than Documentation.html, but I'm pretty sure >> whatever solution you all find will be great. >> >> FYI : there is a third place where information/documentation about the >> configuration options can be found, i.e. the libraries\config.Inc.php > > Dieter, > you probably mean libraries/config.default.php. Yes (didn't have pma repo around when writing that comment), and in libraries/config.values.php there is also some information. Data from these two files could be used to create the documentation. -- Kind regards, Dieter Adriaenssens From thilinaabeyrathna at gmail.com Tue Apr 24 05:45:04 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Tue, 24 Apr 2012 09:15:04 +0530 Subject: [Phpmyadmin-devel] GSOC 2012 Message-ID: Hi, I have selected for Google summer of code 2012 under "Refactoring insert/edit, Privileges, Structures, Operation sections in PMA" project idea. Thank you all who has helped me to accept. Specially Marc, you have helped me lot to prepare the proposal and patches. And my gratitude goes to all the PMA members. Now it is time to work with this project and this is the community bonding period of the time line. I will very thankfull If you have any suggestion for me to start to working and more familiar with pma. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From michal at cihar.com Tue Apr 24 08:55:12 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Tue, 24 Apr 2012 08:55:12 +0200 Subject: [Phpmyadmin-devel] Announcing phpMyAdmin's GSoC 2012 projects and students Message-ID: <20120424085512.51277529@rincewind.suse.cz> We would like to announce that phpMyAdmin will have six projects in Google Summer of Code 2012. We've received 38 applications, what is much more than we are able to mentor and it was sometimes a tough process to select the best ones. We would like to thank all people who have applied, for their time and energy; we hope that not being selected for this summer will not prevent them from contributing to phpMyAdmin. The final six chosen projects are: * Automated Testing by Yasitha Pandithawatta * Refactoring Insert/edit, Operations, Privilege and Structure sections in phpMyAdmin by Thilina Buddika Abeyrathna * Refactoring: Displaying query results by Chanaka Indrajith * Refactoring: Table search, Db search, Multi-table query by Atul Pratap Singh * Removal of frames and integration of a new navigation system into phpMyAdmin by Rouslan Placella * Two approaches for Plugins and OOP and an object-oriented properties system by Alex Marin Good luck to all students to complete all the projects successfully. -- Michal Čihař for the phpMyAdmin team -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From dieter.adriaenssens at gmail.com Tue Apr 24 10:11:50 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Tue, 24 Apr 2012 10:11:50 +0200 Subject: [Phpmyadmin-devel] GSOC 2012 In-Reply-To: References: Message-ID: Op 24 april 2012 05:45 heeft Thilina Buddika Abeyrathna het volgende geschreven: > Hi, > I have selected for Google summer of code 2012 under "Refactoring > insert/edit, Privileges, Structures, Operation sections in PMA" project > idea. Thank you all who has helped me to accept. Specially Marc, you have > helped me lot to prepare the proposal and patches. And my gratitude goes to > all the PMA members. > Now it is time to work with this project and this is the community bonding > period of the time line. I will very thankfull  If you have > any suggestion for me to start to working and more familiar with pma. A good place to start is to have look at the GSoC 2012 Student Guide [0] on our wiki. There you will find some practical instructions (setting up a blog, setting up your branch of the phpmyadmin code, ...). Please read them carefully. [0] http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide Kind regards, Dieter > -- > Regards. > > Thilina Buddika Abeyrathna, > Department of Computer Engineering, > Faculty Of Engineering, > University of Peradeniya, > Sri Lanka. > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Kind regards, Dieter Adriaenssens From thilinaabeyrathna at gmail.com Tue Apr 24 10:20:47 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Tue, 24 Apr 2012 13:50:47 +0530 Subject: [Phpmyadmin-devel] GSOC 2012 In-Reply-To: References: Message-ID: On Tue, Apr 24, 2012 at 1:41 PM, Dieter Adriaenssens < dieter.adriaenssens at gmail.com> wrote: > Op 24 april 2012 05:45 heeft Thilina Buddika Abeyrathna > het volgende geschreven: > > Hi, > > I have selected for Google summer of code 2012 under "Refactoring > > insert/edit, Privileges, Structures, Operation sections in PMA" project > > idea. Thank you all who has helped me to accept. Specially Marc, you have > > helped me lot to prepare the proposal and patches. And my gratitude goes > to > > all the PMA members. > > Now it is time to work with this project and this is > the community bonding > > period of the time line. I will very thankfull If you have > > any suggestion for me to start to working and more familiar with pma. > > A good place to start is to have look at the GSoC 2012 Student Guide > [0] on our wiki. There you will find some practical instructions > (setting up a blog, setting up your branch of the phpmyadmin code, > ...). Please read them carefully. > > [0] http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide > > Kind regards, > > Dieter > > Thanks Dieter. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From michal at cihar.com Tue Apr 24 11:31:22 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Tue, 24 Apr 2012 11:31:22 +0200 Subject: [Phpmyadmin-devel] Announcing phpMyAdmin's GSoC 2012 projects and students In-Reply-To: <20120424085512.51277529@rincewind.suse.cz> References: <20120424085512.51277529@rincewind.suse.cz> Message-ID: <20120424113122.58d40b33@rincewind.suse.cz> Hi Dne Tue, 24 Apr 2012 08:55:12 +0200 Michal Čihař napsal(a): > The final six chosen projects are: > > * Automated Testing by Yasitha Pandithawatta > > * Refactoring Insert/edit, Operations, Privilege and Structure sections > in phpMyAdmin by Thilina Buddika Abeyrathna > > * Refactoring: Displaying query results by Chanaka Indrajith > > * Refactoring: Table search, Db search, Multi-table query by Atul > Pratap Singh > > * Removal of frames and integration of a new navigation system into > phpMyAdmin by Rouslan Placella > > * Two approaches for Plugins and OOP and an object-oriented > properties system by Alex Marin You can find more details at our wiki: http://wiki.phpmyadmin.net/pma/GSoC_2012_Projects -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Tue Apr 24 13:48:28 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 24 Apr 2012 07:48:28 -0400 Subject: [Phpmyadmin-devel] phpMyAdmin 3.5.1-rc1 is released Message-ID: <4F96930C.1040802@infomarc.info> Welcome to the first release candidate for phpMyAdmin 3.5.1, a bugfix release. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team From rouslan at placella.com Tue Apr 24 14:29:46 2012 From: rouslan at placella.com (Rouslan Placella) Date: Tue, 24 Apr 2012 13:29:46 +0100 Subject: [Phpmyadmin-devel] GSoC 2012 - removal of frames Message-ID: <4F969CBA.8030103@placella.com> Hi all, for those who don't know me, my name is Rouslan and this year I will be working on removing the frames from PMA and integrating a new navigation system into the code base. More details about my project can be found at [0], my GIT repo can be found at [1] and my blog can be found at [2]. I look forward to a very productive summer of coding and collaborating with fellow developers. Bye, Rouslan [0]: http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/roccivic/37002 [1]: https://github.com/roccivic/phpmyadmin/tree/frames-removal [2]: http://roccivic.blogspot.com/ From alex.ukf at gmail.com Tue Apr 24 15:27:32 2012 From: alex.ukf at gmail.com (Alex Marin) Date: Tue, 24 Apr 2012 16:27:32 +0300 Subject: [Phpmyadmin-devel] GSoC 2012 - Plugins and OOP Message-ID: Hello phpmyadmins, My name is Alex Marin, I'm a student from Romania, and for this year's edition of GSoC I will be working on the Plugins and OOP for import, export, transformations and authentication. I will also implement a new object-oriented properties system to replace the current one. My proposal can be seen at [0] and I will keep track of the worked pushed to my GIT repository [1], on my blog [2]. Looking forward to work with all of you this summer, Alex [0] http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/alexukf/1 [1] https://github.com/alexukf/phpmyadmin/tree/plugins-and-OOP [2] http://alexukf.wordpress.com From alessio.sorrentino83 at gmail.com Tue Apr 24 16:56:18 2012 From: alessio.sorrentino83 at gmail.com (alessio sorrentino) Date: Tue, 24 Apr 2012 16:56:18 +0200 Subject: [Phpmyadmin-devel] (no subject) Message-ID: I understand why phpmyadmin on your website by creating a local database, until yesterday I also created automatically by checking the various tables only Privileggi and now forces me to I have to create tables. I do not know how to create and how to create them .. I know what happened? Also using EasyPHP and bringing phpmyadmin latest version while changing the password on the config I get always the error 1145 during login. I need urgently a solution -------------- next part -------------- An HTML attachment was scrubbed... URL: From yasitha4 at gmail.com Tue Apr 24 18:14:56 2012 From: yasitha4 at gmail.com (yasitha pandithawatta) Date: Tue, 24 Apr 2012 21:44:56 +0530 Subject: [Phpmyadmin-devel] GSoC 2012 - Automated Testing Message-ID: Hi All, I am Yasitha Pandithawatta from Sri Lanka, currently an undergraduate of the Department of Computer Science and Engineering, University of Moratuwa. In GSoC 2012 I will be working on Automated Testing project. More details about my project can be found at [0], my GIT repo can be found at [1] and my blog can be found at [2]. Looking forward to work with all of you this summer. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka [0] http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/yasitha4/1 [1] https://github.com/yasithacp/phpmyadmin [2] code-mix.blogspot.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Tue Apr 24 18:32:36 2012 From: marc at infomarc.info (Marc Delisle) Date: Tue, 24 Apr 2012 12:32:36 -0400 Subject: [Phpmyadmin-devel] (no subject) In-Reply-To: References: Message-ID: <4F96D5A4.5050100@infomarc.info> Le 2012-04-24 10:56, alessio sorrentino a écrit : > I understand why phpmyadmin on your website by creating a local database, until > yesterday I also created automatically by checking the various tables only > Privileggi and now forces me to I have to create tables. I do not know how > to create and how to create them .. I know what happened? Also using > EasyPHP and > bringing phpmyadmin latest version while changing the password on the config I > get always the error 1145 during login. > I need urgently a solution Please use the phpmyadmin-users mailing list instead of this one. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From pe.chanaka.ck at gmail.com Tue Apr 24 23:20:06 2012 From: pe.chanaka.ck at gmail.com (Chanaka Dharmarathna) Date: Wed, 25 Apr 2012 02:50:06 +0530 Subject: [Phpmyadmin-devel] GSoC 2012 - Refactoring: Displaying query results Message-ID: Hi All, I'm Chanaka Indrajith, final year undergraduate from University of Peradeniya, Sri Lanka. I will be working on "Refactoring: Displaying query results" [0] project idea under phpMyAdmin, for GSoC 2012. My git repository can be found at [1] and my commits will be appeared in that. I'm intending to use my existing blog [2] for documentation purpose. I look forward to do a great job for this GSoC 2012, with all the developers. [0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka777/1 [1] : https://github.com/Chanaka/phpmyadmin [2] : http://chanakaindrajith.blogspot.com/ Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From michal at cihar.com Wed Apr 25 08:49:33 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 25 Apr 2012 08:49:33 +0200 Subject: [Phpmyadmin-devel] GSoC 2012 - Automated Testing In-Reply-To: References: Message-ID: <20120425084933.5dec5478@rincewind.suse.cz> Hi Dne Tue, 24 Apr 2012 21:44:56 +0530 yasitha pandithawatta napsal(a): > I am Yasitha Pandithawatta from Sri Lanka, currently an undergraduate of > the Department of Computer Science and Engineering, University of Moratuwa. > In GSoC 2012 I will be working on Automated Testing project. > > More details about my project can be found at [0], my GIT repo can be found > at [1] and my blog can be found at [2]. > > https://github.com/yasithacp/phpmyadmin Your git repo does not seem to be fork of phpMyAdmin, but rather an empty git repository... -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Wed Apr 25 14:16:39 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 14:16:39 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1277 Message-ID: <901967598.0.1335356201955.JavaMail.jenkins@pmademo> See Changes: [wiltave] Data types descriptions [wiltave] Missing function prefix (PMA_) added. [wiltave] Missing commas in the numbers added. [wiltave] BIGINT description - missing commas added. [rouslan] Updated po files [rouslan] Changelog entry for "Display description of datatypes" ------------------------------------------ [...truncated 271 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:48, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116752 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34848 [exec] Non-Comment Lines of Code (NCLOC): 81904 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 756 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 13 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13659 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 210 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_14-14-03/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Wed Apr 25 14:24:29 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 14:24:29 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1278 In-Reply-To: <901967598.0.1335356201955.JavaMail.jenkins@pmademo> References: <901967598.0.1335356201955.JavaMail.jenkins@pmademo> Message-ID: <35166759.1.1335356669120.JavaMail.jenkins@pmademo> See Changes: [rouslan] Wrap long lines ------------------------------------------ [...truncated 271 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:58, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116766 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34848 [exec] Non-Comment Lines of Code (NCLOC): 81918 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 756 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 22 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13655 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 210 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_14-21-40/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Wed Apr 25 14:34:46 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 14:34:46 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1279 In-Reply-To: <35166759.1.1335356669120.JavaMail.jenkins@pmademo> References: <35166759.1.1335356669120.JavaMail.jenkins@pmademo> Message-ID: <1500872487.2.1335357286859.JavaMail.jenkins@pmademo> See Changes: [mcihar] Wrap some long lines [mcihar] Single function to handle ReplaceHelpImg [mcihar] Standard way for link to documentation [mcihar] Standard way to link to documentation ------------------------------------------ [...truncated 271 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 02:08, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116760 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34859 [exec] Non-Comment Lines of Code (NCLOC): 81901 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 757 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 34 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13653 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 210 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_14-31-41/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Wed Apr 25 14:44:18 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 14:44:18 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1280 In-Reply-To: <1500872487.2.1335357286859.JavaMail.jenkins@pmademo> References: <1500872487.2.1335357286859.JavaMail.jenkins@pmademo> Message-ID: <382860956.3.1335357858707.JavaMail.jenkins@pmademo> See Changes: [mcihar] Saner description of Drizzle types ------------------------------------------ [...truncated 271 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:50, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116760 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34859 [exec] Non-Comment Lines of Code (NCLOC): 81901 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 757 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 14 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13653 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 208 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_14-41-40/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Wed Apr 25 14:54:17 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 14:54:17 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1281 In-Reply-To: <382860956.3.1335357858707.JavaMail.jenkins@pmademo> References: <382860956.3.1335357858707.JavaMail.jenkins@pmademo> Message-ID: <946385473.4.1335358457036.JavaMail.jenkins@pmademo> See Changes: [mcihar] Update docs ------------------------------------------ [...truncated 271 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:41, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116762 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34861 [exec] Non-Comment Lines of Code (NCLOC): 81901 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 757 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 5 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13651 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 208 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_14-51-41/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Wed Apr 25 15:04:22 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 15:04:22 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1282 In-Reply-To: <946385473.4.1335358457036.JavaMail.jenkins@pmademo> References: <946385473.4.1335358457036.JavaMail.jenkins@pmademo> Message-ID: <583473061.5.1335359062732.JavaMail.jenkins@pmademo> See Changes: [weblate] Translated using Weblate. [mcihar] Update po files ------------------------------------------ [...truncated 270 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:45, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116762 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34861 [exec] Non-Comment Lines of Code (NCLOC): 81901 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 757 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 11 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13651 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 208 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_15-01-47/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From yasitha4 at gmail.com Wed Apr 25 15:10:14 2012 From: yasitha4 at gmail.com (yasitha pandithawatta) Date: Wed, 25 Apr 2012 18:40:14 +0530 Subject: [Phpmyadmin-devel] GSoC 2012 - Automated Testing In-Reply-To: <20120425084933.5dec5478@rincewind.suse.cz> References: <20120425084933.5dec5478@rincewind.suse.cz> Message-ID: On Wed, Apr 25, 2012 at 12:19 PM, Michal Čihař wrote: > Hi > > Dne Tue, 24 Apr 2012 21:44:56 +0530 > yasitha pandithawatta napsal(a): > > > I am Yasitha Pandithawatta from Sri Lanka, currently an undergraduate of > > the Department of Computer Science and Engineering, University of > Moratuwa. > > In GSoC 2012 I will be working on Automated Testing project. > > > > More details about my project can be found at [0], my GIT repo can be > found > > at [1] and my blog can be found at [2]. > > > > https://github.com/yasithacp/phpmyadmin > > Your git repo does not seem to be fork of phpMyAdmin, but rather an > empty git repository... > > -- > Michal Čihař | http://cihar.com | http://blog.cihar.com > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > I fixed it. Now it is successfully forked. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka -------------- next part -------------- An HTML attachment was scrubbed... URL: From michal at cihar.com Wed Apr 25 15:19:28 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Wed, 25 Apr 2012 15:19:28 +0200 Subject: [Phpmyadmin-devel] Removing MySQL types from config Message-ID: <20120425151928.21f467cc@rincewind.suse.cz> Hi all I suggest another big cleanup of configuration - to remove all MySQL types/functions/operator definitions. We want to be able to change these with upgrades, they also depend on used server and version and I don't see what would user want to configure here besides reordering them. Any comments on that? I've turned my basic idea into code here: https://github.com/phpmyadmin/phpmyadmin/pull/47 -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Wed Apr 25 15:24:22 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 15:24:22 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1283 In-Reply-To: <583473061.5.1335359062732.JavaMail.jenkins@pmademo> References: <583473061.5.1335359062732.JavaMail.jenkins@pmademo> Message-ID: <815815883.6.1335360262871.JavaMail.jenkins@pmademo> See Changes: [rouslan] Skip PMA_RTN_getDataFromRequest test until we fix it ------------------------------------------ [...truncated 271 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:47, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116762 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34861 [exec] Non-Comment Lines of Code (NCLOC): 81901 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 757 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 13 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13653 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 208 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_15-21-40/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Wed Apr 25 16:05:28 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 16:05:28 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1284 In-Reply-To: <815815883.6.1335360262871.JavaMail.jenkins@pmademo> References: <815815883.6.1335360262871.JavaMail.jenkins@pmademo> Message-ID: <630913694.7.1335362728115.JavaMail.jenkins@pmademo> See Changes: [mcihar] gd_info is present since PHP 4.3, so no need to provide workarouds when it does not exist ------------------------------------------ [...truncated 270 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:43, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116748 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34858 [exec] Non-Comment Lines of Code (NCLOC): 81890 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 757 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 33 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13653 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 208 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_16-01-40/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Wed Apr 25 18:45:08 2012 From: michal at cihar.com (michal at cihar.com) Date: Wed, 25 Apr 2012 18:45:08 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1285 In-Reply-To: <630913694.7.1335362728115.JavaMail.jenkins@pmademo> References: <630913694.7.1335362728115.JavaMail.jenkins@pmademo> Message-ID: <562362167.8.1335372308936.JavaMail.jenkins@pmademo> See Changes: [me] Move columns in table columns editor [me] rfe #3517835 [structure] Move columns easily [me] Fixed missing event variable in move_columns dialog Go-button callback [me] Use PMA_DBI_get_columns_full for moving columns [me] Use PMA_Table::generateAlter for moving columns [me] Move columns: Test whether Comment field is set [me] Move columns: feed generateAlter with same input as when editing single columns [marc] Refresh .po files ------------------------------------------ [...truncated 270 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:47, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 322 [exec] [exec] Lines of Code (LOC): 116958 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 34891 [exec] Non-Comment Lines of Code (NCLOC): 82067 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 78 [exec] Abstract: 2 (2.56%) [exec] Concrete: 76 (97.44%) [exec] Average Class Length (NCLOC): 207 [exec] Methods: 744 [exec] Scope: [exec] Non-Static: 651 (87.50%) [exec] Static: 93 (12.50%) [exec] Visibility: [exec] Public: 609 (81.85%) [exec] Non-Public: 135 (18.15%) [exec] Average Method Length (NCLOC): 21 [exec] Cyclomatic Complexity / Number of Methods: 3.62 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 757 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 36 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 13690 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1276 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1276 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 424 files to scan for tasks [TASKS] Found 208 open tasks. [TASKS] Computing warning deltas based on reference build #1276 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1276 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-25_18-41-51/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file ' for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From marc at infomarc.info Wed Apr 25 19:04:06 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 25 Apr 2012 13:04:06 -0400 Subject: [Phpmyadmin-devel] Removing MySQL types from config In-Reply-To: <20120425151928.21f467cc@rincewind.suse.cz> References: <20120425151928.21f467cc@rincewind.suse.cz> Message-ID: <4F982E86.2000602@infomarc.info> Le 2012-04-25 09:19, Michal Čihař a écrit : > Hi all > > I suggest another big cleanup of configuration - to remove all MySQL > types/functions/operator definitions. We want to be able to change > these with upgrades, they also depend on used server and version and I > don't see what would user want to configure here besides reordering > them. > > Any comments on that? In general I find this a good idea, however I have a case where someone would want to configure. In $cfg['TextOperators'] one of the choices is 'LIKE %...%'. This generates a non-indexed search, so someone could want to remove it from the list for performance reasons. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From rouslan at placella.com Wed Apr 25 20:24:30 2012 From: rouslan at placella.com (Rouslan Placella) Date: Wed, 25 Apr 2012 19:24:30 +0100 Subject: [Phpmyadmin-devel] bug in move columns functionality Message-ID: <4F98415E.7050109@placella.com> Hi there, Just spotted an issue with the new "move columns" functionality. After you add or drop a column, if you click on the "Move columns" link, you will be shown a dialog with the old columns instead of the new ones. Bye, Rouslan From rouslan at placella.com Wed Apr 25 20:34:28 2012 From: rouslan at placella.com (Rouslan Placella) Date: Wed, 25 Apr 2012 19:34:28 +0100 Subject: [Phpmyadmin-devel] bug in move columns functionality In-Reply-To: <4F98415E.7050109@placella.com> References: <4F98415E.7050109@placella.com> Message-ID: <4F9843B4.3090008@placella.com> On 25/04/12 19:24, Rouslan Placella wrote: > Hi there, > > Just spotted an issue with the new "move columns" functionality. > After you add or drop a column, if you click on the "Move columns" link, > you will be shown a dialog with the old columns instead of the new ones. And on a loosely related note, I think that function reloadFieldForm() from tbl_structure.js should use PMA_ajaxShowMessage() to indicate that a request is in progress... From rouslan at placella.com Wed Apr 25 21:12:01 2012 From: rouslan at placella.com (Rouslan Placella) Date: Wed, 25 Apr 2012 20:12:01 +0100 Subject: [Phpmyadmin-devel] bug in move columns functionality In-Reply-To: <4F9843B4.3090008@placella.com> References: <4F98415E.7050109@placella.com> <4F9843B4.3090008@placella.com> Message-ID: <4F984C81.4060904@placella.com> On 25/04/12 19:34, Rouslan Placella wrote: > On 25/04/12 19:24, Rouslan Placella wrote: >> Hi there, >> >> Just spotted an issue with the new "move columns" functionality. >> After you add or drop a column, if you click on the "Move columns" link, >> you will be shown a dialog with the old columns instead of the new ones. > > And on a loosely related note, I think that function reloadFieldForm() > from tbl_structure.js should use PMA_ajaxShowMessage() to indicate that > a request is in progress... And another bug occurs after you first add an index using the "more" dropdown menu and then move some columns. The query is displayed in the wrong place. Screenshot attached. Bye, Rouslan -------------- next part -------------- A non-text attachment was scrubbed... Name: move_columns_screenshot.png Type: image/png Size: 32144 bytes Desc: not available URL: From piotr.prz at gmail.com Wed Apr 25 21:41:31 2012 From: piotr.prz at gmail.com (Piotr Przybylski) Date: Wed, 25 Apr 2012 21:41:31 +0200 Subject: [Phpmyadmin-devel] Removing MySQL types from config In-Reply-To: <4F982E86.2000602@infomarc.info> References: <20120425151928.21f467cc@rincewind.suse.cz> <4F982E86.2000602@infomarc.info> Message-ID: 2012/4/25 Marc Delisle : > Le 2012-04-25 09:19, Michal Čihař a écrit : >> Hi all >> >> I suggest another big cleanup of configuration - to remove all MySQL >> types/functions/operator definitions. We want to be able to change >> these with upgrades, they also depend on used server and version and I >> don't see what would user want to configure here besides reordering >> them. >> >> Any comments on that? > > In general I find this a good idea, however I have a case where someone > would want to configure. > > In $cfg['TextOperators'] one of the choices is 'LIKE %...%'. This > generates a non-indexed search, so someone could want to remove it from > the list for performance reasons. > It can still be entered manually, and any operator used on unindexed column could be just as bad. IMO you don't give full access to a big database to a person who doesn't know the basics. And if you do, something else is wrong, not the software :) -- Regards, Piotr Przybylski From marc at infomarc.info Thu Apr 26 02:58:06 2012 From: marc at infomarc.info (Marc Delisle) Date: Wed, 25 Apr 2012 20:58:06 -0400 Subject: [Phpmyadmin-devel] translation of data type descriptions Message-ID: <4F989D9E.9080702@infomarc.info> Hi Piotr, are you able to see a translation in the drop-down titles? I have translated a few of them (MySQL) in French (for example, integers), pulled and did a generate-mo but I only see the English descriptions. The translations are there in my po/fr.po. -- Marc Delisle http://infomarc.info From piotr.prz at gmail.com Thu Apr 26 09:31:47 2012 From: piotr.prz at gmail.com (Piotr Przybylski) Date: Thu, 26 Apr 2012 09:31:47 +0200 Subject: [Phpmyadmin-devel] translation of data type descriptions In-Reply-To: <4F989D9E.9080702@infomarc.info> References: <4F989D9E.9080702@infomarc.info> Message-ID: 2012/4/26 Marc Delisle : > Hi Piotr, > are you able to see a translation in the drop-down titles? I have > translated a few of them (MySQL) in French (for example, integers), > pulled and did a generate-mo but I only see the English descriptions. > > The translations are there in my po/fr.po. I'll check when I get home. Did you regenerate translations after my changes? I changed all descriptions to be a bit shorter and written new ones for Drizzle. -- Regards, Piotr Przybylski From michal at cihar.com Thu Apr 26 10:38:44 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 26 Apr 2012 10:38:44 +0200 Subject: [Phpmyadmin-devel] translation of data type descriptions In-Reply-To: <4F989D9E.9080702@infomarc.info> References: <4F989D9E.9080702@infomarc.info> Message-ID: <20120426103844.6f3b2c80@rincewind.suse.cz> Hi Dne Wed, 25 Apr 2012 20:58:06 -0400 Marc Delisle napsal(a): > are you able to see a translation in the drop-down titles? I have > translated a few of them (MySQL) in French (for example, integers), > pulled and did a generate-mo but I only see the English descriptions. I guess the problem here is that English description has changed meanwhile so it does not match what you have translated :-). -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Thu Apr 26 12:01:44 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 26 Apr 2012 12:01:44 +0200 Subject: [Phpmyadmin-devel] Demo server for GSoC Message-ID: <20120426120144.32db96ee@rincewind.suse.cz> Hi all as usual, demo server will provide demo for each student allowing us to test the code immediately. The links to demo are available at: http://wiki.phpmyadmin.net/pma/GSoC_2012_Projects -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Thu Apr 26 12:04:31 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 26 Apr 2012 06:04:31 -0400 Subject: [Phpmyadmin-devel] Demo server for GSoC In-Reply-To: <20120426120144.32db96ee@rincewind.suse.cz> References: <20120426120144.32db96ee@rincewind.suse.cz> Message-ID: <4F991DAF.1080002@infomarc.info> Le 2012-04-26 06:01, Michal Čihař a écrit : > Hi all > > as usual, demo server will provide demo for each student allowing us to > test the code immediately. The links to demo are available at: > > http://wiki.phpmyadmin.net/pma/GSoC_2012_Projects > Michal, are you pointing to the master branch from each student's repo? -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From marc at infomarc.info Thu Apr 26 12:40:21 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 26 Apr 2012 06:40:21 -0400 Subject: [Phpmyadmin-devel] translation of data type descriptions In-Reply-To: <20120426103844.6f3b2c80@rincewind.suse.cz> References: <4F989D9E.9080702@infomarc.info> <20120426103844.6f3b2c80@rincewind.suse.cz> Message-ID: <4F992615.4030107@infomarc.info> Le 2012-04-26 04:38, Michal Čihař a écrit : > Hi > > Dne Wed, 25 Apr 2012 20:58:06 -0400 > Marc Delisle napsal(a): > >> are you able to see a translation in the drop-down titles? I have >> translated a few of them (MySQL) in French (for example, integers), >> pulled and did a generate-mo but I only see the English descriptions. > > I guess the problem here is that English description has changed > meanwhile so it does not match what you have translated :-). I confirm that this was the problem, thanks. -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From michal at cihar.com Thu Apr 26 13:04:37 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 26 Apr 2012 13:04:37 +0200 Subject: [Phpmyadmin-devel] Demo server for GSoC In-Reply-To: <4F991DAF.1080002@infomarc.info> References: <20120426120144.32db96ee@rincewind.suse.cz> <4F991DAF.1080002@infomarc.info> Message-ID: <20120426130437.40e6fa9a@rincewind.suse.cz> Hi Dne Thu, 26 Apr 2012 06:04:31 -0400 Marc Delisle napsal(a): > are you pointing to the master branch from each student's repo? I point to branch students gave, in case there was no branch mentioned, it's following master. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Thu Apr 26 16:12:55 2012 From: michal at cihar.com (Michal =?UTF-8?B?xIxpaGHFmQ==?=) Date: Thu, 26 Apr 2012 16:12:55 +0200 Subject: [Phpmyadmin-devel] Coding style checks Message-ID: <20120426161255.16ab0865@rincewind.suse.cz> Hi I've created tuned coding style checks for phpcs, which is now being used on http://ci.phpmyadmin.net/. As you can see we got rid of 2000 useless warnings (mostly about missing @author/@copyright/@link, which we don't use). However we still have more than 10000 violations. Some are simply not fixable or hard to fix, but some are easy (like adding documentation). Anyway please try not to introduce new violations if possible :-). We want nice code base that is easy to understand and following coding standard helps here a lot. -- Michal Čihař | http://cihar.com | http://blog.cihar.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From marc at infomarc.info Thu Apr 26 16:48:41 2012 From: marc at infomarc.info (Marc Delisle) Date: Thu, 26 Apr 2012 10:48:41 -0400 Subject: [Phpmyadmin-devel] Coding style checks In-Reply-To: <20120426161255.16ab0865@rincewind.suse.cz> References: <20120426161255.16ab0865@rincewind.suse.cz> Message-ID: <4F996049.8040300@infomarc.info> Le 2012-04-26 10:12, Michal Čihař a écrit : > Hi > > I've created tuned coding style checks for phpcs, which is now being > used on http://ci.phpmyadmin.net/. As you can see we got rid of 2000 > useless warnings (mostly about missing @author/@copyright/@link, which > we don't use). > > However we still have more than 10000 violations. Some are simply not > fixable or hard to fix, but some are easy (like adding documentation). > Anyway please try not to introduce new violations if possible :-). We > want nice code base that is easy to understand and following coding > standard helps here a lot. Michal, do you mean the coding standard mentioned on [0] or something else? [0] http://www.phpmyadmin.net/home_page/devel.php -- Marc Delisle http://infomarc.info -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 898 bytes Desc: OpenPGP digital signature URL: From rouslan at placella.com Thu Apr 26 18:37:00 2012 From: rouslan at placella.com (Rouslan Placella) Date: Thu, 26 Apr 2012 17:37:00 +0100 Subject: [Phpmyadmin-devel] Coding style checks In-Reply-To: <4F996049.8040300@infomarc.info> References: <20120426161255.16ab0865@rincewind.suse.cz> <4F996049.8040300@infomarc.info> Message-ID: <4F9979AC.1000601@placella.com> On 26/04/12 15:48, Marc Delisle wrote: > Le 2012-04-26 10:12, Michal Čihař a écrit : >> Hi >> >> I've created tuned coding style checks for phpcs, which is now being >> used on http://ci.phpmyadmin.net/. As you can see we got rid of 2000 >> useless warnings (mostly about missing @author/@copyright/@link, which >> we don't use). >> >> However we still have more than 10000 violations. Some are simply not >> fixable or hard to fix, but some are easy (like adding documentation). >> Anyway please try not to introduce new violations if possible :-). We >> want nice code base that is easy to understand and following coding >> standard helps here a lot. > > Michal, > do you mean the coding standard mentioned on [0] or something else? > > [0] http://www.phpmyadmin.net/home_page/devel.php Yes, I think that he meant the PEAR coding standard. Phpcs does some sniffing for us on the continuous integration server and reports the violations (e.g.: [0]), however some of those checks were pretty pointless. Bye, Rouslan [0]: http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1308/checkstyleResult/? From michal at cihar.com Thu Apr 26 22:57:11 2012 From: michal at cihar.com (Michal =?ISO-8859-2?B?yGloYfg=?=) Date: Thu, 26 Apr 2012 22:57:11 +0200 Subject: [Phpmyadmin-devel] Coding style checks In-Reply-To: <4F9979AC.1000601@placella.com> References: <20120426161255.16ab0865@rincewind.suse.cz> <4F996049.8040300@infomarc.info> <4F9979AC.1000601@placella.com> Message-ID: <20120426225711.40c1355a@nutt.cihar.com> Hi Dne Thu, 26 Apr 2012 17:37:00 +0100 Rouslan Placella napsal(a): > Yes, I think that he meant the PEAR coding standard. Phpcs does some > sniffing for us on the continuous integration server and reports the > violations (e.g.: [0]), however some of those checks were pretty pointless. Yes, I mean PEAR coding standards. However few bits really don't apply to us, that's what I tried to adjust. If you still find some pointless checks, please let me know so that I can fix that. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From michal at cihar.com Fri Apr 27 09:25:01 2012 From: michal at cihar.com (michal at cihar.com) Date: Fri, 27 Apr 2012 09:25:01 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1316 Message-ID: <1009608329.9.1335511501876.JavaMail.jenkins@pmademo> See Changes: [michal] Better style [michal] Wrap lines [michal] Wrap some function calls ------------------------------------------ [...truncated 216 lines...] [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] PHP Notice: Uninitialized string offset: 0 in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 257 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->processFile() /usr/share/php/PHP/CodeSniffer.php:476 [exec] PHP 5. PHP_CodeSniffer->_processFile() /usr/share/php/PHP/CodeSniffer.php:1159 [exec] PHP 6. PHP_CodeSniffer_File->start() /usr/share/php/PHP/CodeSniffer.php:1279 [exec] PHP 7. PHP_CodeSniffer_Standards_AbstractScopeSniff->process() /usr/share/php/PHP/CodeSniffer/File.php:470 [exec] PHP 8. PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff->processTokenOutsideScope() /usr/share/php/PHP/CodeSniffer/Standards/AbstractScopeSniff.php:191 [exec] Time: 01:46, Memory: 57.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 321 [exec] [exec] Lines of Code (LOC): 117463 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 35010 [exec] Non-Comment Lines of Code (NCLOC): 82453 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 81 [exec] Abstract: 2 (2.47%) [exec] Concrete: 79 (97.53%) [exec] Average Class Length (NCLOC): 209 [exec] Methods: 769 [exec] Scope: [exec] Non-Static: 676 (87.91%) [exec] Static: 93 (12.09%) [exec] Visibility: [exec] Public: 634 (82.44%) [exec] Non-Public: 135 (17.56%) [exec] Average Method Length (NCLOC): 22 [exec] Cyclomatic Complexity / Number of Methods: 3.70 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 754 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 1 second [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 10606 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1315 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1315 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 429 files to scan for tasks [TASKS] Found 204 open tasks. [TASKS] Computing warning deltas based on reference build #1315 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1315 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-27_09-22-27/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Fri Apr 27 09:42:10 2012 From: michal at cihar.com (michal at cihar.com) Date: Fri, 27 Apr 2012 09:42:10 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1317 In-Reply-To: <1009608329.9.1335511501876.JavaMail.jenkins@pmademo> References: <1009608329.9.1335511501876.JavaMail.jenkins@pmademo> Message-ID: <1783293308.10.1335512530041.JavaMail.jenkins@pmademo> See Changes: [mcihar] Adjust test to current return values [mcihar] Add missing include [mcihar] Properly test input boxes [michal] Oops, missing comas ------------------------------------------ Started by an SCM change Building in workspace Checkout:workspace / - hudson.remoting.LocalChannel at 6688cf9e Using strategy: Default Last Built Revision: Revision 16d040b4a5098a704861b131a3747e057526795d (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 2dfdf94236355cd6daae8295c5caea6442ca53c0 (origin/master) Checking out Revision 2dfdf94236355cd6daae8295c5caea6442ca53c0 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson7839022371208386017.sh + ./scripts/generate-mo --quiet po/fi.po:3: header field `PO-Revision-Date' missing in header [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: clean: [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: phpunit: [exec] PHP Parse error: syntax error, unexpected ''table_info'' (T_CONSTANT_ENCAPSED_STRING) in on line 132 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:139 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:671 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:776 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:848 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:419 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:358 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:79 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:95 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 17 exact clones with 1080 duplicated lines in 10 files: [exec] [exec] - /libraries/export/htmlword.php:202-219 [exec] /libraries/export/htmlword.php:332-349 [exec] [exec] - /libraries/export/odt.php:270-282 [exec] /libraries/export/odt.php:415-427 [exec] [exec] - /libraries/export/texytext.php:199-213 [exec] /libraries/export/texytext.php:328-342 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-478 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:627-652 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Svg_Relation_Schema.class.php:390-406 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Svg_Relation_Schema.class.php:440-448 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-656 [exec] /libraries/schema/Svg_Relation_Schema.class.php:587-637 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-662 [exec] /libraries/schema/Visio_Relation_Schema.class.php:376-432 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:580-601 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1282 [exec] /themes/original/css/theme_right.css.php:1265-1286 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1691 [exec] /themes/original/css/theme_right.css.php:2393-2823 [exec] [exec] - /themes/original/css/theme_right.css.php:1205-1313 [exec] /themes/pmahomme/css/theme_right.css.php:1584-1692 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1514 [exec] /themes/pmahomme/css/theme_right.css.php:3097-3350 [exec] [exec] 0.92% duplicated lines out of 117462 total lines of code. [exec] [exec] Time: 8 seconds, Memory: 101.00Mb [exec] Result: 1 phpcs: [exec] PHP Parse error: syntax error, unexpected 'else' (T_ELSE) in /usr/share/php/PHP/CodeSniffer/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php on line 259 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpcs:0 [exec] PHP 2. PHP_CodeSniffer_CLI->process() /usr/bin/phpcs:37 [exec] PHP 3. PHP_CodeSniffer->process() /usr/share/php/PHP/CodeSniffer/CLI.php:551 [exec] PHP 4. PHP_CodeSniffer->setTokenListeners() /usr/share/php/PHP/CodeSniffer.php:438 [exec] Result: 255 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 321 [exec] [exec] Lines of Code (LOC): 117462 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 35010 [exec] Non-Comment Lines of Code (NCLOC): 82452 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 81 [exec] Abstract: 2 (2.47%) [exec] Concrete: 79 (97.53%) [exec] Average Class Length (NCLOC): 209 [exec] Methods: 769 [exec] Scope: [exec] Non-Static: 676 (87.91%) [exec] Static: 93 (12.09%) [exec] Visibility: [exec] Public: 634 (82.44%) [exec] Non-Public: 135 (17.56%) [exec] Average Method Length (NCLOC): 22 [exec] Cyclomatic Complexity / Number of Methods: 3.70 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 754 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 13 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Computing warning deltas based on reference build #1315 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1315 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 429 files to scan for tasks [TASKS] Found 204 open tasks. [TASKS] Computing warning deltas based on reference build #1315 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1315 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-27_09-41-41/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Fri Apr 27 10:19:54 2012 From: michal at cihar.com (michal at cihar.com) Date: Fri, 27 Apr 2012 10:19:54 +0200 (CEST) Subject: [Phpmyadmin-devel] Jenkins build is back to normal : phpMyAdmin-continuous #1318 In-Reply-To: <1783293308.10.1335512530041.JavaMail.jenkins@pmademo> References: <1783293308.10.1335512530041.JavaMail.jenkins@pmademo> Message-ID: <1180006766.11.1335514794596.JavaMail.jenkins@pmademo> See From michal at cihar.com Fri Apr 27 10:42:30 2012 From: michal at cihar.com (michal at cihar.com) Date: Fri, 27 Apr 2012 10:42:30 +0200 (CEST) Subject: [Phpmyadmin-devel] Jenkins build became unstable: phpMyAdmin-continuous #1319 Message-ID: <54724622.12.1335516150596.JavaMail.jenkins@pmademo> See From dieter.adriaenssens at gmail.com Fri Apr 27 13:04:03 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Fri, 27 Apr 2012 13:04:03 +0200 Subject: [Phpmyadmin-devel] bug in move columns functionality In-Reply-To: <4F984C81.4060904@placella.com> References: <4F98415E.7050109@placella.com> <4F9843B4.3090008@placella.com> <4F984C81.4060904@placella.com> Message-ID: Op 25 april 2012 21:12 heeft Rouslan Placella het volgende geschreven: > On 25/04/12 19:34, Rouslan Placella wrote: >> On 25/04/12 19:24, Rouslan Placella wrote: >>> Hi there, >>> >>> Just spotted an issue with the new "move columns" functionality. >>> After you add or drop a column, if you click on the "Move columns" link, >>> you will be shown a dialog with the old columns instead of the new ones. >> >> And on a loosely related note, I think that function reloadFieldForm() >> from tbl_structure.js should use PMA_ajaxShowMessage() to indicate that >> a request is in progress... > > And another bug occurs after you first add an index using the "more" > dropdown menu and then move some columns. The query is displayed in the > wrong place. Screenshot attached. > > Bye, > Rouslan > Hi Rouslan, Don't forget to create bug reports for these in our tracker. ;) -- Kind regards, Dieter Adriaenssens From marc at infomarc.info Fri Apr 27 13:13:58 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 27 Apr 2012 07:13:58 -0400 Subject: [Phpmyadmin-devel] GSoC student repositories and branching Message-ID: <4F9A7F76.4030307@infomarc.info> Hi, I got a question from a student I am mentoring, about using many feature branches in his tree. Here is the answer that apply (at least) to the two students I mentor. Because the sub-projects on the schedule are linear, my opinion is that it will be simpler to just use the master branch, completing one feature before starting the next one. Of course, the student has to frequently merge origin/master (origin being [0]) to his master branch or to all of his feature branches, to keep up with what happens in the "common" tree. Moreover, if the student has many branches and modifies the same file in more than one branch, cross-merging between his branches has to be done and this require more planning. There won't be a "final" merging at the end of GSoC. From the student guide [1], "Push every change you've done so that we can track your progress. GSoC has few deadlines, but we want to see and merge your code continuously! " [0] git at github.com:phpmyadmin/phpmyadmin.git [1] http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide -- Marc Delisle http://infomarc.info From michal at cihar.com Fri Apr 27 13:34:30 2012 From: michal at cihar.com (Michal =?ISO-8859-2?B?yGloYfg=?=) Date: Fri, 27 Apr 2012 13:34:30 +0200 Subject: [Phpmyadmin-devel] GSoC student repositories and branching In-Reply-To: <4F9A7F76.4030307@infomarc.info> References: <4F9A7F76.4030307@infomarc.info> Message-ID: <20120427133430.6ea54fa4@nutt.cihar.com> Hi Dne Fri, 27 Apr 2012 07:13:58 -0400 Marc Delisle napsal(a): > I got a question from a student I am mentoring, about using many feature > branches in his tree. Here is the answer that apply (at least) to the > two students I mentor. > > Because the sub-projects on the schedule are linear, my opinion is that > it will be simpler to just use the master branch, completing one feature > before starting the next one. I expect this will be the usual case, so one branch should work quite well. However in case you start hacking on something completely different (eg. you notice that some quite unrelated function should be rewritten or fixed), it would be better to have such changes separately to allow easier and faster merging of such fixes. Preferably such branches should branch off official repository. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From rouslan at placella.com Fri Apr 27 13:53:19 2012 From: rouslan at placella.com (Rouslan Placella) Date: Fri, 27 Apr 2012 12:53:19 +0100 Subject: [Phpmyadmin-devel] bug in move columns functionality In-Reply-To: References: <4F98415E.7050109@placella.com> <4F9843B4.3090008@placella.com> <4F984C81.4060904@placella.com> Message-ID: <4F9A88AF.901@placella.com> On 27/04/12 12:04, Dieter Adriaenssens wrote: > Op 25 april 2012 21:12 heeft Rouslan Placella > het volgende geschreven: >> On 25/04/12 19:34, Rouslan Placella wrote: >>> On 25/04/12 19:24, Rouslan Placella wrote: >>>> Hi there, >>>> >>>> Just spotted an issue with the new "move columns" functionality. >>>> After you add or drop a column, if you click on the "Move columns" link, >>>> you will be shown a dialog with the old columns instead of the new ones. >>> >>> And on a loosely related note, I think that function reloadFieldForm() >>> from tbl_structure.js should use PMA_ajaxShowMessage() to indicate that >>> a request is in progress... >> >> And another bug occurs after you first add an index using the "more" >> dropdown menu and then move some columns. The query is displayed in the >> wrong place. Screenshot attached. >> >> Bye, >> Rouslan >> > > Hi Rouslan, > > Don't forget to create bug reports for these in our tracker. ;) Well, the functionality is unreleased, so I was hoping that Jo would just quickly fix the above and we wouldn't have to create any noise on the tracker. But you're right, it's been a few days already, I'll report these later today. Bye, Rouslan From marc at infomarc.info Fri Apr 27 15:26:43 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 27 Apr 2012 09:26:43 -0400 Subject: [Phpmyadmin-devel] about the "\n" Message-ID: <4F9A9E93.3060004@infomarc.info> Hi, When touching a piece of code, if you see a "\n" generated for HTML, it's pretty much safe to remove it (if proven otherwise, we'll build a wiki page documenting those cases). The reason was to generate more readable HTML code; now that we (hopefully) use Firebug to look at the generated HTML, these "\n" are no longer needed. -- Marc Delisle http://infomarc.info From rouslan at placella.com Fri Apr 27 20:55:12 2012 From: rouslan at placella.com (Rouslan Placella) Date: Fri, 27 Apr 2012 19:55:12 +0100 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9A9E93.3060004@infomarc.info> References: <4F9A9E93.3060004@infomarc.info> Message-ID: <4F9AEB90.4040400@placella.com> On 27/04/12 14:26, Marc Delisle wrote: > Hi, > When touching a piece of code, if you see a "\n" generated for HTML, > it's pretty much safe to remove it (if proven otherwise, we'll build a > wiki page documenting those cases). > > The reason was to generate more readable HTML code; now that we > (hopefully) use Firebug to look at the generated HTML, these "\n" are no > longer needed. > I'm not sure how good of an idea this is. What about the casual user that might want to have a stab at figuring out where something is going wrong, for example? Such a user may not have firebug. Bye, Rouslan From marc at infomarc.info Fri Apr 27 21:11:31 2012 From: marc at infomarc.info (Marc Delisle) Date: Fri, 27 Apr 2012 15:11:31 -0400 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9AEB90.4040400@placella.com> References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> Message-ID: <4F9AEF63.1060307@infomarc.info> Le 2012-04-27 14:55, Rouslan Placella a écrit : > On 27/04/12 14:26, Marc Delisle wrote: >> Hi, >> When touching a piece of code, if you see a "\n" generated for HTML, >> it's pretty much safe to remove it (if proven otherwise, we'll build a >> wiki page documenting those cases). >> >> The reason was to generate more readable HTML code; now that we >> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >> longer needed. >> > > I'm not sure how good of an idea this is. What about the casual user > that might want to have a stab at figuring out where something is going > wrong, for example? Such a user may not have firebug. > > Bye, > Rouslan It's mostly older parts of the codebase that are using "\n", so this casual user already has this problem. -- Marc Delisle http://infomarc.info From rouslan at placella.com Fri Apr 27 21:31:58 2012 From: rouslan at placella.com (Rouslan Placella) Date: Fri, 27 Apr 2012 20:31:58 +0100 Subject: [Phpmyadmin-devel] bug in move columns functionality In-Reply-To: <4F9A88AF.901@placella.com> References: <4F98415E.7050109@placella.com> <4F9843B4.3090008@placella.com> <4F984C81.4060904@placella.com> <4F9A88AF.901@placella.com> Message-ID: <4F9AF42E.7000300@placella.com> On 27/04/12 12:53, Rouslan Placella wrote: > On 27/04/12 12:04, Dieter Adriaenssens wrote: >> Op 25 april 2012 21:12 heeft Rouslan Placella >> het volgende geschreven: >>> On 25/04/12 19:34, Rouslan Placella wrote: >>>> On 25/04/12 19:24, Rouslan Placella wrote: >>>>> Hi there, >>>>> >>>>> Just spotted an issue with the new "move columns" functionality. >>>>> After you add or drop a column, if you click on the "Move columns" link, >>>>> you will be shown a dialog with the old columns instead of the new ones. >>>> >>>> And on a loosely related note, I think that function reloadFieldForm() >>>> from tbl_structure.js should use PMA_ajaxShowMessage() to indicate that >>>> a request is in progress... >>> >>> And another bug occurs after you first add an index using the "more" >>> dropdown menu and then move some columns. The query is displayed in the >>> wrong place. Screenshot attached. >>> >>> Bye, >>> Rouslan >>> >> >> Hi Rouslan, >> >> Don't forget to create bug reports for these in our tracker. ;) > > Well, the functionality is unreleased, so I was hoping that Jo would > just quickly fix the above and we wouldn't have to create any noise on > the tracker. But you're right, it's been a few days already, I'll report > these later today. Actually, I ended up fixing issues #1 and #3 myself in d967510e0cef4d0ca20d68af944f324a62991aa2. It seemed easier than filing a bug report. Issue #2 can't really be fixed that easily, because by showing the "Loading" message, we'd be removing the server response from the previous request. The real problem here is that it takes 2 HTTP requests to move the columns. If all the necessary data came back in one request (which is possible), we wouldn't have this issue in the first place and the whole operation would be faster... Bye, Rouslan From dieter.adriaenssens at gmail.com Fri Apr 27 22:39:55 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Fri, 27 Apr 2012 22:39:55 +0200 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9AEF63.1060307@infomarc.info> References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> Message-ID: Op 27 april 2012 21:11 heeft Marc Delisle het volgende geschreven: > Le 2012-04-27 14:55, Rouslan Placella a écrit : >> On 27/04/12 14:26, Marc Delisle wrote: >>> Hi, >>> When touching a piece of code, if you see a "\n" generated for HTML, >>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>> wiki page documenting those cases). >>> >>> The reason was to generate more readable HTML code; now that we >>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>> longer needed. >>> >> >> I'm not sure how good of an idea this is. What about the casual user >> that might want to have a stab at figuring out where something is going >> wrong, for example? Such a user may not have firebug. >> >> Bye, >> Rouslan > > It's mostly older parts of the codebase that are using "\n", so this > casual user already has this problem. For esthetic reasons I prefer to use the "\n", the produced html looks cleaner and better structured. It's a bit like using a coding style (indentation, ...) to have readable code. But it's a lot of work to apply it everywhere, so the question is if it's worth the effort. I don't need it, I usually use the Find function to find what I'm looking for in the html output anyway, or read the sourcecode. -- Kind regards, Dieter Adriaenssens From marc at infomarc.info Sat Apr 28 09:52:26 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 28 Apr 2012 03:52:26 -0400 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> Message-ID: <4F9BA1BA.9060901@infomarc.info> Le 2012-04-27 16:39, Dieter Adriaenssens a écrit : > Op 27 april 2012 21:11 heeft Marc Delisle het > volgende geschreven: >> Le 2012-04-27 14:55, Rouslan Placella a écrit : >>> On 27/04/12 14:26, Marc Delisle wrote: >>>> Hi, >>>> When touching a piece of code, if you see a "\n" generated for HTML, >>>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>>> wiki page documenting those cases). >>>> >>>> The reason was to generate more readable HTML code; now that we >>>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>>> longer needed. >>>> >>> >>> I'm not sure how good of an idea this is. What about the casual user >>> that might want to have a stab at figuring out where something is going >>> wrong, for example? Such a user may not have firebug. >>> >>> Bye, >>> Rouslan >> >> It's mostly older parts of the codebase that are using "\n", so this >> casual user already has this problem. > > For esthetic reasons I prefer to use the "\n", the produced html looks > cleaner and better structured. It's a bit like using a coding style > (indentation, ...) to have readable code. Dieter, aren't you using Firebug to look at the HTML? > > But it's a lot of work to apply it everywhere, so the question is if > it's worth the effort. > I don't need it, I usually use the Find function to find what I'm > looking for in the html output anyway, or read the sourcecode. > -- Marc Delisle http://infomarc.info From rouslan at placella.com Sat Apr 28 10:56:21 2012 From: rouslan at placella.com (Rouslan Placella) Date: Sat, 28 Apr 2012 09:56:21 +0100 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9BA1BA.9060901@infomarc.info> References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> <4F9BA1BA.9060901@infomarc.info> Message-ID: <4F9BB0B5.8040607@placella.com> On 28/04/12 08:52, Marc Delisle wrote: > Le 2012-04-27 16:39, Dieter Adriaenssens a écrit : >> Op 27 april 2012 21:11 heeft Marc Delisle het >> volgende geschreven: >>> Le 2012-04-27 14:55, Rouslan Placella a écrit : >>>> On 27/04/12 14:26, Marc Delisle wrote: >>>>> Hi, >>>>> When touching a piece of code, if you see a "\n" generated for HTML, >>>>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>>>> wiki page documenting those cases). >>>>> >>>>> The reason was to generate more readable HTML code; now that we >>>>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>>>> longer needed. >>>>> >>>> >>>> I'm not sure how good of an idea this is. What about the casual user >>>> that might want to have a stab at figuring out where something is going >>>> wrong, for example? Such a user may not have firebug. >>>> >>>> Bye, >>>> Rouslan >>> >>> It's mostly older parts of the codebase that are using "\n", so this >>> casual user already has this problem. >> >> For esthetic reasons I prefer to use the "\n", the produced html looks >> cleaner and better structured. It's a bit like using a coding style >> (indentation, ...) to have readable code. > > Dieter, > aren't you using Firebug to look at the HTML? I wouldn't call Dieter a casual user, but this kind of proves my point. Also, I don't think that removing all the newlines will give us any noticeable decrease in page load times. >> >> But it's a lot of work to apply it everywhere, so the question is if >> it's worth the effort. >> I don't need it, I usually use the Find function to find what I'm >> looking for in the html output anyway, or read the sourcecode. From dieter.adriaenssens at gmail.com Sat Apr 28 11:41:28 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Sat, 28 Apr 2012 11:41:28 +0200 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9BB0B5.8040607@placella.com> References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> <4F9BA1BA.9060901@infomarc.info> <4F9BB0B5.8040607@placella.com> Message-ID: 2012/4/28 Rouslan Placella : > On 28/04/12 08:52, Marc Delisle wrote: >> Le 2012-04-27 16:39, Dieter Adriaenssens a écrit : >>> Op 27 april 2012 21:11 heeft Marc Delisle het >>> volgende geschreven: >>>> Le 2012-04-27 14:55, Rouslan Placella a écrit : >>>>> On 27/04/12 14:26, Marc Delisle wrote: >>>>>> Hi, >>>>>> When touching a piece of code, if you see a "\n" generated for HTML, >>>>>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>>>>> wiki page documenting those cases). >>>>>> >>>>>> The reason was to generate more readable HTML code; now that we >>>>>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>>>>> longer needed. >>>>>> >>>>> >>>>> I'm not sure how good of an idea this is. What about the casual user >>>>> that might want to have a stab at figuring out where something is going >>>>> wrong, for example? Such a user may not have firebug. >>>>> >>>>> Bye, >>>>> Rouslan >>>> >>>> It's mostly older parts of the codebase that are using "\n", so this >>>> casual user already has this problem. >>> >>> For esthetic reasons I prefer to use the "\n", the produced html looks >>> cleaner and better structured. It's a bit like using a coding style >>> (indentation, ...) to have readable code. >> >> Dieter, >> aren't you using Firebug to look at the HTML? I've used it before, especially when I need to tinker with some layout and css. On my Windows box at work I have the TidyHTML plugin installed, which kicks in when you look at the HTML source. So far this fulfilled my needs, but I guess it will be > I wouldn't call Dieter a casual user, but this kind of proves my point. > Also, I don't think that removing all the newlines will give us any > noticeable decrease in page load times. > >>> >>> But it's a lot of work to apply it everywhere, so the question is if >>> it's worth the effort. >>> I don't need it, I usually use the Find function to find what I'm >>> looking for in the html output anyway, or read the sourcecode. -- Kind regards, Dieter Adriaenssens From dieter.adriaenssens at gmail.com Sat Apr 28 11:43:52 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Sat, 28 Apr 2012 11:43:52 +0200 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> <4F9BA1BA.9060901@infomarc.info> <4F9BB0B5.8040607@placella.com> Message-ID: 2012/4/28 Dieter Adriaenssens : > 2012/4/28 Rouslan Placella : >> On 28/04/12 08:52, Marc Delisle wrote: >>> Le 2012-04-27 16:39, Dieter Adriaenssens a écrit : >>>> Op 27 april 2012 21:11 heeft Marc Delisle het >>>> volgende geschreven: >>>>> Le 2012-04-27 14:55, Rouslan Placella a écrit : >>>>>> On 27/04/12 14:26, Marc Delisle wrote: >>>>>>> Hi, >>>>>>> When touching a piece of code, if you see a "\n" generated for HTML, >>>>>>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>>>>>> wiki page documenting those cases). >>>>>>> >>>>>>> The reason was to generate more readable HTML code; now that we >>>>>>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>>>>>> longer needed. >>>>>>> >>>>>> >>>>>> I'm not sure how good of an idea this is. What about the casual user >>>>>> that might want to have a stab at figuring out where something is going >>>>>> wrong, for example? Such a user may not have firebug. >>>>>> >>>>>> Bye, >>>>>> Rouslan >>>>> >>>>> It's mostly older parts of the codebase that are using "\n", so this >>>>> casual user already has this problem. >>>> >>>> For esthetic reasons I prefer to use the "\n", the produced html looks >>>> cleaner and better structured. It's a bit like using a coding style >>>> (indentation, ...) to have readable code. >>> >>> Dieter, >>> aren't you using Firebug to look at the HTML? I've used it before (or something similar), especially when I need to tinker with some layout and css. On my Windows box at work I have the TidyHTML plugin installed, which kicks in when you look at the HTML source. So far this fulfilled my needs, but I guess it will be a usefull tool when reviewing Rouslan's code this summer. ;) -- Kind regards, Dieter Adriaenssens From atulpratapsingh05 at gmail.com Sat Apr 28 12:19:19 2012 From: atulpratapsingh05 at gmail.com (Atul Pratap Singh) Date: Sat, 28 Apr 2012 15:49:19 +0530 Subject: [Phpmyadmin-devel] GSoC student repositories and branching In-Reply-To: <20120427133430.6ea54fa4@nutt.cihar.com> References: <4F9A7F76.4030307@infomarc.info> <20120427133430.6ea54fa4@nutt.cihar.com> Message-ID: On Fri, Apr 27, 2012 at 5:04 PM, Michal Čihař wrote: > Hi > > Dne Fri, 27 Apr 2012 07:13:58 -0400 > Marc Delisle napsal(a): > > > I got a question from a student I am mentoring, about using many feature > > branches in his tree. Here is the answer that apply (at least) to the > > two students I mentor. > > > > Because the sub-projects on the schedule are linear, my opinion is that > > it will be simpler to just use the master branch, completing one feature > > before starting the next one. > > I expect this will be the usual case, so one branch should work quite > well. > > However in case you start hacking on something completely different > (eg. you notice that some quite unrelated function should be rewritten > or fixed), it would be better to have such changes separately to allow > easier and faster merging of such fixes. Preferably such branches > should branch off official repository. > > Thanks for clearing up my doubt related to using separate branch. As my GSoC project includes refactoring, I would prefer to use the master branch only. I have updated my Git repo information on the wiki page [0]. Please update my demo server [1] to point to the new repository. Thanks Atul [0] https://wiki.phpmyadmin.net/pma/GSoC_2012_Projects#Refactoring:_Table_search.2C_Db_search.2C_Multi-table_query [1] http://demo.phpmyadmin.net/gsoc-atul/ -- > Michal Čihař | http://cihar.com | http://phpmyadmin.cz > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > > -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Sat Apr 28 13:36:50 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 28 Apr 2012 07:36:50 -0400 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9BB0B5.8040607@placella.com> References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> <4F9BA1BA.9060901@infomarc.info> <4F9BB0B5.8040607@placella.com> Message-ID: <4F9BD652.4030906@infomarc.info> Le 2012-04-28 04:56, Rouslan Placella a écrit : > On 28/04/12 08:52, Marc Delisle wrote: >> Le 2012-04-27 16:39, Dieter Adriaenssens a écrit : >>> Op 27 april 2012 21:11 heeft Marc Delisle het >>> volgende geschreven: >>>> Le 2012-04-27 14:55, Rouslan Placella a écrit : >>>>> On 27/04/12 14:26, Marc Delisle wrote: >>>>>> Hi, >>>>>> When touching a piece of code, if you see a "\n" generated for HTML, >>>>>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>>>>> wiki page documenting those cases). >>>>>> >>>>>> The reason was to generate more readable HTML code; now that we >>>>>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>>>>> longer needed. >>>>>> >>>>> >>>>> I'm not sure how good of an idea this is. What about the casual user >>>>> that might want to have a stab at figuring out where something is going >>>>> wrong, for example? Such a user may not have firebug. >>>>> >>>>> Bye, >>>>> Rouslan >>>> >>>> It's mostly older parts of the codebase that are using "\n", so this >>>> casual user already has this problem. >>> >>> For esthetic reasons I prefer to use the "\n", the produced html looks >>> cleaner and better structured. It's a bit like using a coding style >>> (indentation, ...) to have readable code. >> >> Dieter, >> aren't you using Firebug to look at the HTML? > > I wouldn't call Dieter a casual user, but this kind of proves my point. > Also, I don't think that removing all the newlines will give us any > noticeable decrease in page load times. This is not the reason I was thinking of. The main reason is that, because some parts of the code are adding newlines to the generated HTML and some (most?) are not, it's unclear what future development should do. > >>> >>> But it's a lot of work to apply it everywhere, so the question is if >>> it's worth the effort. >>> I don't need it, I usually use the Find function to find what I'm >>> looking for in the html output anyway, or read the sourcecode. -- Marc Delisle http://infomarc.info From rouslan at placella.com Sat Apr 28 13:52:26 2012 From: rouslan at placella.com (Rouslan Placella) Date: Sat, 28 Apr 2012 12:52:26 +0100 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9BD652.4030906@infomarc.info> References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> <4F9BA1BA.9060901@infomarc.info> <4F9BB0B5.8040607@placella.com> <4F9BD652.4030906@infomarc.info> Message-ID: <4F9BD9FA.1030000@placella.com> On 28/04/12 12:36, Marc Delisle wrote: > Le 2012-04-28 04:56, Rouslan Placella a écrit : >> On 28/04/12 08:52, Marc Delisle wrote: >>> Le 2012-04-27 16:39, Dieter Adriaenssens a écrit : >>>> Op 27 april 2012 21:11 heeft Marc Delisle het >>>> volgende geschreven: >>>>> Le 2012-04-27 14:55, Rouslan Placella a écrit : >>>>>> On 27/04/12 14:26, Marc Delisle wrote: >>>>>>> Hi, >>>>>>> When touching a piece of code, if you see a "\n" generated for HTML, >>>>>>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>>>>>> wiki page documenting those cases). >>>>>>> >>>>>>> The reason was to generate more readable HTML code; now that we >>>>>>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>>>>>> longer needed. >>>>>>> >>>>>> >>>>>> I'm not sure how good of an idea this is. What about the casual user >>>>>> that might want to have a stab at figuring out where something is going >>>>>> wrong, for example? Such a user may not have firebug. >>>>>> >>>>>> Bye, >>>>>> Rouslan >>>>> >>>>> It's mostly older parts of the codebase that are using "\n", so this >>>>> casual user already has this problem. >>>> >>>> For esthetic reasons I prefer to use the "\n", the produced html looks >>>> cleaner and better structured. It's a bit like using a coding style >>>> (indentation, ...) to have readable code. >>> >>> Dieter, >>> aren't you using Firebug to look at the HTML? >> >> I wouldn't call Dieter a casual user, but this kind of proves my point. >> Also, I don't think that removing all the newlines will give us any >> noticeable decrease in page load times. > > This is not the reason I was thinking of. The main reason is that, > because some parts of the code are adding newlines to the generated HTML > and some (most?) are not, it's unclear what future development should do. I'd say that devs should make a judgement call on a per case basis. We already have a huge amount of guidelines and rules. If we add another guideline, people will have to remember and/or enforce it. And doing so for something that at the end of the day IMO is pretty irrelevant, is not necessary. > >> >>>> >>>> But it's a lot of work to apply it everywhere, so the question is if >>>> it's worth the effort. >>>> I don't need it, I usually use the Find function to find what I'm >>>> looking for in the html output anyway, or read the sourcecode. From marc at infomarc.info Sat Apr 28 13:57:47 2012 From: marc at infomarc.info (Marc Delisle) Date: Sat, 28 Apr 2012 07:57:47 -0400 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9BD9FA.1030000@placella.com> References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> <4F9BA1BA.9060901@infomarc.info> <4F9BB0B5.8040607@placella.com> <4F9BD652.4030906@infomarc.info> <4F9BD9FA.1030000@placella.com> Message-ID: <4F9BDB3B.7020906@infomarc.info> Le 2012-04-28 07:52, Rouslan Placella a écrit : > On 28/04/12 12:36, Marc Delisle wrote: >> Le 2012-04-28 04:56, Rouslan Placella a écrit : >>> On 28/04/12 08:52, Marc Delisle wrote: >>>> Le 2012-04-27 16:39, Dieter Adriaenssens a écrit : >>>>> Op 27 april 2012 21:11 heeft Marc Delisle het >>>>> volgende geschreven: >>>>>> Le 2012-04-27 14:55, Rouslan Placella a écrit : >>>>>>> On 27/04/12 14:26, Marc Delisle wrote: >>>>>>>> Hi, >>>>>>>> When touching a piece of code, if you see a "\n" generated for HTML, >>>>>>>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>>>>>>> wiki page documenting those cases). >>>>>>>> >>>>>>>> The reason was to generate more readable HTML code; now that we >>>>>>>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>>>>>>> longer needed. >>>>>>>> >>>>>>> >>>>>>> I'm not sure how good of an idea this is. What about the casual user >>>>>>> that might want to have a stab at figuring out where something is going >>>>>>> wrong, for example? Such a user may not have firebug. >>>>>>> >>>>>>> Bye, >>>>>>> Rouslan >>>>>> >>>>>> It's mostly older parts of the codebase that are using "\n", so this >>>>>> casual user already has this problem. >>>>> >>>>> For esthetic reasons I prefer to use the "\n", the produced html looks >>>>> cleaner and better structured. It's a bit like using a coding style >>>>> (indentation, ...) to have readable code. >>>> >>>> Dieter, >>>> aren't you using Firebug to look at the HTML? >>> >>> I wouldn't call Dieter a casual user, but this kind of proves my point. >>> Also, I don't think that removing all the newlines will give us any >>> noticeable decrease in page load times. >> >> This is not the reason I was thinking of. The main reason is that, >> because some parts of the code are adding newlines to the generated HTML >> and some (most?) are not, it's unclear what future development should do. > > I'd say that devs should make a judgement call on a per case basis. We > already have a huge amount of guidelines and rules. If we add another > guideline, people will have to remember and/or enforce it. And doing so > for something that at the end of the day IMO is pretty irrelevant, is > not necessary. IMO it's not irrelevant. The main goal of version 4 is to improve code readability and it's confusing to see newlines generated in some parts and not in another. -- Marc Delisle http://infomarc.info From dieter.adriaenssens at gmail.com Sat Apr 28 21:37:53 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Sat, 28 Apr 2012 21:37:53 +0200 Subject: [Phpmyadmin-devel] about the "\n" In-Reply-To: <4F9BDB3B.7020906@infomarc.info> References: <4F9A9E93.3060004@infomarc.info> <4F9AEB90.4040400@placella.com> <4F9AEF63.1060307@infomarc.info> <4F9BA1BA.9060901@infomarc.info> <4F9BB0B5.8040607@placella.com> <4F9BD652.4030906@infomarc.info> <4F9BD9FA.1030000@placella.com> <4F9BDB3B.7020906@infomarc.info> Message-ID: 2012/4/28 Marc Delisle : > Le 2012-04-28 07:52, Rouslan Placella a écrit : >> On 28/04/12 12:36, Marc Delisle wrote: >>> Le 2012-04-28 04:56, Rouslan Placella a écrit : >>>> On 28/04/12 08:52, Marc Delisle wrote: >>>>> Le 2012-04-27 16:39, Dieter Adriaenssens a écrit : >>>>>> Op 27 april 2012 21:11 heeft Marc Delisle het >>>>>> volgende geschreven: >>>>>>> Le 2012-04-27 14:55, Rouslan Placella a écrit : >>>>>>>> On 27/04/12 14:26, Marc Delisle wrote: >>>>>>>>> Hi, >>>>>>>>> When touching a piece of code, if you see a "\n" generated for HTML, >>>>>>>>> it's pretty much safe to remove it (if proven otherwise, we'll build a >>>>>>>>> wiki page documenting those cases). >>>>>>>>> >>>>>>>>> The reason was to generate more readable HTML code; now that we >>>>>>>>> (hopefully) use Firebug to look at the generated HTML, these "\n" are no >>>>>>>>> longer needed. >>>>>>>>> >>>>>>>> >>>>>>>> I'm not sure how good of an idea this is. What about the casual user >>>>>>>> that might want to have a stab at figuring out where something is going >>>>>>>> wrong, for example? Such a user may not have firebug. >>>>>>>> >>>>>>>> Bye, >>>>>>>> Rouslan >>>>>>> >>>>>>> It's mostly older parts of the codebase that are using "\n", so this >>>>>>> casual user already has this problem. >>>>>> >>>>>> For esthetic reasons I prefer to use the "\n", the produced html looks >>>>>> cleaner and better structured. It's a bit like using a coding style >>>>>> (indentation, ...) to have readable code. >>>>> >>>>> Dieter, >>>>> aren't you using Firebug to look at the HTML? >>>> >>>> I wouldn't call Dieter a casual user, but this kind of proves my point. >>>> Also, I don't think that removing all the newlines will give us any >>>> noticeable decrease in page load times. >>> >>> This is not the reason I was thinking of. The main reason is that, >>> because some parts of the code are adding newlines to the generated HTML >>> and some (most?) are not, it's unclear what future development should do. >> >> I'd say that devs should make a judgement call on a per case basis. We >> already have a huge amount of guidelines and rules. If we add another >> guideline, people will have to remember and/or enforce it. And doing so >> for something that at the end of the day IMO is pretty irrelevant, is >> not necessary. > > IMO it's not irrelevant. The main goal of version 4 is to improve code > readability and it's confusing to see newlines generated in some parts > and not in another. True, it's not very consistent to have it in some parts and not in others. If we would choose to use newlines, after which tags should we put one? While adding newlines is still OK, applying indentation in html, would take a lot of time to get right. Anyway, Having newlines in html makes it look good, and gives a good impression to users who take a peek at the html. A messy html/code looks less attractive and will give the impression that phpmyadmin development is messy as well. I'm not saying that it is, but it's like marketing. If your product looks good, even in the details, it's more likely to attract customers (in our case prospective developers/contributers), the actual quality of the product defines if a customer will continue using the product. But a poor looking product (I'm not talking about our UI), will attract less customers even if the quality of the product is good. I'm a fan of well structured code and well structured html, but I'm also aware that reaching this goal takes a lot of effort, effort that doesn't go into anything else. The question is of course how important it is for phpmyadmin to have well structured html (I think having well structured code is more important). -- Kind regards, Dieter Adriaenssens From me at mynetx.net Sat Apr 28 22:03:46 2012 From: me at mynetx.net (=?utf-8?Q?J.M._R=C3=BCtter?=) Date: Sat, 28 Apr 2012 22:03:46 +0200 Subject: [Phpmyadmin-devel] [ phpmyadmin-Feature Requests-3522109 ] Inline editing by double click Message-ID: <027901cd257a$0569a5a0$103cf0e0$@mynetx.net> > -----Original Message----- > From: SourceForge.net [mailto:noreply at sourceforge.net] > Sent: Saturday, April 28, 2012 12:36 AM > To: SourceForge.net > Subject: [Phpmyadmin-trk-featreq] [ phpmyadmin-Feature Requests-3522109 ] > Inline editing by double click > > Feature Requests item #3522109, was opened at 2012-04-27 14:23 > Message generated for change (Comment added) made by arcadius-radius > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i > d=23067 > > Please note that this message will contain a full copy of the comment thread, > including the initial issue submission, for this request, > not just the latest update. > Category: Interface Improvements > Group: None > Status: Open > Resolution: None > Priority: 5 > Private: No > Submitted By: arcadius (arcadius-radius) > Assigned to: Nobody/Anonymous (nobody) > Summary: Inline editing by double click > > Initial Comment: > Currently (pma 3.5.0) grid editing in browse mode is started on click. > This can be annoying for some users, f.e., they fear important table data can be > accidentally damaged. > Another bad thing is unexpected starting edit mode when trying to select some > text in grid (to copy it to clipboard). > > It would be good to support 3 configuration modes of Grid editing: > - On click (current behavior), > - On double click, > - Disable. > > While there's no this useful setting, I replaced in /js/makegrid.js: > $(g).find("td.data").click > .. with: > $(g).find("td.data").dblclick > > ---------------------------------------------------------------------- > > >Comment By: arcadius (arcadius-radius) > Date: 2012-04-27 15:36 > > Message: > Usual action on double click is selecting all text, on 3-click – > selecting all line... > So ideal shortcut for starting inline editing would be Ctrl+Click, if it > possible. > > ---------------------------------------------------------------------- > > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i > d=23067 Would introducing a new configuration option, as suggested by arcadius, be a good idea? IMHO changing the click behavior for 4.0 would consist a rather big change for people used to 3.5, wouldn't it? -- Jo Michael From michal at cihar.com Sat Apr 28 23:34:44 2012 From: michal at cihar.com (michal at cihar.com) Date: Sat, 28 Apr 2012 23:34:44 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1340 Message-ID: <913529407.13.1335648884247.JavaMail.jenkins@pmademo> See Changes: [ruleant] fix indentation [ruleant] improve docblocks [ruleant] wrap long lines ------------------------------------------ Started by an SCM change Building in workspace Checkout:workspace / - hudson.remoting.LocalChannel at 6688cf9e Using strategy: Default Last Built Revision: Revision 6281b4f9418323c6bb8b661a0885a2c509b750e3 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 229cb53101bbef35a95418514202cd5812519110 (origin/master) Checking out Revision 229cb53101bbef35a95418514202cd5812519110 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson7548124272846965827.sh + ./scripts/generate-mo --quiet po/fi.po:3: header field `PO-Revision-Date' missing in header [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: clean: [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: phpunit: [exec] PHP Parse error: syntax error, unexpected '$local_query' (T_VARIABLE) in on line 508 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:139 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:671 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:776 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:848 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:419 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:358 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:79 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:95 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 17 exact clones with 1080 duplicated lines in 10 files: [exec] [exec] - /libraries/export/htmlword.php:206-223 [exec] /libraries/export/htmlword.php:336-353 [exec] [exec] - /libraries/export/odt.php:270-282 [exec] /libraries/export/odt.php:415-427 [exec] [exec] - /libraries/export/texytext.php:203-217 [exec] /libraries/export/texytext.php:332-346 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-478 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:627-652 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Svg_Relation_Schema.class.php:390-406 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Svg_Relation_Schema.class.php:440-448 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-656 [exec] /libraries/schema/Svg_Relation_Schema.class.php:587-637 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-662 [exec] /libraries/schema/Visio_Relation_Schema.class.php:376-432 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:580-601 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1282 [exec] /themes/original/css/theme_right.css.php:1265-1286 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1691 [exec] /themes/original/css/theme_right.css.php:2393-2823 [exec] [exec] - /themes/original/css/theme_right.css.php:1205-1313 [exec] /themes/pmahomme/css/theme_right.css.php:1584-1692 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1514 [exec] /themes/pmahomme/css/theme_right.css.php:3097-3350 [exec] [exec] 0.92% duplicated lines out of 117706 total lines of code. [exec] [exec] Time: 20 seconds, Memory: 101.00Mb [exec] Result: 1 phpcs: [exec] Time: 01:53, Memory: 57.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 321 [exec] [exec] Lines of Code (LOC): 117706 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 35210 [exec] Non-Comment Lines of Code (NCLOC): 82496 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 81 [exec] Abstract: 2 (2.47%) [exec] Concrete: 79 (97.53%) [exec] Average Class Length (NCLOC): 210 [exec] Methods: 771 [exec] Scope: [exec] Non-Static: 678 (87.94%) [exec] Static: 93 (12.06%) [exec] Visibility: [exec] Public: 636 (82.49%) [exec] Non-Public: 135 (17.51%) [exec] Average Method Length (NCLOC): 22 [exec] Cyclomatic Complexity / Number of Methods: 3.70 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 754 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 25 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 10150 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1339 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1339 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 429 files to scan for tasks [TASKS] Found 204 open tasks. [TASKS] Computing warning deltas based on reference build #1339 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1339 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-28_23-31-43/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Sun Apr 29 00:54:05 2012 From: michal at cihar.com (michal at cihar.com) Date: Sun, 29 Apr 2012 00:54:05 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1341 In-Reply-To: <913529407.13.1335648884247.JavaMail.jenkins@pmademo> References: <913529407.13.1335648884247.JavaMail.jenkins@pmademo> Message-ID: <897343331.14.1335653645741.JavaMail.jenkins@pmademo> See Changes: [ruleant] fix indentation [ruleant] fix indentation [ruleant] use correct English in variable name ------------------------------------------ Started by an SCM change Building in workspace Checkout:workspace / - hudson.remoting.LocalChannel at 6688cf9e Using strategy: Default Last Built Revision: Revision 229cb53101bbef35a95418514202cd5812519110 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 62c134f8f4b373f096b76d64b7cc9526ec97a83a (origin/master) Checking out Revision 62c134f8f4b373f096b76d64b7cc9526ec97a83a (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson5456408319608978723.sh + ./scripts/generate-mo --quiet po/fi.po:3: header field `PO-Revision-Date' missing in header [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: clean: [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: phpunit: [exec] PHP Parse error: syntax error, unexpected '$local_query' (T_VARIABLE) in on line 508 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:139 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:671 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:776 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:848 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:419 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:358 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:79 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:95 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 17 exact clones with 1080 duplicated lines in 10 files: [exec] [exec] - /libraries/export/htmlword.php:206-223 [exec] /libraries/export/htmlword.php:336-353 [exec] [exec] - /libraries/export/odt.php:270-282 [exec] /libraries/export/odt.php:415-427 [exec] [exec] - /libraries/export/texytext.php:203-217 [exec] /libraries/export/texytext.php:332-346 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-478 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:627-652 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Svg_Relation_Schema.class.php:390-406 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Svg_Relation_Schema.class.php:440-448 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-656 [exec] /libraries/schema/Svg_Relation_Schema.class.php:587-637 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-662 [exec] /libraries/schema/Visio_Relation_Schema.class.php:376-432 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:580-601 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1282 [exec] /themes/original/css/theme_right.css.php:1265-1286 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1691 [exec] /themes/original/css/theme_right.css.php:2393-2823 [exec] [exec] - /themes/original/css/theme_right.css.php:1205-1313 [exec] /themes/pmahomme/css/theme_right.css.php:1584-1692 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1514 [exec] /themes/pmahomme/css/theme_right.css.php:3097-3350 [exec] [exec] 0.92% duplicated lines out of 117713 total lines of code. [exec] [exec] Time: 7 seconds, Memory: 101.00Mb [exec] Result: 1 phpcs: [exec] Time: 01:42, Memory: 57.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 321 [exec] [exec] Lines of Code (LOC): 117713 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 35210 [exec] Non-Comment Lines of Code (NCLOC): 82503 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 81 [exec] Abstract: 2 (2.47%) [exec] Concrete: 79 (97.53%) [exec] Average Class Length (NCLOC): 210 [exec] Methods: 771 [exec] Scope: [exec] Non-Static: 678 (87.94%) [exec] Static: 93 (12.06%) [exec] Visibility: [exec] Public: 636 (82.49%) [exec] Non-Public: 135 (17.51%) [exec] Average Method Length (NCLOC): 22 [exec] Cyclomatic Complexity / Number of Methods: 3.70 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 754 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 1 minute 56 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 10095 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1339 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1339 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 429 files to scan for tasks [TASKS] Found 204 open tasks. [TASKS] Computing warning deltas based on reference build #1339 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1339 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-29_00-51-40/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From michal at cihar.com Sun Apr 29 01:17:04 2012 From: michal at cihar.com (michal at cihar.com) Date: Sun, 29 Apr 2012 01:17:04 +0200 (CEST) Subject: [Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1342 In-Reply-To: <897343331.14.1335653645741.JavaMail.jenkins@pmademo> References: <897343331.14.1335653645741.JavaMail.jenkins@pmademo> Message-ID: <372725759.15.1335655024758.JavaMail.jenkins@pmademo> See Changes: [me] Try to fix rare case that commit data can't be loaded from anywhere ------------------------------------------ Started by an SCM change Building in workspace Checkout:workspace / - hudson.remoting.LocalChannel at 6688cf9e Using strategy: Default Last Built Revision: Revision 62c134f8f4b373f096b76d64b7cc9526ec97a83a (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 16bcdb108f1b59d84c6abbb1e4725498a6f1f3a7 (origin/master) Checking out Revision 16bcdb108f1b59d84c6abbb1e4725498a6f1f3a7 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson7620978318131294027.sh + ./scripts/generate-mo --quiet po/fi.po:3: header field `PO-Revision-Date' missing in header [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: clean: [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [delete] Deleting directory [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: [mkdir] Created dir: phpunit: [exec] PHP Parse error: syntax error, unexpected '$local_query' (T_VARIABLE) in on line 508 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:139 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:671 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:776 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:848 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:419 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:358 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:79 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:95 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 17 exact clones with 1080 duplicated lines in 10 files: [exec] [exec] - /libraries/export/htmlword.php:206-223 [exec] /libraries/export/htmlword.php:336-353 [exec] [exec] - /libraries/export/odt.php:270-282 [exec] /libraries/export/odt.php:415-427 [exec] [exec] - /libraries/export/texytext.php:203-217 [exec] /libraries/export/texytext.php:332-346 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-478 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:627-652 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Svg_Relation_Schema.class.php:390-406 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Svg_Relation_Schema.class.php:440-448 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-656 [exec] /libraries/schema/Svg_Relation_Schema.class.php:587-637 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-662 [exec] /libraries/schema/Visio_Relation_Schema.class.php:376-432 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:580-601 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1282 [exec] /themes/original/css/theme_right.css.php:1265-1286 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1691 [exec] /themes/original/css/theme_right.css.php:2393-2823 [exec] [exec] - /themes/original/css/theme_right.css.php:1205-1313 [exec] /themes/pmahomme/css/theme_right.css.php:1584-1692 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1514 [exec] /themes/pmahomme/css/theme_right.css.php:3097-3350 [exec] [exec] 0.92% duplicated lines out of 117715 total lines of code. [exec] [exec] Time: 02:32, Memory: 101.00Mb [exec] Result: 1 phpcs: [exec] Time: 02:18, Memory: 57.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 321 [exec] [exec] Lines of Code (LOC): 117715 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 35210 [exec] Non-Comment Lines of Code (NCLOC): 82505 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 81 [exec] Abstract: 2 (2.47%) [exec] Concrete: 79 (97.53%) [exec] Average Class Length (NCLOC): 210 [exec] Methods: 771 [exec] Scope: [exec] Non-Static: 678 (87.94%) [exec] Static: 93 (12.06%) [exec] Visibility: [exec] Public: 636 (82.49%) [exec] Non-Public: 135 (17.51%) [exec] Average Method Length (NCLOC): 22 [exec] Cyclomatic Complexity / Number of Methods: 3.70 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 754 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 5 minutes 44 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in [CHECKSTYLE] Successfully parsed file of module with 10095 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1339 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in [DRY] Successfully parsed file of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1339 [TASKS] Scanning folder ' for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 429 files to scan for tasks [TASKS] Found 204 open tasks. [TASKS] Computing warning deltas based on reference build #1339 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1339 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-29_01-05-44/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory ' exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to ' for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording. From me at mynetx.net Sun Apr 29 03:19:01 2012 From: me at mynetx.net (J.M.) Date: Sun, 29 Apr 2012 03:19:01 +0200 Subject: [Phpmyadmin-devel] Checkstyle warning for @subpackage Message-ID: File comments for @subpackage should not trigger as 'unknown tag/wrong indentation'. Issue like this: http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1346/checkstyleResult/HIGH/file.752771460/ From madhura.cj at gmail.com Sun Apr 29 04:10:49 2012 From: madhura.cj at gmail.com (Madhura Jayaratne) Date: Sun, 29 Apr 2012 07:40:49 +0530 Subject: [Phpmyadmin-devel] [ phpmyadmin-Feature Requests-3522109 ] Inline editing by double click In-Reply-To: <027901cd257a$0569a5a0$103cf0e0$@mynetx.net> References: <027901cd257a$0569a5a0$103cf0e0$@mynetx.net> Message-ID: On Sun, Apr 29, 2012 at 1:33 AM, J.M. Rütter wrote: > > > > -----Original Message----- > > From: SourceForge.net [mailto:noreply at sourceforge.net] > > Sent: Saturday, April 28, 2012 12:36 AM > > To: SourceForge.net > > Subject: [Phpmyadmin-trk-featreq] [ phpmyadmin-Feature Requests-3522109 ] > > Inline editing by double click > > > > Feature Requests item #3522109, was opened at 2012-04-27 14:23 > > Message generated for change (Comment added) made by arcadius-radius > > You can respond by visiting: > > > https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i > > d=23067 > > > > Please note that this message will contain a full copy of the comment > thread, > > including the initial issue submission, for this request, > > not just the latest update. > > Category: Interface Improvements > > Group: None > > Status: Open > > Resolution: None > > Priority: 5 > > Private: No > > Submitted By: arcadius (arcadius-radius) > > Assigned to: Nobody/Anonymous (nobody) > > Summary: Inline editing by double click > > > > Initial Comment: > > Currently (pma 3.5.0) grid editing in browse mode is started on click. > > This can be annoying for some users, f.e., they fear important table > data can be > > accidentally damaged. > > Another bad thing is unexpected starting edit mode when trying to select > some > > text in grid (to copy it to clipboard). > > > > It would be good to support 3 configuration modes of Grid editing: > > - On click (current behavior), > > - On double click, > > - Disable. > > > > While there's no this useful setting, I replaced in /js/makegrid.js: > > $(g).find("td.data").click > > .. with: > > $(g).find("td.data").dblclick > > > > ---------------------------------------------------------------------- > > > > >Comment By: arcadius (arcadius-radius) > > Date: 2012-04-27 15:36 > > > > Message: > > Usual action on double click is selecting all text, on 3-click – > > selecting all line... > > So ideal shortcut for starting inline editing would be Ctrl+Click, if it > > possible. > > > > ---------------------------------------------------------------------- > > > > You can respond by visiting: > > > https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i > > d=23067 > > Would introducing a new configuration option, as suggested by arcadius, be > a good idea? > Although I'm of the opinion that there are too many configurations options in PMA already, the suggested configuration seems to be quite reasonable. Btw, are you suggesting the default behavior to be Ctrl+Click? I think what is mentioned in the comment makes sense. IMHO changing the click behavior for 4.0 would consist a rather big change > for people used to 3.5, wouldn't it? > Yes, we will get loads of complaints saying their grid editing is not working. How about 3.5.2? I know it is suppose to be a bug fix release. But this would avoid the problem to some extend. -- Thanks and Regards, Madhura Jayaratne -------------- next part -------------- An HTML attachment was scrubbed... URL: From yasitha4 at gmail.com Sun Apr 29 04:28:28 2012 From: yasitha4 at gmail.com (yasitha pandithawatta) Date: Sun, 29 Apr 2012 07:58:28 +0530 Subject: [Phpmyadmin-devel] Automated Testing - GSoC 2012 Message-ID: Hi Michal, In the community bonding period I would like to sort out the issues I face when I install the Jenkins server. I refer to this tutorial [0] for installation. Once I installed the Jenkins server I couldn't restart the Apache server. So I re-installed Apache. Can you suggest any manual installing instruction or a tutorial that can I use and get familiar with Jenkins. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka [0] - https://wiki.jenkins-ci.org/display/JENKINS/Installing+Jenkins+on+Ubuntu -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Sun Apr 29 12:01:35 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 29 Apr 2012 06:01:35 -0400 Subject: [Phpmyadmin-devel] [ phpmyadmin-Feature Requests-3522109 ] Inline editing by double click In-Reply-To: References: <027901cd257a$0569a5a0$103cf0e0$@mynetx.net> Message-ID: <4F9D117F.1050700@infomarc.info> Le 2012-04-28 22:10, Madhura Jayaratne a écrit : > On Sun, Apr 29, 2012 at 1:33 AM, J.M. Rütter wrote: > >> >> >>> -----Original Message----- >>> From: SourceForge.net [mailto:noreply at sourceforge.net] >>> Sent: Saturday, April 28, 2012 12:36 AM >>> To: SourceForge.net >>> Subject: [Phpmyadmin-trk-featreq] [ phpmyadmin-Feature Requests-3522109 ] >>> Inline editing by double click >>> >>> Feature Requests item #3522109, was opened at 2012-04-27 14:23 >>> Message generated for change (Comment added) made by arcadius-radius >>> You can respond by visiting: >>> >> https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i >>> d=23067 >>> >>> Please note that this message will contain a full copy of the comment >> thread, >>> including the initial issue submission, for this request, >>> not just the latest update. >>> Category: Interface Improvements >>> Group: None >>> Status: Open >>> Resolution: None >>> Priority: 5 >>> Private: No >>> Submitted By: arcadius (arcadius-radius) >>> Assigned to: Nobody/Anonymous (nobody) >>> Summary: Inline editing by double click >>> >>> Initial Comment: >>> Currently (pma 3.5.0) grid editing in browse mode is started on click. >>> This can be annoying for some users, f.e., they fear important table >> data can be >>> accidentally damaged. >>> Another bad thing is unexpected starting edit mode when trying to select >> some >>> text in grid (to copy it to clipboard). >>> >>> It would be good to support 3 configuration modes of Grid editing: >>> - On click (current behavior), >>> - On double click, >>> - Disable. >>> >>> While there's no this useful setting, I replaced in /js/makegrid.js: >>> $(g).find("td.data").click >>> .. with: >>> $(g).find("td.data").dblclick >>> >>> ---------------------------------------------------------------------- >>> >>>> Comment By: arcadius (arcadius-radius) >>> Date: 2012-04-27 15:36 >>> >>> Message: >>> Usual action on double click is selecting all text, on 3-click – >>> selecting all line... >>> So ideal shortcut for starting inline editing would be Ctrl+Click, if it >>> possible. >>> >>> ---------------------------------------------------------------------- >>> >>> You can respond by visiting: >>> >> https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i >>> d=23067 >> >> Would introducing a new configuration option, as suggested by arcadius, be >> a good idea? >> > > Although I'm of the opinion that there are too many configurations options > in PMA already, the suggested configuration seems to be quite reasonable. > Btw, are you suggesting the default behavior to be Ctrl+Click? I think what > is mentioned in the comment makes sense. > > IMHO changing the click behavior for 4.0 would consist a rather big change >> for people used to 3.5, wouldn't it? Yes, so let's avoid changing the behavior. >> > > Yes, we will get loads of complaints saying their grid editing is not > working. > How about 3.5.2? I know it is suppose to be a bug fix release. But this > would avoid the problem to some extend. The default value (in 4.0) for this could be "on click" so there would be no problem IMO. We don't add configuration options once a version is released. -- Marc Delisle http://infomarc.info From dieter.adriaenssens at gmail.com Sun Apr 29 13:38:45 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Sun, 29 Apr 2012 13:38:45 +0200 Subject: [Phpmyadmin-devel] Automated Testing - GSoC 2012 In-Reply-To: References: Message-ID: 2012/4/29 yasitha pandithawatta : > Hi Michal, > > In the community bonding period I would like to sort out the issues I face > when I install the Jenkins server. I refer to this tutorial [0] for > installation. Once I installed the Jenkins server I couldn't restart > the Apache server. So I re-installed Apache. Can you suggest any manual > installing instruction or a tutorial that can I use and get familiar with > Jenkins. Hi, Have a look at the error log file of Apache (/var/log/apache2/error.log). It will tell you why Apache won't restart. Probably because of a configuration issue. Or you could just skip the part of the tutorial where Jenkins (on port 8080) is proxied by apache, and access Jenkins directly on port 8080 (I assume you're installing this on your own PC, not on a public server?) > Regards, > -- > Yasitha Pandithawatta > Undergraduate > Computer Science and Engineering Department > University of Moratuwa > Sri Lanka > > [0] > - https://wiki.jenkins-ci.org/display/JENKINS/Installing+Jenkins+on+Ubuntu -- Kind regards, Dieter Adriaenssens From dieter.adriaenssens at gmail.com Sun Apr 29 15:34:20 2012 From: dieter.adriaenssens at gmail.com (Dieter Adriaenssens) Date: Sun, 29 Apr 2012 15:34:20 +0200 Subject: [Phpmyadmin-devel] guidelines for avoiding security pitfalls In-Reply-To: <4F78CB11.3000505@infomarc.info> References: <20120328105335.0c4cba53@rincewind.suse.cz> <4F730622.6040109@infomarc.info> <4F78460E.7070805@infomarc.info> <4F789538.7030406@placella.com> <4F78CB11.3000505@infomarc.info> Message-ID: 2012/4/1 Marc Delisle : > Le 2012-04-01 13:49, Rouslan Placella a écrit : >> On 01/04/12 13:11, Marc Delisle wrote: >>> Le 2012-03-31 11:02, Dieter Adriaenssens a écrit : >>>> Op 28 maart 2012 14:37 heeft Marc Delisle het >>>> volgende geschreven: >>>>> Le 2012-03-28 04:53, Michal Čihař a écrit : >>>>>> Hi >>>>>> >>>>>> Dne Tue, 27 Mar 2012 22:01:05 +0200 >>>>>> Dieter Adriaenssens napsal(a): >>>>>> >>>>>>> As discussed on the team meeting in February, I started creating a >>>>>>> wiki page with some guidelines for avoiding security bugs [0]. >>>>>>> The page is not finished yet, I just set out some ideas, that I will >>>>>>> work out in the next few days. Feel free to comment, improve or add >>>>>>> guidelines as you see fit. >>>>>>> >>>>>>> [0] http://wiki.phpmyadmin.net/pma/Security_pitfalls >>>>>> >>>>>> Thanks, looks great so far! >>>>> >>>>> Yes, thanks. I'm wondering, are there places where we really use >>>>> htmlentities() for protection? >>>> >>>> htmlentities() is not much used (see lower), shall we replace them all >>>> by htmlspecialchars and drop the htmlentities() from the guidelines? >>> >>> It would be more prudent to have a look at them, one by one, and see >>> their exact purpose. >> >> You'd use htmlentities() when you need to escape single quotes, >> htmlspecialchars() doesn't do that. > > From the PHP manual for htmlspecialchars(), we can use the ENT_QUOTES > flag which does this: > "'" (single quote) becomes ''' only when ENT_QUOTES is set. I've added the ENT_QUOTES directive to the page and also added some examples for escaping url's and encoding url parameter values. >> >> E.g.: >> $name = htmlentities("foo's bar", ENT_QUOTES); >> echo ""; >> >>> Anyway, some of them are under libraries/tcpdf and some under /test. >>> >>> In the PHP Architect guide to PHP security by one of the PHP core >>> developers, I checked the chapter about XSS. I could not find a >>> suggestion to use htmlentities(); however, htmlspecialchars() does not >>> find all XSS, so they suggest using preg_replace() with some clever >>> patterns. Do you have a link to that, or do you own a paper copy? >>>> >>>> Using htmlspecialchars() is sufficient to protect against XSS (and >>>> possibly messing up of the html structure), >>>> htmlentities() just converts more characters into their HTML character >>>> entity equivalents (for example ü will become ü) >>>> >>>> Current occurences of escaping/sanitizing functions in PMA codebase: >>>> >>>> htmlentities() : 51 >>>> htmlspecialchars() : 1041 >>>> PMA_sanitize() : 40 >>>> PMA_sanitize_file() : 3 >>>> >>>>> Also I think we should talk about PMA_sanitize(). >>>> >>>> Yes, but it should not be used in all cases? >>>> >>> >>> Maybe, but it would be slower than just plain htmlspecialchars(). Also, >>> with the default parameters of PMA_sanitize(), it just replaces "<" and >>> ">" and takes care of our special formatting codes. >>> > > > > -- > Marc Delisle > http://infomarc.info > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel -- Kind regards, Dieter Adriaenssens From marc at infomarc.info Sun Apr 29 18:06:12 2012 From: marc at infomarc.info (Marc Delisle) Date: Sun, 29 Apr 2012 12:06:12 -0400 Subject: [Phpmyadmin-devel] guidelines for avoiding security pitfalls In-Reply-To: References: <20120328105335.0c4cba53@rincewind.suse.cz> <4F730622.6040109@infomarc.info> <4F78460E.7070805@infomarc.info> <4F789538.7030406@placella.com> <4F78CB11.3000505@infomarc.info> Message-ID: <4F9D66F4.9060502@infomarc.info> Le 2012-04-29 09:34, Dieter Adriaenssens a écrit : > 2012/4/1 Marc Delisle : >> Le 2012-04-01 13:49, Rouslan Placella a écrit : >>> On 01/04/12 13:11, Marc Delisle wrote: >>>> Le 2012-03-31 11:02, Dieter Adriaenssens a écrit : >>>>> Op 28 maart 2012 14:37 heeft Marc Delisle het >>>>> volgende geschreven: >>>>>> Le 2012-03-28 04:53, Michal Čihař a écrit : >>>>>>> Hi >>>>>>> >>>>>>> Dne Tue, 27 Mar 2012 22:01:05 +0200 >>>>>>> Dieter Adriaenssens napsal(a): >>>>>>> >>>>>>>> As discussed on the team meeting in February, I started creating a >>>>>>>> wiki page with some guidelines for avoiding security bugs [0]. >>>>>>>> The page is not finished yet, I just set out some ideas, that I will >>>>>>>> work out in the next few days. Feel free to comment, improve or add >>>>>>>> guidelines as you see fit. >>>>>>>> >>>>>>>> [0] http://wiki.phpmyadmin.net/pma/Security_pitfalls >>>>>>> >>>>>>> Thanks, looks great so far! >>>>>> >>>>>> Yes, thanks. I'm wondering, are there places where we really use >>>>>> htmlentities() for protection? >>>>> >>>>> htmlentities() is not much used (see lower), shall we replace them all >>>>> by htmlspecialchars and drop the htmlentities() from the guidelines? >>>> >>>> It would be more prudent to have a look at them, one by one, and see >>>> their exact purpose. >>> >>> You'd use htmlentities() when you need to escape single quotes, >>> htmlspecialchars() doesn't do that. >> >> From the PHP manual for htmlspecialchars(), we can use the ENT_QUOTES >> flag which does this: >> "'" (single quote) becomes ''' only when ENT_QUOTES is set. > > I've added the ENT_QUOTES directive to the page and also added some > examples for escaping url's and encoding url parameter values. Great. > >>> >>> E.g.: >>> $name = htmlentities("foo's bar", ENT_QUOTES); >>> echo ""; >>> >>>> Anyway, some of them are under libraries/tcpdf and some under /test. >>>> >>>> In the PHP Architect guide to PHP security by one of the PHP core >>>> developers, I checked the chapter about XSS. I could not find a >>>> suggestion to use htmlentities(); however, htmlspecialchars() does not >>>> find all XSS, so they suggest using preg_replace() with some clever >>>> patterns. > > Do you have a link to that, or do you own a paper copy? Sorry, paper copy. > >>>>> >>>>> Using htmlspecialchars() is sufficient to protect against XSS (and >>>>> possibly messing up of the html structure), >>>>> htmlentities() just converts more characters into their HTML character >>>>> entity equivalents (for example ü will become ü) >>>>> >>>>> Current occurences of escaping/sanitizing functions in PMA codebase: >>>>> >>>>> htmlentities() : 51 >>>>> htmlspecialchars() : 1041 >>>>> PMA_sanitize() : 40 >>>>> PMA_sanitize_file() : 3 >>>>> >>>>>> Also I think we should talk about PMA_sanitize(). >>>>> >>>>> Yes, but it should not be used in all cases? >>>>> >>>> >>>> Maybe, but it would be slower than just plain htmlspecialchars(). Also, >>>> with the default parameters of PMA_sanitize(), it just replaces "<" and >>>> ">" and takes care of our special formatting codes. >>>> -- Marc Delisle http://infomarc.info From thilinaabeyrathna at gmail.com Mon Apr 30 16:54:33 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Mon, 30 Apr 2012 20:24:33 +0530 Subject: [Phpmyadmin-devel] Gsoc 2012 - Refactoring Insert/edit, Operations, Privilege and Structure sections in phpMyAdmin Message-ID: Hi Marc, I'm trying to start refactoring for Insert/edit section. There are main three scripts to refactor. But before that, I need your suggestion to start coding. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Mon Apr 30 17:12:22 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 30 Apr 2012 11:12:22 -0400 Subject: [Phpmyadmin-devel] Gsoc 2012 - Refactoring Insert/edit, Operations, Privilege and Structure sections in phpMyAdmin In-Reply-To: References: Message-ID: <4F9EABD6.6050502@infomarc.info> Le 2012-04-30 10:54, Thilina Buddika Abeyrathna a écrit : > Hi Marc, > I'm trying to start refactoring for Insert/edit section. There are main > three scripts to refactor. But before that, I need your suggestion to start > coding. Hi Thilina, have you read and understood these three scripts? A good way of analysing is to use the NetBeans IDE (with PHP support) to follow the execution path and debug at the same time. -- Marc Delisle http://infomarc.info From thilinaabeyrathna at gmail.com Mon Apr 30 17:16:13 2012 From: thilinaabeyrathna at gmail.com (Thilina Buddika Abeyrathna) Date: Mon, 30 Apr 2012 20:46:13 +0530 Subject: [Phpmyadmin-devel] Gsoc 2012 - Refactoring Insert/edit, Operations, Privilege and Structure sections in phpMyAdmin In-Reply-To: <4F9EABD6.6050502@infomarc.info> References: <4F9EABD6.6050502@infomarc.info> Message-ID: On Mon, Apr 30, 2012 at 8:42 PM, Marc Delisle wrote: > Le 2012-04-30 10:54, Thilina Buddika Abeyrathna a écrit : > > Hi Marc, > > I'm trying to start refactoring for Insert/edit section. There are main > > three scripts to refactor. But before that, I need your suggestion to > start > > coding. > > Hi Thilina, > have you read and understood these three scripts? > > Not completely. I'm reading tbl_change.php script > A good way of analysing is to use the NetBeans IDE (with PHP support) to > follow the execution path and debug at the same time. > > I'm already using NetBeans IDE for my developing. :) -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka. -------------- next part -------------- An HTML attachment was scrubbed... URL: From yasitha4 at gmail.com Mon Apr 30 17:16:58 2012 From: yasitha4 at gmail.com (yasitha pandithawatta) Date: Mon, 30 Apr 2012 20:46:58 +0530 Subject: [Phpmyadmin-devel] Automated Testing - GSoC 2012 In-Reply-To: References: Message-ID: On Sun, Apr 29, 2012 at 5:08 PM, Dieter Adriaenssens < dieter.adriaenssens at gmail.com> wrote: > 2012/4/29 yasitha pandithawatta : > > Hi Michal, > > > > In the community bonding period I would like to sort out the issues I > face > > when I install the Jenkins server. I refer to this tutorial [0] for > > installation. Once I installed the Jenkins server I couldn't restart > > the Apache server. So I re-installed Apache. Can you suggest any manual > > installing instruction or a tutorial that can I use and get familiar with > > Jenkins. > > Hi, > > Have a look at the error log file of Apache > (/var/log/apache2/error.log). It will tell you why Apache won't > restart. Probably because of a configuration issue. > Or you could just skip the part of the tutorial where Jenkins (on port > 8080) is proxied by apache, and access Jenkins directly on port 8080 > (I assume you're installing this on your own PC, not on a public > server?) > > > Regards, > > -- > > Yasitha Pandithawatta > > Undergraduate > > Computer Science and Engineering Department > > University of Moratuwa > > Sri Lanka > > > > [0] > > - > https://wiki.jenkins-ci.org/display/JENKINS/Installing+Jenkins+on+Ubuntu > > -- > Kind regards, > > Dieter Adriaenssens > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > Thanks Dieter for the reply. I installed Jenkins successfully. I will now look how to combine my developing copy with Jenkins. If you have any suggestions please inform me. Any tutorials will be preferred. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at infomarc.info Mon Apr 30 17:24:33 2012 From: marc at infomarc.info (Marc Delisle) Date: Mon, 30 Apr 2012 11:24:33 -0400 Subject: [Phpmyadmin-devel] Gsoc 2012 - Refactoring Insert/edit, Operations, Privilege and Structure sections in phpMyAdmin In-Reply-To: References: <4F9EABD6.6050502@infomarc.info> Message-ID: <4F9EAEB1.3060905@infomarc.info> Le 2012-04-30 11:16, Thilina Buddika Abeyrathna a écrit : > On Mon, Apr 30, 2012 at 8:42 PM, Marc Delisle wrote: > >> Le 2012-04-30 10:54, Thilina Buddika Abeyrathna a écrit : >>> Hi Marc, >>> I'm trying to start refactoring for Insert/edit section. There are main >>> three scripts to refactor. But before that, I need your suggestion to >> start >>> coding. >> >> Hi Thilina, >> have you read and understood these three scripts? >> >> Not completely. I'm reading tbl_change.php script > > >> A good way of analysing is to use the NetBeans IDE (with PHP support) to >> follow the execution path and debug at the same time. >> >> I'm already using NetBeans IDE for my developing. :) Good! So, instead of reading the tbl_change.php script, load phpMyAdmin as a project in NetBeans, put a breakpoint at the beginning of tbl_change.php, start execution and watch what happens, line by line, when you try to display a row for editing in phpMyAdmin. -- Marc Delisle http://infomarc.info From pe.chanaka.ck at gmail.com Mon Apr 30 22:32:38 2012 From: pe.chanaka.ck at gmail.com (Chanaka Dharmarathna) Date: Tue, 1 May 2012 02:02:38 +0530 Subject: [Phpmyadmin-devel] Refactoring: Displaying query results Message-ID: Hi Michal, I'm identifying the refactoring points in 'display_tbl.lib.php' file. I am trying to break the tasks on following areas. * As a library file this should not render the HTML codes in functions it selves. First, all the HTML content in functions stored in string and render at the bottom of the function. Next, return the string having the HTML content, instead of rendering it inside the function itself and, from the calling end render that content. Probably method names will be modified with adding 'get' phrase. * Some naming conventions are used incorrectly. For method name in lib file, naming convention is used generally used as 'PMA_methodName'. But some are not following this. While correcting them, suggested conventions in my proposal [0] is going to applied. * There are several functions having more than 200 lines. I'm intending to divide those functions to smaller ones. (PMA_displayTableNavigation(), PMA_displayTableHeaders(), PMA_displayTableBody(), PMA_displayVerticalTable(), PMA_displayTable()) I am looking for your suggestions to identify more important points and modifications on suggested points. So that I can do more research by digging code more. As well, I'm using NetBeans IDE with PHP support, meld tool, Mozilla Firefox with Firebug, command line git client in Linux environment. Are there any other special tools which are more useful ? [0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka777/1 Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: