[Phpmyadmin-devel] [ phpmyadmin-Feature Requests-3522109 ] Inline editing by double click

[Marc Delisle]

Le 2012-04-28 22:10, Madhura Jayaratne a écrit :
> On Sun, Apr 29, 2012 at 1:33 AM, J.M. Rütter <me at mynetx.net> wrote:
> 
>>
>>
>>> -----Original Message-----
>>> From: SourceForge.net [mailto:noreply at sourceforge.net]
>>> Sent: Saturday, April 28, 2012 12:36 AM
>>> To: SourceForge.net
>>> Subject: [Phpmyadmin-trk-featreq] [ phpmyadmin-Feature Requests-3522109 ]
>>> Inline editing by double click
>>>
>>> Feature Requests item #3522109, was opened at 2012-04-27 14:23
>>> Message generated for change (Comment added) made by arcadius-radius
>>> You can respond by visiting:
>>>
>> https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i
>>> d=23067
>>>
>>> Please note that this message will contain a full copy of the comment
>> thread,
>>> including the initial issue submission, for this request,
>>> not just the latest update.
>>> Category: Interface Improvements
>>> Group: None
>>> Status: Open
>>> Resolution: None
>>> Priority: 5
>>> Private: No
>>> Submitted By: arcadius (arcadius-radius)
>>> Assigned to: Nobody/Anonymous (nobody)
>>> Summary: Inline editing by double click
>>>
>>> Initial Comment:
>>> Currently (pma 3.5.0) grid editing in browse mode is started on click.
>>> This can be annoying for some users, f.e., they fear important table
>> data can be
>>> accidentally damaged.
>>> Another bad thing is unexpected starting edit mode when trying to select
>> some
>>> text in grid (to copy it to clipboard).
>>>
>>> It would be good to support 3 configuration modes of Grid editing:
>>> - On click (current behavior),
>>> - On double click,
>>> - Disable.
>>>
>>> While there's no this useful setting, I replaced in /js/makegrid.js:
>>> $(g).find("td.data").click
>>> .. with:
>>> $(g).find("td.data").dblclick
>>>
>>> ----------------------------------------------------------------------
>>>
>>>> Comment By: arcadius (arcadius-radius)
>>> Date: 2012-04-27 15:36
>>>
>>> Message:
>>> Usual action on double click is selecting all text, on 3-click –
>>> selecting all line...
>>> So ideal shortcut for starting inline editing would be Ctrl+Click, if it
>>> possible.
>>>
>>> ----------------------------------------------------------------------
>>>
>>> You can respond by visiting:
>>>
>> https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i
>>> d=23067
>>
>> Would introducing a new configuration option, as suggested by arcadius, be
>> a good idea?
>>
> 
> Although I'm of the opinion that there are too many configurations options
> in PMA already, the suggested configuration seems to be quite reasonable.
> Btw, are you suggesting the default behavior to be Ctrl+Click? I think what
> is mentioned in the comment makes sense.
> 
> IMHO changing the click behavior for 4.0 would consist a rather big change
>> for people used to 3.5, wouldn't it?

Yes, so let's avoid changing the behavior.

>>
> 
> Yes, we will get loads of complaints saying their grid editing is not
> working.
> How about 3.5.2? I know it is suppose to be a bug fix release. But this
> would avoid the problem to some extend.

The default value (in 4.0) for this could be "on click" so there would
be no problem IMO.

We don't add configuration options once a version is released.

-- 
Marc Delisle
http://infomarc.info