[Phpmyadmin-devel] FAO: Thilina. Bad ajax response when adding a user without a host

[Marc Delisle]

Le 2012-08-04 10:58, Thilina Buddika Abeyrathna a écrit :
> On Sat, Aug 4, 2012 at 4:15 PM, Marc Delisle <marc at infomarc.info> wrote:
> 
>> Le 2012-08-03 19:19, Thilina Buddika Abeyrathna a écrit :
>>> On Fri, Aug 3, 2012 at 5:25 PM, Marc Delisle <marc at infomarc.info> wrote:
>>>
>>>> Thilina Buddika Abeyrathna a écrit :
>>>>> On Thu, Aug 2, 2012 at 9:25 PM, Rouslan Placella <rouslan at placella.com
>>>>> wrote:
>>>>>
>>>>>> Hi Thilina,
>>>>>>
>>>>>> In the master branch, if you add a user without specifying a host, an
>>>>>> invalid ajax response is generated. This causes a bug, where you
>> cannot
>>>>>> stright away delete that user without refreshing the page (and in the
>>>>>> displayed table the host part is missing). I don't know how the
>>>> mechanism
>>>>>> for adding users works, but the attached patch fixed the issue for me.
>>>>>>
>>>>>> Bye,
>>>>>> Rouslan
>>>>>>
>>>>>> Hi Rouslan,
>>>>> Thank you very much for pointing out that, you did the correct changes.
>>>>> And I did that changes and commit.
>>>>>
>>>>> Marc, Can you merge that commit to upstream.
>>>>
>>>> Thilina,
>>>> no, there are merge conflicts. Please merge upstream master into your
>>>> tree, resolve the conflicts and ask again.
>>>>
>>>>
>>> Hi Marc,
>>> I merged upstream master.
>>
>> Thilina,
>> the merge was incorrect, because the fix for this bug is no longer in
>> server_privileges.php. I get this error when deleting a user:
>>
>> Warning in ./libraries/server_privileges.lib.php#1735
>> Missing argument 6 for PMA_getExtraDataForAjaxBehavior(), called in
>> server_privileges.php on line 392
>>
>>
> hi Marc,
> I committed the changes.

Thilina,
after deleting a user, I get this at the bottom of the list of users:

Notice in ./server_privileges.php#392
Undefined variable: hostname

Notice in ./server_privileges.php#393
Undefined variable: username

-- 
Marc Delisle
http://infomarc.info