[Phpmyadmin-devel] Bug with properties system

[Rouslan Placella]

On 16/08/2012 22:21, Alex Marin wrote:
> On Thu, Aug 16, 2012 at 10:17 PM, Rouslan Placella <rouslan at placella.com> wrote:
>> I don't see anything weird at the end of get_image.js.php. In your
>> commit, you have one addition and no deletions for that file, so your
>> not commenting anything out, you're just adding a comment. Perhaps you
>> could try to simply add a newline character at the end of the file?
>
> Yes, I'm adding a comment for the unknown characters that are somehow
> appended at the end of the file.

But there aren't any characters there... Look at it with a hex editor if 
you want to, but there is nothing on the last line. Besides, if there 
was a character there, your commit would show a deletion, but it only 
shows an addition.

>> The "theme=someid" parameter is necessary and must not be removed. The
>> idea there is that different themes have different icons embedded in the
>> sprite and that js file is cached on the client side. So the theme id is
>> necessary to invalidate the cache when a user switches themes.
>
> Ok, I've put that back where it belonged and it seems to work fine now
> in my tree.
>
> --
> Alex