rouslan at placella.com
Sat Aug 18 19:22:53 CEST 2012
Just in case you guys decide to change this class from a singleton to
something else, may I recommend that this gets done after GSoC? As IMO
such a move will create a whole bunch of conflicts for everyone to
resolve and yet there is no clear advantage other than shorter syntax in
On 18/08/2012 18:22, Chanaka Dharmarathna wrote:
> Hi Dieter,
> First sorry for top posting. I'm using my phone to send this.
> As I remember I discussed about this class structure in the mailing list
> before. At that time I decided to use singleton pattern for this class.
> Anyway, I got the point you mentioned. Since the class itself have no
> properties singleton may not be essential here. I'll look more on what
> are the pros and cons between these two approaches in this kind
> background. Hope other also will share their ideas on this.
> However, since I need to stop my work by tomorrow according to the GSoC
> timeline (Carol ask to do so) I'll take the responsibility of any
> necessary changes regarding this after GSoC session.
> Regards !
> On Aug 18, 2012 6:10 PM, "Dieter Adriaenssens"
> <dieter.adriaenssens at gmail.com <mailto:dieter.adriaenssens at gmail.com>>
> > Hi Chanaka,
> > I stumbled upon this piece of code (random pick) :
> > PMA_CommonFunctions::getInstance()->backquote($_REQUEST['view']['name'])
> > and it made me wonder if using a singleton for PMA_CommonFunctions is
> > necessary, because basicaly PMA_Commonfunctions is a collection of
> > methods, not really a 'living' object.
> > So then I had a look at the class, and I discovered that the class has
> > no class variables (apart from the _instance variable) and an empty
> > constructor.
> > So basicly this should be a static class, with static methods, because
> > no instance is needed for it to work.
> > And the above piece of code will become :
> > PMA_CommonFunctions::backquote($_REQUEST['view']['name'])
> > BTW: If you convert it to a static class, don't forget to replace the
> > $this->method() calls by the static equivalent self::method().
> > BTW2 : you forgot to add the if (! defined('PHPMYADMIN')), check in
> > the beginning of the file, see .
> >  http://wiki.phpmyadmin.net/pma/File_template
> > --
> > Kind regards,
> > Dieter Adriaenssens
More information about the Developers