[Phpmyadmin-devel] Inline JPEG transformation fails

[Marc Delisle]

Le 2012-07-01 10:05, Alex Marin a écrit :
> On Sun, Jul 1, 2012 at 2:20 PM, Marc Delisle <marc at infomarc.info> wrote:
> 
>> Le 2012-07-01 05:16, Alex Marin a écrit :
>>> By permanent code do you mean that the old format will be kept in
>>> pma_column_info for existing transformations and then treated
>>> differently depending on a version number?
>>
>> By permanent code, I meant code that runs every time, instead of asking
>> the phpMyAdmin installer to run a conversion script.
>>
> 
> Yes, I understood that, what I meant was whether there will be some
> if-else sections that treat either the old format in pma_column_info
> ( x_y__t.inc.php ), either the new one ( x_y_t.class.php )?
> And if so, this leads to the next question.
> 
>  > What happens when a
>>> user modifies an existing transformation, will the same old version
>>> be used?
>>
>> We are not responsible for code changes in phpMyAdmin.
> 
> 
> (I am sorry again for the misunderstanding) I meant if the user
> has a table that contains old transformations on columns, and
> he tries to modify that, what happens? If he has transformation 1
> (x_y__transf1.inc.php) and wants to switch to transformation 2,
> will that become x_y__transf2.inc.php or transf2-neutral-string
> in his pma_column_info table?
> 
> To summarize, if we choose the permanent code version, will
> that imply treating both cases and leaving the pma_column_info
> unchanged for the users that have the old format? Otherwise,
> they will have a mixture of old and new transformation entries.
> 
> The only way I see to change them all without a script, would
> be to run a full update (for all of the entries) on their column_info
> table every time (hopefully only the first) an old format
> transformation is found and replace it with the new neutral string.

Let's explore another idea for a moment; if this idea is a dead end,
we'll continue the previous idea.

Couldn't we keep the pre 4.0 values in pma_column_info, treating them as
some kind of neutral string? Then, you could add conditions to load the
correct new transformation.

-- 
Marc Delisle
http://infomarc.info