[Phpmyadmin-devel] PMA_Header class and PDF display

[Marc Delisle]

Le 2012-07-22 06:36, Rouslan Placella a écrit :
> On 07/21/2012 08:00 PM, Marc Delisle wrote:
>> Le 2012-07-21 13:21, Rouslan Placella a écrit :
>>> On 07/21/2012 05:34 PM, Marc Delisle wrote:
>>>> Le 2012-07-21 10:53, Rouslan Placella a écrit :
>>>>> On 07/21/2012 03:21 PM, Marc Delisle wrote:
>>>>>> Le 2012-07-21 10:11, Rouslan Placella a écrit :
>>>>>>> On 07/21/2012 11:40 AM, Marc Delisle wrote:
>>>>>>>> Le 2012-07-13 06:03, rouslan at placella.com a écrit :
>>>>>>>>> Quoting Marc Delisle <marc at infomarc.info>:
>>>>>>>>>
>>>>>>>>>> Hi Rouslan,
>>>>>>>>>> it seems that since the removal of header.inc.php, the display of PDF
>>>>>>>>>> relational schema no longer works.
>>>>>>>>>>
>>>>>>>>> Hi Marc,
>>>>>>>>>
>>>>>>>>> Thanks for letting me know, I will look into fixing this shortly.
>>>>>>>>
>>>>>>>> Hi Rouslan,
>>>>>>>> any news about this?
>>>>>>>>
>>>>>>>
>>>>>>> Hi Marc,
>>>>>>>
>>>>>>> Actually, I'm not sure how to reproduce this issue.
>>>>>>> Could you please help me out with that?
>>>>>>
>>>>>> Sure. Where do you want to start?
>>>>>>
>>>>>
>>>>> Well, I can't remember how this functionality works. So, maybe some
>>>>> steps of how to create and attempt to display the PDF relational schema
>>>>> would help. Thanks
>>>>>
>>>>
>>>> (For further reference, see my book "Mastering phpMyAdmin 3.4", chapter 15.)
>>>>
>>>> To reproduce the bug, it's not necessary to have real relations between
>>>> tables. Moreover, I found out that there are other problems with current
>>>> master with creating the page, so
>>>>
>>>> With QA_3_5
>>>>
>>>> 1. Open a db
>>>> 2. Click on Operations
>>>> 3. Click on "Edit or export relational schema"
>>>> 4. In "Create a page", give a page name and click on Go
>>>> 5. In "Select Tables", pick a table, then click on Save
>>>>
>>>> Now, switch our repo to master
>>>>
>>>> 6. Clear your browser cache
>>>> 7. Go back to Operations>Edit or export relational schema
>>>> 8. Select the created page and bring it on the panel
>>>> 9. In "Display relational schema", ensure you have PDF selected and
>>>> click on Go
>>>> 10. Ask the browser to save the PDF file
>>>> 11. Open it with an editor, you'll see some HTML and js code at the top
>>>> of the file.
>>>>
>>>
>>> Thanks for you help. This issue is now fixed in master. I had also
>>> spotted the issue with deleting a schema, but you managed to push your
>>> patch first :)
>>
>> Testing with commit 3b75241fa9061da4b3ec9949ad72a1644a24f7a3 under
>> Windows Vista under FF 14 or IE 9, I still have the problem.
>>
> 
> My bad, I've committed the wrong hunk. Should be fixed now.

Confirmed. I have applied the fix to all the other relational schema
export formats.

-- 
Marc Delisle
http://infomarc.info