[Phpmyadmin-devel] Bug with properties system

[Alex Marin]

On Wed, Jul 25, 2012 at 2:18 PM, Alex Marin <alex.ukf at gmail.com> wrote:
> I still haven't solved the custom options bug.

I've done a git bisect in order to see when the bug I was talking about was
introduced, but I could only find a range of commits. The last commit that
I can see that does not contain the bug is 0941d2c, and the first one that I
can say for sure it does is a14da7b. Between those two, is a range of 12
commits: 4a74037 .. afb5600, where I cannot see if the bug is present or
not, because the export page is not displayed at all.

The behavior of the bug is as follows:
When trying to export a table or a database, the Export Method div
(#quick_or_custom) does not have a style="display: block" , so it is hidden
from the css and you cannot select the export method. Additionally, all
of the format specific options for all of the export plug-ins are displayed
on the same page.

I can't really seem to figure out why the toggle_quick_or_custom() function
in export.js is not triggered. That seems to be responsible for the hide/show
differences, so fixing that may remove the behavior of the bug.

Rouslan, I saw that the range of commits that prevent me from seeing
the export page are related to introducing the PMA_Header class. I don't
know if this has anything to do with the bug, or if it is something done
earlier that popped up then, but if you have any wild ideas about what
could be wrong, please share :)

--
Alex