[Phpmyadmin-devel] Refactoring tbl_zoom_select.php

[Marc Delisle]

Le 2012-06-08 08:46, Atul Pratap Singh a écrit :
> On Fri, Jun 8, 2012 at 5:37 PM, Marc Delisle <marc at infomarc.info> wrote:
> 
>> Le 2012-06-08 05:20, Atul Pratap Singh a écrit :
>>> On Thu, May 31, 2012 at 4:18 AM, Atul Pratap Singh <
>>> atulpratapsingh05 at gmail.com> wrote:
>>>
>>>>
>>>>
>>>> On Wed, May 30, 2012 at 9:53 PM, Marc Delisle <marc at infomarc.info>
>> wrote:
>>>>
>>>>> Le 2012-05-30 08:20, Atul Pratap Singh a écrit :
>>>>>
>>>>>>>
>>>>>>> Thanks Marc,
>>>>>> I have tried to fix the bug for now. Please check [0].
>>>>>
>>>>> Works fine now, thanks.
>>>>>
>>>>>>
>>>>>> Also, I have noticed that in case of updating the field information
>>>>> using
>>>>>> AJAX (line 91) the class="textfield datetimefield" attribute doesn't
>>>>> work
>>>>>> and a timestamp type field is also displayed with simply an input box.
>>>>>> 1. Open zoom search for a table with at least a field of timestamp
>> type
>>>>>> 2. Select the timestamp type column from dropdown.
>>>>>> 3. Notice simply an input box without datepicker.
>>>>>
>>>>> The bug is not present in upstream QA_3_5 branch. Please use "git
>>>>> bisect" to find its cause, see [0].
>>>>>
>>>>> [0] http://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit
>>>>>
>>>>> Ok, I'll do that.
>>>>
>>>>>  --
>>>>> Marc Delisle
>>>>> http://infomarc.info
>>>>>
>>>>>
>>>>>
>>>>>
>> ------------------------------------------------------------------------------
>>>>> Live Security Virtual Conference
>>>>> Exclusive live event will cover all the ways today's security and
>>>>> threat landscape has changed and how IT managers can respond.
>> Discussions
>>>>> will include endpoint security, mobile security and the latest in
>> malware
>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>>> _______________________________________________
>>>>> Phpmyadmin-devel mailing list
>>>>> Phpmyadmin-devel at lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Atul Pratap Singh
>>>> Senior Undergraduate Student
>>>> Institute Of Technology,
>>>> Banaras Hindu University, Varanasi,
>>>> India.
>>>>
>>>>
>>> Hi Marc,
>>> I noticed that in zoom search the initial display's data labels are not
>>> correct in Chromium browser too.
>>>
>>> Line 533 (tbl_zoom_plot_jqplot.js)
>>>         // under IE 8, the initial display is mangled; after a manual
>>>         // resizing, it's ok
>>>         // under IE 9, everything is fine
>>>         currentChart = $.jqplot('querychart', series, options);
>>>
>>> Should I add 'currentChart.resetZoom();' here to automatically reset the
>>> zoom plot?
>>
>> Hi Atul,
>> I have to do further testing because I currently have a problem under IE
>> 8 with zoom search, in upstream master.
>>
>> Ok Marc.

Atul,
messages to phpmyadmin-devel are delayed so you are CC'd in this reply.

I have fixed the problem I had under IE 8 and 9 (nothing was happening
when selecting a column as a criteria), see commit
f6330a3f1773092d2e07c6da65116436e0c96187.

Then I have tried your suggestion about adding a resetZoom() but it does
not fix the problem under IE 9.

Please CC me in your reply.

-- 
Marc Delisle
http://infomarc.info