[Phpmyadmin-devel] Refactoring: Displaying query results

[Michal Čihař]

Hi

Dne Sat, 30 Jun 2012 12:39:33 +0530
Chanaka Dharmarathna <pe.chanaka.ck at gmail.com> napsal(a):

> I have merged the current master and commit it to my forked copy.

It looks like you did something wrong as you've reintroduced files
which were deleted in master.

> It contains the class behavior of the common.lib.php file in addition to
> the changes in current master.
> 
> But there are several known issues.
> 1. While browse tables with JPEG or PNG mime types I get following warning,
> Warning in ./libraries/DisplayResults.class.php#4582
> strpos() expects parameter 1 to be string, object given

AFAIK already fixed in master.

> 2. When the session expires, after click logout I get following notice,
> Notice in ./libraries/relation.lib.php#35
> Undefined index: controllink

Probably a bug, not necessarily in your changes.

> 3. When incorrect login, following warning raised,
> *Warning* in ./libraries/dbi/mysqli.dbi.lib.php#97
> mysqli_real_connect(): (28000/1045): Access denied for user 'root'@'localhost'
> (using password: YES)

This is correct.

> 4. When insert data for any table, after click Go button, it shows the SQL
> window. (should redirect to Browse window)

Probably not related to your changes.

-- 
	Michal Čihař | http://cihar.com | http://phpmyadmin.cz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20120630/963d1d97/attachment.sig>