[Phpmyadmin-devel] GSOC 2012 - Refactoring: Insert/edit, Privileges, Operations, Structure

Marc Delisle marc at infomarc.info
Sat Mar 24 16:29:44 CET 2012

Le 2012-03-24 11:19, Thilina Buddika Abeyrathna a écrit :

>>> Thilina,
>>> there must be a reason to use the "id" attribute; in this case I could
>>> not find a reason so I removed them.
>>> Hi Marc,
> I didn't mean that removing id attribute. I meant value of id attribute
> (eg. th1, th2). Sorry for the mis communication.

I understood what you meant about the value of id attributes not making
sense (th1, th2, etc); especially when the rest of code does not use
these values.

>>  These class attributes were not used, except for the "action" class
>>> which is used in functions.js, displayMoreTableOpts(). There is no
>>> reason to use the same class for all these 'th', if we do nothing with
>>> the class, so I removed them (keeping "action").
>>> Anyway, thank you for your comment.

My pleasure.

Marc Delisle

More information about the Developers mailing list