[Phpmyadmin-devel] Coding style checks

[Michal Čihař]

Hi

Dne Thu, 3 May 2012 09:41:04 +0300
Alex Marin <alex.ukf at gmail.com> napsal(a):

> Well I've initially tried it this way, but I get a stack trace:
> 
> $ git co master
> $ git pull upstream master
> $ ls -al | grep PMA
> drwxrwxr-x  3 alex alex   4096 May  3 09:32 PMAStandard
> $ phpcs --standard=PMAStandard libraries/import/*
> PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with
> message 'Class PMAStandard_Sniffs_Commenting_FileCommentSniff not
> found' in /home/alex/Documents/work/pma_github/PMAStandard/Sniffs/Commenting/ClassCommentSniff.php:23
> Stack trace:
> #0 /usr/share/php/PHP/CodeSniffer.php(652): include_once()
> #1 /usr/share/php/PHP/CodeSniffer.php(438):
> PHP_CodeSniffer->setTokenListeners('PMAStandard', Array)
> #2 /usr/share/php/PHP/CodeSniffer/CLI.php(551):
> PHP_CodeSniffer->process(Array, 'PMAStandard', Array, false)
> #3 /usr/bin/phpcs(37): PHP_CodeSniffer_CLI->process()
> #4 {main}
>   thrown in /home/alex/Documents/work/pma_github/PMAStandard/Sniffs/Commenting/ClassCommentSniff.php
> on line 23
> alex at ukf-laptop:~/Documents/work/pma_github$
> 
> So my solution was to move that folder under Standards :)
> Am I the only one getting this error?

Well it works fine for me:

$ phpcs --standard=PMAStandard libraries/import/xml.php 

FILE: /home/mcihar/private/phpmyadmin/phpmyadmin/libraries/import/xml.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 158 | WARNING | Line exceeds 85 characters; contains 103 characters
--------------------------------------------------------------------------------

Time: 0 seconds, Memory: 5.25Mb


What phpcs version are you using? Mine is:

$ phpcs --version
PHP_CodeSniffer version 1.3.3 (stable) by Squiz Pty Ltd.
(http://www.squiz.net)

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20120503/4e003cfa/attachment.sig>