[Phpmyadmin-devel] Duplicate CSS print files?

Rouslan Placella rouslan at placella.com
Sat May 12 22:36:08 CEST 2012


On 09/05/12 10:23, Michal Čihař wrote:
> Hi
>
> Dne Sun, 06 May 2012 20:34:05 +0100
> Rouslan Placella<rouslan at placella.com>  napsal(a):
>
>> Just a quick question about the printing-related CSS files that we have
>> in the code base. We have "print.css" which is globally included and
>> then we also have a "theme_print.css.php" file in each theme. So
>> couldn't we just drop the latter? Or am I missing something?
>
> Having only one definitely makes sense. I don't think it's needed for
> themes to override print CSS, so I would go for removing this file from
> themes.

Just filed a pull request for this [0].

Bye,
Rouslan

[0]: https://github.com/phpmyadmin/phpmyadmin/pull/62




More information about the Developers mailing list