[Phpmyadmin-devel] Refactoring insert-edit

Marc Delisle marc at infomarc.info
Sun May 13 11:53:45 CEST 2012

Le 2012-05-13 03:12, Thilina Buddika Abeyrathna a écrit :
> Hi Marc,
> when I'm writing functions for columns of insertForm I need to pass all the
> following parameters to the functions.
> $field, $backup_field, $field_name_appendix, $unnullify_trigger, $tabindex,
> $tabindex_for_value, $idindex, $data
> So function signature is very long which is somewhat ugly, Is it ok to have
> a global parameter array for insert_edit.lib.php file. Does this break the
> refactoring?

Hi Thilina,
I think it's clearer if we see all the parameters in the signature. See
"Split function definitions onto several lines" in [0].

[0] http://pear.php.net/manual/en/standards.funcdef.php

Marc Delisle

More information about the Developers mailing list