[Phpmyadmin-devel] Refactoring insert-edit

[Thilina Buddika Abeyrathna]

On Wed, May 16, 2012 at 6:20 PM, Thilina Buddika Abeyrathna <
thilinaabeyrathna at gmail.com> wrote:

>
>
> On Wed, May 16, 2012 at 6:15 PM, Marc Delisle <marc at infomarc.info> wrote:
>
>> Le 2012-05-16 08:37, Thilina Buddika Abeyrathna a écrit :
>> > On Mon, May 14, 2012 at 10:23 PM, Thilina Buddika Abeyrathna <
>> > thilinaabeyrathna at gmail.com> wrote:
>> >
>> >>
>> >>
>> >> On Mon, May 14, 2012 at 10:09 PM, Marc Delisle <marc at infomarc.info>
>> wrote:
>> >>
>> >>> Le 2012-05-14 08:50, Thilina Buddika Abeyrathna a écrit :
>> >>>> Hi Marc,
>> >>>> There are HTML code block from line 438 in the tbl_change.php
>> >>> file(after my
>> >>>> last commit [0]).  It doesn't mix with much PHP tags. It is somewhat
>> >>>> readable.
>> >>>> Do I need to implement several functions to render this HTML block.
>> Can
>> >>> you
>> >>>> give me a suggestion..
>> >>>>
>> >>>> [0] -
>> >>>>
>> >>>
>> https://github.com/thilinaa/phpmyadmin/commit/9d6c38daf6a98d915a34391bddb987b116be98c0
>> >>>
>> >>> Hi Thilina,
>> >>> The code generating the actions_panel fieldset would benefit from
>> being
>> >>> refactored into one or more functions. The reason is that it's
>> difficult
>> >>> to understand quickly such a long code block.
>> >>>
>> >>> It could become
>> >>> $html_output = PMA_getActionsPanel(...);
>> >>>
>> >>> Thank you for your reply Marc. I'll do like this
>> >>
>> >>
>> >>> -----------
>> >>>
>> >>> By the way, did you consider using a class? Have a look at
>> >>> libraries/Partition.class.php. Then, the calling script uses this
>> syntax:
>> >>>
>> >>> $partition_names = PMA_Partition::getPartitionNames($db, $table);
>> >>>
>> >>> The benefit is that you don't have to bother about function name
>> clashing.
>> >>>
>> >>> Thanks Marc. I'll look at that.
>> >>
>> >
>> > Hi Marc,
>> > Now tbl_change.php script is somewhat readable and maintainable. Still
>> > there is a long if condition in this script. but it is not a very
>> complex
>> > control statement . So do I need to implement a function to separate
>> that
>> > if condition too.
>>
>> Ok. Don't forget this bug, when following this scenario:
>>
>> 1. Browse a table
>> 2. Click the checkbox for two rows
>> 3. At the botton, click the With selected...change link
>
>
> Fixed.


> Ok Marc.
>
>



-- 
Regards.

Thilina Buddika Abeyrathna,
Department of Computer Engineering,
Faculty Of Engineering,
University of Peradeniya,
Sri Lanka.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20120517/48ab58c5/attachment.html>