[Phpmyadmin-devel] Refactoring tbl_zoom_select.php

[Marc Delisle]

Le 2012-05-29 10:46, Atul Pratap Singh a écrit :
> Hi Marc,
> While looking at "tbl_zoom_select.php":-
> 
> Line 191-201
> if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] !=
> 'pma_null')) {
>     $flag = 2;
>     for ($i = 0 ; $i < 4 ; $i++) {
>         if ($inputs[$i] != 'pma_null') {
>             $key = array_search($inputs[$i], $fields_list);
>             $tbl_fields_type[$i] = $fields_type[$key];
>             $tbl_fields_collation[$i] = $fields_collation[$key];
>             $tbl_fields_null[$i] = $fields_null[$key];
>         }
>     }
> }
> 
> As the condition would be true in cases when post param $inputs is set and
> has index 0 or 1 set to some column name. It would mostly happen if a half
> or full filled search form is submitted, but there seems to be no further
> use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type
> gets used afterwards with indexes >= 4.

Atul,
Indeed, $tbl_fields_collation and $tbl_fields_null could be removed.


> I think as a result after the zoom plot is displayed, clicking at "show
> search criteria" doesn't show any previously filled criteria.

Well, I see the chosen two column names, but indeed there seems to be a
bug because at least the operator and value should be displayed.

> I also didn't understand the use of $flag variable.

This must have been some debugging info, you can safely remove it.

> 
> Thanks
> 
> 
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> 
> 
> 
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel


-- 
Marc Delisle
http://infomarc.info

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: OpenPGP digital signature
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20120529/a8c6ba03/attachment.sig>