[Phpmyadmin-devel] jshint errors

[Marc Delisle]

Michal Čihař a écrit :
> Hi all
> 
> I've took some time to look at jshint checks found on our code:
> 
> http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3132/violations/?#jslint
> 
> I've fixed some obvious ones (like missing ;, typecast safe comparing,
> missing radix for parseInt), but there are still many of them. Most of
> them fit into following case:
> 
> 
> - ['strSave'] is better written in dot notation.
> 
> This error is raised to highlight an unnecessarily verbose and
> potentially confusing piece of code. More detailed explanation is at:
> 
> http://jslinterrors.com/a-is-better-written-in-dot-notation/
> 
> 
> - 'type' is already defined. / 'type' used out of scope.
> 
> Most of these come from following constructs:
> 
> if (foo) {
>     var bar = 1;
> } else {
>     var bar = 1;
> }
> alert(bar);
> 
> This is not an issue for javascript (it has no block scope for
> variables), it can be confusing, more details at:
> 
> http://www.jshint.com/docs/#funcscope
> 
> 
> So both are more just matter of coding style rather than real bug and
> can be disabled in jshint. The question is whether we would prefer to
> hide these warnings or fix them.

Another question: which coding style do we prefer, the one with the dot 
notation or with the square brackets?

-- 
Marc Delisle
http://infomarc.info