[Phpmyadmin-devel] jshint errors

Michal Čihař michal at cihar.com
Tue Apr 16 13:36:00 CEST 2013


Dne Tue, 16 Apr 2013 06:33:52 -0400
Marc Delisle <marc at infomarc.info> napsal(a):

> Le 2013-04-16 03:06, Michal Čihař a écrit :
> > I think PMA_messages.strSave is shorter and looks nicer than
> > PMA_messages['strSave'], though I don't have strong opinion on that.
> > Also with messages (the most frequent of this warning in our case) we
> > can be pretty sure we don't use reserved words, so the dot syntax is
> > always safe here.
> I also think the dot notation is better, and here is another reason. 
> When seeing the string in quotes, I always wonder whether the string 
> 'strSave' will be shown to the user.

I've made pull request for this change:


Please review and eventually merge that.

	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20130416/7fff4a0e/attachment.sig>

More information about the Developers mailing list