[Phpmyadmin-devel] Confirmation needed: mod_deflate

[Michal Čihař]

Hi

Dne Wed, 07 Aug 2013 12:30:44 -0400
Marc Delisle <marc at infomarc.info> napsal(a):

> In Export we can ask for a gzip compression. On Apache server with 
> mod_deflate, this *can* produce a doubly-compressed file, depending on 
> the Apache configuration (see [0]).
> 
> We can detect whether mod_deflate is loaded, but not whether it's 
> configured to compress only certain MIME types. The detection is in 
> place, producing bug [1].
> 
> So I suggest to disable gzip compression in the export choices, when we 
> detect the presence of mod_deflate.
> 
> [0] https://sourceforge.net/p/phpmyadmin/bugs/3673/

IMHO this person has broken mod_deflate setup, so rather he should fix
that than we adjust our code to that. We correctly send headers that
the content is compressed, so mod_deflate should not touch that.

So I'm for removing check for mod_deflate, which would fix this:

> [1] https://sourceforge.net/p/phpmyadmin/bugs/4025/

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20130809/01b9f9ed/attachment.sig>