[Phpmyadmin-devel] New PHPCS rule

Hugues Peccatte hugues.peccatte at gmail.com
Fri Dec 20 07:37:19 CET 2013


Hi Michal,

2013/12/19 Michal Čihař <michal at cihar.com>

> Hi
>
> Dne Sun, 15 Dec 2013 20:36:04 +0100
> Hugues Peccatte <hugues.peccatte at gmail.com> napsal(a):
>
> > What would you think about using the "nesting level" sniff please?
> > This sniff permits to detect when there are too much nested levels like:
> > if (...) {
> >     if (...) {
> >         if (...) {
> >             if (...) {
> >                 if (...) {
> >                     ....
> >                 }
> >             }
> >         }
> >     }
> > }
> >
> > This kind of syntax often means that a refactoring is needed or a
> rewrite.
>
> Lot of things which need refactoring are already detected by phpmd
> (though it's only executed nightly as it takes quite a lot of time):


> http://ci.phpmyadmin.net/job/phpMyAdmin/891/pmdResult/


Ok, thanks, I'll look at this and see if new rules seem useful.
I didn't think to look in PMD. In my job, all this work is done by PHPCS
and I didn't know PMD could do the same...

So... I'll look at PMD to see what I could "improve" in the source code.

Thanks !
Hugues.

>
>
> --
>         Michal Čihař | http://cihar.com | http://phpmyadmin.net
>
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics
> Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20131220/7e16e4e7/attachment.html>


More information about the Developers mailing list