[Phpmyadmin-devel] Coding style for error reporting server

[Mohamed Ashraf]

I was not exactly following any coding guidelines other than my own.
However most of the warnings are because I use spaces and the
convention is to use tabs. I can write a vim regex to change the
files.

I believe that the CakePHP checkstyle should be used since while this
is part of the phpmyadmin family of webapps we should respect the
guidelines of the used framework so that we are not fighting an uphill
battle with our own framework over code guidelines.

Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.

Finally to correct those checkstyle warnings I will have to do
multiple pull requests so I was wondering who has commit access to the
repo so that he may accept my pull requests so that I can see my
changes updated in jenkins

On Tue, Jul 30, 2013 at 10:40 AM, Michal Čihař <michal at cihar.com> wrote:
> Hi
>
> I've added error reporting server to Jenkins, but I wonder what coding
> style it should use - the CakePHP one (as it is CakePHP based) or
> phpMyAdmin one (as it is part of phpMyAdmin)?
>
> Currently it does not really match either of them:
>
> https://ci.phpmyadmin.net/job/phpMyAdmin-error-reporting-server/
>
> --
>         Michal Čihař | http://cihar.com | http://blog.cihar.com
>
> ------------------------------------------------------------------------------
> Get your SQL database under version control now!
> Version control is standard for application code, but databases havent
> caught up. So what steps can you take to put your SQL databases under
> version control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>



-- 
Mohamed Ashraf