[Phpmyadmin-devel] Coding style for error reporting server
mohamed.ashraf.213 at gmail.com
Tue Jul 30 11:47:57 CEST 2013
On Tue, Jul 30, 2013 at 11:39 AM, Michal Čihař <michal at cihar.com> wrote:
> Dne Tue, 30 Jul 2013 11:37:51 +0200
> Michal Čihař <michal at cihar.com> napsal(a):
>> Dne Tue, 30 Jul 2013 11:31:15 +0200
>> Mohamed Ashraf <mohamed.ashraf.213 at gmail.com> napsal(a):
>> > I was not exactly following any coding guidelines other than my own.
>> > However most of the warnings are because I use spaces and the
>> > convention is to use tabs. I can write a vim regex to change the
>> > files.
>> > I believe that the CakePHP checkstyle should be used since while this
>> > is part of the phpmyadmin family of webapps we should respect the
>> > guidelines of the used framework so that we are not fighting an uphill
>> > battle with our own framework over code guidelines.
>> > Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
>> Currently it's using CakePHP style.
> ... you can actually see or change this in build.xml
who has commit access to the repo other than you? I was wondering if
you could add one or both my mentors on this list so that they can
accept my pull requests.
More information about the Developers