[Phpmyadmin-devel] remove "exit" on Dia_Relation_Schema.class.php

Michal Čihař michal at cihar.com
Thu Jun 13 09:07:13 CEST 2013


Hi

Dne Wed, 12 Jun 2013 23:51:30 +0800
adam <adamgsoc2013 at gmail.com> napsal(a):

> On the UT pull request, https://github.com/phpmyadmin/phpmyadmin/pull/419
> 
>  I found that the source code
> https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/schema/Dia_Relation_Schema.class.php#L766
> 
> the "exit" statement will make the UT exit unexpectedly, can we remove "exit" ?

Most likely the exit is there for a reason, have you tested whether the
code still works when removing the exit?

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20130613/55a5ef56/attachment.sig>


More information about the Developers mailing list