[Phpmyadmin-devel] Transferring some code in sql.php into parser/analyser

[Michal Čihař]

Hi

Dne Thu, 13 Jun 2013 11:51:18 +0530
Supun Nakandala <supun.nakandala at gmail.com> napsal(a):

> I am refactoring sql.php and I see some places where parsing of the sql
> query done in the sql.php (eg line 445). I am planning to crate new methods
> for these tasks in sqlparser.lib.php and call them from sql.php . I would
> like to know the opinion from the developers about this approach.

Actually it would be better if those regular expressions would use
parser because it would give it more tolerance to comments in SQL.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20130613/01e2840e/attachment.sig>