[Phpmyadmin-devel] Identifying a call to a stored procedure

Marc Delisle marc at infomarc.info
Wed Jun 19 14:44:36 CEST 2013


Supun Nakandala a écrit :
> On Wed, Jun 19, 2013 at 4:32 PM, Marc Delisle <marc at infomarc.info> wrote:
> 
>> Supun Nakandala a écrit :
>>> On Tue, Jun 18, 2013 at 5:43 PM, Marc Delisle <marc at infomarc.info>
>> wrote:
>>>> Supun Nakandala a écrit :
>>>>> Hi devs,
>>>>>  I am refactoring sql.php and I realized in line 389 of file the check
>>>> for
>>>>> a call to a stored procedure is done by using regexp. I would like to
>>>> know
>>>>> is it ok to keep it like that or is there any better approach to handle
>>>>> that.
>>>>>
>>>>> Regards Supun.
>>>> Hi Supun,
>>>> the better approach is to move this test to the SQL analyzer, like you
>>>> did a few days ago for other cases.
>>>>
>>>> Hi Marc,
>>> I checked PMA_SQP_analyze() method with a test query calling a stored
>>> procedure. But it didn't returned any information. Can you guide me how
>> to
>>> implement the required behavior in PMA_SQP_analyze() method such that it
>>> can identify a call to a stored procedure.
>> Hi Supun,
>> first I must ask whether you passed your query to PMA_SQP_parse() and
>> used the output to feed PMA_SQP_analyze().
>>
> 
> Hi Marc,
> Yes I did that way.

In sqlparser.lib.php there are a few DEBUG comments that deactivate some 
echo statements. When activated, these will show you what the parser did 
  up to this point; this should show you what's going on in the parsing 
phase.

-- 
Marc Delisle
http://infomarc.info




More information about the Developers mailing list