[Phpmyadmin-devel] fixing code style warnings by changing messages?
Bin Zu
xmujay at gmail.com
Sat Jun 22 16:43:00 CEST 2013
Hi Marc,
>Hi,
>I think we had this discussion, but if so, I could not find the outcome
>in [0].
>
>Is it a good idea to wrap long messages like Bin is doing in [1], to fix
>code style warnings? I believe that this would produce new messages for
>our translators.
>
>[0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers
>
>[1]
>https://github.com/xmujay/phpmyadmin/commit/239067f35ff67bc2d707054ed17bc490e6ecef6b#L0L794
In fact, I don't change the messages. I just split the long message(one line) to serveral line and join them. so the message are same as before.
Because the messages are too long.
just like this:
- __('When Host table is used, this field is ignored and values stored in Host table are used instead.')
+ __(
+ 'When Host table is used, this field is ignored '
+ . 'and values stored in Host table are used instead.'
+ )
please advise~thanks
Bin Zu
More information about the Developers
mailing list