[Phpmyadmin-devel] About image sprites

[Isaac Bennetch]

On Thu, Jun 27, 2013 at 2:44 AM, Rouslan Placella <rouslan at placella.com> wrote:
> On 06/27/2013 05:35 AM, Isaac Bennetch wrote:
>> Hello,
>>
>> I'm reviewing Kasun's pull request for the search and replace
>> functionality and realize I'm not sure what the procedure is for
>> adding new images.
>>
>> The wiki documentation [1] is pretty thorough except for one question;
>> when do we actually run the script? My understanding is that any time
>> a new icon is added, the developer would run the generate-sprites
>> script and commit the resulting sprite file. Is that correct?
>>
>> 1 - http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage
>
> Yes, your understanding is correct. To be comprehensive, an icon will be
> picked up even if you don't run the script. More important is to run the
> script after an icon is modified or deleted.
>
> Bye,
> Rouslan

Rouslan, thanks for the explanation!

Kasun, do you have the appropriate image tools (ImageMagick and
pngcrush) to run the generate-sprites script?