[Phpmyadmin-devel] PMA_SQPdata_reserved_word list is invalid

[Michal Čihař]

Hi

Dne Mon, 20 May 2013 13:58:02 -0400
Marc Delisle <marc at infomarc.info> napsal(a):

> Michal Čihař a écrit :
> > Hi
> > 
> > Dne Mon, 20 May 2013 11:55:26 -0400
> > Marc Delisle <marc at infomarc.info> napsal(a):
> > 
> >> We should probably review the list of reserved words to ensure that they 
> >> correspond exactly to the list(s) in the MySQL manual.
> > 
> > Or at least create separate list for the warning if no other fix is
> > found for 4.0.
> > 
> >> The downside of this would be that the syntax highlighter (not the one 
> >> when editing a query) would no longer highlight these words, but to fix 
> >> this, the analyzer needs serious work.
> > 
> > Are you sure it would break only highlighting? For me the SQL
> > parser/analyzer was piece of code I never wanted to touch too much :-).
> 
> git grep reservedWord
> 
> shows a few other places to check

Well the question I meant was rather: Will changing this list affect
other uses of the analyzer? It's used to detect type of queries and
maybe some other stuff (adding LIMIT clause?).

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20130521/44be86d2/attachment.sig>