[Phpmyadmin-devel] Clarification on Design of PMA_RecentFavoriteTable Class

Chanaka Dharmarathna pe.chanaka.ck at gmail.com
Wed Apr 16 18:02:52 CEST 2014


It seems like, the latest PMA_RecentFavoriteTable is trying to behave as
singleton design pattern. Is that a requirement ? I mean is there any
reason for making it singleton ? By the way, there is good possibility to
create new instances again and again with current logic.

And the class has $table_type instance variable and more. Isn't it risky
behaviour to share a static instance throughout the web server, which has
instance variable which used in functions of that instance ?

Regards !
Chanaka Dharmarathna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140416/bcd87ad8/attachment.html>

More information about the Developers mailing list