[Phpmyadmin-devel] Confirm navigation for non ajax reloads

[Minhaz A V]

Atul, I get that, that is the normal workflow, but this is a new feature
this must go to master branch when the pull is merged like it happened this
time.
Although I have a feeling that *matching the values of input fields against
the values they were loaded with would be a good solution to this*, rather
than checking if length of visible input.text fields, i think rather than
merging this directly to master, in pma main repo if it is merged with some
other branch and other members have confirmed no bugs exist, it can be
merged to master.




Minhaz
cistoner.org


On Tue, Apr 22, 2014 at 5:23 PM, Atul Pratap Singh <
atulpratapsingh05 at gmail.com> wrote:

> On Tue, Apr 22, 2014 at 5:16 PM, Minhaz A V <minhazav at gmail.com> wrote:
>
>> Hi,
>> I see the code is showing behavior other than expected behavior at
>> certain sections.
>> I was thinking this code could be modified to check if any input field
>> was changed from the value it was loaded with if some user try to perform
>> ajax operation or any operation that triggers onbeforeunload event.
>>
>> AJAX code will go well in ajax.js while for onbeforeunload section, I'd
>> add an event listener to it in common.js as mentioned by Atul.
>>
>> If you guys feel this feature should not exist in pma, I'd stop here on
>> this. Kindly let me know by night or I'll start writing :D, as I feel this
>> feature should be there.
>>
>> Also, is it possible to add a branch for this in pma, till this feature
>> is working well or I should come up with a whole working one in my fork
>> before I pull.
>>
>> About a separate branch, it is not meant to be created in main PMA
> repository, instead you can create a new branch out of master in your local
> repo and push it to your github account for public review, then you can
> open a pull request from your branch to the main PMA repo's master branch
> when it's all done.
>
>
> --
> Atul Pratap Singh
> http://blog.atulsisodia.in/
>
>
> ------------------------------------------------------------------------------
> Start Your Social Network Today - Download eXo Platform
> Build your Enterprise Intranet with eXo Platform Software
> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
> Get Started Now And Turn Your Intranet Into A Collaboration Platform
> http://p.sf.net/sfu/ExoPlatform
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140422/79c51c31/attachment.html>