[Phpmyadmin-devel] hhvm unit test

[Hugues Peccatte]

2014-08-19 8:00 GMT+02:00 Michal Čihař <michal at cihar.com>:

> Hi
>
> Dne Mon, 18 Aug 2014 21:23:56 +0200
> Hugues Peccatte <hugues.peccatte at gmail.com> napsal(a):
>
> > I'm currently experiencing an issue with hhvm, see
> > https://travis-ci.org/phpmyadmin/phpmyadmin/builds/32882088
> > As you can see, all unit tests are ok, except for tests of stristr with
> > hhvm.
> > It seems that the hhvm version used on Travis is "HipHop VM 3.2.0".
> >
> > Does anyone have hhvm (this version or another) please, could run phpunit
> > on test/libraries/PMA_String_Compare_test.php and give me a feedback?
>
> It indeed does not work, I've reported it here:
>
> https://github.com/facebook/hhvm/issues/3520
>
> PS: We don't seem to use this functionality in our code, so maybe
> support for this could be removed from PMA_String?
>
> --
>         Michal Čihař | http://cihar.com | http://phpmyadmin.net


Hi,

We're using it, see
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/DisplayResults.class.php#L3893
(many uses in this file).
But, as Marc suggested, we may remove it from PMA_String for now.

Hugues.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140819/41141157/attachment.html>