[Phpmyadmin-devel] use of count() in for loops

[Marc Delisle]

Minhaz A V a écrit :
> Hi,
> Do I have to add it to bug tracker first or I can directly send the pull
> request!
> 

Hi,
(Please use bottom-posting on this list).

This is not a bug, it's a speed improvement.

> 
> Minhaz
> cistoner.org
> 
> 
> On Sun, Feb 16, 2014 at 8:55 PM, Hugues Peccatte
> <hugues.peccatte at gmail.com>wrote:
> 
>> Hi,
>>
>> 2014-02-14 23:21 GMT+01:00 Minhaz A V <minhazav at gmail.com>:
>>
>> Hi,
>>> I was going through the codes and at many places I found use of *count()
>>> *inside the *for* statement.
>>> I think statements like
>>>
>>> *for($i = 0; $i < count($arr); $i++)*
>>> should be converted with statements like
>>>
>>> *$len = count($arr);*
>>> *for($i = 0; $i < $len; $i++)*
>>>
>>> this would help us speed up the whole phpMyAdmin system.
>>>
>> You're right. The second write is better. But as you said in your second
>> mail, we try to avoid the first syntax.
>> If you find the use of count into a loop, please fix it a send a pull
>> request.
>>
>> Thanks,
>> Hugues.
>>



-- 
Marc Delisle
http://infomarc.info | http://phpmyadmin.net