[Phpmyadmin-devel] #4040 Fatal error while resetting settings

[Marc Delisle]

Smita a écrit :
> Hi,
> 
> I was looking into the bug http://sourceforge.net/p/phpmyadmin/bugs/4040/ ,
> I am able to reproduce it, I get the fatal error in apache error log saying
> "
>  PHP Fatal error:  Call to a member function getPath() on a non-object in
> /var/www/phpmyadmin/libraries/Util.class.php on line 184"
> Though there is no error shown on UI, at the user interface I get the
> expected message "Configuration has been saved" .
> Also the error comes only when active theme is "pmahomme". Because in the
> code we are unsetting the SESSION['PMA_Theme_Manager'] and
> $_SESSION['PMA_Theme'] if the current theme is not "original".
> 
> So I have a Question:
> Currently when we reset the settings, active theme doesn't reset to default
> one, which is "pmahomme", it remains same. Is it the correct behaviour or
> should it reset the current theme to default one?
> 
> So if we don't need to reset the theme to default one, then just removing
> the unset statement which is unsetting themes session variables should fix
> the issue. Otherwise instead of unsetting,  setting the themes session
> variables to default theme will fix the issue.
> 
> Please let me know if any concerns, so that I can proceed with fixing this
> bug.
> 
> Thanks and Regards
> Smita Kumari

Smita,
I'm not sure that it will help, but when someone chooses a theme 
different than the default one, a persistent cookie named "pma_theme" is 
sent to the browser. Therefore, this user choice should be respected.

-- 
Marc Delisle
http://infomarc.info | http://phpmyadmin.net