[Phpmyadmin-devel] Regarding RFE #908

[Marc Delisle]

Le 2014-07-08 08:31, Marc Delisle a écrit :
> Le 2014-07-08 07:52, Ashutosh Dhundhara a écrit :
>> Hi,
>>
>> I have got some ideas regarding RFE #908
>> <http://sourceforge.net/p/phpmyadmin/feature-requests/908/> (Improvements for
>> the table editor (index creation)).
>>
>> *_1. Making Column section on 'Add Index' dialog sort-able._*
>> With this user will be able to change the order of columns in case of
>> composite keys.
>>
>> *_2. Displaying a dialog box when multiple columns for same type of
>> index are selected on 'Create table' page._*
>> This dialog will have two options: 'Create new' and 'Create composite'.
>> - 'Create new' will allow user to create a new single column key. (Table
>> can have only one Primary key)
>> - 'Create composite' will allow user to add that column to a existing
>> key (to be created) and sort the order of columns.
>>
>> Will this implement this feature request?
> 
> Hi Ashutosh,
> first, the feature request says "If I add two indexed fields to a
> table"; remember that this action can be done on initial table creation,
> and when adding columns on an existing table.
> 
> About your suggestion #1, are you talking about the dialog that appears
> after choosing table Structure > Indexes > Create an index on x columns
> ? If so, the user can already choose the columns in the correct order;
> so you want to help the user change his mind when creating the index?
> 
> I am not against, but this would be more useful when _editing_ an index.
> Or it can be done in both situations.
> 
> About your suggestion #2, if the user chose PRIMARY in the selector for
> two columns, it makes no sense to show this additional dialog (unless
> you want him to confirm that the PRIMARY will be composite) but it makes
> sense to allow column sorting.
> 
> If he chose UNIQUE or INDEX, instead of "Create new" I would say "Create
> single-column indexes". The other message could be "Create a composite
> index" but do you suggest that this choice opens the already-existing
> Edit index dialog, which you would prefill with the chosen column names?
> 
> As per the feature request, the default choice should be to create
> single-column indexes.
> 
> As I told to Smita for her project, it's better to reuse existing
> interfaces, in this case the existing index editor.
> 

Another issue: let's say the user is adding columns a, b and c, and
wants to create a composite index on a + b and a single-index on c. User
chose "INDEX" for all columns. Will your interface handle this case?

-- 
Marc Delisle | phpMyAdmin