[Phpmyadmin-devel] Regarding Correcting Coding Standard Violations

Michal Čihař michal at cihar.com
Fri Jun 6 14:00:20 CEST 2014


Dne Fri, 6 Jun 2014 10:13:15 +0530
Dhananjay Nakrani <dhananjaynakrani at gmail.com> napsal(a):

> I created a pull [0] for the php error reporting functionality.
> phpmyadmin-bot shows so many coding standard violations.
> Should I correct them by pushing the changes as a separate commit?
> OR
> Do I need to redo all the previous commits?

It's okay to fix that in additional commit, but you can also fix the
individual commits (git rebase -i can help you with that).

	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140606/ed0fcc09/attachment.sig>

More information about the Developers mailing list