[Phpmyadmin-devel] Regarding Bug #4302

[Atul Pratap Singh]

On 3/2/14, Atul Pratap Singh <atulpratapsingh05 at gmail.com> wrote:
> On 3/1/14, Hugues Peccatte <hugues.peccatte at gmail.com> wrote:
>> Hi,
>>
>> 2014-03-01 12:49 GMT+01:00 Marc Delisle <marc at infomarc.info>:
>>
>>> Le 2014-02-28 09:42, Omer Jer a écrit :
>>> > Hi,
>>> > Refreshing the Table Export page causes this bug.
>>> > After looking at the code I got that the bug is due to the missing of
>>> > this parameter '$_REQUEST['single_table']' in the
>>> > display_export.inc.php
>>> >
>>> > The only way to fix it is (as I suppose) to append the
>>> > single_table='true' in the url when the users first come to the Table
>>> > Export page.
>>>
>>> But single_table is already set to true on the table Export menu link.
>>>
>>
>> But the fact is that he seems to be right...  After refreshing the page,
>> the
>> single_table input is no longer in the form...
>> His fix is working for me.
>>
> It is a class of bugs, whenever a parameter is omitted from being
> added to selflink in microhistory, and we refresh.
> I commented on a related fix by J.M. at [0]
>
> Alternative solution to what is mentioned in the comment: we could
> consider adding an if condition for each possible param after looking
> for the param names in [1] (look for ['args']['....']), as is already
> done for 'viewing_mode' in [0].
>
Done in https://github.com/phpmyadmin/phpmyadmin/commit/15539d4d7df53ef8546497e05805baa0204f3528


Regards
-- 
Atul Pratap Singh
http://blog.atulsisodia.in/