[Phpmyadmin-devel] Changes in SOB checking in pull requests
madhura.cj at gmail.com
Wed Mar 19 19:16:14 CET 2014
On Wed, Mar 19, 2014 at 11:39 PM, Michal Čihař <michal at cihar.com> wrote:
> Dne Thu, 13 Mar 2014 11:54:25 +0100
> Michal Čihař <michal at cihar.com> napsal(a):
> > Source code for the hook is in our scripts repo:
> > https://github.com/phpmyadmin/scripts/tree/master/hooks
> > This has advantage that authors get direct feedback mentioning what is
> > wrong and also these comments are directly visibly in pull request.
> I've just added check for tab characters in the code to the same hook,
> the sample message it has fired can be seen here:
> That's great!, something I always wanted. Thanks Michal.
Another area for improvement would be to warn about trailing white spaces
Thanks and Regards,
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Developers