[Phpmyadmin-devel] Changes in SOB checking in pull requests

[Madhura Jayaratne]

On Wed, Mar 19, 2014 at 11:39 PM, Michal Čihař <michal at cihar.com> wrote:

> Hi
>
> Dne Thu, 13 Mar 2014 11:54:25 +0100
> Michal Čihař <michal at cihar.com> napsal(a):
>
> > Source code for the hook is in our scripts repo:
> >
> > https://github.com/phpmyadmin/scripts/tree/master/hooks
> >
> > This has advantage that authors get direct feedback mentioning what is
> > wrong and also these comments are directly visibly in pull request.
>
> I've just added check for tab characters in the code to the same hook,
> the sample message it has fired can be seen here:
>
>
> https://github.com/ganeshaditya1/phpmyadmin/commit/396ac695d439b0ac37f9c7c7e839a8b19ed775b5#commitcomment-5732466
>
> That's great!, something I always wanted. Thanks Michal.
Another area for improvement would be to warn about trailing white spaces
:)

-- 
Thanks and Regards,

Madhura Jayaratne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140319/80920fc1/attachment.html>