[Phpmyadmin-devel] Changes in SOB checking in pull requests

Isaac Bennetch bennetch at gmail.com
Wed Mar 19 22:50:23 CET 2014

On 3/19/14 2:09 PM, Michal Čihař wrote:
> Hi
> Dne Thu, 13 Mar 2014 11:54:25 +0100
> Michal Čihař <michal at cihar.com> napsal(a):
>> Source code for the hook is in our scripts repo:
>> https://github.com/phpmyadmin/scripts/tree/master/hooks
>> This has advantage that authors get direct feedback mentioning what is
>> wrong and also these comments are directly visibly in pull request.
> I've just added check for tab characters in the code to the same hook,
> the sample message it has fired can be seen here:
> https://github.com/ganeshaditya1/phpmyadmin/commit/396ac695d439b0ac37f9c7c7e839a8b19ed775b5#commitcomment-5732466

Great work Michal. These improvements are the "little things" that make
development and code checks so much easier over time. It's great to see
these checks improve our tests and coverage.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 882 bytes
Desc: OpenPGP digital signature
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140319/7a1098aa/attachment.sig>

More information about the Developers mailing list