[Phpmyadmin-devel] Changes in SOB checking in pull requests

Michal Čihař michal at cihar.com
Thu Mar 20 08:44:22 CET 2014


Dne Thu, 20 Mar 2014 08:38:25 +0100
Michal Čihař <michal at cihar.com> napsal(a):

> Hi
> Dne Thu, 20 Mar 2014 12:45:19 +0530
> Sastry aditya <ganeshaditya1 at gmail.com> napsal(a):
> > I am using sublime editor to write my code and after I got that error
> > message I checked to see if I am using tabs for indentation and turns out
> > that I am not using tabs for indentation and also just to be sure I
> > selected all my source code and used this option in sublime that
> > automatically replaces tabs with 4 spaces and re-uploaded the patch.
> > 
> > Could you please check it out once, seems to me that there is some bug in
> > this system at your end.
> You have tabs used in js/columndelete.js, so I see nothing wrong that
> the bot is complaining here.

... I've now improved the bot to mention offending files and also to
avoid duplicate comments on a commit.

	Michal Čihař | http://cihar.com | http://phpmyadmin.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20140320/d67b44ba/attachment.sig>

More information about the Developers mailing list