[phpMyAdmin Developers] PHPMYADMIN constant check

Dan Ungureanu udan1107 at gmail.com
Sat Aug 1 22:10:13 CEST 2015


I see the following snippet in almost every file of phpMyAdmin, but I 
believe that in most files it is not required.

     if (! defined('PHPMYADMIN')) {

I think that it was used to prevent execution if a direct request was 
made to the file, but nowadays, most files contain only procedural code. 
In most cases, with or without this, the code behaves the same so it may 
be considered dead code.

I propose removing it where possible. What is your opinion?

Best regards,
Dan Ungureanu

More information about the Developers mailing list