[Phpmyadmin-devel] Updating metro theme for PMA v4.4

[Madhura Jayaratne]

On Thu, Mar 19, 2015 at 3:18 PM, Kushagra Pandey <kushagra4296 at gmail.com>
wrote:

>
>
> On Thu, Mar 19, 2015 at 7:55 AM, Madhura Jayaratne <madhura.cj at gmail.com>
> wrote:
>
>>
>>
>> On Wed, Mar 18, 2015 at 10:56 PM, Kushagra Pandey <kushagra4296 at gmail.com
>> > wrote:
>>
>>> Hi Issac
>>>
>>> On Wed, Mar 18, 2015 at 7:31 PM, Isaac Bennetch <bennetch at gmail.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On 3/18/15 9:58 AM, Isaac Bennetch wrote:
>>>> > Hi Madhura,
>>>> >
>>>> > On 3/18/15 6:26 AM, Madhura Jayaratne wrote:
>>>> >>
>>>> >>
>>>> >> On Fri, Mar 13, 2015 at 3:03 PM, Madhura Jayaratne <
>>>> madhura.cj at gmail.com
>>>> >> <mailto:madhura.cj at gmail.com>> wrote:
>>>> >>
>>>> >>     Hi all,
>>>> >>
>>>> >>     As per the discussion on the recent team meeting [1] I have
>>>> started
>>>> >>     working on updating metro theme to be compatible with phpMyAdmin
>>>> 4.4
>>>> >>     and you can find what I've done so far at [2]. I am basically
>>>> going
>>>> >>     through all the commits that had some style/image change since
>>>> 2013
>>>> >>     and adapting them to metro them to make sure nothing is missed.
>>>> >>
>>>> >>     [1] https://wiki.phpmyadmin.net/pma/2015-03_Meeting#Themes
>>>> >>     [2] https://github.com/madhuracj/metro/commits/master
>>>> >>
>>>> >>     --
>>>> >>     Thanks and Regards,
>>>> >>
>>>> >>     Madhura Jayaratne
>>>> >>
>>>> >>
>>>> >> Hi devs,
>>>> >>
>>>> >> I think the theme is in a reasonable state now. Would appreciate if
>>>> you
>>>> >> could get the theme from [1] and try it with phpMyAdmin version 4.4
>>>> (in
>>>> >> Beta) and give feedback.
>>>> >>
>>>> >> [1] https://github.com/madhuracj/metro/
>>>> >
>>>> > Great progress! Very nice job. I have some thoughts:
>>>> >
>>>> > * On the login page, there's a large 'a' displayed. I don't remember
>>>> > much about the metro theme from times past, so maybe the original
>>>> > designer had some motivation for it, but I'd rather see a p or our
>>>> logo
>>>> > or something there.
>>>>
>>> Seems somehow IcoMoon font didn't load on your system. Kindly refresh.
>>> It's a user icon there.
>>>
>>>> >
>>>> > * On the main page, I see something extra after the Theme selection
>>>> > dropdown: "Scheme: win" do you have thoughts about that? I do not see
>>>> it
>>>> > with pmahomme
>>>> >
>>>> > * From a table structure page, under the list of columns there's the
>>>> > list of actions; Print view, Propose table structure, etc. The spacing
>>>> > between the first three (Print view, Propose table structure, and
>>>> Track
>>>> > table) look okay, but then the rest seem to be squished closer
>>>> together.
>>>> > This is particularly noticeable because the 'e' from "Track table"
>>>> seems
>>>> > to be slightly covered by the icon for "Move columns"
>>>> >
>>>> > * The green color used, for instance, when showing a successful query
>>>> > "Showing rows 0 - 8 (9 total, Query took 0.0009 seconds.)" is a bit
>>>> > bright for the tone of the rest of the theme. It's currently #01A31C,
>>>> > perhaps something like #77BB77 would fit better.
>>>> >
>>>> > * The navigation icons, Home, Log out, phpMyAdmin documentation, MySQL
>>>> > documentation, and Reload navigation frame -- none of the icons are
>>>> > appearing for me. For Home I see an exclamation point, and the rest of
>>>> > them have the appearance of unsupported unicode characters. Is this a
>>>> > problem with my Firefox?
>>>>
>>> No such issues on my Chrome.
>>>
>>>> >
>>>> > Again, great work.
>>>> > ~isaac
>>>> >
>>>>
>>>> Also, for some reason I don't see a tool tip for the MySQL documentation
>>>> when I hover over that icon, but I do see it with the other two themes.
>>>>
>>> Well, other icons <a> tag have a title attribute, but the MySQL
>>> documentation <a> is missing the title attribute. Other themes are showing
>>> the tooltips on the <img> tag (child of <a> tag), but this theme is showing
>>> the <a>'s title attribs. Should I add the 'title' attrib to this <a> in
>>> phpmyadmin code?
>>>
>>
>> Hi Kushagra,
>>
>> You may submit a pull request against QA_4_4 branch. Also, since the
>> layout seems to be ok now, you are most welcome to work on improving the
>> theme.
>>
>> Hi Madhura, I have submitted a pull request here:
> https://github.com/phpmyadmin/phpmyadmin/pull/1595
> Let me know if something needs to be changed. I changed "documentation" to
> "MySQL Documentation" for clarity.
> I have been little occupied with trying something to do (bug fix/feature
> implementation) for GSOC - so once I get free, I will contribute to the
> theme, as I guess contribution to theme will not be counted as one for GSOC.
>
> AFAIK, it is not counted unless your GSoC project is in the same area.
Others can verify this.


-- 
Thanks and Regards,

Madhura Jayaratne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20150319/c80b7b9c/attachment.html>