[phpMyAdmin Developers] Namespaces and autoloading

[Hugues Peccatte]

Le lun. 5 oct. 2015 à 22:07, Marc Delisle <marc at infomarc.info> a écrit :

> Le 2015-10-05 13:46, Hugues Peccatte a écrit :
> > Le sam. 3 oct. 2015 à 21:13, Hugues Peccatte <hugues.peccatte at gmail.com
> > <mailto:hugues.peccatte at gmail.com>> a écrit :
> >
> >     Le sam. 3 oct. 2015 à 12:46, Remi Collet <remi at fedoraproject.org
> >     <mailto:remi at fedoraproject.org>> a écrit :
> >
> > Le 03/10/2015 09:14, Hugues Peccatte a écrit :
> >> Dear developers,
> >
> >> The following PR is trying to use namespaces and autoloading for
> >> pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR
> >> seems to be quite stable now. As almost all PHP files had been
> >> updated, this is a huge work to test all cases, all
> > configurations,
> >> all features. Would it be possible to have some testers please?
> >
> > At a first (and quick) look
> >
> > PMA\libraries namespace seems a bit uggly...
> >
> > 'libraries' is a directory, only a layout artefact, why should it be
> > part of the namespace.
> >
> > Per PSR-4 definition, namespace should be
> >
> >         "The fully qualified class name MUST have a top-level
> >         namespace name, also known as a "vendor namespace".
> >
> > So, is PMA the "vendor" ? it seems.
> >
> >         "The fully qualified class name MAY have one or
> >         more sub-namespace names."
> >
> > I think a second level is needed (but again, "libraries" seems
> > strange
> > to me... but perhaps only to me)
> >
> > Notice: it will be nice to move all 3rd party lib to a separate
> > directory (will make downstream work much easier)
> >
> > Remi.
> >
> >> Thanks to Marc and Isaac who already did a lot of tests. And
> > thanks
> >> to new testers.
> >
> >> Have a nice day,
> >
> >> H.
> >
> >
> >> _______________________________________________ Developers mailing
> >> list Developers at phpmyadmin.net <mailto:Developers at phpmyadmin.net>
> >> https://lists.phpmyadmin.net/mailman/listinfo/developers
> >
> >
> >
> >
> >     Hi Remi,
> >
> >     Thanks for your feedback.
> >
> >     Why does PMA\libraries seem ugly?
> >     OK, "libraries" is a directory, but all classes are not in
> >     libraries, that's why I decided to set the vendor namespace (PMA) at
> >     project root. If needed, we can imagine to have a specific vendor
> >     namespace for libraries, but why and which one?
> >
> >     I saw your notice about moving 3rd party libraries. But I think this
> >     is not the subject here.
> >     In fact, this is a really huge work that had been done (at least, I
> >     think…) and I think that a lot of subjects could be discussed here.
> >     That's why I'ld like to focus on test and errors.
> >
> >     Had you some time to test the PR?
> >
> >     Thanks,
> >     H.
> >
> >
> > Hi,
> >
> > Any other feedback please? Or maybe we can merge…
>
> Seems ready indeed.
>
>
> --
> Marc Delisle | phpMyAdmin
>

Hi,

Thanks for your answer Marc.
I'll merge again master in the branch and then it should be OK. Do you want
me to do the merge (by GitHub)?

H.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.phpmyadmin.net/pipermail/developers/attachments/20151006/16f3441c/attachment.html>