[phpMyAdmin Developers] templates validation

[Hugues Peccatte]

Le lun. 31 août 2015 à 10:06, Michal Čihař <michal at cihar.com> a écrit :

> Dne Sun, 30 Aug 2015 13:45:14 +0000
> Hugues Peccatte <hugues.peccatte at gmail.com> napsal(a):
>
> > Le dim. 30 août 2015 à 15:11, Marc Delisle <marc at infomarc.info> a écrit
> :
> >
> > > Hi,
> > > please have a look at
> > >
> > >
> https://github.com/phpmyadmin/phpmyadmin/commit/993134cacd61add9f049eee96a53943a87c99342
> > >
> > > Can we have a validation when a template is rendered, to ensure we
> don't
> > > forget passing some of the parameters?
> > >
> > > Probably too late for 4.5, but at least for 4.6?
> > >
> > > --
> > > Marc Delisle | phpMyAdmin
> > >
> >
> > Hi,
> >
> > What do you mean by "validation"? Is it a code review or a message by
> > Template class that tells you that a variable / parameter is missing?
>
> The best would be if we can make the template layer fail on missing
> variable and test all templates in testsuite.
>
>
> --
>         Michal Čihař | http://cihar.com | http://phpmyadmin.net
>
> _______________________________________________
> Developers mailing list
> Developers at phpmyadmin.net
> https://lists.phpmyadmin.net/mailman/listinfo/developers


Hi,

I agree with this last comment.
Should we review our position regarding template unit tests?

H.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.phpmyadmin.net/pipermail/developers/attachments/20150905/eeda7404/attachment.html>