[phpMyAdmin Developers] sql-parser status

[Remi Collet]

Howdy phpMyAdmin devs.

Looking at phpMyAdmin 4.5.0rc I notice the new "sql-parser" library.

=> No bundled library rules

I think this is:
https://github.com/dmitry-php/sql-parser

But this one seems stalled (June) while the version in phpMyAdmin 4.5
have more recent changes (August).

Questions:
- as dmitry-php/sql-parser is registered on packagist, will it be
updated soon ?
- a "rc" release could be nice (in sync with phpMyAdmin RC)
- a "stable" release could be nice (perhaps in sync with phpMyAdmin 4.5)
- why not use a git sub-modules to keep change easy ?

Current master version submitted to review for Fedora [1] to be usable
from phpMyAdmin, but of course, need to be updated first.

And vendor_config.php also need to be updated (patch attached)


Regards,
Remi.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1262807
-------------- next part --------------
diff --git a/libraries/common.inc.php b/libraries/common.inc.php
index 83ff2cc..ea15788 100644
--- a/libraries/common.inc.php
+++ b/libraries/common.inc.php
@@ -1069,7 +1069,7 @@ if (! defined('PMA_MINIMUM_COMMON')) {
         /**
          * Initializes the SQL parsing library.
          */
-        include_once './libraries/sql-parser/autoload.php';
+        include_once SQL_PARSER_AUTOLOAD;
 
         // Loads closest context to this version.
         SqlParser\Context::loadClosest(
diff --git a/libraries/vendor_config.php b/libraries/vendor_config.php
index b9c25c6..cea194f 100644
--- a/libraries/vendor_config.php
+++ b/libraries/vendor_config.php
@@ -85,6 +85,11 @@ define('TCPDF_INC', './libraries/tcpdf/tcpdf.php');
 define('PHPSECLIB_INC_DIR', './libraries/phpseclib/');
 
 /**
+ * Path to the dmitry-php/sql-parser. Useful when you want to use system version.
+ */
+define('SQL_PARSER_AUTOLOAD', './libraries/sql-parser/autoload.php');
+
+/**
  * Avoid referring to nonexistent files (causes warnings when open_basedir
  * is used)
  */