[phpMyAdmin Developers] 22.214.171.124??
bennetch at gmail.com
Fri Nov 25 22:28:36 CET 2016
On Fri, Nov 25, 2016 at 1:10 PM, Michal Čihař <michal at cihar.com> wrote:
> Isaac Bennetch píše v Pá 25. 11. 2016 v 12:21 -0500:
>> On Fri, Nov 25, 2016 at 8:02 AM, Isaac Bennetch <bennetch at gmail.com>
>> > Do we need a quick release of 4.6.51 because of #12735 ?
>> What's the best way to handle this? Since QA_4_6 is so fresh, should
>> just base the release on QA_4_6 (which at the moment includes
>> Node.js fix and a few language improvements? I think that's better
>> than cherry-picking the fix back to a branch created from
>> RELEASE_4_6_5 because the history will be cleaner, but it will
>> a few more fixes than just the issue mentioned.
> There is nothing Node.js related from me, just sanity checks in php-
> gettext to avoid miserable failure when mbstring is not there. This
> should be fine for release. So I'd release from QA_4_6.
I was slightly mistaken, the commit I was referring is Node.php, not
Node.js — anyway, I'll release from QA_4_6 this evening.
> issue #12735 Incorrect parameters to escapeString in Node.php
See also https://github.com/phpmyadmin/phpmyadmin/compare/RELEASE_4_6_5...QA_4_6
> Michal Čihař | https://cihar.com/ | https://weblate.org/
> Developers mailing list
> Developers at phpmyadmin.net
More information about the Developers