[phpMyAdmin Developers] Regarding creating new branch in main PMA repo and closing existing gsoc pr

MaurĂ­cio Meneghini Fauth mauriciofauth at gmail.com
Wed Jul 11 06:37:44 CEST 2018


I think that's a good idea. This will greatly facilitate the review of pull
requests and the development of the GSoC project.

I created a new branch called gsoc-js-refactoring [1] and changed the base
branch of the first PR to that branch [2].

[1] https://github.com/phpmyadmin/phpmyadmin/tree/gsoc-js-refactoring
[2] https://github.com/phpmyadmin/phpmyadmin/pull/14464


On Fri, Jul 6, 2018 at 11:01 AM Piyush Vijay <piyushvijay.1997 at gmail.com>

> Hi,
> Me and Devan were discussing about the current pr 'gsoc' which I have made
> for the modular javascript code but the pr has lots of unused files which I
> have created for making sure that existing code is not breaking and
> contains lot of commented out code.
> So we have decided to create a new branch in main repo of phpMyAdmin and
> multiple pr's from gsoc branch with small changes which can be reviewed and
> then merged into the newly created branch and we'll then keep merging this
> new branch into master after review and testing.
> So I am closing this gsoc pr and will make multiple small pr's from this
> branch by cherry-picking the commits.
> Any suggestions regarding this would be welcome.
> Regards
> Piyush Vijay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.phpmyadmin.net/pipermail/developers/attachments/20180711/464c8242/attachment.html>

More information about the Developers mailing list