<div dir="ltr"><div class="gmail_quote"><div dir="ltr">Le mar. 6 oct. 2015 à 22:35, Marc Delisle <<a href="mailto:marc@infomarc.info">marc@infomarc.info</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Le 2015-10-06 14:47, Hugues Peccatte a écrit :<br>
> Le lun. 5 oct. 2015 à 22:07, Marc Delisle <<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a><br>
> <mailto:<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>>> a écrit :<br>
><br>
> Le 2015-10-05 13:46, Hugues Peccatte a écrit :<br>
> > Le sam. 3 oct. 2015 à 21:13, Hugues Peccatte<br>
> <<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>><br>
> > <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a><br>
> <mailto:<a href="mailto:hugues.peccatte@gmail.com" target="_blank">hugues.peccatte@gmail.com</a>>>> a écrit :<br>
> ><br>
> > Le sam. 3 oct. 2015 à 12:46, Remi Collet<br>
> <<a href="mailto:remi@fedoraproject.org" target="_blank">remi@fedoraproject.org</a> <mailto:<a href="mailto:remi@fedoraproject.org" target="_blank">remi@fedoraproject.org</a>><br>
> > <mailto:<a href="mailto:remi@fedoraproject.org" target="_blank">remi@fedoraproject.org</a><br>
> <mailto:<a href="mailto:remi@fedoraproject.org" target="_blank">remi@fedoraproject.org</a>>>> a écrit :<br>
> ><br>
> > Le 03/10/2015 09:14, Hugues Peccatte a écrit :<br>
> >> Dear developers,<br>
> ><br>
> >> The following PR is trying to use namespaces and autoloading for<br>
> >> pMA: <a href="https://github.com/phpmyadmin/phpmyadmin/pull/11428" rel="noreferrer" target="_blank">https://github.com/phpmyadmin/phpmyadmin/pull/11428</a> This PR<br>
> >> seems to be quite stable now. As almost all PHP files had been<br>
> >> updated, this is a huge work to test all cases, all<br>
> > configurations,<br>
> >> all features. Would it be possible to have some testers please?<br>
> ><br>
> > At a first (and quick) look<br>
> ><br>
> > PMA\libraries namespace seems a bit uggly...<br>
> ><br>
> > 'libraries' is a directory, only a layout artefact, why should it be<br>
> > part of the namespace.<br>
> ><br>
> > Per PSR-4 definition, namespace should be<br>
> ><br>
> > "The fully qualified class name MUST have a top-level<br>
> > namespace name, also known as a "vendor namespace".<br>
> ><br>
> > So, is PMA the "vendor" ? it seems.<br>
> ><br>
> > "The fully qualified class name MAY have one or<br>
> > more sub-namespace names."<br>
> ><br>
> > I think a second level is needed (but again, "libraries" seems<br>
> > strange<br>
> > to me... but perhaps only to me)<br>
> ><br>
> > Notice: it will be nice to move all 3rd party lib to a separate<br>
> > directory (will make downstream work much easier)<br>
> ><br>
> > Remi.<br>
> ><br>
> >> Thanks to Marc and Isaac who already did a lot of tests. And<br>
> > thanks<br>
> >> to new testers.<br>
> ><br>
> >> Have a nice day,<br>
> ><br>
> >> H.<br>
> ><br>
> ><br>
> >> _______________________________________________ Developers mailing<br>
> >> list <a href="mailto:Developers@phpmyadmin.net" target="_blank">Developers@phpmyadmin.net</a> <mailto:<a href="mailto:Developers@phpmyadmin.net" target="_blank">Developers@phpmyadmin.net</a>><br>
> <mailto:<a href="mailto:Developers@phpmyadmin.net" target="_blank">Developers@phpmyadmin.net</a> <mailto:<a href="mailto:Developers@phpmyadmin.net" target="_blank">Developers@phpmyadmin.net</a>>><br>
> >> <a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/mailman/listinfo/developers</a><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > Hi Remi,<br>
> ><br>
> > Thanks for your feedback.<br>
> ><br>
> > Why does PMA\libraries seem ugly?<br>
> > OK, "libraries" is a directory, but all classes are not in<br>
> > libraries, that's why I decided to set the vendor namespace<br>
> (PMA) at<br>
> > project root. If needed, we can imagine to have a specific vendor<br>
> > namespace for libraries, but why and which one?<br>
> ><br>
> > I saw your notice about moving 3rd party libraries. But I<br>
> think this<br>
> > is not the subject here.<br>
> > In fact, this is a really huge work that had been done (at<br>
> least, I<br>
> > think…) and I think that a lot of subjects could be discussed<br>
> here.<br>
> > That's why I'ld like to focus on test and errors.<br>
> ><br>
> > Had you some time to test the PR?<br>
> ><br>
> > Thanks,<br>
> > H.<br>
> ><br>
> ><br>
> > Hi,<br>
> ><br>
> > Any other feedback please? Or maybe we can merge…<br>
><br>
> Seems ready indeed.<br>
><br>
><br>
> --<br>
> Marc Delisle | phpMyAdmin<br>
><br>
><br>
> Hi,<br>
><br>
> Thanks for your answer Marc.<br>
> I'll merge again master in the branch and then it should be OK. Do you<br>
> want me to do the merge (by GitHub)?<br>
<br>
Please do.<br><br>
--<br>
Marc Delisle | phpMyAdmin<br></blockquote><div> </div><div>Hi everyone,</div><div><br></div><div>The merge will be done in some minutes. I just wait for the return of <a href="https://travis-ci.org/phpmyadmin/phpmyadmin/builds/84153692">https://travis-ci.org/phpmyadmin/phpmyadmin/builds/84153692</a></div><div><br></div><div>H.</div></div></div>