<div dir="ltr">Indeed, it looks too long. I will look into the <span style="font-size:12.8px">indexAction() </span>method to find logical sections to break into new methods.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 29, 2015 at 4:26 PM, Marc Delisle <span dir="ltr"><<a href="mailto:marc@infomarc.info" target="_blank">marc@infomarc.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Madhura and Atul,<br>
<br>
I was looking at indexAction() in DatabaseStructureController.class.php,<br>
which is 566 lines. I find it too long to be manageable, and PMD agrees [0].<br>
<br>
Do you consider this method a work in progress? Does MVC mandate that<br>
indexAction() should remain that size?<br>
<br>
[0]<br>
<a href="http://ci.phpmyadmin.net/job/phpMyAdmin/1588/pmdResult/type.-385120790/file.-1544904175/" rel="noreferrer" target="_blank">http://ci.phpmyadmin.net/job/phpMyAdmin/1588/pmdResult/type.-385120790/file.-1544904175/</a><br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Marc Delisle | phpMyAdmin<br>
<br>
_______________________________________________<br>
Developers mailing list<br>
<a href="mailto:Developers@phpmyadmin.net">Developers@phpmyadmin.net</a><br>
<a href="https://lists.phpmyadmin.net/mailman/listinfo/developers" rel="noreferrer" target="_blank">https://lists.phpmyadmin.net/mailman/listinfo/developers</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Thanks and Regards,<div><br></div><div>Madhura Jayaratne<br><div><br></div></div></div>
</div>